[00:03] gsi_ (~gsi@x4db9b329.dyn.telefonica.de) joined #scummvm. [00:07] gsi (~gsi@x4db6afe6.dyn.telefonica.de) left irc: Ping timeout: 260 seconds [01:27] [scummvm] mistydemeo opened pull request #3442: DEVTOOLS: dumper companion - fix filename for mac command (master...companion_fix_mac) https://git.io/JiIaZ [01:51] DominusExult (~dominus@exult/developer/dominus) joined #scummvm. [01:52] Dominus (~dominus@exult/developer/dominus) left irc: Ping timeout: 260 seconds [01:52] Nick change: DominusExult -> Dominus [02:06] [scummvm] deckarep opened pull request #3443: SCI: Clarify passing of parameter: pass instead of parse for `classtable` debug command. (master...patch-1) https://git.io/JiIid [04:05] reset (~reset@user/reset) left irc: Quit: reset [04:22] _sev_ (~sev@193.19.255.138) joined #scummvm. [04:22] _sev_ (~sev@193.19.255.138) left irc: Changing host [04:22] _sev_ (~sev@scummvm/sev) joined #scummvm. [04:22] #scummvm: mode change '+o _sev_' by ChanServ!ChanServ@services.libera.chat [04:52] _sev__ (~sev@193.19.255.138) joined #scummvm. [04:52] _sev_ (~sev@scummvm/sev) left irc: Read error: Connection reset by peer [04:52] _sev__ (~sev@193.19.255.138) left irc: Changing host [04:52] _sev__ (~sev@scummvm/sev) joined #scummvm. [04:52] #scummvm: mode change '+o _sev__' by ChanServ!ChanServ@services.libera.chat [05:09] Build [#26](https://buildbot.scummvm.org/#builders/159/builds/26) of `daily-master` completed successfully. [05:30] eriktorbjorn (~d91tan@scummvm/eriktorbjorn) left irc: Quit: Leaving. [05:36] [scummvm] mistydemeo opened pull request #3444: DIRECTOR: add various new games (master...director_add_more_games) https://git.io/JiLKH [05:50] _sev__ (~sev@scummvm/sev) left irc: Quit: This computer has gone to sleep [05:53] _sev__ (~sev@193.19.255.138) joined #scummvm. [05:53] _sev__ (~sev@193.19.255.138) left irc: Changing host [05:53] _sev__ (~sev@scummvm/sev) joined #scummvm. [05:53] #scummvm: mode change '+o _sev__' by ChanServ!ChanServ@services.libera.chat [05:56] [scummvm] mistydemeo opened pull request #3445: DEVTOOLS: dumper-companion: work around bug (master...dumper-companion_bug_workaround) https://git.io/JiLMS [06:06] [scummvm] sev- pushed 1 new commits to master: https://git.io/JiL9k [06:06] scummvm/master 7bbff06 sev-: GROOVIE: Fix logic for opGallery [06:31] palasso (~palasso@user/palasso) joined #scummvm. [06:49] TMM_ (hp@amanda.tmm.cx) left irc: Quit: https://quassel-irc.org - Chat comfortably. Anywhere. [06:49] TMM_ (hp@amanda.tmm.cx) joined #scummvm. [07:58] BrainChild (~brainchil@185.237.182.250) joined #scummvm. [08:34] ny00123 (~ny00123@5.102.216.175) joined #scummvm. [08:51] [scummvm] alxpnv pushed 2 new commits to master: https://git.io/Jitou [08:51] scummvm/master 3d5fe05 alxpnv: ASYLUM: don't play intro video when loading during startup [08:51] scummvm/master 0c64bb8 alxpnv: ASYLUM: speed up puzzle animations a little bit [10:30] borosky (~borosky@213.134.185.182) left irc: [10:58] [scummvm] sev- closed pull request #3442: DEVTOOLS: dumper companion - fix filename for mac command (master...companion_fix_mac) https://git.io/JiIaZ [10:58] [scummvm] sev- pushed 1 new commits to master: https://git.io/JitA9 [10:58] scummvm/master a62ef12 mistydemeo: DEVTOOLS: fix filename for mac command [10:59] [scummvm] sev- closed pull request #3445: DEVTOOLS: dumper-companion: work around bug (master...dumper-companion_bug_workaround) https://git.io/JiLMS [10:59] [scummvm] sev- pushed 1 new commits to master: https://git.io/JitAF [10:59] scummvm/master 7def925 mistydemeo: DEVTOOLS: dumper-companion: work around bug [11:00] [scummvm] sev- closed pull request #3401: DEVTOOLS: simplify macbinary packing a bit (master...dumper-companion) https://git.io/J26Ir [11:00] [scummvm] sev- pushed 1 new commits to master: https://git.io/Jitxf [11:00] scummvm/master 34e58d9 einstein95: DEVTOOLS: simplify macbinary packing a bit [11:32] Sylvain (~SylvainTV@2a01cb0c08d23e0048c688a57f28973b.ipv6.abo.wanadoo.fr) left irc: Read error: Connection reset by peer [13:07] _sev__ (~sev@scummvm/sev) left irc: Quit: This computer has gone to sleep [13:07] ced117 (~ced117@april/member/ced117) left irc: Ping timeout: 264 seconds [13:12] _sev__ (~sev@193.19.255.138) joined #scummvm. [13:12] _sev__ (~sev@193.19.255.138) left irc: Changing host [13:12] _sev__ (~sev@scummvm/sev) joined #scummvm. [13:12] #scummvm: mode change '+o _sev__' by ChanServ!ChanServ@services.libera.chat [15:07] ny00123 (~ny00123@5.102.216.175) left irc: Quit: Leaving [15:12] Scrutinizer (Scrutinize@user/scrutinizer) joined #scummvm. [15:35] _sev__ (~sev@scummvm/sev) left irc: Quit: This computer has gone to sleep [15:36] _sev__ (~sev@193.19.255.138) joined #scummvm. [15:36] _sev__ (~sev@193.19.255.138) left irc: Changing host [15:36] _sev__ (~sev@scummvm/sev) joined #scummvm. [15:36] #scummvm: mode change '+o _sev__' by ChanServ!ChanServ@services.libera.chat [15:38] ced117 (~ced117@april/member/ced117) joined #scummvm. [16:09] _sev__ (~sev@scummvm/sev) left irc: Quit: This computer has gone to sleep [16:12] _sev__ (~sev@scummvm/sev) joined #scummvm. [16:12] #scummvm: mode change '+o _sev__' by ChanServ!ChanServ@services.libera.chat [16:24] _sev__ (~sev@scummvm/sev) left irc: Quit: This computer has gone to sleep [16:25] _sev__ (~sev@scummvm/sev) joined #scummvm. [16:25] #scummvm: mode change '+o _sev__' by ChanServ!ChanServ@services.libera.chat [16:46] BrainChild (~brainchil@185.237.182.250) left irc: Quit: Keep smiling and bye for now. [16:54] Scrutinizer (Scrutinize@user/scrutinizer) left irc: Quit: Bye! [16:56] Scrutinizer (Scrutinize@user/scrutinizer) joined #scummvm. [17:17] _sev__ (~sev@scummvm/sev) left irc: Quit: This computer has gone to sleep [17:19] _sev__ (~sev@scummvm/sev) joined #scummvm. [17:19] #scummvm: mode change '+o _sev__' by ChanServ!ChanServ@services.libera.chat [17:22] Scrutinizer (Scrutinize@user/scrutinizer) left irc: Quit: Bye! [17:40] eriktorbjorn (~d91tan@scummvm/eriktorbjorn) joined #scummvm. [17:40] #scummvm: mode change '+o eriktorbjorn' by ChanServ!ChanServ@services.libera.chat [17:45] [scummvm] sluicebox closed pull request #3443: SCI: Clarify passing of parameter: pass instead of parse for `classtable` debug command. (master...patch-1) https://git.io/JiIid [17:45] [scummvm] sluicebox pushed 1 new commits to master: https://git.io/Jimcd [17:45] scummvm/master a272a6b deckarep: SCI: Clarify passing of parameter: pass instead of parse for `class_table` debug command. [17:48] (Looks at the list of logged in users.) Hmmm... I wonder if our chances of someone figuring out why the Clandestiny intro cutscene doesn't work properly just improved. @MultimediaMike 😀 [17:48] [scummvm] sluicebox pushed 1 new commits to master: https://git.io/JimCL [17:48] scummvm/master 98acee3 sluicebox: SCI: Fix class_table debugging command output [17:49] sup [17:50] wow... Trilobyte had a third game? [17:51] does it have RoQ files for FMV? [17:52] I didn't see any standalone files, but the FMV I saw from starting the game used the Groovie engine's RoQ player. The first two videos look fine, the third one has lots of artifacts. [17:54] There are five games it recognizes, but I think only The 7th Guest is fully supported so far. The others being The 11th Hour (of course), Clandestiny, Uncle Henry's Playhouse (which I think is just a collection of puzzles from 7th Guest and 11th Hour?) and Tender Loving Care. [17:56] _sev__ (~sev@scummvm/sev) left irc: Ping timeout: 260 seconds [17:57] I think Tender Loving Care also uses RoQ for the videos? (Except the DVD-ROM version, which uses .vob files.) [17:58] Oh dear, is that the time? Got to go. [18:01] _sev (~sev@193.19.255.138) joined #scummvm. [18:01] _sev (~sev@193.19.255.138) left irc: Changing host [18:01] _sev (~sev@scummvm/sev) joined #scummvm. [18:01] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.libera.chat [18:03] Hi, I am trying to play Loom on my Mac (bless you guys for creating this option to play) -- I use Steam. I am able to start the game, but there is no audio. Am I doing something wrong? [18:05] TLC I think might work completely, I'm not sure what's wrong with the Clandestiny cutscenes, cause the other groovie2 games are using roq too, I haven't looked into it much though cause I've only been working on T11H [18:05] i don't think loom had voices. but it should've had sound effects and music. [18:06] Loom CD Talki had voices. [18:06] wtf now it's working? [18:06] Weird rofl [18:06] Steam and GOG both sell this version [18:06] It had voices on the audio cassette. [18:06] It all of a sudden started working - the audio. I don't get it. [18:06] Kuriin do you get sound at all? [18:07] hm, I cannot guess as to what the glitch was, but glad it's working [18:08] _sev (~sev@scummvm/sev) left irc: Ping timeout: 260 seconds [18:08] TLC demo has MPG files, but it looks like those are audio only. [18:10] MP2 codec [18:13] But there's a big GJD file that I can't get into. Different format than t7g / 11h. [18:17] reset (~reset@user/reset) joined #scummvm. [18:22] Yeah the roq videos are inside the gjd [18:24] ok, yeah I'm only seeing jpgs. I think I need to use something else to extract it (I'll DM you). [18:24] https://cdn.discordapp.com/attachments/581224061091446795/901175692190949408/Unnamed_File_000016.jpg [18:25] If you step through the debugger, you'll see it's running the functions inside roq.cpp [18:28] _sev (~sev@193.19.254.182) joined #scummvm. [18:28] _sev (~sev@193.19.254.182) left irc: Changing host [18:28] _sev (~sev@scummvm/sev) joined #scummvm. [18:28] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.libera.chat [19:11] where does the ScummVM RoQ player come from? homegrown or lifted from FFmpeg? If the latter, how long ago was it lifted? if you are seeing artifacts, that sounds consistent with my original RoQ decoder that didn't perform sub-pixel motion compensation correctly; however, the fix went into FFmpeg a really long time ago [19:12] RoQ is how I first noticed that YouTube is running code that I wrote 🤓 my MC artifact bugs were still present 😆 [19:18] YT runs RoQ code? [19:19] I think it might've been reverse engineered from one of the games is the ffmpeg roq based on Quake 3 or a Trilobyte game? [19:19] I didn't know sub-pixel motion was a thing, that might be the problem [19:19] it only affects Clandestiny though [19:25] could you tell me which commit fixed those artifacts? https://github.com/FFmpeg/FFmpeg/commits/master/libavcodec/roqvideo.c [19:27] https://multimedia.cx/eggs/googles-youtube-uses-ffmpeg/ [19:30] is it this? https://github.com/FFmpeg/FFmpeg/commit/ec59fd536f93fdca464ac9cbe423647c96bf69c0#diff-7b7ed4eb65cba27016d95c0092cb73d598c44e23838ec72e496e7aa364ffce4d [19:40] Wow, had it been 18 years already? [19:40] Actually, I'm pretty sure it was later than that [19:41] Look up the roq decoder from scummvm and figure out where it came from [19:48] // ROQ video player based on this specification by Dr. Tim Ferguson: // http://www.csse.monash.edu.au/~timf/videocodec/idroq.txt [19:50] That doesn't have all the details [19:50] That was good enough for 11th hour but it looks like later versions went through some refinements [19:51] That's why later games use a different variation with sub pixel MC [19:51] Right, it sounds like the Quake 3 version of the decoder [19:51] That's the one [19:54] Ok so I need to make it support sub pixel motion, and ffmpeg is doing that? Using apply_motion_generic? [19:55] I haven't seen the problem in action [19:55] However, based on description, that sounds like the discrepancy [19:56] If the scummvm roq decoder only sports whole pixel MC, that's a limitation [19:57] [scummvm] sev- pushed 6 new commits to master: https://git.io/JimaF [19:57] scummvm/master e2c058b sev-: GROOVIE: Added stub for Beehive game [19:57] scummvm/master e10a09e sev-: GROOVIE: Move Beehive puzzle logic to a separate file, more implementation [19:57] scummvm/master d5f291e sev-: GROOVIE: Implemented top method for Beehive [20:01] Basically, if a motion vector component is odd, you need to perform some pixel averaging, if memory serves [20:01] [scummvm] sev- pushed 1 new commits to master: https://git.io/JimVB [20:01] scummvm/master 9b1823d sev-: GROOVIE: Hid noisy warning [20:04] yea I saw that in one of the commits, but I'm not sure I'm seeing it in current master [20:05] Check my blog post I posted above-- it illustrates the artifact bleeding that is the manifestation of the problem [20:05] Is that the problem you are seeing? [20:06] https://github.com/FFmpeg/FFmpeg/blob/master/libavcodec/roqvideodec.c#L130-L133 apply_motion_generic is using memcpy https://github.com/FFmpeg/FFmpeg/blob/master/libavcodec/roqvideo.c#L127 [20:08] the blogpost describes an issue with colorspace conversions though, not subpixel motion vectors? [20:09] @Die4Ever please see the DMs 😄 [20:10] > FFmpeg fixed this bug in June of 2007 (thanks to Eric Lasota). [20:10] Look in the file history for that [20:11] It was MC-related but there was a problem in the way it was interacting with color space conversion [20:26] @MultimediaMike [20:26] https://cdn.discordapp.com/attachments/581224061091446795/901206216229941258/unknown.png [20:28] Yeah.. implement sub pixel and remember to do it in the original yuv space BEFORE converting to RGB [20:29] I don't see that in the ffmpeg code though, I see it using memcpy [20:32] SylvainTV (~SylvainTV@2a01cb0c00cc1d00841929c055d4578b.ipv6.abo.wanadoo.fr) joined #scummvm. [20:33] TMM_ (hp@amanda.tmm.cx) left irc: Quit: https://quassel-irc.org - Chat comfortably. Anywhere. [20:33] looks like looks like 3ccda4c is the magic bullet [20:33] TMM_ (hp@amanda.tmm.cx) joined #scummvm. [20:33] reviewing how it was overhauled, Eric unpacked the vectors as non-subsampled YUV 4:4:4 [20:33] I remember what's up [20:34] it was always whole-pel on the Y place, but the U and V planes are subsampled and it wasn't entirely clear how to handle that [20:34] Eric's change blew up those planes to take up the same space as Y, so that's why you only see the memcpu [20:35] I hope that makes sense [20:35] keep asking questions if it doesn't [20:40] ok thanks [20:40] I'm no video expert, but I think I understand enough about chroma subsampling to get it [20:45] hmm our codebook is already in rgb format [20:48] Yeah, that's the issue [20:49] This can't be processed in RGB, it really needs to be YUV [20:49] edheldil (~edheldil@178-79-239-109.cust.centrio.cz) joined #scummvm. [20:49] Hi, guys [20:51] _sev (~sev@scummvm/sev) left irc: Quit: This computer has gone to sleep [20:51] any idea why this issue doesn't affect the other games? [20:52] they probably used an earlier version of the RoQ encoder that wasn't as aggressive in its motion estimation [20:53] ok [20:53] makes sense [20:53] I wrote a standalone RoQ decoder about a decade ago [20:54] now I'm wondering if I'm crazy, since I didn't do the decoding that way [20:54] _sev (~sev@193.19.254.182) joined #scummvm. [20:54] _sev (~sev@193.19.254.182) left irc: Changing host [20:54] _sev (~sev@scummvm/sev) joined #scummvm. [20:54] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.libera.chat [20:54] might be worthwhile to see if this code can handle the file correctly: https://github.com/multimediamike/dreamroq [20:54] Clandestiny might be the only game with this issue lol [20:54] yea I was thinking of making scummvm strip the file out [20:54] Jedi Knight also had it (as seen in the blog post) [20:55] here's the file from my blog post: https://samples.mplayerhq.hu/game-formats/idroq/jk02.roq [20:55] try that and see if ScummVM can handle it with zero artifacts [21:01] thanks [21:01] gonna have to hack up this code to get it to play a naked file lol [21:17] _sev (~sev@scummvm/sev) left irc: Quit: This computer has gone to sleep [21:21] I don't think it's a color space issue [21:23] Can you get me a copy of the file? [21:23] these games use archive files, so they're packed together in gjd files [21:23] I'm gonna have to modify this to extract them [21:24] https://cdn.discordapp.com/attachments/581224061091446795/901220796796637194/unknown.png [21:24] that's with no YUV/RGB conversion [21:25] tsoliman (~tsoliman@user/tsoliman) got netsplit. [21:25] ScummBot (~ScummBot@al.scummvm.net) got netsplit. [21:26] ScummBot (~ScummBot@al.scummvm.net) returned to #scummvm. [21:27] tsoliman (~tsoliman@user/tsoliman) returned to #scummvm. [21:44] is the file in the demo? because I can find that on IA [21:46] let me see [21:46] I remember 1 of the demos didn't have the issue [21:49] this one https://archive.org/details/Clandestiny_demo [21:50] it's inside the MEDIA/CDDEMO.GJD file [21:52] that file is 80MB, the intro video inside it is 65MB [21:56] https://drive.google.com/file/d/1TNqLtZPt0kBf-O1z5I9fbtRyJnXU3siU/view?usp=sharing [21:57] Last message repeated 1 time(s). [22:11] Love when 80% of the demo is the intro FMV 😂 [22:11] it's quite the intro lol [22:31] [scummvm] bluegr pushed 3 new commits to master: https://git.io/JimMd [22:31] scummvm/master 4c74f65 bluegr: GROOVIE: Split the cake puzzle logic into a separate file [22:31] scummvm/master e0bb071 bluegr: GROOVIE: Remove debug function [22:31] scummvm/master 0f70fa0 bluegr: GROOVIE: Split the gallery puzzle logic into a separate file [22:45] palasso (~palasso@user/palasso) left irc: Remote host closed the connection [22:49] [scummvm] bluegr pushed 1 new commits to master: https://git.io/JimDi [22:49] scummvm/master 7ee08ef bluegr: GROOVIE: Hook up the cake puzzle like the rest. Some cleanup/renaming [23:26] edheldil (~edheldil@178-79-239-109.cust.centrio.cz) left irc: Ping timeout: 245 seconds [23:37] [scummvm] bluegr pushed 1 new commits to master: https://git.io/JimSA [23:37] scummvm/master 692bad5 bluegr: GROOVIE: Restructure GroovieV2 game logic [23:37] [scummvm] ScummVM-Translations pushed 1 new commits to master: https://git.io/JimSp [23:41] scummvm/master bccd437 : I18N: Update translations templates [23:41] [scummvm] bluegr pushed 2 new commits to master: https://git.io/Jim9Y [23:41] scummvm/master 4827c87 bluegr: GROOVIE: Remove leftover include [23:41] scummvm/master 14e773b bluegr: GROOVIE: Add missing ifdefs for groovie2 game logic [23:41] [scummvm] ScummVM-Translations pushed 2 new commits to master: https://git.io/Jim9O [23:41] guys i have a question i install scummvm and grim fandango and it works very well and i need to apply language patch but i cant. i have a grim.tab and Grimfandango.exe for apply patch. How can i apply the patch [23:42] if replace the grim.tab file but language still same, english [23:42] scummvm/master 9030505 : I18N: Update translation files [23:42] scummvm/master b1ace30 : I18N: Update translations templates [23:42] [scummvm] bluegr closed pull request #3439: MISC: Fix printf long/int64 type mismatches (master...printf-type) https://git.io/JifuR [23:42] [scummvm] bluegr pushed 1 new commits to master: https://git.io/Jim9Z [23:42] scummvm/master db76992 orgads: MISC: Fix printf long/int64 type mismatches [23:42] how can i install language patch on scummvm (android) [23:43] [scummvm] ScummVM-Translations pushed 1 new commits to master: https://git.io/Jim9n [23:43] scummvm/master f4aae6f : I18N: Update translation files [23:45] [scummvm] Die4Ever opened pull request #3446: GROOVIE: dump_resources config option (master...groovie-dump-resources) https://git.io/Jim92 [00:00] --- Sat Oct 23 2021