ScummVM IRC Log - 22 Nov 2022

[Back to Index]

[00:22] <Scummette> [scummvm] phcoder opened pull request #4463: SHERLOCK: Support Chinese version of Rose Tattoo (master...tattoo-cn) https://is.gd/QeXaxw
[02:11] <Scummette> [scummvm] elasota opened pull request #4464: COMMON: Add functions to get Mac Finder metadata such as type/creator codes. (master...add-finder-info-read) https://is.gd/WZbWUf
[02:18] <Scummette> [scummvm] elasota closed pull request #4431: MTROPOLIS: Add detection for Star Trek: The Game Show demo (master...mtrop) https://is.gd/byFQca
[02:18] <Scummette> [scummvm] elasota pushed 1 new commits to master: https://is.gd/ZlUS5t
[02:18] <Scummette> scummvm/master a6501be einstein95: MTROPOLIS: Add detection for Star Trek: The Game Show demo (#4431)
[02:18] <Scummette> [scummvm] ScummVM-Translations pushed 1 new commits to master: https://is.gd/mjFIcq
[02:18] <Scummette> scummvm/master 395cf84 : I18N: Update translation files
[02:55] --> DominusExult joined #scummvm.
[02:57] <-- Dominus left irc: Ping timeout: 260 seconds
[02:57] Nick change: DominusExult -> Dominus
[04:03] <grogbot> [discord] <sluicebox> it's weird that that discussion about parsing a documented font structure didn't ever reference the documentation for that structure? https://learn.microsoft.com/en-us/windows/win32/menurc/fontdirentry
[04:05] <grogbot> [discord] <sluicebox> the existing code was correct and lands on szDeviceName. the new code lands in the middle of a uint32. maybe the font file that was being parsed was wrong (or a different format version?) but... yikes. revert that, it's broken for everyone now
[04:13] <-- gsi left irc: Ping timeout: 260 seconds
[04:15] --> gsi joined #scummvm.
[04:42] <ScummBot> Build [#423](https://buildbot.scummvm.org/#builders/159/builds/423) of `daily-master` completed successfully.
[05:26] <grogbot> [discord] <eientei> I'll have a look at the fon file in question from the director talk
[05:43] <grogbot> [discord] <eriktorbjorn> One more question from my "This used to work" list: It seems the detection entry for the Tender Loving Care trailer has been made more strict, so the one from my English CD is no longer recognized. It uses preview.grv and drama1.gjd for detection. Does anyone know if drama1.gjd is actually part of the trailer? My CD version has both files, my DVD version only has preview.grv.
[05:43] <-- TMM_ left irc: Quit: https://quassel-irc.org - Chat comfortably. Anywhere.
[05:43] --> TMM_ joined #scummvm.
[05:45] <grogbot> [discord] <eientei> Ok, re-reading the Director talk and looking at the FON files (both from the game the PR mentions and Hugo 1), it looks like the change to `stream.skip` was from before `readString(stream); // Skip Device Name` was added to replace the change, but the change was never reverted
[05:51] <grogbot> [discord] <eriktorbjorn> I can understand why detecting preview.grv is a bad idea, because it's only 19 bytes. 🙂
[05:53] <grogbot> [discord] <eriktorbjorn> I can't run it from the DVD files though, so I guess I should just add my CD version, similar to the entry for the German one.
[06:04] <Scummette> [scummvm] eriktorbjorn pushed 1 new commits to master: https://is.gd/yT2Rhg
[06:04] <Scummette> scummvm/master e5553b0 eriktorbjorn: GROOVIE: Add entr for English Tender Loving Care trailer
[06:16] <Scummette> [scummvm] eriktorbjorn pushed 1 new commits to master: https://is.gd/EQSo4P
[06:16] <Scummette> scummvm/master 1ae0fe2 eriktorbjorn: GRAPHICS: Assume PICT are version 2 by default
[06:20] <grogbot> [discord] <eriktorbjorn> Will you be fixing it? You seem to understand it a lot better than me, and I have to go. (Technically, I could stay a little longer but I need to clean out a litter box.)
[06:25] <-- reset left irc: Quit: reset
[06:35] <-- eriktorbjorn left irc: Quit: Leaving.
[06:40] <-- NK` left irc: Read error: Software caused connection abort
[06:40] --> NK` joined #scummvm.
[06:43] <grogbot> [discord] <eientei> Just needs reverting that `stream.skip` change, I can put in a PR if you want
[06:47] <Scummette> [scummvm] einstein95 opened pull request #4465: DEVTOOLS: COMPANION: Format using black (master...dumper_companion) https://is.gd/l74OJ7
[07:37] <Scummette> [scummvm] einstein95 opened pull request #4466: MADS: Add detection for Once Upon a Forest; fix segment loading for Rex Nebular, Dragonsphere and Phantom demos (master...mads) https://is.gd/hGdrOv
[08:02] --> ldevulder joined #scummvm.
[08:18] <grogbot> [discord] <sluicebox> i'll take care of it. unbreaking hugo is my sacred duty. hugo2 taught me how to spell chasm
[08:31] <Scummette> [scummvm] sluicebox pushed 1 new commits to master: https://is.gd/Uvqmxn
[08:31] <Scummette> scummvm/master 74d94f1 sluicebox: GRAPHICS: Fix WinFontDirEntry parsing regression
[09:04] --> ccawley2011 joined #scummvm.
[09:04] #scummvm: mode change '+o ccawley2011' by ChanServ!ChanServ@services.libera.chat
[09:43] <grogbot> [discord] <eientei> When you do this, probably should make `TLCDEMOENTRY` similar to the ones for 11th Guest and Clandestiny
[09:43] <grogbot> [discord] <eientei> https://cdn.discordapp.com/attachments/581224061091446795/1044548722786308117/groovie_demo.patch
[09:44] <grogbot> [discord] <eientei> When you do this, probably should make `TLCDEMOENTRY` similar to the ones for 11th Guest and Clandestiny (edited)
[09:44] <grogbot> [discord] <eientei> like this, probably
[09:44] <grogbot> [discord] <eientei> https://cdn.discordapp.com/attachments/581224061091446795/1044549049149296640/groovie_demo.patch
[09:58] <-- niska left irc: Quit: Leaving
[10:04] --> niska joined #scummvm.
[10:11] <grogbot> [discord] <sev> @eriktorbjorn that is _very_ annoying. That's just another not-well-tested change
[10:12] <grogbot> [discord] <sev> question, if I revert back that particular skip, does it fix it for you? Then I will figure out what is wrong with Director
[10:15] <grogbot> [discord] <eientei> There's nothing wrong with the fon files in McLuhan
[10:15] <grogbot> [discord] <sluicebox> i just committed the windows for parsing fix, i confirmed that it fixes hugo1
[10:15] <grogbot> [discord] <sluicebox> i just committed the windows font parsing fix, i confirmed that it fixes hugo1 (edited)
[10:15] <grogbot> [discord] <sluicebox> (if that's the one we're talking about)
[10:17] <grogbot> [discord] <sluicebox> it does look like that line didn't even belong in the eventual commit, so i don't believe anything new depended on it. (and if it did, that should break so it can be dealt with.)
[10:23] <grogbot> [discord] <sev> Not about wrong, but why the student needed to change the skip for mcluhan
[10:23] <grogbot> [discord] <sev> e.g. if it breaks the font loading, how it was working for him in the first place then
[10:30] <Scummette> [scummvm] ScummVM-Translations pushed 1 new commits to master: https://is.gd/veg2vw
[10:30] <Scummette> scummvm/master 3ba4ae7 IlDucci: I18N: Update translation (Spanish)
[10:30] <Scummette> [scummvm] ScummVM-Translations pushed 2 new commits to master: https://is.gd/cFfsaj
[10:30] <Scummette> scummvm/master 480becb goodoldgeorge: I18N: Update translation (Hungarian)
[10:30] <Scummette> scummvm/master 5f8b27a VAN-Gluon: I18N: Update translation (Japanese)
[10:32] <grogbot> [discord] <sluicebox> i think we'll either find that he was confused or that there's something seriously wrong with that first file, but it's also possible that he was mistaken and the broken parsing accidentally worked for him. by reading a string five bytes earlier than where it really is, if all five bytes in that particular font file were non-zero then the rest of the parsing would have ended up at the right locations, just a with a silly string. the
[10:34] <grogbot> [discord] <sluicebox> i'm also very sympathetic to "i totally messed up this offset math" -- i do it every time!
[10:35] <-- Tooncinator left irc: Quit: Bridge terminating on SIGTERM
[10:38] <grogbot> [discord] <sev> @sluicebox there was a perpetual problem with that student. He was is "write-only" mode. Often I was finding that he did not even _TRY_ to run his code, but submitted it via PR
[10:38] <grogbot> [discord] <sev> for him the pass mark was: "it compiles"
[10:39] <grogbot> [discord] <sev> @sluicebox there was a perpetual problem with that student. He was in "write-only" mode. Often I was finding that he did not even _TRY_ to run his code, but submitted it via PR (edited)
[10:39] <grogbot> [discord] <sluicebox> i was relieved to see that the commit wasn't in the 2.6 branch, and that releases were unaffected
[10:40] <grogbot> [discord] <sev> unfortunately, I realised that problem after I merged number of PRs
[10:40] <grogbot> [discord] <sev> I had even to revert some of work
[10:40] --> Tooncinator joined #scummvm.
[10:40] <grogbot> [discord] <sev> and even more work was reverted later as it uncovered number of problems
[10:40] <grogbot> [discord] <sev> and even more work was reverted later as it uncovered number of problems which were difficult to see via code review (edited)
[10:41] <grogbot> [discord] <sev> this is also why there are still 2 half-baked PRs in the list as I need to find time to properly test them, document and merge manually
[10:41] <grogbot> [discord] <sluicebox> i'm happy to have indirectly contributed to hugo. those three games meant a lot to me, and if i had the capacity to work on more than one engine, i would take on hugo
[10:41] <grogbot> [discord] <eientei> Yeah, I can't seem to see why the -5 difference was needed
[10:43] <grogbot> [discord] <eientei> Windows version of McLuhan doesn't even start as it tries to open an xlib with the pathname attached, so the engine tries to open `\LabelDrv`
[10:43] <grogbot> [discord] <sluicebox> i got stuck on the hugo2 chasm for so long as a kid (months and months...) that i saved up my one dollar bills and gave them to my mom and somehow (mail? phone??) we ordered the hugo2 hintbook from david gray, and it arrived months later, clearly a printed-out-at-home and hand-stapled pink booklet, all the way from the UK, and i loved it
[10:44] <grogbot> [discord] <sluicebox> lol and i was FURIOUS at the chasm solution!!
[10:56] --> BrainChild joined #scummvm.
[11:10] <grogbot> [discord] <eientei> ```
[11:10] <grogbot> [discord] <eientei> For registering this game you will receive:
[11:10] <grogbot> [discord] <eientei>
[11:10] <grogbot> [discord] <eientei> FREE Hugo's House of Horrors, hint booklet
[11:10] <grogbot> [discord] <eientei> FREE Hugo's House of Horrors, registered version with self-running feature
[11:10] <grogbot> [discord] <eientei> FREE Unregistered Hugo II, Whodunit? (3-D adventure game) not including
[11:10] <grogbot> [discord] <eientei> the hint booklet
[11:10] <grogbot> [discord] <eientei>
[11:10] <grogbot> [discord] <eientei> You can register by sending $20.00 plus $4.00 S&H to David P. Gray, Gray Design
[11:10] <grogbot> [discord] <eientei> Associates P.O. Box 333, Northboro, MA 01532, USA. Please see registration
[11:10] <grogbot> [discord] <eientei> form at the end of this document for methods of payment.
[11:11] <grogbot> [discord] <eientei> ```
[11:11] Last message repeated 1 time(s).
[11:11] <grogbot> [discord] <eientei> For registering this game you will receive:
[11:11] <grogbot> [discord] <eientei> FREE Hint Booklet (range of clues from cryptic to obvious)
[11:11] <grogbot> [discord] <eientei> FREE Registered version with self-running feature
[11:11] <grogbot> [discord] <eientei> FREE Hugo's House of Horrors (3D adventure game)
[11:11] <grogbot> [discord] <eientei>
[11:11] <grogbot> [discord] <eientei> You can register by sending $20.00 to David P. Gray, Gray Design Associates
[11:11] <grogbot> [discord] <eientei> P.O. Box 333, Northboro, MA 01532, USA.
[11:11] <grogbot> [discord] <eientei> ``` (edited)
[11:12] <grogbot> [discord] <eientei> (from the Hugo 2 shareware readme.doc file)
[11:15] --> SylvainTV__ joined #scummvm.
[11:18] <-- SylvainTV left irc: Ping timeout: 260 seconds
[11:31] <grogbot> [discord] <eientei> @sluicebox if you want to contribute to the Hugo engine, the GUI could use a bit of touching up in the spacing (parser.cpp, line 218) and having the original dialog windows would make it look better
[11:31] <grogbot> [discord] <eientei> https://cdn.discordapp.com/attachments/581224061091446795/1044575751523008512/image.png
[11:31] <grogbot> [discord] <eientei> https://cdn.discordapp.com/attachments/581224061091446795/1044575752064086016/hugo_001.png
[12:28] <Scummette> [scummvm] sev- closed pull request #4465: DEVTOOLS: COMPANION: Format using black (master...dumper_companion) https://is.gd/l74OJ7
[12:28] <Scummette> [scummvm] sev- pushed 1 new commits to master: https://is.gd/tnCxJd
[12:28] <Scummette> scummvm/master 82f636f einstein95: DEVTOOLS: COMPANION: Format using black
[12:30] <Scummette> [scummvm] sev- closed pull request #4466: MADS: Add detection for Once Upon a Forest; fix segment loading for Rex Nebular, Dragonsphere and Phantom demos (master...mads) https://is.gd/hGdrOv
[12:30] <Scummette> [scummvm] sev- pushed 2 new commits to master: https://is.gd/Dn2YUw
[12:30] <Scummette> scummvm/master f8e01d6 einstein95: MADS: Add detection for Once Upon a Forest
[12:30] <Scummette> scummvm/master a22e5f5 einstein95: MADS: Skip some segments for the Nebular, Dragonsphere and Phantom demos
[12:53] <-- CAT_S left irc: Read error: Connection reset by peer
[12:59] <-- TMM_ left irc: Quit: https://quassel-irc.org - Chat comfortably. Anywhere.
[12:59] --> TMM_ joined #scummvm.
[13:10] <Scummette> [scummvm] ScummVM-Translations pushed 1 new commits to master: https://is.gd/6qqZUv
[13:10] <Scummette> scummvm/master ebddc45 antoniou79: I18N: Update translation (Greek)
[13:10] --> CAT_S joined #scummvm.
[13:23] --> reset joined #scummvm.
[13:51] <grogbot> [discord] <TiCoKH> The big fan into revers engineering something, when found bug in the original code and solution how they patched instead of fixed. The FMTowns Graphic Bios have a function to draw circle arc with center, startpoint endpoint and radius parameter. They used this for draw the main rounded border. But they missed the first corner parameter because the start and end is a same point (mean drawn full circle). I sitting in here hours ago think
[16:45] --> ny00123 joined #scummvm.
[16:52] <-- ldevulder left irc: Remote host closed the connection
[16:54] --> ldevulder joined #scummvm.
[17:19] <Scummette> [scummvm] bluegr closed pull request #4446: SCI: Move MidiDriver_CMS to the new CMS API (master...sci-cms) https://is.gd/BxRljb
[17:19] <Scummette> [scummvm] bluegr pushed 1 new commits to master: https://is.gd/zUZ6mJ
[17:19] <Scummette> scummvm/master e97812c ccawley2011: SCI: Move MidiDriver_CMS to the new CMS API
[17:44] <-- BrainChild left irc: Quit: Leaving...
[18:02] <-- ccawley2011 left irc: Read error: Connection reset by peer
[18:08] <Scummette> [scummvm] sev- pushed 1 new commits to master: https://is.gd/Ak86Uf
[18:08] <Scummette> scummvm/master b6d423e sev-: MOHAWK: Added another tortoise-mac-demo. Bug #12979
[18:08] <Scummette> [scummvm] ScummVM-Translations pushed 1 new commits to master: https://is.gd/HSnDPo
[18:08] <Scummette> scummvm/master e0c62ab : I18N: Update translations templates
[18:17] --> eriktorbjorn joined #scummvm.
[18:17] #scummvm: mode change '+o eriktorbjorn' by ChanServ!ChanServ@services.libera.chat
[18:19] <-- ny00123 left irc: Ping timeout: 255 seconds
[18:23] <Scummette> [scummvm] ScummVM-Translations pushed 1 new commits to master: https://is.gd/imITXP
[18:23] <Scummette> scummvm/master 0e0b83d : I18N: Update translation (French)
[18:29] --> ny00123 joined #scummvm.
[18:42] <Scummette> [scummvm] ScummVM-Translations pushed 1 new commits to master: https://is.gd/qao6Rn
[18:42] <Scummette> scummvm/master 2d21c57 tag2015: I18N: Update translation (Italian)
[19:32] <Scummette> [scummvm] ScummVM-Translations pushed 1 new commits to master: https://is.gd/MDatBa
[19:32] <Scummette> scummvm/master e43d997 sev-: I18N: Update translation (Russian)
[19:32] <Scummette> [scummvm] ScummVM-Translations pushed 1 new commits to master: https://is.gd/GKi4A2
[19:32] <Scummette> scummvm/master 1ffb9c9 sev-: I18N: Update translation (Ukrainian)
[19:38] <Scummette> [scummvm] neuromancer pushed 3 new commits to master: https://is.gd/ZWK32B
[19:38] <Scummette> scummvm/master 28c51e2 neuromancer: FREESCAPE: correct shot direction when using shootMode
[19:38] <Scummette> scummvm/master 317c388 neuromancer: FREESCAPE: correctly place mouse pointer in demo mode
[19:38] <Scummette> scummvm/master 62e7ab6 neuromancer: FREESCAPE: implement missing keys in demo mode for driller releses of amiga/atari
[19:38] <Scummette> [scummvm] ScummVM-Translations pushed 1 new commits to master: https://is.gd/dGtWR1
[19:38] <Scummette> scummvm/master 3761f0f : I18N: Update translation files
[20:38] <Scummette> [scummvm] sluicebox pushed 1 new commits to master: https://is.gd/KnOBkE
[20:38] <Scummette> scummvm/master 2fbeeca sluicebox: SCI: Prevent script lockers from overflowing
[21:52] <-- ny00123 left irc: Quit: Leaving
[22:08] <grogbot> [discord] <sluicebox> there was a huge "if" in my statement!
[22:16] <grogbot> [discord] <sluicebox> also to clarify: *if* i had capacity i would work on the hugo engine because i think that would be fun, not because i think it needs a bunch of work or anything. (i haven't even played them in scummvm, or anywhere, since i was a kid!)
[22:17] <grogbot> [discord] <SupSuper> you wanna work on an engine with actual source code? 😱
[22:29] <grogbot> [discord] <Strangerke> it's quite funny to look at the original code then at the engine code 🙂
[22:59] --> chiptune1 joined #scummvm.
[23:04] NK` (~NK@2001:bc8:33c1::1337) got netsplit.
[23:04] chiptuner (~bobby@user/chiptuner) got netsplit.
[23:10] NK` (~NK@2001:bc8:33c1::1337) returned to #scummvm.
[23:15] chiptuner (~bobby@user/chiptuner) got lost in the net-split.
[00:00] --- Wed Nov 23 2022