[Back to Index]

  
[00:05] <-- delacroix left irc: Quit: ZNC - http://znc.in
[00:05] --> delacroix joined #scummvm.
[00:06] <Scummette> [scummvm] athrxx pushed 1 new commits to master: https://git.io/JvMfg
[00:06] <Scummette> scummvm/master 5991e8c athrxx: AUDIO: fix compiler warning
[00:11] <-- Tea left irc: Quit: Quit messages are a thing?
[00:13] --> Tea joined #scummvm.
[00:13] <-- Tea left irc: Changing host
[00:13] --> Tea joined #scummvm.
[00:17] <-- Tea left irc: Client Quit
[00:18] --> Tea joined #scummvm.
[00:18] <-- Tea left irc: Changing host
[00:18] --> Tea joined #scummvm.
[00:42] --> dreammaster joined #scummvm.
[00:42] #scummvm: mode change '+o dreammaster' by ChanServ!ChanServ@services.
[00:50] <-- _sev left irc: Read error: Connection reset by peer
[00:50] --> _sev_ joined #scummvm.
[00:50] #scummvm: mode change '+o _sev_' by ChanServ!ChanServ@services.
[02:18] <-- SylvainTV left irc: Read error: Connection reset by peer
[03:25] --> _dreammaster joined #scummvm.
[03:25] #scummvm: mode change '+o _dreammaster' by ChanServ!ChanServ@services.
[03:27] <-- dreammaster left irc: Ping timeout: 250 seconds
[03:58] Nick change: _dreammaster -> dreammaster
[04:01] --> DominusExult joined #scummvm.
[04:01] <-- DominusExult left irc: Changing host
[04:01] --> DominusExult joined #scummvm.
[04:04] <-- Dominus left irc: Ping timeout: 264 seconds
[04:04] Nick change: DominusExult -> Dominus
[04:12] --> P2E_ joined #scummvm.
[04:14] <-- P2E left irc: Ping timeout: 256 seconds
[04:56] <-- dreammaster left irc:
[06:09] <-- BeefEats left irc: Read error: Connection reset by peer
[06:58] <-- systwi_ left irc: Read error: Connection reset by peer
[06:58] --> systwi joined #scummvm.
[07:24] --> ny00123 joined #scummvm.
[07:40] --> waltervn joined #scummvm.
[07:40] #scummvm: mode change '+o waltervn' by ChanServ!ChanServ@services.
[08:05] <-- Mia left irc: Read error: Connection reset by peer
[08:10] <Scummette> [scummvm] mduggan opened pull request #2153: ULTIMA8: Add short fade in/out around menu items to match original game (master...u8_add_menu_fades) https://git.io/JvMsu
[08:36] --> Mia joined #scummvm.
[08:36] <-- Mia left irc: Changing host
[08:36] --> Mia joined #scummvm.
[08:41] <-- Lightkey left irc: Ping timeout: 256 seconds
[08:53] --> Lightkey joined #scummvm.
[08:57] <grogbot> <ZvikaZ> @_athrxx , that's my mistake. I'm sorry. Will send later PR to fix that. Thanks for noting that.
[09:10] <-- timofonic left irc: Remote host closed the connection
[09:14] --> timofonic joined #scummvm.
[09:14] <-- timofonic left irc: Read error: Connection reset by peer
[09:14] --> timofonic joined #scummvm.
[09:14] <-- timofonic left irc: Read error: Connection reset by peer
[09:15] --> waltervn_ joined #scummvm.
[09:15] #scummvm: mode change '+o waltervn_' by ChanServ!ChanServ@services.
[09:18] <-- waltervn left irc: Ping timeout: 246 seconds
[09:26] <grogbot> <ZvikaZ> @_athrxx , now I see that you already fixed that. Thanks...
[09:29] --> timofonic joined #scummvm.
[09:35] Nick change: waltervn_ -> waltervn
[09:40] --> ldevulder_ joined #scummvm.
[09:44] <-- ldevulder left irc: Ping timeout: 250 seconds
[10:13] <Scummette> [scummvm] aryanrawlani28 opened pull request #2154: Fix bug #7125 (master...master) https://git.io/JvMcv
[10:22] <grogbot> <Henke37> any chance of my pull request being accepted despite codacy complaining about my use of seemingly unused variables?
[11:37] <-- antlarr2 left irc: Quit: bye!
[11:38] --> antlarr joined #scummvm.
[11:45] --> vliaskov joined #scummvm.
[12:08] --> SylvainTV joined #scummvm.
[12:08] #scummvm: mode change '+o SylvainTV' by ChanServ!ChanServ@services.
[12:15] <-- SylvainTV left irc: Ping timeout: 256 seconds
[12:16] <Scummette> [scummvm] yuv422 pushed 1 new commits to master: https://git.io/JvMle
[12:16] <Scummette> scummvm/master 21778dc yuv422: DRAGONS: Added power meters to thumb wrestling mini game
[12:17] <-- yuv422 left irc: Remote host closed the connection
[12:18] --> yuv422 joined #scummvm.
[12:18] #scummvm: mode change '+o yuv422' by ChanServ!ChanServ@services.
[12:20] <grogbot> <_athrxx> @Henke37 Yes. Satisfying pointless warnings of static check tools isn't required (or even recommended). You should just check these warnings to see whether they are valid or not. Which you apparently have done...
[12:39] <-- timofonic left irc: Remote host closed the connection
[12:39] --> timofonic joined #scummvm.
[12:39] <-- timofonic left irc: Read error: Connection reset by peer
[12:45] --> mataniko_ joined #scummvm.
[12:45] #scummvm: mode change '+o mataniko_' by ChanServ!ChanServ@services.
[12:47] <-- mataniko left irc: Ping timeout: 256 seconds
[12:54] --> timofonic joined #scummvm.
[12:56] <-- timofonic left irc: Read error: Connection reset by peer
[13:14] --> timofonic joined #scummvm.
[14:00] <grogbot> <sev> we do not pay way too much attention to the static analysers
[14:00] <grogbot> <Henke37> i just wish i knew some magic incantation to make it shut up
[14:00] <grogbot> <sev> especially I am annoyed by hundreds of "tainted variable" of Coverity: yes, I know I'm not checking data range when reading
[14:01] <grogbot> <sev> and all that nonsense of unsafe strlen() by codacity
[14:03] <grogbot> <_athrxx> @Henke37 Well, you could make a PR for codacy 🙂
[14:03] <grogbot> <sev> ah, recently Coverity started to complain a lot about our String class
[14:04] <grogbot> <sev> but unfortunately, my C++ knowledge does not allow me to understand its validity
[14:04] <grogbot> <Henke37> i try to keep the number of project i'm involved in to a minimum
[14:04] <grogbot> <sev> any volunteers with deep C++ knowledge? 😄
[14:05] <grogbot> <_athrxx> what does it say about the String class? (and no, I don't qualify as a C++ expert)
[14:06] <grogbot> <sev> let me explain
[14:07] <grogbot> <Henke37> i dabble too. and i've got time
[14:10] <grogbot> <sev> okay, I found a small example: line 229: https://github.com/scummvm/scummvm/blob/master/engines/pink/gui.cpp#L229
[14:10] <grogbot> <sev> prefix and suffix are String class
[14:10] <grogbot> <sev> then we do: prefix + suffix
[14:11] <grogbot> <Henke37> not seeing anything strange here.
[14:12] <grogbot> <_athrxx> and what is the coverity complaint?
[14:12] <grogbot> <sev> which eventually executes this: https://github.com/scummvm/scummvm/blob/master/common/str.cpp#L297
[14:13] <grogbot> <sev> return operator+=(String(str));
[14:13] <grogbot> <Henke37> create a copy of the current string, nothing strange there.
[14:13] <grogbot> <sev> now, for the construct String(str) we call reference copying constructor
[14:14] <grogbot> <sev> here: https://github.com/scummvm/scummvm/blob/master/common/str.cpp#L114
[14:14] <grogbot> <sev> as a result
[14:14] <grogbot> <sev> Coverity complains about double free of suffix
[14:15] <grogbot> <sev> if you have access to Coverity, here is is the link: https://scan6.coverity.com/reports.htm#v45941/p10140/fileInstanceId=98309893&defectInstanceId=29696439&mergedDefectId=1420333
[14:15] <grogbot> <sev> and it shows dozens of such places. E.g.
[14:15] <grogbot> <sev> String a("a");
[14:15] <grogbot> <sev> String b;
[14:15] <grogbot> <sev> b = a;
[14:16] <grogbot> <sev> in this case it will be copy by reference
[14:16] <grogbot> <Henke37> that's operator +, not operator +=
[14:16] <grogbot> <sev> and seemingly (according to Coverity), b will be freed 2 times
[14:17] <grogbot> <Henke37> this is the actual code that runs: https://github.com/scummvm/scummvm/blob/master/common/str.cpp#L900
[14:17] <grogbot> <sev> sigh
[14:18] <grogbot> <_athrxx> okay, this needs some thought. No, I can't access coverity. ("Your credentials are not valid for this resource")
[14:18] <grogbot> <sev> here is same code issue with +=: https://github.com/scummvm/scummvm/blob/master/engines/director/lingo/lingo-code.cpp#L567
[14:19] <grogbot> <sev> Coverity says:
[14:19] <grogbot> <sev> CID 1412183 (#1 of 1): Double free (USE_AFTER_FREE) 2. double_free: Calling ~String frees pointer d2.u.s->_str which has already been freed.
[14:19] <grogbot> <sev> because it says:
[14:19] <grogbot> <sev> 1. freed_arg: operator += frees d2.u.s._str
[14:21] <grogbot> <sev> here is issue with `+': https://github.com/scummvm/scummvm/blob/master/gui/ThemeEval.cpp#L160
[14:23] <grogbot> <sev> whenever constructor String::String(const String &str) is involved, there seems to be a problem
[14:23] <grogbot> <sev> because instead of reallocating memory, it makes: _str = str._str;, e.g. copies the pointer
[14:25] <grogbot> <sev> ah, I see it now
[14:25] <grogbot> <sev> ugh, this is stupid
[14:26] <grogbot> <sev> guys, no need to look
[14:26] <grogbot> <Henke37> please tell us, because i don't see the issue
[14:26] <grogbot> <sev> ~Stringdoes not free
[14:26] <grogbot> <sev> it calls decRefCount()
[14:26] <grogbot> <sev> and that thing counts references
[14:27] <grogbot> <Henke37> https://github.com/scummvm/scummvm/blob/master/common/str.cpp#L216 Pretty simple stuff once you figure out that the reference counter itself is lazily allocated.
[14:28] <grogbot> <sev> see line 111
[14:28] <grogbot> <sev> it increases the ref counter right before that pointer copy
[14:28] <grogbot> <sev> so, false positive
[14:29] <grogbot> <Henke37> yup.
[14:29] <grogbot> <sev> I'll go through and tame the Coverity
[14:31] <grogbot> <Henke37> line 282 is possible UB tho. not legal to compare pointers like that if they aren't from the same array.
[14:32] <grogbot> <Henke37> i mean, it works on all implementations I know of, but the standard says it's UB
[14:35] <grogbot> <sev> well, this is specifically check about str being from the same array
[14:35] <grogbot> <Henke37> formally you need to cast to something like intptr_t (which is IB) and do an integer comparison.
[14:35] <grogbot> <Henke37> i know what it does. i've written similar code once.
[14:36] <-- timofonic left irc: Ping timeout: 256 seconds
[14:37] --> timofonic joined #scummvm.
[14:38] <-- timofonic left irc: Remote host closed the connection
[14:50] <LePhilousophe> _sev_: for me the String errors reported by Coverity is bogus
[14:50] <LePhilousophe> but I would like someone to take a second look on it too
[14:51] <LePhilousophe> I suppose we need to put some coverity tag in str.cpp but I don't know which one
[14:51] <LePhilousophe> ok so you did second look :) cool
[14:58] <Scummette> [scummvm] henke37 opened pull request #2155: COMMON: Dedicated function for in buffer check (master...strPtrCmpUBFix) https://git.io/JvM0A
[15:05] <grogbot> <SupSuper> speaking of strings, is this correct? https://github.com/scummvm/scummvm/pull/2151/files#diff-269b333a6e284c657a1b22445014839eR52
[15:05] <grogbot> <SupSuper> i get lost when mixing between char* and string and
[15:08] <-- _sev_ left irc: Quit: This computer has gone to sleep
[15:09] <grogbot> <SupSuper> i do not miss figuring out what is or isn't a manually allocated string
[15:46] <grogbot> <Henke37> *grumble grumble* another time i want to use a C++11 feature, but couldn't. having to switch to a C header for the same result is not fun.
[15:51] --> _sev_ joined #scummvm.
[15:51] #scummvm: mode change '+o _sev_' by ChanServ!ChanServ@services.
[15:54] <grogbot> <SupSuper> technically C99 isn't part of C++11 either 😛
[15:55] <grogbot> <Henke37> it's 9 years old. time to get on with the times!
[15:57] <_sev_> LePhilousophe: we've cleared it out
[15:58] <_sev_> LePhilousophe: thanks for checking!
[16:01] <Scummette> [scummvm] SupSuper pushed 1 new commits to master: https://git.io/JvMzg
[16:01] <Scummette> scummvm/master 22943ee SupSuper: NETWORKING: Fix delete instead of free
[16:17] <grogbot> <sev> @Henke37 I have some idea about potentially enabling c++11
[16:17] <grogbot> <sev> @Henke37 willing to help?
[16:22] <grogbot> <Henke37> i wouldn't know how
[16:22] <grogbot> <Henke37> i try to avoid build management stuff
[16:23] <grogbot> <SupSuper> i think there was a PR for it
[16:23] <grogbot> <sev> well, it is not about that
[16:23] <grogbot> <sev> it is about introducing another configure flag, something like --test-c++11
[16:23] <grogbot> <sev> and then when this flag is enabled, but into a single file a no-op thing, but which will use most of the interesting c++11 features
[16:24] <grogbot> <sev> then at the time of release I will ask all the porters to test compiling and running it with this feature
[16:24] <grogbot> <sev> and we understand which ports will potentially stop working if we enable it for the whole project
[16:24] <grogbot> <Henke37> an autoconf flag or something? i don't know autoconf
[16:24] <grogbot> <sev> I need help with writing that test file
[16:25] <grogbot> <sev> I can add that configure file, no problem
[16:25] <grogbot> <Henke37> we have one example already: the <cstdint> include.
[16:25] <grogbot> <sev> there should be one class which I will call from main.cpp, and it should do nothing except debug output
[16:26] <grogbot> <sev> @Henke37 I need .cpp code, not messages on Discord 😄
[16:26] <grogbot> <Henke37> and there is a preprocessor symbol to check the claimed supported c++ version.
[16:27] <grogbot> <sev> does it mean that you don't have time/desire to help?
[16:28] <grogbot> <Henke37> not this exact instant. i'm making dinner
[16:59] --> travis-ci joined #scummvm.
[16:59] <travis-ci> scummvm/scummvm#12551 (master - 22943ee : SupSuper): The build has errored.
[16:59] <travis-ci> Change view : https://github.com/scummvm/scummvm/compare/21778dcb8089...22943ee3688e
[16:59] <travis-ci> Build details : https://travis-ci.org/scummvm/scummvm/builds/664912310
[16:59] travis-ci (travis-ci@ec2-34-235-142-38.compute-1.amazonaws.com) left #scummvm.
[17:11] <LePhilousophe> @sev: do you already know which platform could cause problems?
[17:14] --> ajax16384 joined #scummvm.
[17:14] #scummvm: mode change '+o ajax16384' by ChanServ!ChanServ@services.
[17:15] <bgK> a complaint I have with Common::String is that it's not thread safe because to the Copy on Write stuff. Interestingly with C++11 the spec for std::string was changed to make CoW implementations non-conformant. Which has the interesting side effect of making std::string more thread safe. I was thinking perhaps we should switch to a non-CoW implementation as well.
[17:15] <-- ny00123 left irc: Quit: Leaving
[17:15] <bgK> however I guess we should wait until we switch to C++11 to reduce useless string copies by using move semantics.
[17:30] --> ccawley2011 joined #scummvm.
[17:30] #scummvm: mode change '+o ccawley2011' by ChanServ!ChanServ@services.
[17:30] --> WindlePoons joined #scummvm.
[17:30] WindlePoons (WindlePoo@80-110-56-88.cable.dynamic.surfer.at) left #scummvm.
[17:34] --> BeefEats joined #scummvm.
[17:36] <grogbot> <Henke37> i've been trying to think of a good c++11 test. but i don't have anything better than this. cpp int main() { return __cplusplus; }
[17:37] <bgK> I believe what sev means is exercising the interesting c++11 features, like using a lambda, range based loop, move semantics, perfect forwarding, .. to check whether all our target platforms can handle them
[17:37] <grogbot> <SupSuper> the point isn't to test that c++11 exists, but that c++11 works as expected
[17:38] <grogbot> <SupSuper> and you can't rely on that macro in msvc due to backcompat
[17:38] <grogbot> <SupSuper> this might help: http://www.glenmccl.com/cpp11.htm
[17:39] Nick change: ldevulder_ -> ldevulder
[17:59] --> criezy joined #scummvm.
[17:59] #scummvm: mode change '+o criezy' by ChanServ!ChanServ@services.
[18:14] <grogbot> <aryanrawlani28> > <bgK> I believe what sev means is exercising the interesting c++11 features, like using a lambda, range based loop, move semantics, perfect forwarding, .. to check whether all our target platforms can handle them @Grogbot If a plan is to convert existing codebase to modern cpp, let me know - I'll help as much as I can, i love doing work like this
[18:14] --> travis-ci joined #scummvm.
[18:14] <travis-ci> SupSuper/scummvm#2 (travis - 357053f : SupSuper): The build has errored.
[18:14] <travis-ci> Change view : https://github.com/SupSuper/scummvm/compare/00663b85aceb...357053f48612
[18:14] <travis-ci> Build details : https://travis-ci.org/SupSuper/scummvm/builds/664958973
[18:14] travis-ci (travis-ci@ec2-34-201-108-2.compute-1.amazonaws.com) left #scummvm.
[18:15] --> travis-ci joined #scummvm.
[18:15] <travis-ci> SupSuper/scummvm#1 (master - 22943ee : SupSuper): The build has errored.
[18:15] <travis-ci> Change view : https://github.com/SupSuper/scummvm/compare/21778dcb8089dd2e76520dea1fe2edb1097f4402...22943ee3688eb639528a4878cea65cfac9642599
[18:15] <travis-ci> Build details : https://travis-ci.org/SupSuper/scummvm/builds/664958509
[18:15] travis-ci (travis-ci@ec2-3-91-18-34.compute-1.amazonaws.com) left #scummvm.
[18:35] <grogbot> <SupSuper> whoops sorry about that
[18:45] <-- P2E_ left irc: Quit: Reconnecting
[18:45] --> P2E joined #scummvm.
[19:07] <-- Stormkeeper left irc: Quit: KVIrc 5.0.0 Aria http://www.kvirc.net/
[19:10] --> Stormkeeper joined #scummvm.
[19:24] <-- ajax16384 left irc: Read error: Connection reset by peer
[19:42] --> SylvainTV joined #scummvm.
[19:42] #scummvm: mode change '+o SylvainTV' by ChanServ!ChanServ@services.
[20:01] <-- Tomaz^ left irc: Ping timeout: 246 seconds
[20:42] <grogbot> <SupSuper> @criezy been poking around the mac travis loop and it seems to be related to this: Running ./configure with the last specified parameters seems make keeps trying to reconfigure? might be something off with ccache?
[20:52] <-- waltervn left irc: Quit: Leaving
[20:58] <grogbot> <criezy> @SupSuper I have zero experience with ccache. Maybe that could be the issue. But I have absolutely no idea.
[21:06] Nick change: CommunistWolf -> veggies
[21:06] Nick change: veggies -> CommunistWolf
[21:21] <Scummette> [scummvm] ccawley2011 opened pull request #2156: GPH/DINGUX: Unify the downscaling code (master...downscale) https://git.io/JvM1r
[21:29] <-- Tkachov left irc: Ping timeout: 260 seconds
[21:38] <-- yuv422 left irc: Remote host closed the connection
[21:38] --> yuv422 joined #scummvm.
[21:38] #scummvm: mode change '+o yuv422' by ChanServ!ChanServ@services.
[21:59] --> cd joined #scummvm.
[22:03] <Strangerke> hi guys
[22:04] Action: yuv422 waves
[22:14] <-- ccawley2011 left irc: Quit: Leaving
[22:27] --> _athrxx joined #scummvm.
[22:29] --> Tkachov joined #scummvm.
[22:29] #scummvm: mode change '+o Tkachov' by ChanServ!ChanServ@services.
[22:43] <-- vliaskov left irc: Ping timeout: 256 seconds
[22:43] <-- _athrxx left irc: Quit: Leaving
[23:22] --> NULUSIOS1 joined #scummvm.
[23:27] NULUSIOS1 (nls@mail2.termoil.com) left #scummvm.
[23:44] <-- yuv422 left irc: Remote host closed the connection
[23:44] --> yuv422 joined #scummvm.
[23:44] #scummvm: mode change '+o yuv422' by ChanServ!ChanServ@services.
[00:00] --- Sat Mar 21 2020