[00:04] [scummvm] bluegr pushed 1 new commits to master: https://git.io/JvITo [00:04] scummvm/master 82d5938 bluegr: SCI: Don't error out when updating an item with an invalid plane [00:22] [scummvm] sev- pushed 1 new commits to master: https://git.io/JvIkf [00:22] scummvm/master 1d368c4 sev-: SCI: Added detection for the updated Russian LoL translation [00:23] i have a question for the braintrust about the Language game option [00:23] someone just reported a GK2 bug that isn't a bug, but caused by them having the Language setting set to Spanish [00:24] there is no Spanish version, no Spanish version in the detection table, so it seems that they must have set this themselves [00:25] but, at least for me, that field is always disabled for GK2 games, which is of course good because changing it can only break things [00:25] so my question is, could it sometimes be enabled? or can this only happen by editing the .ini directly? [00:33] [scummvm] sev- pushed 1 new commits to master: https://git.io/JvIkZ [00:33] scummvm/master bbb0eff sev-: SCI: Added md5 for the latest Russian LoL [00:34] ny00123 (~ny00123@5.102.239.60) left irc: Quit: Leaving [00:56] normally, engines which use AdvancedDetector, store list of languages in the .ini [00:57] I do not remember whether it works on SCI. When it is enabled, it is not possible to switch language other than supported for this particular target [00:58] however, nothing prevents from changing the setting in the .ini file. Especially for the engines with detection fallbacl [00:58] thanks, i'm hoping they manually changed it in the ini and didn't mention it [01:02] I just checked. Indeed, SCI also disables other languages. [01:02] so, either detection is non-terminal, or they edited .ini file [01:08] _sev (~sev@scummvm/undead/sev) left irc: Quit: This computer has gone to sleep [01:10] _sev (~sev@scummvm/undead/sev) joined #scummvm. [01:10] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services. [01:14] travis-ci (~travis-ci@ec2-54-210-193-20.compute-1.amazonaws.com) joined #scummvm. [01:14] scummvm/scummvm#11604 (master - 1d368c4 : Eugene Sandulenko): The build has errored. [01:14] Change view : https://github.com/scummvm/scummvm/compare/82d59387ed5f...1d368c432202 [01:14] Build details : https://travis-ci.org/scummvm/scummvm/builds/639274512 [01:14] travis-ci (travis-ci@ec2-54-210-193-20.compute-1.amazonaws.com) left #scummvm. [01:20] [scummvm] bluegr closed pull request #2001: AGI: Add pirated version of GoldRush! to detection table (master...master) https://git.io/Jvkx2 [01:20] [scummvm] bluegr pushed 2 new commits to master: https://git.io/JvIIc [01:20] scummvm/master 5c9d3d7 ZvikaZ: AGI: Add pirated version of GoldRush! to detection table [01:20] scummvm/master 274b166 ZvikaZ: AGI: fixed whitespace error in previous commit [01:27] JohnnyonFlame (~quassel@187.3.224.235) left irc: Read error: Connection reset by peer [02:33] Deledrius (~Deledrius@68.118.138.186) left irc: Quit: App.Exit [02:37] DominusExult (~dominus@port-92-194-120-139.dynamic.as20676.net) joined #scummvm. [02:37] DominusExult (~dominus@port-92-194-120-139.dynamic.as20676.net) left irc: Changing host [02:37] DominusExult (~dominus@unaffiliated/dominus) joined #scummvm. [02:38] Deledrius (~Deledrius@68.118.138.186) joined #scummvm. [02:40] Dominus (~dominus@unaffiliated/dominus) left irc: Ping timeout: 240 seconds [02:40] Nick change: DominusExult -> Dominus [03:08] [scummvm] lolbot-iichan opened pull request #2002: WINTERMUTE: Add flags for SD/HD games and some more detection (master...wme_detection) https://git.io/JvItn [03:40] Deledrius (~Deledrius@68.118.138.186) left irc: Quit: App.Exit [03:46] Deledrius (~Deledrius@68.118.138.186) joined #scummvm. [03:50] _sev (~sev@scummvm/undead/sev) left irc: Read error: Connection reset by peer [03:50] _sev (~sev@scummvm/undead/sev) joined #scummvm. [03:50] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services. [04:06] Strangerke_ (~Strangerk@cust-208-39-111-94.dyn.as47377.net) joined #scummvm. [04:07] cd (~cd@unaffiliated/cd) left irc: Quit: cd [04:09] Strangerke (~Strangerk@cust-208-39-111-94.dyn.as47377.net) left irc: Ping timeout: 260 seconds [04:09] Nick change: Strangerke_ -> Strangerke [06:13] dreammaster (~dreammast@c-73-241-66-252.hsd1.ca.comcast.net) left irc: [06:20] thesquib (~thesquib@192.241.198.27) left irc: Quit: ZNC - http://znc.in [06:29] thesquib (~thesquib@192.241.198.27) joined #scummvm. [06:30] Begasus (~begasus@ptr-4qba4ec1ypvlhj6e911.18120a2.ip6.access.telenet.be) joined #scummvm. [06:37] Strangerke (~Strangerk@cust-208-39-111-94.dyn.as47377.net) left irc: Read error: Connection reset by peer [06:38] Strangerke (~Strangerk@cust-208-39-111-94.dyn.as47377.net) joined #scummvm. [06:47] eriktorbjorn (d91tan@213-65-60-100-no2480.tbcn.telia.com) left #scummvm. [06:48] ldevulder_ (~ldevulder@176.177.124.161) joined #scummvm. [06:52] ldevulder__ (~ldevulder@176.167.143.59) left irc: Ping timeout: 268 seconds [07:08] Nick change: Harekiet_ -> Harekiet [07:48] Begasus (~begasus@ptr-4qba4ec1ypvlhj6e911.18120a2.ip6.access.telenet.be) left irc: Ping timeout: 252 seconds [07:49] Begasus (~begasus@ptr-4qba4ec1ypvlhj6e911.18120a2.ip6.access.telenet.be) joined #scummvm. [07:58] _sev (~sev@scummvm/undead/sev) left irc: Quit: This computer has gone to sleep [08:00] Begas_VBox (~Begasus@d54C05BEA.access.telenet.be) joined #scummvm. [08:02] SylvainTV (~Sylvain@lfbn-lil-1-491-186.w81-49.abo.wanadoo.fr) left irc: Read error: Connection reset by peer [08:05] Nick change: ldevulder_ -> ldevulder [08:16] ldevulder (~ldevulder@176.177.124.161) left irc: Quit: Leaving [08:23] ldevulder (~ldevulder@176.177.124.161) joined #scummvm. [08:30] Begas_VBox (~Begasus@d54C05BEA.access.telenet.be) left irc: Quit: Vision[0.10.3]: i've been blurred! [09:01] Cheeseness (~cheesenes@ppp118-208-241-220.bras1.hba2.internode.on.net) left irc: Quit: Leaving. [09:17] Cheeseness (~cheesenes@ppp118-208-241-220.bras1.hba2.internode.on.net) joined #scummvm. [09:21] spookypeanut (~spookypea@88.97.46.77) joined #scummvm. [09:33] BeefEats (~BeefEats@unaffiliated/beefeats) left irc: Read error: Connection reset by peer [11:07] Strangerke_ (~Strangerk@cust-208-39-111-94.dyn.as47377.net) joined #scummvm. [11:09] Strangerke (~Strangerk@cust-208-39-111-94.dyn.as47377.net) left irc: Ping timeout: 272 seconds [11:09] Nick change: Strangerke_ -> Strangerke [11:24] spookypeanut (~spookypea@88.97.46.77) left irc: Remote host closed the connection [11:53] P2E_ (~tgz@209.251.45.7) joined #scummvm. [11:56] P2E (~tgz@209.251.45.7) left irc: Ping timeout: 258 seconds [12:03] vliaskov (~vliaskov@x4dbf8aa6.dyn.telefonica.de) joined #scummvm. [12:24] Strangerke (~Strangerk@cust-208-39-111-94.dyn.as47377.net) left irc: Read error: Connection reset by peer [12:25] Strangerke (~Strangerk@cust-208-39-111-94.dyn.as47377.net) joined #scummvm. [13:00] timofonic (~timofonic@unaffiliated/timofonic) joined #scummvm. [13:17] cd (~cd@unaffiliated/cd) joined #scummvm. [13:52] Lightkey (~Darklock@p200300F693C0487022CF30FFFE083718.dip0.t-ipconnect.de) left irc: Ping timeout: 260 seconds [13:54] [scummvm] ccawley2011 pushed 1 new commits to master: https://git.io/JvIBL [14:05] Lightkey (~Darklock@p200300F693C0484722CF30FFFE083718.dip0.t-ipconnect.de) joined #scummvm. [14:49] nutron (~nutron@unaffiliated/nutron) left irc: Ping timeout: 260 seconds [14:50] nutron (~nutron@unaffiliated/nutron) joined #scummvm. [15:39] delacroix (~delacroix@ip5b43a60b.dynamic.kabel-deutschland.de) left irc: Read error: Connection reset by peer [15:44] delacroix (~delacroix@ip5b43a60b.dynamic.kabel-deutschland.de) joined #scummvm. [16:19] scummvm/master 24b9e9f ccawley2011: ANDROID: Remove old and broken keymapper code [16:19] [scummvm] ccawley2011 pushed 1 new commits to master: https://git.io/JvIa8 [16:19] scummvm/master 5950644 ccawley2011: ANDROID: Check the KeyEvent source instead of using getRmbGuard() [16:24] marcus_c (~marcus@bahamut.mc.pp.se) left irc: Ping timeout: 248 seconds [16:25] marcus_c (~marcus@bahamut.mc.pp.se) joined #scummvm. [16:46] ny00123 (~ny00123@5.102.239.60) joined #scummvm. [16:47] marcus_c (~marcus@bahamut.mc.pp.se) left irc: Ping timeout: 248 seconds [16:48] marcus_c (~marcus@bahamut.mc.pp.se) joined #scummvm. [17:04] timofonic (~timofonic@unaffiliated/timofonic) left irc: Remote host closed the connection [17:10] timofonic (~timofonic@unaffiliated/timofonic) joined #scummvm. [17:16] ajax16384 (~User@109.60.130.33) joined #scummvm. [17:16] #scummvm: mode change '+o ajax16384' by ChanServ!ChanServ@services. [17:22] [scummvm] ZvikaZ opened pull request #2003: README: Added debug console information for AGI and SCI (master...master) https://git.io/JvIwW [17:36] Should we be worried about these warnings? /data/sharedrepo/engines/sword25/kernel/inputpersistenceblock.cpp: In member function 'void Sword25::InputPersistenceBlock::read(float&)': /data/sharedrepo/engines/sword25/kernel/inputpersistenceblock.cpp:78:27: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] value = ((float *)tmp)[0]; ^ C++ [17:36] engines/sword25/kernel/persistenceservice.o C++ engines/sword25/kernel/resmanager.o /data/sharedrepo/engines/sword25/kernel/outputpersistenceblock.cpp: In member function 'void Sword25::OutputPersistenceBlock::write(float)': /data/sharedrepo/engines/sword25/kernel/outputpersistenceblock.cpp:67:18: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] ((float *)tmp)[0] = value; ^ [17:40] [scummvm] sev- pushed 2 new commits to master: https://git.io/JvIwP [17:40] scummvm/master fa9d525 sev-: CONFIGURE: Added option for enabling clang Address Sanitizer [17:40] scummvm/master 841b125 sev-: DIRECTOR: Added sanity check to score parsing [17:42] from the look of the function names, that looks like save code that is indeed of refactoring. there already exists code to serialize primitive types [17:45] Begasus (~begasus@ptr-4qba4ec1ypvlhj6e911.18120a2.ip6.access.telenet.be) left irc: Quit: Ex-Chat [17:52] _sev (~sev@scummvm/undead/sev) joined #scummvm. [17:52] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services. [18:00] Scummette (~Scummette@roberta.scummvm.net) left irc: Ping timeout: 252 seconds [18:00] Scummette (~Scummette@roberta.scummvm.net) joined #scummvm. [18:03] [scummvm] Mataniko closed pull request #2003: README: Added debug console information for AGI and SCI (master...master) https://git.io/JvIwW [18:03] [scummvm] Mataniko pushed 1 new commits to master: https://git.io/JvIr8 [18:03] scummvm/master b13bb12 ZvikaZ: README: Added debug console information for AGI and SCI [18:04] Raziel^ (~Raziel@ipbcc15a0c.dynamic.kabel-deutschland.de) joined #scummvm. [18:04] #scummvm: mode change '+v Raziel^' by ChanServ!ChanServ@services. [18:16] JohnnyonFlame (~quassel@187.3.224.235) joined #scummvm. [18:51] Different platforms give different warnings. THe above was PSP, on Vita I also get this in addition: /data/sharedrepo/engines/titanic/sound/music_room_handler.cpp: In member function 'void Titanic::CMusicRoomHandler::setSpeedControl2(Titanic::MusicInstrument, int)': /data/sharedrepo/engines/titanic/sound/music_room_handler.cpp:131:17: warning: comparison is always true due to limited range of data type [-Wtype-limits] if (instrument [18:51] >= BELLS && instrument <= BASS && value >= -2 && value <= 2) ~~~~~~~~~~~^~~~~~~~ [18:51] Something in Starship Titanic. [18:54] It is using types like "int" instead of "int32_t" etc. so depending on platform, these will have different bitwidths [18:54] sounds like a portability issue [19:22] SylvainTV (~Sylvain@lfbn-lil-1-240-153.w90-45.abo.wanadoo.fr) joined #scummvm. [19:22] #scummvm: mode change '+o SylvainTV' by ChanServ!ChanServ@services. [19:37] vliaskov (~vliaskov@x4dbf8aa6.dyn.telefonica.de) left irc: Remote host closed the connection [20:00] bazaar (~bazaar@unaffiliated/bazaar) left irc: Quit: leaving [20:04] Raziel^ (~Raziel@ipbcc15a0c.dynamic.kabel-deutschland.de) left irc: Read error: Connection reset by peer [20:12] ajax16384 (~User@109.60.130.33) left irc: Read error: Connection reset by peer [20:31] Scummette (~Scummette@roberta.scummvm.net) left irc: Ping timeout: 252 seconds [20:31] Scummette (~Scummette@roberta.scummvm.net) joined #scummvm. [20:37] BeefEats (~BeefEats@unaffiliated/beefeats) joined #scummvm. [20:52] criezy (~criezy@host86-153-233-9.range86-153.btcentralplus.com) joined #scummvm. [20:52] #scummvm: mode change '+o criezy' by ChanServ!ChanServ@services. [20:54] I suppose warnings like this are no concern? ../scummvm/engines/composer/saveload.cpp:139:9: warning: 'id' may be used uninitialized in this function [-Wmaybe-uninitialized] 139 | uint16 id; | ^~ [20:54] "Maybe" sounds like no problem to me. [21:04] ny00123_ (~ny00123@31.210.177.39) joined #scummvm. [21:05] ny00123 (~ny00123@5.102.239.60) left irc: Ping timeout: 260 seconds [21:33] [scummvm] ScummVM-Translations pushed 1 new commits to master: https://git.io/JvIP9 [21:33] scummvm/master 36ae7ec sev-: PRINCE: I18N: Update translation (English) [21:35] [scummvm] ccawley2011 pushed 1 new commits to master: https://git.io/JvIPd [21:35] scummvm/master c9824ad ccawley2011: ANDROID: Improve handling of system keys [22:04] [scummvm] ScummVM-Translations pushed 1 new commits to master: https://git.io/JvIXE [22:04] scummvm/master 5536b61 sev-: PRINCE: I18N: Update translation (Russian) [22:08] It depends on how the variables are used. For example if you have a loop for i 0..10, and then do a "if (i > 3) id = 99 else if (i > 6) debug("%d", id);. In this case, id can't be used without having being set, but it's too complicated for the compiler to realize that. But there might be cases where the warning is legitimate. [22:11] criezy (~criezy@host86-153-233-9.range86-153.btcentralplus.com) left irc: Quit: criezy [22:12] Probably a good idea to explicitly set the variables to stop the warning, even if it's not strictly needed. Just like what we do with the explicit comment for switch statement fall-throughs, so the compiler doesn't warning about missing breaks [22:12] Or simplify the code so that the analyzer can understand it too 🙂 [22:13] Yep, if feasible. 🙂 [22:13] [scummvm] antoniou79 pushed 1 new commits to master: https://git.io/JvIXw [22:13] scummvm/master 33b4710 antoniou79: BLADERUNNER: RESTOREDCONTENT: Leary's line about Zuben for ESP and ITA [22:17] [scummvm] ccawley2011 opened pull request #2004: BACKENDS: Add more keycodes (master...keys) https://git.io/JvIXM [22:19] ldevulder_ (~ldevulder@i15-lef02-th2-89-83-218-89.ft.lns.abo.bbox.fr) joined #scummvm. [22:21] #scummvm: mode change '+o Strangerke' by ChanServ!ChanServ@services. [22:22] ldevulder (~ldevulder@176.177.124.161) left irc: Ping timeout: 272 seconds [22:23] [scummvm] sev- pushed 1 new commits to master: https://git.io/JvIXQ [22:23] scummvm/master 54f42fb sev-: DIRECTOR: Added sanity check for reading BITD images [22:56] ldevulder__ (~ldevulder@176.167.25.169) joined #scummvm. [22:57] [scummvm] bluegr pushed 1 new commits to master: https://git.io/JvI1u [23:00] ldevulder_ (~ldevulder@i15-lef02-th2-89-83-218-89.ft.lns.abo.bbox.fr) left irc: Ping timeout: 268 seconds [23:01] cd (~cd@unaffiliated/cd) left irc: Quit: cd [23:03] Scummette (~Scummette@roberta.scummvm.net) left irc: Ping timeout: 252 seconds [23:03] Scummette (~Scummette@roberta.scummvm.net) joined #scummvm. [23:24] [scummvm] bluegr pushed 1 new commits to master: https://git.io/JvIM3 [23:24] scummvm/master b6cb87b bluegr: SCI: Promote Inside the Chest/Behind the Developer's Shield to testing [23:30] ny00123_ (~ny00123@31.210.177.39) left irc: Quit: Leaving [23:59] joostp (~joostp@scummvm/undead/joostp) left irc: Ping timeout: 258 seconds [00:00] --- Tue Jan 21 2020