ScummVM IRC Log - 20 Jan 2020

[Back to Index]

[00:04] <Scummette> [scummvm] bluegr pushed 1 new commits to master: https://git.io/JvITo
[00:04] <Scummette> scummvm/master 82d5938 bluegr: SCI: Don't error out when updating an item with an invalid plane
[00:22] <Scummette> [scummvm] sev- pushed 1 new commits to master: https://git.io/JvIkf
[00:22] <Scummette> scummvm/master 1d368c4 sev-: SCI: Added detection for the updated Russian LoL translation
[00:23] <grogbot> <sluicebox> i have a question for the braintrust about the Language game option
[00:23] <grogbot> <sluicebox> someone just reported a GK2 bug that isn't a bug, but caused by them having the Language setting set to Spanish
[00:24] <grogbot> <sluicebox> there is no Spanish version, no Spanish version in the detection table, so it seems that they must have set this themselves
[00:25] <grogbot> <sluicebox> but, at least for me, that field is always disabled for GK2 games, which is of course good because changing it can only break things
[00:25] <grogbot> <sluicebox> so my question is, could it sometimes be enabled? or can this only happen by editing the .ini directly?
[00:33] <Scummette> [scummvm] sev- pushed 1 new commits to master: https://git.io/JvIkZ
[00:33] <Scummette> scummvm/master bbb0eff sev-: SCI: Added md5 for the latest Russian LoL
[00:34] <-- ny00123 left irc: Quit: Leaving
[00:56] <grogbot> <sev> normally, engines which use AdvancedDetector, store list of languages in the .ini
[00:57] <grogbot> <sev> I do not remember whether it works on SCI. When it is enabled, it is not possible to switch language other than supported for this particular target
[00:58] <grogbot> <sev> however, nothing prevents from changing the setting in the .ini file. Especially for the engines with detection fallbacl
[00:58] <grogbot> <sluicebox> thanks, i'm hoping they manually changed it in the ini and didn't mention it
[01:02] <grogbot> <sev> I just checked. Indeed, SCI also disables other languages.
[01:02] <grogbot> <sev> so, either detection is non-terminal, or they edited .ini file
[01:08] <-- _sev left irc: Quit: This computer has gone to sleep
[01:10] --> _sev joined #scummvm.
[01:10] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[01:14] --> travis-ci joined #scummvm.
[01:14] <travis-ci> scummvm/scummvm#11604 (master - 1d368c4 : Eugene Sandulenko): The build has errored.
[01:14] <travis-ci> Change view : https://github.com/scummvm/scummvm/compare/82d59387ed5f...1d368c432202
[01:14] <travis-ci> Build details : https://travis-ci.org/scummvm/scummvm/builds/639274512
[01:14] travis-ci (travis-ci@ec2-54-210-193-20.compute-1.amazonaws.com) left #scummvm.
[01:20] <Scummette> [scummvm] bluegr closed pull request #2001: AGI: Add pirated version of GoldRush! to detection table (master...master) https://git.io/Jvkx2
[01:20] <Scummette> [scummvm] bluegr pushed 2 new commits to master: https://git.io/JvIIc
[01:20] <Scummette> scummvm/master 5c9d3d7 ZvikaZ: AGI: Add pirated version of GoldRush! to detection table
[01:20] <Scummette> scummvm/master 274b166 ZvikaZ: AGI: fixed whitespace error in previous commit
[01:27] <-- JohnnyonFlame left irc: Read error: Connection reset by peer
[02:33] <-- Deledrius left irc: Quit: App.Exit
[02:37] --> DominusExult joined #scummvm.
[02:37] <-- DominusExult left irc: Changing host
[02:37] --> DominusExult joined #scummvm.
[02:38] --> Deledrius joined #scummvm.
[02:40] <-- Dominus left irc: Ping timeout: 240 seconds
[02:40] Nick change: DominusExult -> Dominus
[03:08] <Scummette> [scummvm] lolbot-iichan opened pull request #2002: WINTERMUTE: Add flags for SD/HD games and some more detection (master...wme_detection) https://git.io/JvItn
[03:40] <-- Deledrius left irc: Quit: App.Exit
[03:46] --> Deledrius joined #scummvm.
[03:50] <-- _sev left irc: Read error: Connection reset by peer
[03:50] --> _sev joined #scummvm.
[03:50] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[04:06] --> Strangerke_ joined #scummvm.
[04:07] <-- cd left irc: Quit: cd
[04:09] <-- Strangerke left irc: Ping timeout: 260 seconds
[04:09] Nick change: Strangerke_ -> Strangerke
[06:13] <-- dreammaster left irc:
[06:20] <-- thesquib left irc: Quit: ZNC - http://znc.in
[06:29] --> thesquib joined #scummvm.
[06:30] --> Begasus joined #scummvm.
[06:37] <-- Strangerke left irc: Read error: Connection reset by peer
[06:38] --> Strangerke joined #scummvm.
[06:47] eriktorbjorn (d91tan@213-65-60-100-no2480.tbcn.telia.com) left #scummvm.
[06:48] --> ldevulder_ joined #scummvm.
[06:52] <-- ldevulder__ left irc: Ping timeout: 268 seconds
[07:08] Nick change: Harekiet_ -> Harekiet
[07:48] <-- Begasus left irc: Ping timeout: 252 seconds
[07:49] --> Begasus joined #scummvm.
[07:58] <-- _sev left irc: Quit: This computer has gone to sleep
[08:00] --> Begas_VBox joined #scummvm.
[08:02] <-- SylvainTV left irc: Read error: Connection reset by peer
[08:05] Nick change: ldevulder_ -> ldevulder
[08:16] <-- ldevulder left irc: Quit: Leaving
[08:23] --> ldevulder joined #scummvm.
[08:30] <-- Begas_VBox left irc: Quit: Vision[0.10.3]: i've been blurred!
[09:01] <-- Cheeseness left irc: Quit: Leaving.
[09:17] --> Cheeseness joined #scummvm.
[09:21] --> spookypeanut joined #scummvm.
[09:33] <-- BeefEats left irc: Read error: Connection reset by peer
[11:07] --> Strangerke_ joined #scummvm.
[11:09] <-- Strangerke left irc: Ping timeout: 272 seconds
[11:09] Nick change: Strangerke_ -> Strangerke
[11:24] <-- spookypeanut left irc: Remote host closed the connection
[11:53] --> P2E_ joined #scummvm.
[11:56] <-- P2E left irc: Ping timeout: 258 seconds
[12:03] --> vliaskov joined #scummvm.
[12:24] <-- Strangerke left irc: Read error: Connection reset by peer
[12:25] --> Strangerke joined #scummvm.
[13:00] --> timofonic joined #scummvm.
[13:17] --> cd joined #scummvm.
[13:52] <-- Lightkey left irc: Ping timeout: 260 seconds
[13:54] <Scummette> [scummvm] ccawley2011 pushed 1 new commits to master: https://git.io/JvIBL
[14:05] --> Lightkey joined #scummvm.
[14:49] <-- nutron left irc: Ping timeout: 260 seconds
[14:50] --> nutron joined #scummvm.
[15:39] <-- delacroix left irc: Read error: Connection reset by peer
[15:44] --> delacroix joined #scummvm.
[16:19] <Scummette> scummvm/master 24b9e9f ccawley2011: ANDROID: Remove old and broken keymapper code
[16:19] <Scummette> [scummvm] ccawley2011 pushed 1 new commits to master: https://git.io/JvIa8
[16:19] <Scummette> scummvm/master 5950644 ccawley2011: ANDROID: Check the KeyEvent source instead of using getRmbGuard()
[16:24] <-- marcus_c left irc: Ping timeout: 248 seconds
[16:25] --> marcus_c joined #scummvm.
[16:46] --> ny00123 joined #scummvm.
[16:47] <-- marcus_c left irc: Ping timeout: 248 seconds
[16:48] --> marcus_c joined #scummvm.
[17:04] <-- timofonic left irc: Remote host closed the connection
[17:10] --> timofonic joined #scummvm.
[17:16] --> ajax16384 joined #scummvm.
[17:16] #scummvm: mode change '+o ajax16384' by ChanServ!ChanServ@services.
[17:22] <Scummette> [scummvm] ZvikaZ opened pull request #2003: README: Added debug console information for AGI and SCI (master...master) https://git.io/JvIwW
[17:36] <grogbot> <rsn8887> Should we be worried about these warnings? /data/sharedrepo/engines/sword25/kernel/inputpersistenceblock.cpp: In member function 'void Sword25::InputPersistenceBlock::read(float&)': /data/sharedrepo/engines/sword25/kernel/inputpersistenceblock.cpp:78:27: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] value = ((float *)tmp)[0]; ^ C++
[17:36] <grogbot> engines/sword25/kernel/persistenceservice.o C++ engines/sword25/kernel/resmanager.o /data/sharedrepo/engines/sword25/kernel/outputpersistenceblock.cpp: In member function 'void Sword25::OutputPersistenceBlock::write(float)': /data/sharedrepo/engines/sword25/kernel/outputpersistenceblock.cpp:67:18: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] ((float *)tmp)[0] = value; ^
[17:40] <Scummette> [scummvm] sev- pushed 2 new commits to master: https://git.io/JvIwP
[17:40] <Scummette> scummvm/master fa9d525 sev-: CONFIGURE: Added option for enabling clang Address Sanitizer
[17:40] <Scummette> scummvm/master 841b125 sev-: DIRECTOR: Added sanity check to score parsing
[17:42] <grogbot> <Henke37> from the look of the function names, that looks like save code that is indeed of refactoring. there already exists code to serialize primitive types
[17:45] <-- Begasus left irc: Quit: Ex-Chat
[17:52] --> _sev joined #scummvm.
[17:52] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[18:00] <-- Scummette left irc: Ping timeout: 252 seconds
[18:00] --> Scummette joined #scummvm.
[18:03] <Scummette> [scummvm] Mataniko closed pull request #2003: README: Added debug console information for AGI and SCI (master...master) https://git.io/JvIwW
[18:03] <Scummette> [scummvm] Mataniko pushed 1 new commits to master: https://git.io/JvIr8
[18:03] <Scummette> scummvm/master b13bb12 ZvikaZ: README: Added debug console information for AGI and SCI
[18:04] --> Raziel^ joined #scummvm.
[18:04] #scummvm: mode change '+v Raziel^' by ChanServ!ChanServ@services.
[18:16] --> JohnnyonFlame joined #scummvm.
[18:51] <grogbot> <rsn8887> Different platforms give different warnings. THe above was PSP, on Vita I also get this in addition: /data/sharedrepo/engines/titanic/sound/music_room_handler.cpp: In member function 'void Titanic::CMusicRoomHandler::setSpeedControl2(Titanic::MusicInstrument, int)': /data/sharedrepo/engines/titanic/sound/music_room_handler.cpp:131:17: warning: comparison is always true due to limited range of data type [-Wtype-limits] if (instrument
[18:51] <grogbot> >= BELLS && instrument <= BASS && value >= -2 && value <= 2) ~~~~~~~~~~~^~~~~~~~
[18:51] <grogbot> <rsn8887> Something in Starship Titanic.
[18:54] <grogbot> <rsn8887> It is using types like "int" instead of "int32_t" etc. so depending on platform, these will have different bitwidths
[18:54] <grogbot> <Henke37> sounds like a portability issue
[19:22] --> SylvainTV joined #scummvm.
[19:22] #scummvm: mode change '+o SylvainTV' by ChanServ!ChanServ@services.
[19:37] <-- vliaskov left irc: Remote host closed the connection
[20:00] <-- bazaar left irc: Quit: leaving
[20:04] <-- Raziel^ left irc: Read error: Connection reset by peer
[20:12] <-- ajax16384 left irc: Read error: Connection reset by peer
[20:31] <-- Scummette left irc: Ping timeout: 252 seconds
[20:31] --> Scummette joined #scummvm.
[20:37] --> BeefEats joined #scummvm.
[20:52] --> criezy joined #scummvm.
[20:52] #scummvm: mode change '+o criezy' by ChanServ!ChanServ@services.
[20:54] <grogbot> <rsn8887> I suppose warnings like this are no concern? ../scummvm/engines/composer/saveload.cpp:139:9: warning: 'id' may be used uninitialized in this function [-Wmaybe-uninitialized] 139 | uint16 id; | ^~
[20:54] <grogbot> <rsn8887> "Maybe" sounds like no problem to me.
[21:04] --> ny00123_ joined #scummvm.
[21:05] <-- ny00123 left irc: Ping timeout: 260 seconds
[21:33] <Scummette> [scummvm] ScummVM-Translations pushed 1 new commits to master: https://git.io/JvIP9
[21:33] <Scummette> scummvm/master 36ae7ec sev-: PRINCE: I18N: Update translation (English)
[21:35] <Scummette> [scummvm] ccawley2011 pushed 1 new commits to master: https://git.io/JvIPd
[21:35] <Scummette> scummvm/master c9824ad ccawley2011: ANDROID: Improve handling of system keys
[22:04] <Scummette> [scummvm] ScummVM-Translations pushed 1 new commits to master: https://git.io/JvIXE
[22:04] <Scummette> scummvm/master 5536b61 sev-: PRINCE: I18N: Update translation (Russian)
[22:08] <grogbot> <DreamMaster> It depends on how the variables are used. For example if you have a loop for i 0..10, and then do a "if (i > 3) id = 99 else if (i > 6) debug("%d", id);. In this case, id can't be used without having being set, but it's too complicated for the compiler to realize that. But there might be cases where the warning is legitimate.
[22:11] <-- criezy left irc: Quit: criezy
[22:12] <grogbot> <DreamMaster> Probably a good idea to explicitly set the variables to stop the warning, even if it's not strictly needed. Just like what we do with the explicit comment for switch statement fall-throughs, so the compiler doesn't warning about missing breaks
[22:12] <grogbot> <madmoose> Or simplify the code so that the analyzer can understand it too 🙂
[22:13] <grogbot> <DreamMaster> Yep, if feasible. 🙂
[22:13] <Scummette> [scummvm] antoniou79 pushed 1 new commits to master: https://git.io/JvIXw
[22:13] <Scummette> scummvm/master 33b4710 antoniou79: BLADERUNNER: RESTOREDCONTENT: Leary's line about Zuben for ESP and ITA
[22:17] <Scummette> [scummvm] ccawley2011 opened pull request #2004: BACKENDS: Add more keycodes (master...keys) https://git.io/JvIXM
[22:19] --> ldevulder_ joined #scummvm.
[22:21] #scummvm: mode change '+o Strangerke' by ChanServ!ChanServ@services.
[22:22] <-- ldevulder left irc: Ping timeout: 272 seconds
[22:23] <Scummette> [scummvm] sev- pushed 1 new commits to master: https://git.io/JvIXQ
[22:23] <Scummette> scummvm/master 54f42fb sev-: DIRECTOR: Added sanity check for reading BITD images
[22:56] --> ldevulder__ joined #scummvm.
[22:57] <Scummette> [scummvm] bluegr pushed 1 new commits to master: https://git.io/JvI1u
[23:00] <-- ldevulder_ left irc: Ping timeout: 268 seconds
[23:01] <-- cd left irc: Quit: cd
[23:03] <-- Scummette left irc: Ping timeout: 252 seconds
[23:03] --> Scummette joined #scummvm.
[23:24] <Scummette> [scummvm] bluegr pushed 1 new commits to master: https://git.io/JvIM3
[23:24] <Scummette> scummvm/master b6cb87b bluegr: SCI: Promote Inside the Chest/Behind the Developer's Shield to testing
[23:30] <-- ny00123_ left irc: Quit: Leaving
[23:59] <-- joostp left irc: Ping timeout: 258 seconds
[00:00] --- Tue Jan 21 2020