[Back to Index]

[01:21] <-- ccawley2011 left irc: Quit: Page closed
[02:11] <-- SylvainTV left irc: Read error: Connection reset by peer
[02:19] --> dreammaster joined #scummvm.
[02:19] #scummvm: mode change '+o dreammaster' by ChanServ!ChanServ@services.
[02:40] --> DominusExult joined #scummvm.
[02:42] <-- Dominus left irc: Ping timeout: 260 seconds
[02:42] Nick change: DominusExult -> Dominus
[03:19] <-- m_kiewitz left irc: Quit: technology isn't intrinsically good or evil. It's how it's used. Like the Death Ray.
[05:19] --> scummvm_github joined #scummvm.
[05:19] <scummvm_github> [scummvm] digitall pushed 4 new commits to master: https://git.io/fpZth
[05:19] <scummvm_github> scummvm/master 6227cc8 Cameron Cawley: BUILD: Add a rule to print the current ScummVM version
[05:19] <scummvm_github> scummvm/master 0170f39 Cameron Cawley: PSP: Don't hard-code the version and list of data files in the build script
[05:19] <scummvm_github> scummvm/master 6360c7e Cameron Cawley: PSP: Add README.PSP to the output of the print-dists rule
[05:19] scummvm_github (scummvm_gi@gateway/service/github.com/x-xqbxcdmnpqignhlv) left #scummvm.
[06:06] <-- tsoliman left irc: Ping timeout: 246 seconds
[06:08] <-- Dark-Star left irc: Ping timeout: 252 seconds
[06:12] --> Dark-Star joined #scummvm.
[06:22] <-- dreammaster left irc:
[06:43] --> mlk joined #scummvm.
[06:55] <-- SupSuper left irc: Quit: Rip
[06:59] --> tsoliman joined #scummvm.
[06:59] #scummvm: mode change '+o tsoliman' by ChanServ!ChanServ@services.
[07:15] <-- Strangerke left irc: Ping timeout: 246 seconds
[07:51] <-- mlk left irc: Quit: My iMac has gone to sleep. ZZZzzz&
[08:06] --> ny00123 joined #scummvm.
[09:14] --> m_kiewitz joined #scummvm.
[09:14] #scummvm: mode change '+o m_kiewitz' by ChanServ!ChanServ@services.
[09:15] --> scummvm_github joined #scummvm.
[09:15] <scummvm_github> [scummvm] digitall pushed 1 new commit to master: https://git.io/fpZc1
[09:15] <scummvm_github> scummvm/master 8c6f9e5 Cameron Cawley: WIN32: Retrieve the version information for the resource script from base/internal_version.h
[09:15] scummvm_github (scummvm_gi@gateway/service/github.com/x-qrlzmjduhwacpldf) left #scummvm.
[09:15] <-- emmalyn left irc: Ping timeout: 272 seconds
[09:53] <-- joostp left irc: Ping timeout: 268 seconds
[09:53] <-- mataniko left irc: Ping timeout: 268 seconds
[09:53] --> mataniko joined #scummvm.
[09:57] --> emmalyn joined #scummvm.
[09:59] --> joostp joined #scummvm.
[09:59] #scummvm: mode change '+o joostp' by ChanServ!ChanServ@services.
[10:16] --> emmalyn_ joined #scummvm.
[10:17] <-- emmalyn left irc: Read error: Connection reset by peer
[11:10] --> mlk joined #scummvm.
[11:33] <-- mlk left irc: Quit: My iMac has gone to sleep. ZZZzzz&
[11:40] --> mlk joined #scummvm.
[12:34] <-- ny00123 left irc: Quit: Leaving
[12:53] <-- Deledrius left irc: Quit: App.Exit
[12:58] --> Deledrius joined #scummvm.
[13:53] <-- Deledrius left irc: Quit: App.Exit
[14:08] --> Deledrius joined #scummvm.
[14:20] --> Littleboy joined #scummvm.
[14:20] #scummvm: mode change '+o Littleboy' by ChanServ!ChanServ@services.
[14:24] --> m-kiewitz joined #scummvm.
[14:24] <-- m-kiewitz left irc: Changing host
[14:24] --> m-kiewitz joined #scummvm.
[14:24] #scummvm: mode change '+o m-kiewitz' by ChanServ!ChanServ@services.
[14:27] <-- m_kiewitz left irc: Ping timeout: 272 seconds
[14:55] --> scummvm_github joined #scummvm.
[14:55] <scummvm_github> [scummvm] Mataniko pushed 1 new commit to master: https://git.io/fpZyO
[14:55] <scummvm_github> scummvm/master e2e1ec2 Matan Bareket: GITHUB: Add Pull Request template
[14:55] scummvm_github (scummvm_gi@gateway/service/github.com/x-llmxssfkgsnikuax) left #scummvm.
[15:12] --> waltervn joined #scummvm.
[15:12] #scummvm: mode change '+o waltervn' by ChanServ!ChanServ@services.
[15:14] <bgK> mataniko: doesn't CONTRIBUTING.md already links to the rules that need to be followed when opening pull requests?
[15:15] <mataniko> it does, but this populates the actual PR
[15:16] <mataniko> so when you open a PR it's prefilled with instructions
[15:17] <bgK> isn't PULL_REQUEST_TEMPLATE.md rather meant to provide guidance to properly write the PR description?
[15:20] --> ccawley2011 joined #scummvm.
[15:21] <mataniko> it does so by pre-populating the message though
[15:21] <mataniko> I'm not sure what you're asking
[15:22] <bgK> it feels to me with this change we are filling the PR description field with text that is not a pull request template and needs to be deleted each time
[15:29] <mataniko> if the end result is well formatted PRs that saves us time on asking people to fix commit messages and PR messages it's a win
[15:29] <mataniko> it's a paragraph of instructions and then the template we want
[15:30] <mataniko> and can be adjusted
[15:30] <mataniko> or removed if no one likes it
[16:11] Nick change: emmalyn_ -> emmalyn
[16:12] --> scummvm_github joined #scummvm.
[16:12] <scummvm_github> [scummvm] Kawa-oneechan opened pull request #1397: SCI: Add support for The Dating Pool (master...master) https://git.io/fpZNI
[16:12] scummvm_github (scummvm_gi@gateway/service/github.com/x-euwjjsxzkqvbfwgr) left #scummvm.

[16:45] --> ajax16384 joined #scummvm.
[16:45] #scummvm: mode change '+o ajax16384' by ChanServ!ChanServ@services.
[17:38] --> scummvm_github joined #scummvm.
[17:38] <scummvm_github> [scummvm] bgK pushed 2 new commits to master: https://git.io/fpnfn
[17:38] <scummvm_github> scummvm/master 4d36606 Bastien Bouclet: BUILD: Free the a52 state in the configure compilation test...
[17:38] <scummvm_github> scummvm/master 8efe46d Bastien Bouclet: BUILD: Set PKG_CONFIG_LIBDIR only when needed when running configure...
[17:38] scummvm_github (scummvm_gi@gateway/service/github.com/x-uoqgemsgrgxlawbu) left #scummvm.
[18:35] --> scummvm_github joined #scummvm.
[18:35] <scummvm_github> [scummvm] whiterandrek pushed 1 new commit to master: https://git.io/fpnkM
[18:35] <scummvm_github> scummvm/master acac597 Andrei Prykhodko: PINK: fixed null pointer dereference in ConditionInventoryItemOwner...
[18:35] scummvm_github (scummvm_gi@gateway/service/github.com/x-rqbaqtpaoqytwlwa) left #scummvm.
[18:41] <-- mlk left irc: Quit: My iMac has gone to sleep. ZZZzzz&
[19:36] --> Deledrius_ joined #scummvm.
[19:39] <-- Deledrius left irc: Ping timeout: 268 seconds
[19:45] Nick change: Deledrius_ -> Deledrius
[19:50] <-- Deledrius left irc: Quit: App.Exit
[19:50] --> Deledrius joined #scummvm.
[20:17] --> SupSuper joined #scummvm.
[20:25] <-- ajax16384 left irc: Read error: Connection reset by peer
[20:29] --> ajax16384 joined #scummvm.
[20:29] #scummvm: mode change '+o ajax16384' by ChanServ!ChanServ@services.
[21:17] --> Begas_VBox joined #scummvm.
[21:27] <-- ajax16384 left irc: Read error: Connection reset by peer
[21:34] --> scummvm_github joined #scummvm.
[21:34] <scummvm_github> [scummvm] kparal opened pull request #1398: manpage: update cmdline options and hotkeys (master...manpage) https://git.io/fpn8I
[21:34] scummvm_github (scummvm_gi@gateway/service/github.com/x-haxlldjybutcmkoi) left #scummvm.
[21:58] <-- ccawley2011 left irc: Quit: Page closed
[22:51] <-- Begas_VBox left irc: Quit: Vision[0.10.3]: i've been blurred!
[22:59] --> scummvm_github joined #scummvm.
[22:59] <scummvm_github> [scummvm] sluicebox opened pull request #1399: SCI: Fix LB2CD act 5 finale music (master...laurabow2act5finalemusic) https://git.io/fpnu8
[22:59] scummvm_github (scummvm_gi@gateway/service/github.com/x-mkpxgxoniekxbhvj) left #scummvm.
[23:02] <-- m-kiewitz left irc: Ping timeout: 268 seconds
[23:28] --> SylvainTV joined #scummvm.
[23:28] #scummvm: mode change '+o SylvainTV' by ChanServ!ChanServ@services.
[00:00] --- Sat Nov 17 2018