ScummVM IRC Log - 16 Feb 2020

[Back to Index]

[00:02] <grogbot> <_athrxx> You have to do it manually. Read the values from the config manager and do whatever you have to do to your driver/emulator/whatever.
[00:07] --> travis-ci joined #scummvm.
[00:07] <travis-ci> scummvm/scummvm#12062 (master - 1e3bd59 : sluicebox): The build has errored.
[00:07] <travis-ci> Change view : https://github.com/scummvm/scummvm/compare/a2692be73090...1e3bd598ba72
[00:07] <travis-ci> Build details : https://travis-ci.org/scummvm/scummvm/builds/650952286
[00:07] travis-ci (travis-ci@ec2-3-83-81-200.compute-1.amazonaws.com) left #scummvm.
[01:22] <grogbot> <sev> @spookypeanut yay, that is awesome! Use unp.exe (https://www.pcjs.org/disks/pcx86/tools/other/unp/) for unpacking DOS executables. Also, what game do you have in mind? We have many engines started these days
[01:23] <-- Lightkey left irc: Ping timeout: 248 seconds
[01:25] --> Lightkey joined #scummvm.
[01:31] <Scummette> [scummvm] sev- closed pull request #2069: DIRECTOR: LINGO: Fix compiler warning (master...master) https://git.io/Jv8UY
[01:31] <Scummette> [scummvm] sev- pushed 1 new commits to master: https://git.io/Jv8kE
[01:31] <Scummette> scummvm/master 6da0010 jepael: DIRECTOR: LINGO: Fix compiler warning
[01:43] <-- criezy left irc: Quit: criezy
[01:44] <-- _sev left irc: Quit: This computer has gone to sleep
[02:00] <-- ldevulder_ left irc: Remote host closed the connection
[02:00] --> ldevulder_ joined #scummvm.
[02:00] <Scummette> [scummvm] sluicebox pushed 1 new commits to master: https://git.io/Jv8kD
[02:00] <Scummette> scummvm/master 1106194 sluicebox: SCI32: Fix PHANT2 volume scrollbar arrows
[02:23] <-- marcusr left irc: Remote host closed the connection
[02:23] <-- L0ngcat left irc: Remote host closed the connection
[02:25] --> L0ngcat joined #scummvm.
[02:26] --> marcusr joined #scummvm.
[02:28] --> dreammaster joined #scummvm.
[02:28] #scummvm: mode change '+o dreammaster' by ChanServ!ChanServ@services.
[02:37] --> DominusExult joined #scummvm.
[02:37] <-- DominusExult left irc: Changing host
[02:37] --> DominusExult joined #scummvm.
[02:38] <-- Dominus left irc: Ping timeout: 272 seconds
[02:38] Nick change: DominusExult -> Dominus
[05:41] <Scummette> [scummvm] dreammaster pushed 7 new commits to master: https://git.io/Jv8qs
[05:41] <Scummette> scummvm/master 962c796 dreammaster: ULTIMA8: Field renaming for Gump classes
[05:41] <Scummette> scummvm/master 4f0cda0 dreammaster: ULTIMA8: More field renaming of gump classes
[05:41] <Scummette> scummvm/master 17c6ce4 dreammaster: ULTIMA8: Renaming kernel class fields
[05:44] --> Begasus joined #scummvm.
[05:50] <grogbot> <Henke37> and not quite as many finished.
[05:51] <-- Swant left irc: Ping timeout: 608 seconds
[05:58] --> _sev joined #scummvm.
[05:58] <-- _sev left irc: Changing host
[05:58] --> _sev joined #scummvm.
[05:58] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[06:00] <Scummette> [scummvm] sev- pushed 2 new commits to master: https://git.io/Jv8qV
[06:00] <Scummette> scummvm/master 8450584 sev-: DIRECTOR: LINGO: Check score for presense. Makes tests passable again
[06:00] <Scummette> scummvm/master a369a13 sev-: ULTIMA: Fix incorrect assignment
[06:03] <-- _sev left irc: Quit: This computer has gone to sleep
[06:05] --> _sev joined #scummvm.
[06:05] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[06:07] <-- dreammaster left irc:
[06:26] <-- _sev left irc: Ping timeout: 240 seconds
[06:44] --> _sev joined #scummvm.
[06:44] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[06:46] <-- _sev left irc: Read error: Connection reset by peer
[07:36] <-- Scummette left irc: Ping timeout: 272 seconds
[07:36] --> Scummette joined #scummvm.
[07:57] --> ajax16384 joined #scummvm.
[07:57] #scummvm: mode change '+o ajax16384' by ChanServ!ChanServ@services.
[08:37] <-- borosky left irc: Ping timeout: 268 seconds
[08:54] --> borosky joined #scummvm.
[09:27] <-- BeefEats left irc: Read error: Connection reset by peer
[09:57] <Scummette> [scummvm] ZvikaZ opened pull request #2070: SCI: fix MasterVolume to modify music volume, fixing #11012 for KQ6 (master...z_midi_master_volume) https://git.io/Jv8sN
[10:00] <-- tsoliman left irc: Quit: I've been banished!
[10:01] --> tsoliman joined #scummvm.
[10:01] #scummvm: mode change '+o tsoliman' by ChanServ!ChanServ@services.
[10:36] <spookypeanut> Hey @sev! I tried unp on the original dos executable, but it didn't seem to work. I couldn't find anything that did. BUT I did remember that they released a Windows executable (uncompressed) for 11h, so I'm using that :-D
[10:37] <spookypeanut> That also answers your other question: I'm sticking with something that I know to start with! Or at least, something that I at one point knew something similar too but have forgotten everything!
[11:06] <Scummette> [scummvm] bluegr closed pull request #2052: ENGINES: Standardization of debuggers (master...debugger) https://git.io/JvcC1
[11:06] <Scummette> [scummvm] bluegr pushed 73 new commits to master: https://git.io/Jv8Z9
[11:06] <Scummette> scummvm/master 7b721ea dreammaster: ENGINES: Adding debugger to base Engine class
[11:06] <Scummette> scummvm/master 35c30cd dreammaster: ACCESS: Refactor to use Engine debugger
[11:06] <Scummette> scummvm/master 19bf2b7 dreammaster: ADL: Refactor to use Engine debugger
[11:31] <Scummette> [scummvm] lephilousophe pushed 1 new commits to master: https://git.io/Jv8nE
[11:31] <Scummette> scummvm/master b5bd7f4 lephilousophe: CRYOMNI3D: Fix two Coverity issues
[11:32] <Scummette> [scummvm] bluegr closed pull request #2059: MIDI/SCI/KYRA: Add support for Roland GS drumkits (master...gs-drumkits) https://git.io/JvW1H
[11:32] <Scummette> [scummvm] bluegr pushed 5 new commits to master: https://git.io/Jv8nu
[11:32] <Scummette> scummvm/master 65f85a2 NMIError: SCI: Add support for Roland GS drumkits
[11:32] <Scummette> scummvm/master b2468d9 NMIError: SCI/MIDI: GS drumkits - comments and re-usability
[11:32] <Scummette> scummvm/master 18acefa NMIError: KYRA: Apply correction for invalid GS drumkits
[12:20] --> criezy joined #scummvm.
[12:20] #scummvm: mode change '+o criezy' by ChanServ!ChanServ@services.
[12:36] <LePhilousophe> hey there
[12:37] <LePhilousophe> Am I the only one who can't link last version of scummvm since merging of PR #2052?
[12:38] <LePhilousophe> maybe it's tied to how I configured it: ./configure --disable-all-engines --enable-engine=versailles
[12:39] <LePhilousophe> putting engines before gui in MODULES variable of Makefile.common seems to fix it
[12:41] <-- spookypeanut left irc: Ping timeout: 268 seconds
[13:02] <-- Lightkey left irc: Ping timeout: 240 seconds
[13:15] --> Lightkey joined #scummvm.
[13:21] --> ldevulder__ joined #scummvm.
[13:24] <-- ldevulder_ left irc: Ping timeout: 240 seconds
[13:28] <-- cd left irc: Quit: cd
[13:33] <grogbot> <rootfather> yes, indeed.
[13:34] <grogbot> <rootfather> I could replicate this with your configure command, however, a full rebuild with all engines enabled seems to be unaffected
[13:34] <-- JohnnyonFlame left irc: Read error: Connection reset by peer
[13:44] <-- Scummette left irc: Ping timeout: 246 seconds
[13:44] --> Scummette joined #scummvm.
[13:50] --> _sev joined #scummvm.
[13:50] <-- _sev left irc: Changing host
[13:50] --> _sev joined #scummvm.
[13:50] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[13:57] <Scummette> [scummvm] sev- pushed 3 new commits to master: https://git.io/Jv8W8
[13:57] <Scummette> scummvm/master 0f3b188 sev-: GRAPHICS: MACGUI: Fix double Geneva font ids
[13:57] <Scummette> scummvm/master 8df4d8a sev-: GRAPHICS: MACGUI: Proper processing of font slant names
[13:57] <Scummette> scummvm/master 988daef sev-: GRAPHICS: MACGUI: Parse slant in extra fonts too
[14:19] <-- _sev left irc: Quit: This computer has gone to sleep
[14:19] --> _sev joined #scummvm.
[14:19] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[14:22] <LePhilousophe> @rootfather maybe because cryomni3d engine doesn't have its own debugger
[14:24] <-- _sev left irc: Quit: This computer has gone to sleep
[14:38] <Scummette> [scummvm] bgK pushed 3 new commits to master: https://git.io/Jv8lL
[14:38] <Scummette> scummvm/master 60ab1dc bgK: MOHAWK: Remove the debugger keymapper action
[14:38] <Scummette> scummvm/master 06e6176 bgK: PEGASUS: Remove the debugger keymapper action
[14:38] <Scummette> scummvm/master e069f25 bgK: KEYMAPPER: Remove the debugger standard action
[14:44] --> _sev joined #scummvm.
[14:44] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[15:24] <-- ldevulder__ left irc: Quit: Leaving
[15:35] <grogbot> <rvanlaar> I'm having a problem building the current master.
[15:41] <LePhilousophe> @rvanlaar: which error do you have?
[15:44] <grogbot> <rvanlaar> engines/engine.cpp:767: error: undefined reference to 'GUI::Debugger::Debugger()' collect2: error: ld returned 1 exit status make: *** [Makefile.common:90: scummvm] Error 1
[15:44] <grogbot> <rvanlaar> While getting to the bottom of this, this happens to me because I only have the director eninge enabled.
[15:46] <LePhilousophe> yep
[15:46] <LePhilousophe> I will PR a fix
[15:47] <grogbot> <rvanlaar> Great,
[15:47] <grogbot> <rvanlaar> It was introduced in this commit: https://github.com/scummvm/scummvm/commit/98f9c4f254f081202db3fb77e2438785c4cfaa9b
[15:50] <LePhilousophe> yes
[15:51] <Scummette> [scummvm] lephilousophe opened pull request #2071: Fix building when selected engines don't have their own debugger (master...fix-build) https://git.io/Jv88p
[15:51] <LePhilousophe> @rvanlaar could you try my fix?
[15:52] <grogbot> <rvanlaar> Yes, where can I find it?
[15:53] <LePhilousophe> https://git.io/Jv88p
[15:53] <Scummette> [scummvm] bluegr closed pull request #2071: Fix building when selected engines don't have their own debugger (master...fix-build) https://git.io/Jv88p
[15:53] <Scummette> [scummvm] bluegr pushed 1 new commits to master: https://git.io/Jv84f
[15:53] <Scummette> scummvm/master 41e1dc0 lephilousophe: Fix building when selected engines don't have their own debugger
[15:53] <LePhilousophe> too late @rvanlaar already merge :)
[15:53] <LePhilousophe> +d
[15:53] <LePhilousophe> just upgrade master
[15:55] <grogbot> <rvanlaar> yeah, it's fixed.
[15:55] <grogbot> <rvanlaar> That was a quick fix, great work.
[16:47] --> ny00123 joined #scummvm.
[17:00] <grogbot> <SupSuper> what is scummvm replacement for fscanf and fprintf?
[17:28] <grogbot> <Henke37> Common::String::Format?
[17:28] <grogbot> <Henke37> no wait, you wanted the ones that work with a file
[17:29] <grogbot> <Henke37> or Common::ReadStream and Common::WriteStream
[17:30] <grogbot> <SupSuper> yeah but those only work with binary. i suspect scummvm really doesn't want you touching files
[17:46] <-- timofonic left irc: Ping timeout: 268 seconds
[17:46] --> timofonic joined #scummvm.
[17:59] <Scummette> [scummvm] BallM4788 opened pull request #2072: 3DS: Improve cursor behavior in Drag Mode (master...3ds_bettercursor) https://git.io/Jv80d
[18:02] <-- timofonic left irc: Read error: Connection reset by peer
[18:02] --> timofonic joined #scummvm.
[18:12] <-- timofonic left irc: Ping timeout: 268 seconds
[18:13] --> timofonic joined #scummvm.
[18:17] <-- timofonic left irc: Ping timeout: 265 seconds
[18:17] --> timofonic joined #scummvm.
[18:25] --> BeefEats joined #scummvm.
[18:39] <-- timofonic left irc: Ping timeout: 268 seconds
[18:39] --> timofonic joined #scummvm.
[18:44] <-- timofonic left irc: Ping timeout: 260 seconds
[18:46] --> timofonic joined #scummvm.
[18:49] <-- Begasus left irc: Quit: Ex-Chat
[19:12] --> spookypeanut joined #scummvm.
[19:22] <Scummette> [scummvm] lephilousophe pushed 1 new commits to master: https://git.io/Jv8zu
[19:22] <Scummette> scummvm/master 1bc068d lephilousophe: CRYOMNI3D: Fix Coverity warnings
[19:38] <grogbot> <Strangerke> Yes, I guess writestream is used for savegames?
[19:39] <grogbot> <Strangerke> I haven't checked yet
[19:40] <grogbot> <Henke37> among other things
[19:41] <LePhilousophe> there is the DumpFile class
[19:42] <LePhilousophe> with writeString method
[19:52] <grogbot> <Henke37> full name Scumm::DumpFile iirc
[19:53] <grogbot> <ZvikaZ> Hi. Can anyone explain me what's the purpose of SciMusic::remapChannels? I'm trying to debug issue #9735, and noticed that if I disable that channel remapping, the jingle is playing. But maybe I'm doing some other harm... What's more interesting, that the problem is only with GM, but with MT32 it's working well. After debugging, I saw that the original track was on channel 1, on MT32 it's remapped to channel 3 (and working). And on on
[19:53] <grogbot> GM it's mapped to channel 9. Ha - got it! Channel 9 in code is actually "channel 10" - which is percussion. That's might be the reason why it's not playing it. Which returns to my original question - why do change the channel numbers at all?
[19:54] <grogbot> <ZvikaZ> (and we can relate that to issue #6686 - these channel number changing causes problems with a real SC-55)
[19:55] <grogbot> <Henke37> nope, it's Common::DumpFile.
[20:10] <-- Mia left irc: Read error: Connection reset by peer
[20:12] --> Mia joined #scummvm.
[20:33] <-- Scummette left irc: Ping timeout: 246 seconds
[20:33] --> Scummette joined #scummvm.
[20:34] <Scummette> [scummvm] ZvikaZ opened pull request #2073: SCI: fix bug #9735 by avoiding remap to percussion channel (master...z_midi_gk_jingle) https://git.io/Jv82T
[20:35] <grogbot> <ZvikaZ> Indeed, avoiding the reserved percussion channel fixed that issue. Sent PR. Still, if someone can elaborate on the remapping mechanism, I'd be happy.
[20:43] <-- ajax16384 left irc: Quit: Leaving
[20:54] <grogbot> <_athrxx> @ZvikaZ: What you did does not match the original code. The last time I looked at the remap code in disasm (iirc KQ5) it seemed to be very accurate. I couldn't find any errors. Also, the code in music.cpp is not the driver level. Channel 9 doesn't have to represent a rhythm channel there. So fixing it like this might cause regressions.
[20:56] <grogbot> <Henke37> the original code that is so bad that there is an entire system for applying script patches?
[20:58] <grogbot> <_athrxx> The midi player is certainly more complicated than it has to be. The purpose of the remapping code is mostly being able to play multiple sounds at once.
[20:59] <grogbot> <md5> @Henke37: the game scripts are a different kind of beast
[20:59] <grogbot> <Henke37> i'm seeing it as a systemic issue: poor QA
[21:00] <grogbot> <md5> Also, in SCI, the music contains signals for the game scripts
[21:00] <grogbot> <md5> to synchronize game animations with the music
[21:00] <grogbot> <md5> so if something is different in our implementation, things might fail spectacularly
[21:01] <grogbot> <md5> and our implementation is more complex than it needs to be, indeed
[21:01] <grogbot> <Henke37> of course it does.
[21:01] <grogbot> <_athrxx> I actually meant the original player :-). I am not sure if they had to do it like that...
[21:02] <grogbot> <md5> but the original SCI engine went through a lot of redesign
[21:02] <grogbot> <Henke37> i'd imagine so, how many games did they make using it? 30+?
[21:02] <grogbot> <md5> hm
[21:04] <grogbot> <md5> about 60+, with a quick glance
[21:05] <grogbot> <md5> the earlier ones having EGA graphics, and the latter ones using FMV videos and speech
[21:07] <grogbot> <md5> the first SCI game was KQ4 on 1988, and the last one was Phantasmagoria 2 in 1996... and there's also Shivers 2 in 1997
[21:08] <grogbot> <md5> Shivers 2 was different from previous games, as it was using a pseudo-3D graphics renderer
[21:09] <grogbot> <md5> come to think of it, that was 8 years of massive development
[21:09] <grogbot> <SupSuper> not to mention all the platforms it ran on
[21:09] <grogbot> <md5> yeah
[21:11] <grogbot> <Trembyle> ScummVM is 18+ years of massive development
[21:11] <grogbot> <Trembyle> not too mention all the platforms ...
[21:11] <grogbot> <md5> yeah, but ScummVM focuses on the game interpreters
[21:11] <grogbot> <md5> companies like Sierra had loads of other departments for their games
[21:12] <grogbot> <md5> including artists, script writers, musicians etc
[21:12] <grogbot> <md5> so, 60+ games in 8 years is quite a feat
[21:12] <grogbot> <md5> and that's just the SCI games
[21:12] <grogbot> <Trembyle> For sure, it's a monumental body of work, which is why we're still talking about it now
[21:13] <grogbot> <md5> they had all sorts of other engines too
[21:13] <grogbot> <SupSuper> scummvm is also a mess 😛 but by necessity
[21:13] <grogbot> <md5> a mess? 😦
[21:15] <grogbot> <md5> btw, according to Mobygames, Sierra made 583 (!) games https://www.mobygames.com/browse/games/sierra-entertainment-inc/list-games/
[21:16] <grogbot> <SupSuper> in the sense that it's made out of reverse-engineering old games, not building shiny new ones. it has to preserve all the old questionable logics and hacks and platforms. there's only so pretty you can make it
[21:16] <grogbot> <md5> @SupSuper: ah yes, agreed
[21:16] <grogbot> <md5> a beatiful mess 😛
[21:17] <grogbot> <SupSuper> a glorious mess
[21:17] <grogbot> <Trembyle> Sierra also made productivity software that's not in Moby
[21:17] <grogbot> <Trembyle> and Moby is missing a lot from those crazy early years where they basically freelanced development
[21:19] <grogbot> <Trembyle> My comment above is just to place the achievements of the scummvm developers in perspective. This application covers a huge amount of games, even if they're not original development. It's not like anyone is making money here
[21:19] <grogbot> <Trembyle> We don't have a Ken Williams ...
[21:19] <grogbot> <md5> true that 🙂
[21:20] <grogbot> <Henke37> i suppose one could say that the GSOC students are being paid to work on the project
[21:21] <grogbot> <md5> yeah, that's true for all open source projects in GSoC
[21:21] <-- _sev left irc: Quit: This computer has gone to sleep
[21:22] <Lightkey> That list also includes lots of re-releases and compilations though.
[21:24] <-- timofonic left irc: Ping timeout: 272 seconds
[21:25] <grogbot> <Trembyle> I doubt these will be supported by ScummVM anytime soon ...
[21:25] <grogbot> <Trembyle> https://cdn.discordapp.com/attachments/581224061091446795/678713941832237116/screenwriter-ii-apple-ii-sierra-line_1_da032201e211c5379a3013d243eb13e6.jpg
[21:25] --> timofonic joined #scummvm.
[21:25] <grogbot> <Trembyle> https://cdn.discordapp.com/attachments/581224061091446795/678713961251602459/s-l640.jpg
[21:25] <grogbot> <Trembyle> https://cdn.discordapp.com/attachments/581224061091446795/678713976544165898/91yz9kKnvXL._SX522_.jpg
[21:27] <grogbot> <md5> heh
[21:28] <-- criezy left irc: Quit: criezy
[21:28] <grogbot> <md5> They also made obscure mashups like "Disney's Aladdin Chess Adventures"
[21:30] <grogbot> <Trembyle> That was just published by the Sierra brand after it was dismantled
[21:30] <grogbot> <Trembyle> If you count publishing, then things like Half Life count too
[21:30] <grogbot> <md5> yeah, they also published Half Life
[21:31] <grogbot> <Trembyle> We can talk to ResidualVM about adding that
[21:31] <grogbot> <md5> Half Life? That would be a feat indeed 🙂 but ResidualVM is mostly about 2.5D games
[21:31] <grogbot> <md5> i.e. games like Siberia
[21:32] <grogbot> <md5> or Grim Fandango
[21:34] <grogbot> <Trembyle> But no Gabriel Knight 3 unfortunately. Anyway, that's OT for this discord.
[21:34] <grogbot> <md5> true
[21:37] --> P2E joined #scummvm.
[22:01] <-- Scummette left irc: Ping timeout: 246 seconds
[22:01] --> Scummette joined #scummvm.
[22:26] --> dreammaster joined #scummvm.
[22:26] #scummvm: mode change '+o dreammaster' by ChanServ!ChanServ@services.
[22:43] --> ny00123_ joined #scummvm.
[22:43] --> JohnnyonFlame joined #scummvm.
[22:45] <-- ny00123 left irc: Ping timeout: 260 seconds
[22:52] <-- dreammaster left irc:
[22:54] <-- spookypeanut left irc: Ping timeout: 260 seconds
[23:20] --> LeChuck joined #scummvm.
[23:32] <-- ny00123_ left irc: Quit: Leaving
[23:42] --> dreammaster joined #scummvm.
[23:42] #scummvm: mode change '+o dreammaster' by ChanServ!ChanServ@services.
[23:43] <Scummette> [scummvm] dreammaster closed pull request #2050: ENGINES: Standardization of autosaves (master...autosaves) https://git.io/JvnHK
[23:43] <Scummette> [scummvm] dreammaster pushed 28 new commits to master: https://git.io/Jv8rS
[23:43] <Scummette> scummvm/master a00e44b dreammaster: ENGINES: Merge saveGameState virtual methods into a single one
[23:43] <Scummette> scummvm/master 30d34fa dreammaster: ENGINES: Implement autosaving in the Engine base class
[23:43] <Scummette> scummvm/master af265a1 dreammaster: GRIFFON: Remove autosave code
[00:00] --- Mon Feb 17 2020