[00:20] well, RPGs were also only allowed rather recently, so it's not entirely unlikely that some other game types might be accepted/included in the future... [00:20] ldevulder_ (~ldevulder@176.167.178.134) left irc: Ping timeout: 265 seconds [00:22] Seems there's no way for the current stable 2.1.0 Android build to interfafe with cloud-storge sites. Is this a leftover from the Windows/Mac/Linux versions, or does the team plan on integrating Google Play cloud-saving somewhere down the line? [00:38] lets just say that it's a lot easier to deny an engine before someone actually implements it [00:48] RPG was allwed because lands of lore uses same engine as Legend of Kyrandia? [00:50] Amongst others, like the Eye of the Beholder series. And that they're closely related to adventures in that many of them have a definitive story just like adventures do. [00:51] @DreamMaster Oh. [01:11] Scummette (~Scummette@roberta.scummvm.net) left irc: Ping timeout: 252 seconds [01:11] Scummette (~Scummette@roberta.scummvm.net) joined #scummvm. [01:37] JohnnyonFlame (~quassel@187.3.224.235) joined #scummvm. [01:50] [scummvm] lolbot-iichan opened pull request #1995: WINTERMUTE: Add detection for Hor game (master...wme_hor) https://git.io/Jvv2S [02:06] [scummvm] sluicebox pushed 2 new commits to master: https://git.io/Jvvat [02:06] scummvm/master a804afc sluicebox: SCI: Trigger bpr/bpw breakpoints within kernel calls [02:06] scummvm/master e0a3a38 sluicebox: SCI: Log bp_function (bpe) parameters in debugger [02:11] jamm (~jamm@unaffiliated/jamm) joined #scummvm. [02:11] jamm (~jamm@unaffiliated/jamm) left irc: Client Quit [02:12] jamm (~jamm@unaffiliated/jamm) joined #scummvm. [02:30] dreammaster (~dreammast@c-73-241-66-252.hsd1.ca.comcast.net) joined #scummvm. [02:30] #scummvm: mode change '+o dreammaster' by ChanServ!ChanServ@services. [02:36] SylvainTV (~Sylvain@lfbn-lil-1-240-153.w90-45.abo.wanadoo.fr) left irc: Read error: Connection reset by peer [02:36] [scummvm] dreammaster pushed 1 new commits to master: https://git.io/Jvvaj [02:36] scummvm/master a18eae1 dreammaster: GUI: Fix crash opening edit game dialog for games with no music [02:37] DominusExult (~dominus@port-92-194-83-235.dynamic.as20676.net) joined #scummvm. [02:37] DominusExult (~dominus@port-92-194-83-235.dynamic.as20676.net) left irc: Changing host [02:37] DominusExult (~dominus@unaffiliated/dominus) joined #scummvm. [02:41] Dominus (~dominus@unaffiliated/dominus) left irc: Ping timeout: 260 seconds [02:41] Nick change: DominusExult -> Dominus [03:34] LePhilousophe (~lephilous@amsn/developer/lephilousophe) left irc: Ping timeout: 240 seconds [04:03] Strangerke_ (~Strangerk@cust-208-39-111-94.dyn.as47377.net) joined #scummvm. [04:05] Strangerke (~Strangerk@cust-208-39-111-94.dyn.as47377.net) left irc: Ping timeout: 258 seconds [04:05] Nick change: Strangerke_ -> Strangerke [05:57] jamm (~jamm@unaffiliated/jamm) left irc: Ping timeout: 240 seconds [06:04] _dreammaster (~dreammast@c-73-241-66-252.hsd1.ca.comcast.net) joined #scummvm. [06:04] #scummvm: mode change '+o _dreammaster' by ChanServ!ChanServ@services. [06:06] dreammaster (~dreammast@c-73-241-66-252.hsd1.ca.comcast.net) left irc: Ping timeout: 240 seconds [06:16] _dreammaster (~dreammast@c-73-241-66-252.hsd1.ca.comcast.net) left irc: [06:18] Mia (~Mia@176.234.103.230) joined #scummvm. [06:18] Mia (~Mia@176.234.103.230) left irc: Changing host [06:18] Mia (~Mia@unaffiliated/mia) joined #scummvm. [06:43] Begasus (~begasus@ptr-4qba4ebmdta0w0n6lhu.18120a2.ip6.access.telenet.be) joined #scummvm. [07:21] ny00123 (~ny00123@5.102.239.60) joined #scummvm. [07:25] girafe (~girafe@lfbn-gre-1-225-202.w90-112.abo.wanadoo.fr) joined #scummvm. [07:31] JohnnyonFlame (~quassel@187.3.224.235) left irc: Read error: Connection reset by peer [07:33] @Mataniko Sure, that's why I'm here early [07:34] Visual Studio was a mess, now I switched to Linux, but it's taking too long to build [07:35] how many CPUs do you have? [07:35] @harshbawari ? [07:36] Umm, you mean cores? [07:37] or cores, same thing. including virtual ones [07:38] 4 [07:39] i5 8th gen [07:39] then run make -j6 [07:39] The previous build hasn't finished yet [07:39] stop the current build [07:39] Should I stop it? [07:40] ctrl + c [07:40] Ok running make -j6 [07:40] What's this command btw? [07:40] parallel building, for using all cores [07:41] Oh got it. [07:41] I have less experience with Linux [07:41] Only used it during 2nd semester [07:41] It's done [07:41] Thanks [07:43] So now since I've successfully compiled scummvm, can I get my hands on coding? [07:43] Easy bugs, etc. [07:43] So that I can get familiar with the code [07:44] yes, I have something low-hanging for you [07:44] fix the finall boss in Griffon Legend [07:45] Can you elaborate? [07:45] Begasus (~begasus@ptr-4qba4ebmdta0w0n6lhu.18120a2.ip6.access.telenet.be) left irc: Ping timeout: 252 seconds [07:46] what is your e-mail? I'll add you to the Trello board [07:47] harshbawari@gmail.com [07:47] check your e-mail [07:48] download the game from here: https://www.phatcode.net/downloads.php?id=430 [07:48] Ot it [07:48] the card "The final boss is sluggish" has a save attached and steps to reproduce [07:49] *got it [07:49] pls tell me when you manage to reproduce [07:51] OK so what you're saying is the player needs to spawn in another room [07:51] load the save [07:51] did you manage to? [07:52] Wait I haven't downloaded the game yet [07:58] Begasus (~begasus@ptr-4qba4ebmdta0w0n6lhu.18120a2.ip6.access.telenet.be) joined #scummvm. [07:59] So I downloaded giffon_legend.zip from that link, extracted it, then run .scummvm using the command. /scummvm, navigated to the directory where the game is stored, clicked Choose, but it cannot find the game [08:00] ah, of course [08:00] Command sent by sev [08:00] ./configure --disable-all-engines --enable-engine=griffon [08:00] make -j6 [08:03] Unrecognized engine: griffon [08:06] _sev__ (~sev@scummvm/undead/sev) left irc: Quit: This computer has gone to sleep [08:07] I checked the engine names list in. /configure --help and there's no value as griffon for engine name [08:08] err [08:08] _sev__ (~sev@d158167.upc-d.chello.nl) joined #scummvm. [08:08] _sev__ (~sev@d158167.upc-d.chello.nl) left irc: Changing host [08:08] _sev__ (~sev@scummvm/undead/sev) joined #scummvm. [08:08] #scummvm: mode change '+o _sev__' by ChanServ!ChanServ@services. [08:08] what source do you use? [08:09] did you clone the github repo? [08:09] I downloaded source files from the website [08:09] Not cloned [08:09] that is half year old, dude [08:09] Oh I didn't know that [08:09] Sorry [08:10] for development, clone the repo [08:10] https://github.com/scummvm/scummvm [08:10] jamm (~jamm@unaffiliated/jamm) joined #scummvm. [08:12] Ok cloning... [08:24] Ok [08:24] Where do I place griffon.s03 file that I download from trello? [08:27] in your save path [08:28] see scummvm options [08:29] Got it [08:29] It crashed [08:30] As soon as I loaded it [08:31] oh? [08:32] Ya [08:33] Placed griffon.s03 in save path, then loaded the game, scummvm crashed [08:34] okay, I loaded and saved it again [08:34] could you please redownload and check? [08:34] Sure [08:36] and if it crashes [08:36] then [08:36] gdb ./scummvm [08:36] then [08:36] run griffon [08:36] load, let it crash [08:36] then [08:36] bt [08:37] and it will show you the backtrace. Tell me what is it (top 5 lines) [08:37] I marked commands to type with $ [08:39] Ok [08:40] Something messed up [08:41] Now it's not responding [08:41] Earlier it worked fine [08:41] Lemme check for some time [08:41] well [08:41] most probably there are uninitalized variables [08:41] you may catch those with valgrind [08:42] $ valgrind ./scummvm griffon [08:42] then load and if it complains about uninitalized reads [08:42] and this could be also a good task to do: fix it 😄 [08:43] ldevulder (~ldevulder@i15-lef02-th2-89-83-213-75.ft.lns.abo.bbox.fr) joined #scummvm. [08:43] Installing valgrind [08:47] https://cdn.discordapp.com/attachments/581224061091446795/665114698231840768/IMG_20200110_141804.jpg [08:54] Cool, fix it 🙂 [08:55] Dialogs.cpp line 120 [08:55] Something is not initialised there which is then fed to sin() [08:58] Ok so I found that, after you add the game to scummvm, it will run the first time, but if you close the engine, the next time onwards it goes not responding [08:59] Starts working again if you remove the game and then add it again [09:00] JohnnyonFlame (~quassel@187.3.224.235) joined #scummvm. [09:02] And how does it stop working? The crash above? [09:02] Yes, it crashes [09:03] waltervn (~waltervn@scummvm/undead/waltervn) joined #scummvm. [09:03] #scummvm: mode change '+o waltervn' by ChanServ!ChanServ@services. [09:03] Then it is time to fix [09:03] Next time you starts, it goes not responding on main menu [09:03] Trying [09:03] Could you start digging? [09:03] Valgrind is your ultimate friend for this [09:04] Catch any uninitialised reads or writes beyond the boundaries [09:04] Never used valgrind [09:04] Any resources? [09:12] The variable _itemyloc [09:15] girafe (~girafe@lfbn-gre-1-225-202.w90-112.abo.wanadoo.fr) left irc: Read error: Connection reset by peer [09:21] I guess _itemyloc is not assigned a value [09:22] You saw the output above. It gives you the line number where the read occurs [09:23] Griffin.cpp line 155? [09:23] BeefEats (~BeefEats@unaffiliated/beefeats) left irc: Read error: Connection reset by peer [09:25] I'm already in dialogs.cpp [09:26] I am not near my computer [09:27] Well _itemyloc is not assigned a value anywhere in the file, and the variable is being used at line 120 [09:27] https://cdn.discordapp.com/attachments/581224061091446795/665124806143901696/IMG_20200110_145814.jpg [09:28] I mean initial value of _itemyloc is not defined [09:31] Yoooo did it [09:31] This time it does not go Not Responding [09:31] Lololollll [09:32] I just set _itemyloc=0 at the beginning [09:35] borosky (~borosky@095160157148.dynamic-ra-10.vectranet.pl) joined #scummvm. [09:36] brooksy (~borosky@095160157148.dynamic-ra-10.vectranet.pl) left irc: Ping timeout: 240 seconds [09:46] vliaskov (~vliaskov@x4dbf979a.dyn.telefonica.de) joined #scummvm. [09:52] Should I open pull request? [09:52] @sev [10:34] jamm (~jamm@unaffiliated/jamm) left irc: Ping timeout: 258 seconds [11:15] Yes please [11:15] But not necessarily at this stage [11:15] Try to fix the boss behaviour [11:15] Just make sure you have the current fix as a separate commit [11:20] I have never opened a pull request [11:20] How to do it? [11:25] What is *this? [11:25] https://cdn.discordapp.com/attachments/581224061091446795/665154344953577502/JPEG_20200110_165542.jpg [11:25] From transparent_surface.cpp blit() [11:26] Reference to the current class object instance [11:26] Basic C++ [11:26] do not open a Pull Request now [11:26] Yeah, but the object variables are not defined till this point [11:26] Were you able to reproduce the bug? [11:27] Yes [11:27] Plus the crash [11:28] Cool. The boss sluggishness will take more time as the code is not very easy to understand [11:28] I think the bug is related to the variable _itemSelOn [11:30] I have no idea [11:30] I did not start looking into that as you saw in Trello [11:30] I have checked [11:31] Regarding crash: How can you pass *this when the object is just created, since the variables will not hold any value [11:32] When object is created, then you have a reference to it [11:32] If it was not created, you could get a garbage there and that must be fixed then [11:33] Yeah, but since no member variable is assigned any value, you'll have no data inside it to use [11:33] Then you have to initiatlize those in the class constructor [11:33] Thats a bug [11:34] Generally, all class variables must be initialised in constructors [11:34] *this goes to this function [11:34] https://cdn.discordapp.com/attachments/581224061091446795/665156787116310548/JPEG_20200110_170358.jpg [11:34] It's a constructor [11:34] I think [11:38] Please [11:38] Use pastebin.com [11:38] Or better direct link to github [11:38] Not these screenshots with camera [11:40] Oh sorry I'm using Discord on phone [11:40] Like this: https://github.com/scummvm/scummvm/blob/a18eae10679ed12fb6a37c93cb0b391df874c7c6/graphics/transparent_surface.cpp#L69 [11:41] Im using discord on phone as well [11:41] And just opened the repo in the browser in the phone [11:42] Click on three dots on left of the line, Cooy permalink [11:42] Oh I didn't know how to do this [11:42] Thanks [11:43] You may need to tap on the line number prior to that [11:43] Got it [11:43] It is being called here https://github.com/scummvm/scummvm/blob/a18eae10679ed12fb6a37c93cb0b391df874c7c6/graphics/transparent_surface.cpp#L414 [11:44] And why is it a problem? [11:44] It is called as [11:45] Surface->blit(...) [11:45] Right? [11:46] Yes [11:46] Then it is called for object instance Surface [11:46] And this will refer to it [11:47] I suggest to read some book on C++ [11:47] About basics of its OOP implementation [11:48] Unless Surface was uninitialised before the call, of course [11:48] Because then it will contain garbage and crash [11:48] In simple words [11:48] Imagine a call [11:49] void Class::method(int a) [11:49] And you call [11:50] Class b = new Class; b->metod(5); [11:50] Internally the method will be turned into [11:50] void Class__method(Class *this, int a); [11:51] And that call respectively is transferred into [11:51] Class__metod(b, 5); [11:51] This is where you get this from [11:51] Clear? [11:53] Oh yes, got it [12:13]