[00:09] [scummvm] elasota pushed 1 new commits to master: https://is.gd/Bq3Ee7 [00:09] scummvm/master b9c7730 elasota: VCRUISE: Fix detection of German version and detect it separate from English version. [00:12] sev (~sev@scummvm/sev) left irc: Quit: This computer has gone to sleep [00:56] [scummvm] elasota pushed 1 new commits to master: https://is.gd/Pya64e [00:56] scummvm/master 422e639 elasota: VCRUISE: Fix up default language behavior. [00:59] [scummvm] elasota pushed 1 new commits to master: https://is.gd/t011Yi [00:59] scummvm/master f42b729 elasota: VCRUISE: Fix bad file size in German version detection. [01:30] [scummvm] elasota pushed 1 new commits to master: https://is.gd/wuvTXR [01:30] scummvm/master 54b7274 elasota: VCRUISE: Pass AVI palette to fix credits crash in some versions. [01:51] gsi_ (~gsi@dynamic-077-015-094-057.77.15.pool.telefonica.de) joined #scummvm. [01:54] gsi (~gsi@dynamic-077-181-074-080.77.181.pool.telefonica.de) left irc: Ping timeout: 240 seconds [01:55] DominusExult (~dominus@exult/developer/dominus) joined #scummvm. [01:57] Dominus (~dominus@exult/developer/dominus) left irc: Ping timeout: 256 seconds [01:57] Nick change: DominusExult -> Dominus [02:06] [scummvm] elasota opened pull request #4991: COMMON: Strip whitespace before checking if an INI line is a comment. (master...fix-ini-whitespace) https://is.gd/n1gUeD [03:35] @eientei yeah, so it shouldn't be difficult to port... or are you saying it's already playable with some hacking? [03:35] I'm new to ScummVM anyways [04:34] Nick change: Smedles_ -> Smedles [06:26] borosky (~borosky@213.134.185.160) joined #scummvm. [07:30] cihancan (~cian@88.234.218.201) joined #scummvm. [07:43] sev (~sev@81-205-47-249.fixed.kpn.net) joined #scummvm. [07:43] sev (~sev@81-205-47-249.fixed.kpn.net) left irc: Changing host [07:43] sev (~sev@scummvm/sev) joined #scummvm. [07:43] #scummvm: mode change '+o sev' by ChanServ!ChanServ@services.libera.chat [08:30] reset (~reset@user/reset) left irc: Ping timeout: 268 seconds [08:42] reset (~reset@user/reset) joined #scummvm. [09:00] BrainChild (~BrainChil@185.237.182.250) joined #scummvm. [09:42] TMM_ (hp@amanda.tmm.cx) left irc: Quit: https://quassel-irc.org - Chat comfortably. Anywhere. [09:42] TMM_ (hp@amanda.tmm.cx) joined #scummvm. [10:22] [scummvm] mduggan pushed 14 new commits to master: https://is.gd/Kk8azy [10:22] scummvm/master 8e3e77c mduggan: TETRAEDGE: Fix copy-paste error. PVS-Studio V656 [10:22] scummvm/master b0d33ce mduggan: TETRAEDGE: Fix computer puzzle display [10:22] scummvm/master cdd6805 mduggan: TETRAEDGE: Add more search paths used by Amerzone [10:24] [scummvm] yarolig opened pull request #4992: XEEN: Fix crash in MM4 ending cutscene (branch 2-7) (branch-2-7...fix_mm4_cutscene-2-7) https://is.gd/MkPHlb [11:04] oh wait you're right, it says it's already been ported [11:04] bye [11:04] fmlatghor (lcoogan@user/fmlatghor) left #scummvm (WeeChat 3.8). [11:12] [scummvm] digitall pushed 1 new commits to master: https://is.gd/hW9Yz2 [11:12] scummvm/master 0ce7a44 digitall: VCRUISE: Fix Missing Initialization GCC Compiler Warning [11:24] [discord] Cosmology of Kyoto is even Director v4, so it's almost usable [11:34] ccawley2011 (~ccawley20@146.66.56.22) joined #scummvm. [11:34] #scummvm: mode change '+o ccawley2011' by ChanServ!ChanServ@services.libera.chat [12:02] [scummvm] yarolig opened pull request #4993: XEEN: Fix crash in MM4 ending cutscene (master...fix_mm4_cutscene-master) https://is.gd/JoQBuI [12:09] [scummvm] elasota pushed 2 new commits to master: https://is.gd/LZtxtF [12:09] scummvm/master 5824ba0 elasota: VCRUISE: Fix subtitles not respecting subtitles setting. [12:09] scummvm/master 62f2ffb elasota: VCRUISE: Resume game on pressing the pause action while in the pause menu. [12:14] [scummvm] yarolig opened pull request #4994: XEEN: show class restriction icons in shops (master...xeen_shop_restrictions) https://is.gd/MHmw3h [12:17] [scummvm] elasota pushed 1 new commits to master: https://is.gd/bzaqBo [12:17] scummvm/master 06f70c1 elasota: VCRUISE: Fix wrong file hash for German version. [12:21] [discord] wow. the only game Roger Ebert ever liked... [12:32] [discord] @fracturehill Hey, saw your PR, quite a rewrite it was ^_^ [12:32] [discord] seems like the perfect thing i was looking for, but the changes seem way too much excessive [12:39] [discord] it's way simpler than it looks imo [12:39] [discord] just shuffling around existing code and renaming some variables [12:48] [discord] that's my question [12:49] [discord] why do you shuffle around code and rename variables [12:49] [discord] when functionally it is same? [12:50] [discord] isn't it redundant ? [12:51] [discord] because the next time someone touches this code they won't have to spend hours decoding what every poorly labelled variable name means like I did :) [12:51] [discord] Ah i see [12:54] [scummvm] elasota opened pull request #4995: COMMON: Avoid makeUnique on string if trim wouldn't modify it. (master...trim-opt) https://is.gd/g6Qqy8 [13:00] ccawley2011 (~ccawley20@146.66.56.22) left irc: Read error: Connection reset by peer [13:04] [scummvm] phcoder opened pull request #4996: SCUMM: Fix Mojibake in Japanese Macintosh atlantis (master...macmoji) https://is.gd/syW4cq [13:16] [discord] It is called "code refactoring" and is always important to not forget to do it [13:16] [discord] because it lowers the maintainability bar [13:16] [discord] I see [13:16] [discord] when you design a software, very often, you do not anticipate all the details [13:17] [discord] as you implement things, you start squeezing more and more new functionality and at some point, it becomes ugly, because the initial design did not anticipate certain thing [13:17] [discord] then you do refactoring [13:17] [discord] creating equivalent but more readable and maintainable code. And you have the old version for comparison so you make sure you do not break things [13:17] [discord] understandable [13:18] [discord] to be honest, I thought the code in repository would be very clean (As scummvm is quite mature) [13:18] [discord] especially those seems to be main classes (often used?) [13:18] [discord] how much dirty code do you expect we have in here [13:20] [discord] A lot more than you'd think [13:59] cihancan (~cian@88.234.218.201) left irc: Remote host closed the connection [14:08] [discord] I would say, that the state of ScummVM repository is much better than vast majority of the commercial projects I was working with [14:09] [discord] and that is thanks to periodic refactoring [14:51] cihancan (~cian@88.234.218.201) joined #scummvm. [15:32] speachy (~speachy@tunnel658658-pt.tunnel.tserv12.mia1.ipv6.he.net) joined #scummvm. [15:32] speachy (~speachy@tunnel658658-pt.tunnel.tserv12.mia1.ipv6.he.net) left irc: Changing host [15:32] speachy (~speachy@rockbox/developer/speachy) joined #scummvm. [16:39] BrainChild (~BrainChil@185.237.182.250) left irc: Quit: Leaving... [17:03] ny00123 (~ny00123@213.137.65.140) joined #scummvm. [17:04] cihancan (~cian@88.234.218.201) left irc: Remote host closed the connection [17:14] cihancan (~cian@88.234.218.201) joined #scummvm. [17:34] cihancan (~cian@88.234.218.201) left irc: Remote host closed the connection [17:46] cihancan (~cian@88.234.218.201) joined #scummvm. [18:01] ny00123 (~ny00123@213.137.65.140) left irc: Read error: Connection reset by peer [18:21] ny00123 (~ny00123@213.137.65.140) joined #scummvm. [19:08] ccawley2011 (~ccawley20@146.66.56.22) joined #scummvm. [19:08] #scummvm: mode change '+o ccawley2011' by ChanServ!ChanServ@services.libera.chat [19:30] [scummvm] bluegr closed pull request #4984: SAGA2: move call to delayMillis in updatePalette() (master...fix_saga2_infinite_loop) https://is.gd/lxaEqk [19:30] [scummvm] bluegr pushed 1 new commits to master: https://is.gd/AR27tu [19:30] scummvm/master fd32607 spleen1981: SAGA2: move call to delayMillis in updatePalette() [19:30] ny00123 (~ny00123@213.137.65.140) left irc: Read error: Connection reset by peer [19:35] BrainChild (~BrainChil@185.237.182.250) joined #scummvm. [19:37] [scummvm] bluegr closed pull request #4978: Ultima: Remove extra space in quest of the avatar name (master...patch-1) https://is.gd/hIHlTX [19:37] [scummvm] bluegr pushed 1 new commits to master: https://is.gd/PnBK0K [19:37] scummvm/master 5be4f52 i30817: ULTIMA: Remove extra space in quest of the avatar name [19:46] ny00123 (~ny00123@213.137.65.140) joined #scummvm. [20:24] ny00123 (~ny00123@213.137.65.140) left irc: Quit: Leaving [21:55] cihancan (~cian@88.234.218.201) left irc: Remote host closed the connection [22:03] BrainChild (~BrainChil@185.237.182.250) left irc: Quit: Leaving... [22:39] TMM_ (hp@amanda.tmm.cx) left irc: Quit: https://quassel-irc.org - Chat comfortably. Anywhere. [22:39] TMM_ (hp@amanda.tmm.cx) joined #scummvm. [22:44] borosky (~borosky@213.134.185.160) left irc: Ping timeout: 256 seconds [22:45] ccawley2011 (~ccawley20@146.66.56.22) left irc: Read error: Connection reset by peer [00:00] --- Tue May 9 2023