ScummVM IRC Log - 08 May 2020

[Back to Index]

[00:05] <-- yuv422 left irc: Remote host closed the connection
[00:06] --> yuv422 joined #scummvm.
[00:06] #scummvm: mode change '+o yuv422' by ChanServ!ChanServ@services.
[00:21] <-- marcusr left irc: Remote host closed the connection
[00:21] <-- L0ngcat left irc: Remote host closed the connection
[00:21] --> L0ngcat joined #scummvm.
[00:22] --> marcusr joined #scummvm.
[00:24] <-- L0ngcat left irc: Remote host closed the connection
[00:24] <-- marcusr left irc: Remote host closed the connection
[00:24] --> L0ngcat joined #scummvm.
[00:25] --> marcusr joined #scummvm.
[01:02] <Lightkey> https://twitter.com/Sierra_OffLine/status/1258454547778936838 AGI engine stream at 17:00 UTC today.
[01:18] <-- crns left irc: Quit: bye
[01:21] --> dreammaster joined #scummvm.
[01:21] #scummvm: mode change '+o dreammaster' by ChanServ!ChanServ@services.
[01:23] <-- SylvainTV left irc: Read error: Connection reset by peer
[01:31] <Scummette> [scummvm] dreammaster pushed 4 new commits to master: https://git.io/JfcYg
[01:31] <Scummette> scummvm/master 5be5920 dreammaster: ULTIMA4: Deprecating in-game key repeat settings
[01:31] <Scummette> scummvm/master 314df69 dreammaster: ULTIMA4: Cleanup of other remaining TODOs
[01:31] <Scummette> scummvm/master 57453ad dreammaster: ULTIMA4: Fix implementation of peer action
[01:37] --> DominusExult joined #scummvm.
[01:37] <-- DominusExult left irc: Changing host
[01:37] --> DominusExult joined #scummvm.
[01:40] <-- Dominus left irc: Ping timeout: 260 seconds
[01:40] Nick change: DominusExult -> Dominus
[02:05] <-- yuv422 left irc: Remote host closed the connection
[02:05] --> yuv422 joined #scummvm.
[02:05] #scummvm: mode change '+o yuv422' by ChanServ!ChanServ@services.
[02:09] <-- yuv422 left irc: Remote host closed the connection
[02:09] --> yuv422 joined #scummvm.
[02:09] #scummvm: mode change '+o yuv422' by ChanServ!ChanServ@services.
[02:16] <Scummette> [scummvm] deckarep opened pull request #2228: SCI: added missing but implemented help commands for scripts (master...patch-1) https://git.io/JfcOX
[02:52] <-- Stormkeeper left irc: Ping timeout: 256 seconds
[03:01] <-- yuv422 left irc: Remote host closed the connection
[03:02] --> yuv422 joined #scummvm.
[03:02] #scummvm: mode change '+o yuv422' by ChanServ!ChanServ@services.
[03:29] <Scummette> [scummvm] digitall closed pull request #2228: SCI: add missing but implemented help commands for script related debug commands (master...patch-1) https://git.io/JfcOX
[03:29] <Scummette> [scummvm] digitall pushed 1 new commits to master: https://git.io/JfcsH
[03:29] <Scummette> scummvm/master c17e82c deckarep: SCI: added missing but implemented help commands for scripts
[03:44] <Scummette> [scummvm] dreammaster pushed 2 new commits to master: https://git.io/JfcGq
[03:44] <Scummette> scummvm/master 876c5af dreammaster: GLK: ADRIFT: Added detection entries
[03:44] <Scummette> scummvm/master 0d41026 dreammaster: XEEN: Fix curing the well in Nightshadow
[04:40] <Scummette> [scummvm] sluicebox pushed 2 new commits to master: https://git.io/JfcGj
[04:40] <Scummette> scummvm/master 267317f sluicebox: SCI: Add script_said debug command to help text, regroup
[04:40] <Scummette> scummvm/master 7afe586 sluicebox: SCI: Fix KQ6 floating off the logic cliff steps
[04:41] <-- dreammaster left irc:
[05:13] <-- yuv422 left irc: Remote host closed the connection
[05:14] --> yuv422 joined #scummvm.
[05:14] #scummvm: mode change '+o yuv422' by ChanServ!ChanServ@services.
[05:40] <-- Dominus left irc: Read error: Connection reset by peer
[05:40] --> Dominus joined #scummvm.
[05:40] <-- Dominus left irc: Changing host
[05:40] --> Dominus joined #scummvm.
[05:48] <grogbot> <aryanrawlani28> Kinda offtopic question: is using ternary operators more optimized than if else? The latter is more readable, and most modern compilers have good optimizations. Since we use older standard of C++, i dunno
[05:49] <Scummette> [scummvm] sluicebox pushed 1 new commits to master: https://git.io/JfcCU
[05:49] <Scummette> scummvm/master 0eca800 sluicebox: SCI32: Implement kMacPlatform32 volume subop
[06:01] <grogbot> <mduggan> It's a good question - it may depend on the specifics of the code, but for basic cases the generated code would be identical. You can play with it here https://godbolt.org/z/nQywQp
[06:01] <grogbot> <mduggan> I don't mind ternarys for really simple cases like null checks, but for anything more complex and if/else is definitely more readable I agree
[06:02] <grogbot> <mduggan> eg something like int itemlen = ((item != nullptr) ? item->len() : 0); is readable enough
[06:58] --> ny00123 joined #scummvm.
[07:12] <-- Lightkey left irc: Ping timeout: 240 seconds
[07:21] --> NULUSIOS joined #scummvm.
[07:21] NULUSIOS (nls@mail2.termoil.com) left #scummvm.
[07:25] --> Lightkey joined #scummvm.
[08:31] --> vliaskov joined #scummvm.
[08:35] <grogbot> <lephilousophe> @aryanrawlani28 "premature optimization is the root of all evil" keeping the code easier to read is the best thing to do
[08:36] <grogbot> <lephilousophe> in addition, ternary should yield the same code as an if/else
[08:49] --> ajax16384 joined #scummvm.
[08:49] #scummvm: mode change '+o ajax16384' by ChanServ!ChanServ@services.
[09:27] <-- BeefEats left irc: Quit: Bye
[09:38] <-- cd left irc: Quit: cd
[09:40] <-- ny00123 left irc: Quit: Leaving
[10:02] <-- _sev left irc: Quit: This computer has gone to sleep
[10:10] --> _sev joined #scummvm.
[10:10] <-- _sev left irc: Changing host
[10:10] --> _sev joined #scummvm.
[10:10] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[10:22] <-- yuv422 left irc: Remote host closed the connection
[10:22] --> yuv422 joined #scummvm.
[10:22] #scummvm: mode change '+o yuv422' by ChanServ!ChanServ@services.
[10:33] --> Shine joined #scummvm.
[10:36] --> SylvainTV joined #scummvm.
[10:36] #scummvm: mode change '+o SylvainTV' by ChanServ!ChanServ@services.
[11:06] --> NULUSIOS joined #scummvm.
[11:07] NULUSIOS (nls@mail2.termoil.com) left #scummvm.
[11:13] <-- _sev left irc: Quit: This computer has gone to sleep
[11:15] --> _sev joined #scummvm.
[11:15] <-- _sev left irc: Changing host
[11:15] --> _sev joined #scummvm.
[11:15] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[11:19] <-- _sev left irc: Client Quit
[11:21] --> _sev joined #scummvm.
[11:21] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[11:26] <-- _sev left irc: Client Quit
[11:27] --> _sev joined #scummvm.
[11:27] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[11:28] <-- ajax16384 left irc: Read error: Connection reset by peer
[11:37] --> ajax16384 joined #scummvm.
[11:37] #scummvm: mode change '+o ajax16384' by ChanServ!ChanServ@services.
[11:49] --> crns joined #scummvm.
[11:55] --> Stormkeeper joined #scummvm.
[12:08] <-- Shine left irc: Read error: Connection reset by peer
[12:12] --> DJW|Badger joined #scummvm.
[12:13] --> girafe2 joined #scummvm.
[12:13] --> TAS-2012v joined #scummvm.
[12:14] <-- TAS_2012v left irc: Ping timeout: 256 seconds
[12:14] Nick change: TAS-2012v -> TAS_2012v
[12:16] <-- DJW|Home left irc: Ping timeout: 256 seconds
[12:16] <-- girafe left irc: Ping timeout: 256 seconds
[12:23] --> JamaicanBill joined #scummvm.
[12:27] --> BeefEats joined #scummvm.
[12:35] --> Shine joined #scummvm.
[12:42] <-- _sev left irc: Quit: This computer has gone to sleep
[12:43] --> _sev joined #scummvm.
[12:43] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[12:49] <-- JamaicanBill left irc: Remote host closed the connection
[13:23] <grogbot> <madmoose> Ugh, I'm not a fan of comparisons with nullptr or 0...
[13:44] <-- yuv422 left irc: Remote host closed the connection
[13:44] --> yuv422 joined #scummvm.
[13:44] #scummvm: mode change '+o yuv422' by ChanServ!ChanServ@services.
[13:59] <-- _sev left irc: Quit: This computer has gone to sleep
[14:10] <grogbot> <trembyle> There is an Italian fan translation for GK1. It's quite old actually - I think it was completed in 2006.
[14:10] <grogbot> <trembyle> https://gkpatches.vogons.org/
[14:10] <grogbot> <trembyle> To add support for this, do we need to try to contact the translation group for permission?
[14:12] <grogbot> <trembyle> https://cdn.discordapp.com/attachments/581224061091446795/708320957156032652/unknown.png
[14:13] <grogbot> <trembyle> It appears to run fine when detected as the English version, but it would be nice to call out support for it.
[14:16] <grogbot> <antoniou79> Hello, everyone!
[14:16] <grogbot> <ZvikaZ> What support does it need? Adding to detection table with the correct language?
[14:16] --> _sev joined #scummvm.
[14:16] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[14:17] <grogbot> <trembyle> Yes, and some way to differentiate it from English preferably.
[14:18] <grogbot> <antoniou79> @rootfather could you set me up as a translator on weblate again? I think something's been reverted for my account and I can only make suggestions.
[14:18] <grogbot> <trembyle> So I think another file would need to be checked.
[14:18] <grogbot> <trembyle> Maybe I could actually try to do this and make a pull request.
[14:19] <grogbot> <trembyle> But still my question about permission stands.
[14:25] <-- _sev left irc: Quit: This computer has gone to sleep
[14:40] <grogbot> <ZvikaZ> I don't think that you need permission to detect a game... Have you requested permission from the commercial companies? Why is fan made translation any different?
[14:40] <grogbot> <trembyle> Just because it's a fan group that may have requested acknowledgement or limited use of their translation.
[14:42] <grogbot> <trembyle> Admittedly, I have not tried to translate the above notice in the screen shot.
[14:42] <grogbot> <trembyle> That might answer my question.
[14:42] <grogbot> <trembyle> doing that now
[14:45] <grogbot> <trembyle> > The Italian translation of this game is the result of amateur work, completely non-profit, and can be downloaded for free from the gabriel knight 2k website. unauthorized total or partial re-use is prohibited. this localization work has not been promoted by sierra online or by other affiliated companies.
[14:49] <grogbot> <trembyle> How did it work with the recent GK2 subtitle patch? Was the group at least notified that support was being added to ScummVM?
[15:21] <grogbot> <Dirt in a cup> uh i need help
[15:22] <grogbot> <Dirt in a cup> how do I add a game the add game button isnt there
[15:22] --> _sev joined #scummvm.
[15:22] <-- _sev left irc: Changing host
[15:22] --> _sev joined #scummvm.
[15:22] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[15:23] <grogbot> <antoniou79> What platform are you on and can you provide a screenshot?
[15:23] --> criezy joined #scummvm.
[15:23] #scummvm: mode change '+o criezy' by ChanServ!ChanServ@services.
[15:23] <grogbot> <Dirt in a cup> uh im on a pc
[15:23] <grogbot> <Dirt in a cup> let me get the screen
[15:24] <grogbot> <Dirt in a cup> https://cdn.discordapp.com/attachments/581224061091446795/708339036527263764/unknown.png
[15:28] <grogbot> <criezy> @Dirt in a cup That's the website. You need to install the ScummVM application and use that. The User Manual (https://wiki.scummvm.org/index.php?title=User_Manual), and especially the Quick Start section, may help you (even if it is a bit outdated).
[15:28] <grogbot> <Dirt in a cup> oh
[15:28] <grogbot> <Dirt in a cup> sorry for that
[15:33] <grogbot> <ZvikaZ> @trembyle , I still don't understand why we don't need to request permission from Sierra (whoever that is today), for supporting GK, but for the Italian translation, we need to ask permission? What's the difference? And I even doubt that this group itself requested permission from Sierra for their IP of GK dialogs...
[15:36] <grogbot> <criezy> @trembyle I think that adding detection for a fan translation is different from distributing the translation ourselves, and I don't think that we have to ask permission to add the detection entry. However it might be polite to still contacting them to let them know we are adding the detection for their translation.
[15:38] <grogbot> <trembyle> That's kind of where I was going. I wasn't assuming it would be any issue. It also might be nice to add it to the release notes once support has been added.
[15:39] <grogbot> <trembyle> I'll see if I can find contact info and then add this as my first commit and pr
[15:48] <grogbot> <ZvikaZ> Beware, once you send your first PR, it's difficult to stop 😂
[15:50] <grogbot> <trembyle> Well, I'm not actually a real coder, so I doubt I could get very far. But I will say after staring at this source code for a long time, I'm able to understand a lot of what's going on.
[16:10] <grogbot> <SupSuper> famous last words 😛
[16:29] <Scummette> [scummvm] sev- closed pull request #2143: PINK: fixed pausing when menu bar disappears (master...pink_fix) https://git.io/Jvi2U
[16:29] <Scummette> [scummvm] sev- pushed 1 new commits to master: https://git.io/JfcQT
[16:29] <Scummette> scummvm/master 0f96d7b whiterandrek: PINK: fixed pausing when menu bar disappears
[17:09] <grogbot> <Dominus Dragon> @mduggan I've been busy the last few weeks and just now took a peek... man YOU've been busy! awesome work!
[17:09] <grogbot> <Dominus Dragon> however... yes there is always a but :)... you added the jump on space, could you somehow hook that up to the running long jump?
[17:24] --> salty-horse joined #scummvm.
[17:24] <-- salty-horse left irc: Changing host
[17:24] --> salty-horse joined #scummvm.
[17:24] #scummvm: mode change '+o salty-horse' by ChanServ!ChanServ@services.
[17:24] <salty-horse> history of AGI, live now: https://www.twitch.tv/sierra_offline
[17:24] <salty-horse> will not be available later
[18:11] <grogbot> <Henke37> Aw... The wrong pr was accepted.
[18:12] <grogbot> <Henke37> The hack instead of my token based fix.
[19:31] <grogbot> <Henke37> so, how to correctly reverse the order of the tabs in the options dialog box. this is going to be a mess to deal with using the hacky solution.
[19:32] <grogbot> <Henke37> because it's supposed to be keyboard accessible, right?
[19:33] <grogbot> <rvanlaar> Hi, I'm building a new integration for out #engine-director channel. It's going to be discord reporter for buildbot via webhooks, and I'm looking for hands to build it. All help is welcome.
[20:07] <grogbot> <sev> @monyarm simplest format in what terms?
[20:08] <grogbot> <sev> many games just concatenate resources together and provide table of contents
[20:08] <grogbot> <sev> that's probably the simplest one
[20:10] <grogbot> <monyarm> simple implementation. I'm trying to implement the file format CPK, which unfortunately has no existing libraries for it (only c# ones). I'm currently looking at the ultima engine archives, but they seem to have some sort of inner and outer archive, what i'm looking for is a simple implementation of a simple archive, that I can disect, and figure out how it works
[20:13] <grogbot> <sev> engines/scumm/file.cpp:64
[20:13] <grogbot> <sev> ScummFile::openSubFile(const Common::String &filename)
[20:13] <grogbot> <sev> this is archive with TOC and concatenated resources which Mac versions of SCUMM games use
[20:15] <grogbot> <monyarm> How come it extends Common::File and not Common::Archive?
[20:16] <grogbot> <sev> because it is simple
[20:16] <grogbot> Command sent by sev
[20:16] <grogbot> ...and it was implemented before we introduced Archive class 🙂
[20:17] <grogbot> <monyarm> Ah ok, I was under the impression that you needed to use Common::Archive to be able to use the file as an archive. Ah it was implemented before, gotcha
[20:17] <grogbot> <sev> Archive is a nice way to pre-hash your files and have speedy access
[20:17] <grogbot> <sev> as you may see, this thing scans through the TOC on every call
[20:18] <grogbot> <sev> if you want something simple which uses Archive, I can provide that too
[20:19] <grogbot> <monyarm> Ya archive would be best, CPK files aren't actually quite that simple, and they can be quite large
[20:19] <grogbot> <sev> hdb/file-manager.cpp is a pre-caching, but without Archive usage
[20:20] <grogbot> <sev> fullpipe/ngiarchive.cpp is what you're looking for
[20:21] <grogbot> <sev> another simple resource concatenation, except that TOC is xored
[20:21] <grogbot> <sev> and uses Common::Archive
[20:24] <grogbot> <monyarm> thanks, i'll take a look at it
[20:30] <grogbot> <trembyle> Hey @Strangerke if you are around, I've still been trying to figure out the Gobliiins CD-i disc.
[20:30] <grogbot> <trembyle> I think you mentioned that you wrote a tool to extract the files. If you can find that, it would be great, but if not, could you remember anything about the format that might help me find the files on the disc?
[20:37] <-- salty-horse left irc: Quit: Leaving
[20:39] <grogbot> <janisozaur> hey, what's up with clang-format? The rules are present, but nothing adheres to them
[20:42] --> CuriosTiger joined #scummvm.
[20:46] <grogbot> <SupSuper> probably too destructive to retroactively apply
[20:47] <grogbot> <janisozaur> does it somehow make you lose the history?
[20:48] <grogbot> <madmoose> Yay, now I have to learn electronics repair.
[20:50] <grogbot> <madmoose> I picked up a Roland SD-35, which works fine, and a Roland RA-50, which has janky buttons.
[20:50] <grogbot> <sev> @janisozaur could you please elaborate, what is not adhering to the rules?
[20:51] <grogbot> <sev> because I did it for the first time, and could make it wrong
[20:51] <grogbot> <sev> I tried to follow our coding standards
[20:52] <grogbot> <janisozaur> I took some random files and applying clang-format is not idempotent
[20:52] <grogbot> <sev> and what are the differences?
[20:52] --> cd joined #scummvm.
[20:53] <-- Shine left irc: Read error: Connection reset by peer
[20:56] <Scummette> [scummvm] janisozaur opened pull request #2229: ALL: clang-format (master...clang-format) https://git.io/JfCe9
[20:57] <grogbot> <janisozaur> @sev let's just say there are a few here and there: https://github.com/scummvm/scummvm/pull/2229
[21:01] <grogbot> <SupSuper> problem with clang-format it's very opiniated, anything you omit it will just apply the default
[21:02] <grogbot> <janisozaur> for reference: I was primary driver for https://github.com/OpenRCT2/OpenRCT2/pull/7718 and can answer some questions
[21:02] <grogbot> <janisozaur> @SupSuper problem with having clang-format rules and not enforcing them is not enforcing them
[21:03] <grogbot> <SupSuper> it's been 2 days
[21:04] <grogbot> <janisozaur> ah, that I haven't noticed
[21:04] <grogbot> <janisozaur> so what's the plan if I want to do a PR? should I clang-format touched files?
[21:16] <grogbot> <sev> @janisozaur I see that many of those places which got reformatted are in fact correct
[21:17] <grogbot> <sev> but I do not like those places where it breaks intentional formatting of constant lists
[21:17] <grogbot> <sev> the goal was to make vscode a bit more sane, but it is still ignores some of the rules
[21:18] <grogbot> <sev> or changes like this:
[21:18] <grogbot> <sev> - #pragma mark --- Ogg Vorbis stream --- + #pragma mark--- Ogg Vorbis stream ---
[21:18] <grogbot> <sev> huh? why removing space after "mark"?
[21:19] <grogbot> <sev> but to answer your question, no, there is no plan to mass-format the files
[21:19] <grogbot> <sev> though it could definitely help for the new code
[21:20] <grogbot> <janisozaur> // clang-format off static const uint8_t my_array = { 'p', 'r', 'e', 'f', 'o', 'r', 'm', 'a', 't', 't', 'e', 'd', }; // clang-format on
[21:20] <grogbot> <sev> oh, that's lame
[21:20] <grogbot> <janisozaur> I'd suggest identifying places that need such treatment as the first step
[21:20] <grogbot> <Strangerke> @trembyle : I spent a couple of hours looking for the extraction tool
[21:20] <grogbot> <Strangerke> I found something in a mail from 2014, but sadly Google thinks it's a virus and blocks it
[21:20] <grogbot> <Strangerke> still searching
[21:21] <grogbot> <sev> and then // emacs-format off, and then // astyle-format-off and finally // all-formatters-leave-me-alone?
[21:21] <grogbot> <sev> 😄
[21:21] <grogbot> <janisozaur> @sev do you use multiple? why? of course they're going to fight with each other
[21:21] <grogbot> <janisozaur> what's the point of having any then?
[21:22] <grogbot> <sev> I tried to explain: to make vscode happy
[21:22] <grogbot> <James W> Hi everyone.... hope all are well!
[21:22] <grogbot> <janisozaur> I usually vote for clang-format as the most prolific one, find me an editor that would not support it
[21:23] <grogbot> <James W> Question if I may: Is there a nice program that can extract backgrounds from Simon the Sorcerer?
[21:23] <grogbot> <sev> hi @James W
[21:23] <grogbot> <sev> @James W no, nobody written it, but it would be relatively simple with use of ScummVM sources
[21:24] <grogbot> <trembyle> @Strangerke thanks 🙂
[21:24] <grogbot> <James W> @sev you may regret saying that 🙂
[21:24] <grogbot> <sev> @James W for you? never
[21:24] <grogbot> <James W> Charmer 🙂
[21:27] <-- ajax16384 left irc: Quit: Leaving
[21:28] <Scummette> [scummvm] janisozaur opened pull request #2230: TRAVIS: enable ccache compression (master...patch-3) https://git.io/JfCfO
[21:31] <grogbot> <janisozaur> @sev so what about using many formatters?
[21:32] <grogbot> <sev> When I was developing on enacs, I put my config on the Wiki
[21:33] <grogbot> <sev> Then, for many years I used astyle, its on the Wiki too. And finally, three days ago @Mataniko tempted me to try vscode
[21:33] <grogbot> <sev> And I abused my commit rights and added that file to the repo 😉
[21:34] <grogbot> <janisozaur> that's all good, but they will contradict each other
[21:34] <grogbot> <janisozaur> what's the point of having multiple rules, when you can enforce none?
[21:35] <grogbot> <madmoose> I just trim trailing spaces, that's enough auto formatting for me.
[22:01] <grogbot> <monyarm> I started working on the file reading, but am having a small problem, it won't compile, and i'm not sure why, https://pastebin.com/3LUsnKFV That is the error im getting (it's at the bottom of the paste, i decited to also add the code)
[22:02] <grogbot> <monyarm> The error is about Common::NonCopyable::NonCopyable(const Common::NonCopyable&) being private in File, but i'm not trying to copy file, so i'm not sure what the issue is
[22:04] <grogbot> <monyarm> moving Common::File f; outside of the header, and into the cpp, makes it compile, but i'm not sure why having it be in the header would make it think it's being copied?
[22:06] <-- vliaskov left irc: Ping timeout: 264 seconds
[22:36] <grogbot> <SupSuper> because if CPKFile is ever copied, so would File
[22:40] <grogbot> <Strangerke> hum... I'm currently looking, I don't have an answer yet
[22:41] <grogbot> <Strangerke> oh. but what would you use? a pointer on the file, then?
[22:46] --> timofonic joined #scummvm.
[22:47] <grogbot> <SupSuper> yes. or just inherit from File, that's what most do
[22:48] <grogbot> <SupSuper> or just override the default copy constructor
[22:48] <grogbot> <SupSuper> etc etc
[22:49] <grogbot> <monyarm> I'm gonna inherit from Archive later, but for now i'm just trying to get the actual reading of the file down, as the only source i have for this format, is some confusing c# code, but i now have another issue: on this line f.read(_utf_packet, utf_size); I get a seg fault https://pastebin.com/qGZxGge7 I really am sorry for asking for help so often
[22:51] --> ldevulder joined #scummvm.
[22:51] <grogbot> <SupSuper> you need to initialize the memory
[22:52] <-- ldevulder_ left irc: Ping timeout: 264 seconds
[22:53] <grogbot> <SupSuper> byte* _utf_packet = new byte[utf_size] or some such
[22:53] <grogbot> <monyarm> Thank you, i did that before, but kept switching between byte* and std::vector, and forgot to initialize my byte* when i switched back
[22:56] <Scummette> [scummvm] trembyle opened pull request #2231: SCI32: Add GK1 Italian translation patch detection (master...master) https://git.io/JfCke
[22:58] <grogbot> <monyarm> And i now got the worst kind of issue, the one that shows up when you run it normally, but not when you run it in the debugger
[23:00] <grogbot> <monyarm> Turns out it was because of the difference in how std::string and Common::String behave, setting my string to " ", before adding to it, fixed my crash
[23:02] <grogbot> <trembyle> @DreamMaster For the Magnetic Scrolls games, there are platforms listed: Amstrad, Speccy, C64,etc. What are these used for? Are they actually detectable?
[23:02] <grogbot> <trembyle> I've gotten it to work with the story files, but those don't really apply to specific platforms.
[23:11] <Scummette> [scummvm] ccawley2011 opened pull request #2232: GRAPHICS: MACGUI: Allow specifying a custom cursor using Graphics::Cursor (master...mac-cursor) https://git.io/JfCIL
[23:16] <-- criezy left irc: Quit: criezy
[23:33] <grogbot> <DreamMaster> If you mean the text in the detection entries, these come from the (open source) Magnetic interpreter.. it was the only one (off the top of my head), that actually came with it's own list of game detection entries, so I reused it. It's also why Magnetic is the only glk subengine has doesn't use an md5-based detection like other ScummVM games do
[23:35] <grogbot> <DreamMaster> They're just there for informational purposes, indicating which system's game was detected. Ideally, the list should really be refactored at some point to use our Common::Platform constants as well, but that's a low priority
[23:51] <grogbot> <trembyle> Got it. Thanks. Those games would be great to support. At least in the US, I don't think a lot of people know them.
[23:51] <grogbot> <trembyle> Obviously in UK they were bigger.
[23:57] <-- yuv422 left irc: Remote host closed the connection
[23:57] --> yuv422 joined #scummvm.
[23:57] #scummvm: mode change '+o yuv422' by ChanServ!ChanServ@services.
[23:58] <grogbot> <DreamMaster> I was actually really pleased the list was present. Considering they were all commercial games, I only had one or two of them in my collection.
[00:00] --- Sat May 9 2020