ScummVM IRC Log - 07 May 2021

[Back to Index]

[00:10] --> Shine_ joined #scummvm.
[00:16] <-- Shine_ left irc: Read error: Connection reset by peer
[00:41] --> girafe joined #scummvm.
[00:47] --> Shine_ joined #scummvm.
[01:15] <Scummette> scummvm/master 519b212 sev-: SLUDGE: Improved script decompilation
[01:15] <Scummette> scummvm/master 2270799 sev-: SLUDGE: Dump images
[01:15] <Scummette> scummvm/master becfea5 sev-: SLUDGE: Changed naming format for dump files
[01:15] <Scummette> [scummvm] dreammaster pushed 2 new commits to master: https://git.io/J3Mtx
[01:15] <Scummette> scummvm/master c51f717 dreammaster: SLUDGE: Compilation fix for Visual Studio
[01:15] <Scummette> scummvm/master 6a9f01f dreammaster: AGS: Mark other game detection macros as testing
[01:25] <-- vliaskov left irc: Remote host closed the connection
[01:32] --> Shine__ joined #scummvm.
[01:35] <-- Shine_ left irc: Ping timeout: 252 seconds
[01:43] <-- JohnnyonFlame left irc: Read error: Connection reset by peer
[01:52] --> DominusExult joined #scummvm.
[01:54] <Scummette> [scummvm] mduggan pushed 4 new commits to master: https://git.io/J3MsB
[01:54] <Scummette> scummvm/master a1880b8 mduggan: ULTIMA8: Remove text from inventory gump when Crusader dies
[01:54] <Scummette> scummvm/master 764f310 mduggan: ULTIMA8: Crusader camera centre button improvement
[01:54] <Scummette> scummvm/master 014ad8f mduggan: ULTIMA8: Avoid possible assertion on avatar death
[01:55] <-- Dominus left irc: Ping timeout: 240 seconds
[01:55] Nick change: DominusExult -> Dominus
[02:07] <-- TMM left irc: Quit: https://quassel-irc.org - Chat comfortably. Anywhere.
[02:08] --> TMM joined #scummvm.
[02:08] #scummvm: mode change '+o TMM' by ChanServ!ChanServ@services.
[02:09] <-- mlk23 left irc: Quit: The Lounge - https://thelounge.chat
[03:44] <Scummette> [scummvm] mduggan pushed 1 new commits to master: https://git.io/J3Mrr
[03:44] <Scummette> scummvm/master dc8a948 mduggan: ULTIMA8: Return area search items in same order as original
[04:21] <eriktorbjorn> _sev: Both versions of SOMI are correctly detected as Macintosh versions when I add them. But when I start them, they warn about missing CD audio tracks. That didn't use to happen, but I haven't tried to find out when that started. Yet. Also, I seem to recall that one of them used to ask about copy protection, but doesn't any more. Since I got them second-hand (two CDs in cardboard sleeves), I don't know if the code wheel w
[04:21] <eriktorbjorn> included or not though, so that *could* be correct.
[04:24] <eriktorbjorn> _sev: 2.2.0 doesn't warn about the CD audio, but also doesn't ask for copy protection.
[04:34] <grogbot> <antoniou79> The warning about missing audio tracks in all ports of ScummVM, and not only in Windows version, was something I changed recently with commit https://github.com/scummvm/scummvm/commit/669b9a0ffd75c8517c08c18a0f251a075ca4f7a1
[04:37] <-- SylvainTV left irc: Ping timeout: 260 seconds
[04:37] --> SylvainTV joined #scummvm.
[04:37] #scummvm: mode change '+o SylvainTV' by ChanServ!ChanServ@services.
[04:38] <grogbot> <antoniou79> That was because, while the Windows ScummVM version did warn about missing extracted CD audio tracks for the CD version of SoMI, the Android version would not, and this made no sense.
[04:49] <eriktorbjorn> antoniou79: I'm using Linux. So is that why I never saw the warning before, then?
[04:53] <eriktorbjorn> So I guess the question is, why does it think the Mac version has audio tracks?
[04:55] <grogbot> <antoniou79> yes on both accounts. But I don't as of yet know why it thinks that. Probably someone else who's worked on the Scumm engine stuff will have an answer, or find it quicker than I will
[05:00] --> JohnnyonFlame joined #scummvm.
[05:38] <-- JohnnyonFlame left irc: Read error: Connection reset by peer
[05:44] --> ny00123 joined #scummvm.
[06:00] --> palasso joined #scummvm.
[06:23] <Scummette> [scummvm] ScummVM-Translations pushed 4 new commits to master: https://git.io/J3DUl
[06:23] <Scummette> scummvm/master f0d03ca iplaysomegames101: I18N: Update translation (German)
[06:23] <Scummette> scummvm/master ddb6973 iplaysomegames101: I18N: Update translation (Russian)
[06:23] <Scummette> scummvm/master cbd6ade iplaysomegames101: I18N: Update translation (Ukrainian)
[06:40] <-- Shine__ left irc: Read error: Connection reset by peer
[06:41] <eriktorbjorn> I think the problem is that the Macintosh version of SOMI is defined as the "CD" variant in scumm-md5.h, and the "CD" variant is defined as having audio tracks in detection_tables.h.
[06:47] <-- SylvainTV left irc: Ping timeout: 260 seconds
[06:47] --> SylvainTV joined #scummvm.
[06:47] #scummvm: mode change '+o SylvainTV' by ChanServ!ChanServ@services.
[07:37] <eriktorbjorn> Hmm... There are three different versions of SOMI for the Mac? I only have two of them.
[07:57] --> vliaskov joined #scummvm.
[08:03] <-- Mia left irc: Ping timeout: 240 seconds
[08:21] <-- girafe left irc: Read error: Connection reset by peer
[08:31] --> girafe joined #scummvm.
[08:31] <Scummette> [scummvm] eriktorbjorn opened pull request #3002: SCUMM: Add Macintosh variant of Monkey Island 1 (master...monkey-mac-variant) https://git.io/J3DEZ
[09:19] --> Mia joined #scummvm.
[09:36] <-- SylvainTV left irc: Read error: Connection reset by peer
[09:51] <Scummette> [scummvm] mduggan pushed 2 new commits to master: https://git.io/J3DMT
[09:51] <Scummette> scummvm/master 7338e7a mduggan: ULTIMA8: Fix animations used for Crusader combat rolls
[09:51] <Scummette> scummvm/master 6f483eb mduggan: ULTIMA8: Don't reset FIRSTSTEP on non-step animations
[09:51] <Scummette> [scummvm] ScummVM-Translations pushed 1 new commits to master: https://git.io/J3DMk
[09:51] <Scummette> scummvm/master cff8795 : I18N: Update translation files
[10:12] <_sev> eriktorbjorn: there was this recent commit...
[10:14] <_sev> eriktorbjorn: could you please check if revertin 669b9a0ffd75c8517c08c18a0f251a075ca4f7a1 helps?
[10:15] <grogbot> <antoniou79> _sev: I already mentioned this (my) commit above. It is the reason that he got the warning but not the root of the issue.
[10:16] <grogbot> <antoniou79> The warning should appear in all ports of ScummVM, not just Windows.
[10:16] <grogbot> <antoniou79> It just should not appear for versions of the games that do not actually have CD audio tracks
[10:17] <Scummette> [scummvm] bluegr closed pull request #3002: SCUMM: Add Macintosh variant of Monkey Island 1 (master...monkey-mac-variant) https://git.io/J3DEZ
[10:17] <Scummette> [scummvm] bluegr pushed 1 new commits to master: https://git.io/J3D9z
[10:17] <Scummette> scummvm/master 40a7ebc eriktorbjorn: SCUMM: Add Macintosh variant of Monkey Island 1
[10:17] <grogbot> <antoniou79> in which case, it's an issue of how we detect them
[10:17] --> Shine_ joined #scummvm.
[10:19] <grogbot> <sev> you mean, there are also problems with the simultaneous access to CD audio and CD data?
[10:20] <grogbot> <antoniou79> I don't understand the question. The issue here is that the Mac version(s) of SoMI do not feature CD audio (albeit they were published in CD form)
[10:20] <grogbot> <antoniou79> The PR by eriktorbjorn that was just merged, fixes this
[10:21] <grogbot> <sev> the reason for that check is that when the game is marked as having CD tracks and we do not see them dumped, we assume that they will be read from the CD. On Windows it was causing the problems. This check is for that
[10:21] <grogbot> <sev> maybe there was some confusion on the purpose of the function?
[10:22] <grogbot> <sev> and now you basically remove that and prompt users to always dump their CDs
[10:24] <grogbot> <antoniou79> The check for the Windows issue remains. Within the macros guard define check
[10:24] <grogbot> <antoniou79> The issue my commit fixed was, as I explained above, this practical example:
[10:25] <grogbot> <antoniou79> When running SoMI VGA/CD (as extracted from the Special Edition files) on ScummVM (Windows), you get the warning that no audio tracks were found and you don't get music (correct behavior).
[10:26] <grogbot> <antoniou79> When running the same version on ScummVM Andoird (or on Linux, or any other port) you don't get the warning, and you don't get music. You basically don't know why you don't get music
[10:27] <grogbot> <antoniou79> And that function actually provides this warning (as well as the other warning about the Windows specific issue with audio directly from the CD drive)
[10:28] <-- _sev left irc: Quit: This computer has gone to sleep
[10:30] <grogbot> <antoniou79> (I do have a question as to the purpose of the !defined check for SYMBIAN in the function, but the change shouldn't cause side-effects to Symbian port anyway)
[10:35] --> _sev joined #scummvm.
[10:35] <-- _sev left irc: Changing host
[10:35] --> _sev joined #scummvm.
[10:35] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[10:36] <grogbot> <sev> @antoniou79 well, the thing is that that is not the original purpose of the function
[10:37] <grogbot> <sev> as of Symbian, I do not care. The code quality is so low there that I am thinking more and more of removing it completely. And it basically infested bunch of places in our code with those ifdefs
[10:49] <grogbot> <antoniou79> I don't disagree. The function seems to have shifted purpose without consideration of ports other than the Windows main one. I wanted a simple fix for the situation of the missing warning, hence my commit. As I said, this did not cause eriktorbjorn issue. It just exposed another bug in the detection entries for macintosh.
[10:52] <-- ldevulder left irc: Remote host closed the connection
[10:55] <grogbot> <antoniou79> The name of the function does not help either. Maybe the better way would be to split it in two parts. One part checking for the existence of extracted audio tracks for the CD versions in any of the supported formats (based on what was compiled into ScummVM), and the other part being specific and only the one with the check for the Windows issue with audio from CD drive -- called if the first method returns false (= no supported
[10:55] <grogbot> extracted audio was found). So: same logic, but two separate methods, named appropriately as to their purpose.
[11:08] --> ldevulder joined #scummvm.
[11:13] <-- speachy left irc: Quit: WeeChat 3.0.1
[11:25] <-- _sev left irc: Quit: This computer has gone to sleep
[11:25] --> _sev joined #scummvm.
[11:25] <-- _sev left irc: Changing host
[11:25] --> _sev joined #scummvm.
[11:25] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[11:58] <-- girafe left irc: Read error: Connection reset by peer
[12:08] <Scummette> [scummvm] orgads closed pull request #2998: BUILD: Deduplicate install targets (master...dedup-install) https://git.io/J3agO
[12:08] <Scummette> [scummvm] orgads pushed 1 new commits to master: https://git.io/J3yqA
[12:17] <grogbot> <madmoose> The older I've gotten the longer my function names have become.
[12:53] <-- Lightkey left irc: Ping timeout: 250 seconds
[13:01] --> ajax16384 joined #scummvm.
[13:01] #scummvm: mode change '+o ajax16384' by ChanServ!ChanServ@services.
[13:06] --> Lightkey joined #scummvm.
[13:27] --> h00ligan joined #scummvm.
[13:27] #scummvm: mode change '+o h00ligan' by ChanServ!ChanServ@services.
[13:31] <-- ajax16384 left irc: Ping timeout: 252 seconds
[13:32] <-- h00ligan left irc: Client Quit
[13:40] --> JohnnyonFlame joined #scummvm.
[13:41] <-- TMM left irc: Quit: https://quassel-irc.org - Chat comfortably. Anywhere.
[13:41] --> TMM joined #scummvm.
[13:41] #scummvm: mode change '+o TMM' by ChanServ!ChanServ@services.
[13:45] --> ajax16384 joined #scummvm.
[13:45] #scummvm: mode change '+o ajax16384' by ChanServ!ChanServ@services.
[14:54] <grogbot> <thoth> I find this as well, but I'm still young and inexperienced. We'll see if it continues.
[14:59] <grogbot> <antoniou79> I hit a slope point early on, where I used ridiculously long names. For variables too. I think I've improved somewhat, but you know, old habits and all.
[15:03] <-- andreas1107 left irc: Ping timeout: 240 seconds
[15:15] --> andreas1107 joined #scummvm.
[15:28] <-- andreas1107 left irc: Ping timeout: 252 seconds
[15:38] <-- ny00123 left irc: Quit: Leaving
[15:40] --> andreas1107 joined #scummvm.
[15:45] --> girafe joined #scummvm.
[16:01] --> speachy joined #scummvm.
[16:16] <grogbot> <TheUp> if your functions names are not at least 80 columns, my brain don't want none !
[17:04] <grogbot> <thoth> Heresy. In this house we respect the 80 column limit.
[17:08] <grogbot> <madmoose> My monitor is ultra-widescreen for a reason.
[17:18] <Scummette> scummvm/master eef5a81 orgads: BUILD: Deduplicate install targets (#2998)
[17:18] <Scummette> [scummvm] ScummVM-Translations pushed 1 new commits to master: https://git.io/J3SBk
[17:18] <Scummette> scummvm/master 5b58e92 lotharsm: I18N: Update translation (German)
[17:39] <grogbot> <thoth> Yeah. To display code from six different files at once.
[17:53] <grogbot> <somaen> That 80 column thing is a weird legacy thing imho.
[17:53] <grogbot> <somaen> We have slightly higher resolution these days
[18:48] <grogbot> <SupSuper> that's why you rotate it
[18:48] <grogbot> <SupSuper> https://cdn.discordapp.com/attachments/581224061091446795/840299488228147200/Sem_Titulo_2.jpg
[18:53] <grogbot> <antoniou79> This discussion is getting cursed by the minute 😄
[18:56] <Scummette> [scummvm] sluicebox opened pull request #3003: WIN32: Enable building with UNICODE (master...win32-unicode) https://git.io/J3SDD
[19:05] <grogbot> <madmoose> @SupSuper I couldn't handle the neck strain 🙂
[19:32] <grogbot> <thoth> Having an 80 line limit makes it easy and comfortable to fit many files on the screen at once, which is useful for cross-referencing.
[19:33] <grogbot> <sev> @antoniou79 splitting the function is a good idea
[19:57] <-- Shine_ left irc: Read error: Connection reset by peer
[20:16] <Scummette> [scummvm] mparnaudeau opened pull request #3004: BACKENDS: SDL: Fix stack buffer overflow on empty supported formats list (master...backends_graphics_sdl_fix_stack_buffer_overflow_suppported_formats_grim) https://git.io/J3SjJ
[20:17] <Scummette> [scummvm] fracturehill pushed 8 new commits to master: https://git.io/J3SjZ
[20:17] <Scummette> scummvm/master 3013d07 fracturehill: NANCY: Implement PlaySoundPanFrameAnchorAndDie action record
[20:17] <Scummette> scummvm/master 7ac4cb8 fracturehill: NANCY: Fix PlayDigiSoundAndDie action record in The Vampire Diaries
[20:17] <Scummette> scummvm/master 913f450 fracturehill: NANCY: Implement palette change action record types
[20:17] <Scummette> [scummvm] ScummVM-Translations pushed 1 new commits to master: https://git.io/J3Sjn
[20:17] <Scummette> scummvm/master 0b8f006 : I18N: Update translations templates
[20:18] --> cd joined #scummvm.
[20:21] <-- ajax16384 left irc: Quit: Leaving
[21:00] <-- ced117 left irc: Ping timeout: 252 seconds
[21:07] --> ccawley2011 joined #scummvm.
[21:07] #scummvm: mode change '+o ccawley2011' by ChanServ!ChanServ@services.
[21:22] --> ced117 joined #scummvm.
[21:34] <-- ldevulder left irc: Quit: Leaving
[21:38] <-- ced117 left irc: Ping timeout: 240 seconds
[21:38] --> ced117 joined #scummvm.
[21:45] <grogbot> <somaen> We got wider screens these days too, still not buying that argument completely. (But Im not advocating for something super wide either, like 200 column, just saying that 80 is a bit on the slim side.)
[21:46] <grogbot> <somaen> If programming languages lent themselves to linebreaking the same way prose does, that would solve a lot of this though.
[21:46] <grogbot> <somaen> And that said, not advocating for changing anything wrt ScummVM code style, just saying that I find that particular historical inheritance outdated.
[22:40] <-- palasso left irc: Remote host closed the connection
[22:52] --> SylvainTV joined #scummvm.
[22:52] #scummvm: mode change '+o SylvainTV' by ChanServ!ChanServ@services.
[23:39] <-- JohnnyonFlame left irc: Read error: Connection reset by peer
[23:40] --> JohnnyonFlame joined #scummvm.
[23:55] <-- JohnnyonFlame left irc: Ping timeout: 240 seconds
[00:00] --- Sat May 8 2021