[Back to Index]

[01:19] <-- vliaskov left irc: Ping timeout: 246 seconds
[01:51] --> DominusExult joined #scummvm.
[01:51] <-- DominusExult left irc: Changing host
[01:51] --> DominusExult joined #scummvm.
[01:55] <-- Dominus left irc: Ping timeout: 272 seconds
[01:55] Nick change: DominusExult -> Dominus
[02:16] --> exmensa joined #scummvm.
[02:27] <-- cd left irc: Quit: cd
[02:39] --> dreammaster joined #scummvm.
[02:39] #scummvm: mode change '+o dreammaster' by ChanServ!ChanServ@services.
[02:51] <exmensa> @dreammaster Thanks, that Lure demo doesn't seem to be anything besides the opening cinematic and first room anyway; just figured someone might want it around for reference.
[03:07] <dreammaster> It's certainly an interesting tidbit of gaming history, indeed, and somemay want to play around with supporting it one day for completeness sake
[03:09] <dreammaster> In some cases, when I've had time, there's been interesting differences between a demo and the full game, which can give interesting insights on how the particular engine evolved
[04:11] <Lightkey> https://itch.io/b/520/bundle-for-racial-justice-and-equality Neat little bundle.
[04:34] <Deledrius> Yeah
[04:34] <Deledrius> Thanks for sharing that.
[04:34] <grogbot> <SupSuper> "little" 🙂
[04:44] <-- dreammaster left irc: Ping timeout: 256 seconds
[05:08] exmensa (exmensa@65.sub-174-250-66.myvzw.com) left #scummvm.
[05:37] <ScummBot> Port build status changed with 6bea770e: Failure: master-osx_x64
[05:59] --> Begasus joined #scummvm.
[06:20] <-- Lightkey left irc: Ping timeout: 260 seconds
[06:34] --> Lightkey joined #scummvm.
[07:24] <-- BeefEats left irc: Read error: Connection reset by peer
[07:43] --> ny00123 joined #scummvm.
[08:00] --> ldevulder__ joined #scummvm.
[08:03] <grogbot> <Rod> Hello everyone! I used to collaborate in the spanish translation but today I realized that I lost the possibility to save new translations. That happened to me when I tried to translate the last news in the website. Could anyone help me to join as official translator? Thanks.
[08:03] <-- ldevulder_ left irc: Ping timeout: 272 seconds
[08:32] <grogbot> <rootfather> Sure, just drop me your github username in a PM/direct message and I'll add you
[08:43] --> ajax16384 joined #scummvm.
[08:43] #scummvm: mode change '+o ajax16384' by ChanServ!ChanServ@services.
[09:23] --> JohnnyonF joined #scummvm.
[09:23] <-- JohnnyonFlame left irc: Read error: Connection reset by peer
[09:46] --> Stormkeeper joined #scummvm.
[09:58] <-- Tkachov left irc: Ping timeout: 272 seconds
[10:20] --> Tkachov joined #scummvm.
[10:20] #scummvm: mode change '+o Tkachov' by ChanServ!ChanServ@services.
[10:49] --> criezy joined #scummvm.
[10:49] #scummvm: mode change '+o criezy' by ChanServ!ChanServ@services.
[10:58] <Scummette> [scummvm] sev- pushed 4 new commits to master: https://git.io/Jf1Ff
[10:58] <Scummette> scummvm/master 2680916 sev-: DIRECTOR: LINGO: Moved thenetitywithid to simpleexpr
[10:58] <Scummette> scummvm/master 547e166 sev-: DIRECTOR: LINGO: Clean up obsolete tokens
[10:58] <Scummette> scummvm/master 1bf7358 sev-: DIRECTOR: LINGO: Added test for additional 'the' entity syntax
[11:00] <Scummette> [scummvm] lotharsm pushed 1 new commits to master: https://git.io/Jf1FT
[11:00] <Scummette> scummvm/master aca3975 lotharsm: BASE: Fix missing newline in command line output
[11:01] <Scummette> [scummvm] lotharsm opened pull request #2310: MT32: Update munt emulation code to mt32emu 2.4.0 (master...mt32emu-2.4.0) https://git.io/Jf1Fk
[11:02] <Scummette> [scummvm] sev- pushed 1 new commits to master: https://git.io/Jf1FI
[11:02] <Scummette> scummvm/master 6c6fde7 sev-: DIRECTOR: LINGO: Fix version for 'the text of field'
[11:20] <grogbot> <Henke37> say, what's this "deep-code-ai" thing i'm now seeing in PRs?
[11:22] <Scummette> [scummvm] sev- pushed 1 new commits to master: https://git.io/Jf1F1
[11:22] <Scummette> scummvm/master 07fbcc2 sev-: DIRECTOR: LINGO: Do not error() inside Lingo, but issue warning
[11:28] <grogbot> <rootfather> Its our new integration with deepcode.ai. AI driven code analysis
[11:29] <grogbot> <timofonic> It seems the https://www.deepcode.ai/
[11:29] <grogbot> <timofonic> Yep
[11:29] <grogbot> <timofonic> Is it good?
[11:33] <grogbot> <Henke37> i gave it a try. it found a bunch of stupid things. malloc returning null. realloc returning null. break statements being dead code because of a return statement.
[11:33] <grogbot> <Henke37> oh, and it doesn't like strcpy
[11:37] <grogbot> <timofonic> Is that bad? Can them be reported?
[11:38] <grogbot> <Henke37> it's warning fatigue. and i have no idea if there is a way to report your experience
[11:40] <grogbot> <rootfather> you can provide feedback over at deepcode.ai itself. I even think there's a "feedback" link in the PR comments when issues are spotted.
[11:46] <grogbot> <timofonic> https://habr.com/en/company/pvs-studio/blog/496534/
[11:53] --> borosky joined #scummvm.
[11:53] --> Shine_ joined #scummvm.
[12:07] <ScummBot> Port build status changed with aaaffa96: Success: master-osx_x64
[12:12] <grogbot> <sev> @timofonic what about PVS Studio?
[12:13] <grogbot> <timofonic> I have no idea, it seems PVS Studio developers reviewed DeepCode. Not an objective review, it seems, but it seems to give some insights.
[12:18] <grogbot> <sev> ah
[12:18] <grogbot> <sev> I thought you're recommending PVS Studio
[12:18] <grogbot> <sev> we already used them
[12:18] <grogbot> <sev> but their license is outrageous
[12:18] <grogbot> <sev> and completely unacceptable
[12:18] <grogbot> <sev> first, they require like $10k/year for a project of our size
[12:18] <grogbot> <sev> could be more, I just don't remember
[12:19] <grogbot> <sev> and then they state that they give it "for free" for the OSS projects
[12:20] <grogbot> <sev> but in order to use it, you must insert in the first like 4 lines of code something like "Use PVS-Studio, a free and superwonderful tool, or die. <link to their website>"
[12:21] <grogbot> <rootfather> yikes
[12:23] <grogbot> <sev> ah, here it is
[12:23] <grogbot> <sev> just look at it
[12:23] <grogbot> <sev> // This is an open source non-commercial project. Dear PVS-Studio, please check it. // PVS-Studio Static Code Analyzer for C, C++, C#, and Java: http://www.viva64.com
[12:24] <grogbot> <sev> you have to add this permanently to every file you want to check
[12:24] <grogbot> <madmoose> "Dear PVS-Studio"...? wtf...
[12:24] <grogbot> <sev> it is not allowed to add it just for testing
[12:24] <grogbot> <sev> @madmoose precisely: https://www.viva64.com/en/b/0457/
[12:25] <grogbot> <sev> and they check that this message is pasted verbatim
[12:25] <grogbot> <timofonic> @sev Oh yes, I was aware PVS Studio has an evil license for FOSS.
[12:40] <grogbot> <madmoose> It appears that --enable-tts requires --enable-translation
[12:46] --> cd joined #scummvm.
[13:06] <Scummette> [scummvm] sev- pushed 3 new commits to master: https://git.io/Jf1A0
[13:06] <Scummette> scummvm/master 83c8035 sev-: MATH: Added hypotenuse() call
[13:06] <Scummette> scummvm/master b1c5e63 sev-: JANITORIAL: Whitespace fixes
[13:06] <Scummette> scummvm/master b53a7db sev-: ALL: Switch to Common::hypotenuse()
[13:56] <grogbot> <sev> oh, that's good to know
[13:56] <grogbot> <sev> shall it be fixed or we should bail out when tranlsations are not enabled and TTS requested?
[14:18] <grogbot> <rootfather> I wonder why --enable-translation is required or currently "enforced" by --enable-tts in the first place, since they both seem to be pretty unrelated
[14:19] Last message repeated 1 time(s).
[14:24] <grogbot> <Henke37> speech does need to know which language is being used, but that shouldn't require bringing in the entire translation subsystem
[14:24] <grogbot> <madmoose> I don't know more than that I get a compilation error if I disable translation and enable tts 🙂
[14:34] <ScummBot> Port build status changed with b53a7db0: Success: master-ps2
[14:35] <Scummette> [scummvm] djsrv opened pull request #2311: DIRECTOR: LINGO: Implement factories (master...director-factory) https://git.io/Jf1ht
[14:51] <Scummette> [scummvm] antoniou79 closed pull request #2298: COMMON: Use assert for CLIP() if bounds are not properly ordered (master...improveCLIPUtil) https://git.io/Jf6VW
[14:51] <Scummette> [scummvm] antoniou79 pushed 1 new commits to master: https://git.io/Jf1h9
[14:51] <Scummette> scummvm/master c2a1290 antoniou79: COMMON: Use assert for CLIP() if bounds are not properly ordered (#2298)
[15:24] <grogbot> <lephilousophe> @sev thanks for fixing ps2 build
[15:24] <grogbot> <sev> I was annoyed by it
[15:24] <grogbot> <lephilousophe> I was looking at it to fix it in a different way
[15:24] <grogbot> <sev> like what?
[15:25] <grogbot> <lephilousophe> that just required to do the undef __STRICT_ANSI__ in scummsys.h
[15:25] <grogbot> <lephilousophe> I don't know which one is cleaner
[15:26] <grogbot> <lephilousophe> well... not using hypot is really a good thing
[15:26] <grogbot> <lephilousophe> as it's not C++98
[16:31] <Scummette> [scummvm] sev- closed pull request #2311: DIRECTOR: LINGO: Implement factories (master...director-factory) https://git.io/Jf1ht
[16:31] <Scummette> [scummvm] sev- pushed 26 new commits to master: https://git.io/JfMfg
[16:31] <Scummette> scummvm/master 182402f djsrv: DIRECTOR: LINGO: Create and populate factory objs
[16:31] <Scummette> scummvm/master 041326b djsrv: DIRECTOR: LINGO: Implement factory method calls
[16:31] <Scummette> scummvm/master 95a70de djsrv: DIRECTOR: LINGO: Clean up LC::call
[16:33] --> BeefEats joined #scummvm.
[16:41] <Scummette> [scummvm] sev- pushed 1 new commits to master: https://git.io/JfMf9
[16:41] <Scummette> scummvm/master 7537528 sev-: JANITORIAL: Whitespace fixes
[16:57] --> dreammaster joined #scummvm.
[16:57] #scummvm: mode change '+o dreammaster' by ChanServ!ChanServ@services.
[17:21] <grogbot> <Henke37> hmm, looking at the voyeur code, i think i see two nearly identical loops for playing a RL2 video. should these two loops be refactored into just one?
[17:22] <grogbot> <Henke37> VoyeurEngine::playRL2Video vs RL2Decoder::play. They are pretty much the same with the exception for the frames argument
[17:27] <grogbot> <Henke37> @DreamMaster do you see any reason for these two versions? not counting the frames argument
[17:29] <grogbot> <Henke37> the only other difference i can see is the use of setPalette128, which I suspect is an accident since there doesn't seem to be any particular palette trickery here
[17:43] <dreammaster> A lot of the Voyeur code is based on a straight decompilation of the original executable. It was the first game I worked on that had full debug symbols accidentally included in the release executable
[17:43] <dreammaster> So it was likely a simple matter of not spending a lot of time after I got it working trying to optimize it as much as possible
[17:47] <grogbot> <Henke37> i figured as much.
[17:50] <grogbot> <Henke37> hmm. i see one big difference, the source of the palette. i will need to analyze the code more deeply to see if it is semantically meaningful
[17:52] <dreammaster> Have at it, thanks. I may have moved onto other engines, but if there are improvements to be had, every little bit will help for posterity
[17:52] <grogbot> <Henke37> goodie. a third version. VoyeurEngine::playAVideoDuration
[18:01] <dreammaster> Right now, I'm rediscovering the joys of the weird stuff earlier video modes did. Empiracally that video mode 4, 320x200x4 is actually one of the more sensible ones.. 4 2 bit pixels to a byte. But it does have a weird gotcha that even rows start at b800:0, whilst odd ones start at b800:2000.
[18:01] <dreammaster> I guess I should be thankful it doesn't use ports to switch bits of pixels in and out of memory, like certain other earlier graphic modes
[18:25] <grogbot> <Henke37> goodie. i found the palette trickery.
[18:25] <grogbot> <Henke37> a function called getMouseInfo is obviously involved in running a palette animation
[18:36] <grogbot> <Henke37> hmm, is it just me being unlucky, or does the voyeur end credits fail to run when you chose the quit option?
[18:37] <grogbot> <Henke37> seems like it holds on to the mouse click from clicking "quit" and imedetiatly dismisses the credits crawl.
[18:39] <dreammaster> Really? Let me check. Ironic if that's the case and I never end noticed
[18:44] <grogbot> <Henke37> While at it, think you can fasttrack this tweak? seems a little too tiny to bother with a pr
[18:44] <grogbot> <Henke37> https://cdn.discordapp.com/attachments/581224061091446795/718898620413509637/0001-VOYEUR-Only-skip-missing-video-in-demo-when-doing-th.patch
[18:50] <dreammaster> Sure
[18:51] <Scummette> [scummvm] dreammaster pushed 3 new commits to master: https://git.io/JfMkw
[18:51] <Scummette> scummvm/master 1255854 dreammaster: GLK: COMPREHEND: Implement draw line algorithm, disabled for now
[18:51] <Scummette> scummvm/master dd3b84b dreammaster: VOYEUR: Fix end credits getting skipped on exit
[18:51] <Scummette> scummvm/master 1902474 dreammaster: VOYEUR: Still show end credits when quitting demo
[19:01] <dreammaster> Going AFK for a while, be back later
[19:01] <-- dreammaster left irc:
[19:06] <ScummBot> Port build status changed with 75375280: Failure: master-amigaos4
[19:10] <Scummette> [scummvm] antoniou79 pushed 1 new commits to master: https://git.io/JfMkd
[19:10] <Scummette> scummvm/master f04acf5 antoniou79: BLADERUNNER: Clarify naming of unused Luther flag
[19:40] <ScummBot> Port build status changed with 75375280: Failure: master-ds
[20:05] <-- Begasus left irc: Quit: Ex-Chat
[20:49] --> dreammaster joined #scummvm.
[20:49] #scummvm: mode change '+o dreammaster' by ChanServ!ChanServ@services.
[21:26] <-- ajax16384 left irc: Quit: Leaving
[22:00] <Scummette> [scummvm] sev- closed pull request #2299: New engine - KINGDOM (master...kingdom) https://git.io/Jf6wb
[22:00] <Scummette> [scummvm] sev- pushed 144 new commits to master: https://git.io/JfMmS
[22:04] <Scummette> scummvm/master fa37b76 Strangerke: KINGDOM: Add skeletton engine
[22:04] <Scummette> scummvm/master 15d07a0 Strangerke: KINGDOM: Add some stubs and the main loop
[22:04] <Scummette> scummvm/master f7bdd77 Strangerke: KINGDOM: Add some functions and constants (courtesy of TMM), fix the IFFDecoder for chunks with odd size
[22:04] <Scummette> [scummvm] sev- pushed 3 new commits to master: https://git.io/JfMmF
[22:04] <Scummette> scummvm/master 99386a2 sev-: KINGDOM: Fix warning
[22:04] <Scummette> scummvm/master 353dd6c sev-: JANITORIAL: Remove trailing whitespaces
[22:04] <Scummette> scummvm/master a8401ab sev-: KINGDOM: Added missing override keywords
[22:14] <-- DrMcCoy left irc: Ping timeout: 272 seconds
[22:14] --> DrMcCoy joined #scummvm.
[22:14] #scummvm: mode change '+o DrMcCoy' by ChanServ!ChanServ@services.
[22:14] <dreammaster> Boo yah :)
[22:14] <Lightkey> Kasha?
[22:15] <Strangerke> :)
[22:15] <Scummette> [scummvm] madmoose pushed 4 new commits to master: https://git.io/JfMYf
[22:15] <Scummette> scummvm/master fcccb2b madmoose: KINGDOM: Use _frameStop in MoviePlay
[22:15] <Scummette> scummvm/master a01c28e madmoose: KINGDOM: Fix logic error in getUserInput
[22:15] <Scummette> scummvm/master 2553cc0 madmoose: KINGDOM: Properly initialize inventory slots
[22:16] <grogbot> <madmoose> Boom shanka.
[22:17] <-- heroux left irc: Read error: Connection reset by peer
[22:22] <-- Shine_ left irc: Read error: Connection reset by peer
[22:28] --> heroux joined #scummvm.
[22:34] <Scummette> [scummvm] madmoose pushed 1 new commits to master: https://git.io/JfMYo
[22:34] <Scummette> scummvm/master 96b5abd madmoose: KINGDOM: Fix item selection
[22:38] <-- ny00123 left irc: Quit: Leaving
[22:53] <Scummette> [scummvm] sev- closed pull request #2310: MT32: Update munt emulation code to mt32emu 2.4.0 (master...mt32emu-2.4.0) https://git.io/Jf1Fk
[22:53] <Scummette> [scummvm] sev- pushed 3 new commits to master: https://git.io/JfMOY
[22:53] <Scummette> scummvm/master cc52999 lotharsm: MT32: Update to libmt32emu 2.4.0
[22:53] <Scummette> scummvm/master d831c59 lotharsm: MT32: Fix MSVC warning
[22:53] <Scummette> scummvm/master b0b0e57 lotharsm: MT32: Add missing default switch cases
[23:57] <Scummette> [scummvm] mduggan closed pull request #2303: ULTIMA8: Improve keyboard movement (master...u8_improve_key_movement) https://git.io/Jfial
[23:57] <Scummette> [scummvm] mduggan pushed 6 new commits to master: https://git.io/JfMsZ
[23:57] <Scummette> scummvm/master d64ec47 OMGPizzaGuy: ULTIMA8: Add "run" and "step" keymaps and consolidate movement variables to a flag state variable
[23:57] <Scummette> scummvm/master 197d6c5 OMGPizzaGuy: ULTIMA8: refactor non-combat movement to properly handle jumping and use movement state for mouse as well.
[23:57] <Scummette> scummvm/master 0df027c OMGPizzaGuy: ULTIMA8: Better handling of combat move & run for keyboard
[00:00] --- Sun Jun 7 2020