ScummVM IRC Log - 05 Feb 2020

[Back to Index]

[00:00] <Dark-Star> yeah but it's their IDE, and if they think .editorconfig lacks some important style setting, they could easily add their own
[00:03] <grogbot> <Henke37> they do however have a c++ compiler of their own
[00:04] <grogbot> <Henke37> well, that's a lie. they have several of them
[00:04] <grogbot> <SupSuper> well nothing else will compile win32 😛
[00:11] --> |Cable| joined #scummvm.
[00:20] <-- vliaskov left irc: Remote host closed the connection
[00:24] <-- |Cable| left irc: Ping timeout: 268 seconds
[00:27] --> |Cable| joined #scummvm.
[00:39] <-- ny00123 left irc: Quit: Leaving
[01:36] <-- SylvainTV left irc: Read error: Connection reset by peer
[01:57] <-- Tea left irc: Quit: Quit messages are a thing?
[01:58] --> Tea joined #scummvm.
[01:58] --> dreammaster joined #scummvm.
[01:58] #scummvm: mode change '+o dreammaster' by ChanServ!ChanServ@services.
[02:29] <dreammaster> Visual Studio settings is a bust. I could only export to a .vssettings file, and it doesn't seem like VS supports automatically loading them for projects
[02:37] --> DominusExult joined #scummvm.
[02:37] <-- DominusExult left irc: Changing host
[02:37] --> DominusExult joined #scummvm.
[02:41] <-- Dominus left irc: Ping timeout: 240 seconds
[02:41] Nick change: DominusExult -> Dominus
[03:04] <Scummette> [scummvm] dreammaster closed pull request #2037: ENGINES: Savegame code simplifications (master...saves) https://git.io/Jvs1o
[03:04] <Scummette> [scummvm] dreammaster pushed 11 new commits to master: https://git.io/JvG9R
[03:04] <Scummette> scummvm/master 6c419d7 dreammaster: ENGINES: Adding new save wrappers to better support extended saves
[03:04] <Scummette> scummvm/master 31f4bc7 dreammaster: GRIFFON: Update save code to use new engine save methods
[03:04] <Scummette> scummvm/master 866cc57 dreammaster: ULTIMA: Move methods for showing save/restore dialogs into Engine class
[04:12] <Scummette> [scummvm] dreammaster pushed 2 new commits to master: https://git.io/JvGHr
[04:12] <Scummette> scummvm/master 9f8c45a dreammaster: ENGINES: Provide a default MetaEngine::hasFeature with extended save options on
[04:12] <Scummette> scummvm/master 5b80320 dreammaster: ENGINES: Adding override keyword to hasFeature methods
[05:04] --> travis-ci joined #scummvm.
[05:04] <travis-ci> scummvm/scummvm#11857 (master - 5b80320 : Paul Gilbert): The build has errored.
[05:04] <travis-ci> Change view : https://github.com/scummvm/scummvm/compare/2d0935803014...5b8032052521
[05:04] <travis-ci> Build details : https://travis-ci.org/scummvm/scummvm/builds/646251483
[05:04] travis-ci (travis-ci@ec2-3-93-69-105.compute-1.amazonaws.com) left #scummvm.
[05:10] <Scummette> [scummvm] henke37 opened pull request #2041: PINK: Implement save & load in the menubar (master...pinkSaveLoad) https://git.io/JvGQl
[05:25] <Scummette> [scummvm] henke37 opened pull request #2042: TESTBED: Provide correct engine feature implementation data (master...testbedUnfeatures) https://git.io/JvGQg
[05:54] <-- dreammaster left irc:
[07:01] <-- eriktorbjorn left irc: Quit: Leaving.
[08:12] <-- girafe left irc: Read error: Connection reset by peer
[08:29] Nick change: ldevulder__ -> ldevulder
[08:51] <Scummette> [scummvm] sev- pushed 1 new commits to master: https://git.io/JvGdM
[08:51] <Scummette> scummvm/master 5410b10 sev-: ULTIMA: Fix Amiga build
[08:57] --> waltervn joined #scummvm.
[08:57] #scummvm: mode change '+o waltervn' by ChanServ!ChanServ@services.
[08:57] --> vliaskov joined #scummvm.
[09:21] --> travis-ci joined #scummvm.
[09:21] <travis-ci> scummvm/scummvm#11860 (master - 5410b10 : Eugene Sandulenko): The build passed.
[09:21] <travis-ci> Change view : https://github.com/scummvm/scummvm/compare/5b8032052521...5410b10ba0f1
[09:21] <travis-ci> Build details : https://travis-ci.org/scummvm/scummvm/builds/646312013
[09:21] travis-ci (travis-ci@ec2-3-86-145-154.compute-1.amazonaws.com) left #scummvm.
[09:42] <grogbot> <ZvikaZ> Hi. Do we have a common util to open an archived .exe file? Its info, according to 7-zip: Type: Nsis Method: LZMA:23 Solid: + SubType: NSIS-2
[09:44] <grogbot> <ZvikaZ> (I know how top open .zip files with Common::Archive* zipArchive = Common::makeZipArchive(node); , but it failed on this .exe)
[10:04] <ScummBot> Port build status changed with 5410b10b: Success: master-amigaos4
[10:56] <-- yuv422 left irc: Remote host closed the connection
[10:56] --> yuv422 joined #scummvm.
[10:56] #scummvm: mode change '+o yuv422' by ChanServ!ChanServ@services.
[11:27] --> NULUSIOS joined #scummvm.
[11:32] --> BeefEats joined #scummvm.
[11:37] <-- BeefEats left irc: Ping timeout: 268 seconds
[11:38] --> BeefEats joined #scummvm.
[11:45] NULUSIOS (nls@mail2.termoil.com) left #scummvm.
[12:19] <-- LeChuck left irc: Ping timeout: 265 seconds
[12:20] --> LeChuck joined #scummvm.
[12:40] --> Begasus joined #scummvm.
[12:47] <-- yuv422 left irc: Remote host closed the connection
[12:48] --> yuv422 joined #scummvm.
[12:48] #scummvm: mode change '+o yuv422' by ChanServ!ChanServ@services.
[13:11] <-- _sev left irc: Ping timeout: 240 seconds
[13:22] <-- Lightkey left irc: Ping timeout: 265 seconds
[13:24] <-- Tea left irc: Changing host
[13:24] --> Tea joined #scummvm.
[13:35] --> Lightkey joined #scummvm.
[13:39] --> _sev joined #scummvm.
[13:39] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[13:41] <-- _sev left irc: Client Quit
[13:43] --> _sev joined #scummvm.
[13:43] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[13:49] <Scummette> [scummvm] bgK opened pull request #2043: ENGINES: Display a GUI error message when loading / saving failed (master...engine-save-load-dialog-error-checking) https://git.io/JvGhx
[13:58] <Scummette> [scummvm] sev- pushed 14 new commits to master: https://git.io/JvGjt
[13:58] <Scummette> scummvm/master bfcbdc8 sev-: DIRECTOR: Fixed score header reading
[13:58] <Scummette> scummvm/master ae2ddbe sev-: SCUMM: Added override keywords
[13:58] <Scummette> scummvm/master 2b90d1a sev-: ACCESS: Added override keywords
[14:14] --> ldevulder_ joined #scummvm.
[14:16] <Scummette> [scummvm] sev- pushed 8 new commits to master: https://git.io/JvGjr
[14:16] <Scummette> scummvm/master c7a9fc2 sev-: COMPOSER: Split out detection tables
[14:16] <Scummette> scummvm/master 70d4543 sev-: CRYO: Added override keywords
[14:16] <Scummette> scummvm/master fe19789 sev-: DIRECTOR: Added override keywords
[14:17] <-- ldevulder left irc: Ping timeout: 265 seconds
[14:54] <Scummette> [scummvm] sev- pushed 16 new commits to master: https://git.io/JvZeP
[14:54] <Scummette> scummvm/master 94f4d3c sev-: GNAP: Added override keywords
[14:54] <Scummette> scummvm/master b4fe7e0 sev-: GOB: Added override keywords
[14:54] <Scummette> scummvm/master defdf02 sev-: GRIFFON: Added override keywords
[15:06] <-- VonGuard left irc:
[15:06] --> VonGuard joined #scummvm.
[15:17] <Scummette> [scummvm] sev- pushed 16 new commits to master: https://git.io/JvZvT
[15:17] <Scummette> scummvm/master 3265068 sev-: MOHAWK: Added override keywords
[15:17] <Scummette> scummvm/master 9be24ff sev-: MORTEVIELLE: Added override keywords
[15:17] <Scummette> scummvm/master 0f1bf29 sev-: NEVERHOOD: Added override keywords
[15:38] <grogbot> <Mataniko> @Zvika NSIS is the nullsoft installer, you will probably have to find the offset for the compressed content
[16:24] <grogbot> <Henke37> i think it's open source?
[16:29] <-- _sev left irc: Quit: This computer has gone to sleep
[16:29] --> _sev joined #scummvm.
[16:29] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[16:30] <-- _sev left irc: Client Quit
[16:31] <Scummette> [scummvm] antoniou79 pushed 2 new commits to master: https://git.io/JvZJK
[16:31] <Scummette> scummvm/master af84139 antoniou79: BLADERUNNER: A better approach for the DR01 flame glitch
[16:31] <Scummette> scummvm/master d4c6596 antoniou79: BLADERUNNER: Fixes for McCoy's stamina system and drain
[17:06] --> ldevulder__ joined #scummvm.
[17:09] <-- ldevulder_ left irc: Ping timeout: 265 seconds
[17:13] <-- ScummBot left irc: Quit: buildmaster reconfigured: bot disconnecting
[17:13] --> ScummBot joined #scummvm.
[17:13] --> ny00123 joined #scummvm.
[17:15] <grogbot> <sev> We had something
[17:16] <grogbot> <sev> Not sure that it implements exactly this method. Looking
[17:17] <grogbot> <sev> No, wrong memory. That is for InstallShieod cabinets: https://github.com/scummvm/scummvm/blob/master/common/installshield_cab.h
[17:18] <grogbot> <sev> @ZvikaZ what are you trying to achieve and unpack?
[17:43] <grogbot> <Harsh> While compiling its showing error in visual studio cannot include theoradec.h
[17:43] <grogbot> <Harsh> Can anyone please tell
[17:44] <grogbot> <Harsh> @ZvikaZ
[17:44] <grogbot> <Henke37> do you have libtheora?
[17:44] <grogbot> <Harsh> @Henke37no whats this ?
[17:44] <grogbot> <Henke37> the library that provides the theora feature
[17:45] <grogbot> <Harsh> I downloaded the libarary mentioned in the wiki page. In that folder i do have theoradec.h file
[17:45] <grogbot> <Henke37> it should be part of the dependencies package
[17:46] <grogbot> <Harsh> @Henke37 yes where shouild i paste that file
[17:46] <grogbot> <Henke37> it's more than just one file
[17:46] <grogbot> <Harsh> Yea a folder named theora
[17:46] <grogbot> <Henke37> are you using the create_project program?
[17:47] <grogbot> <Harsh> @Henke37 yes
[17:47] <grogbot> <DreamMaster> The most common error for not finding any of the library include files when compiling ScummVM in Visual Studio is if you didn't correctly set the system environment variable to point to wherever you unpacked the includes.
[17:47] <grogbot> <DreamMaster> It may also require restarting the computer afterwards for the environment variable to take effect, not sure
[17:47] <grogbot> <Henke37> is this a recent setup? there was some recent edits to the create_project system
[17:48] <grogbot> <DreamMaster> No, it's been that way for a while
[17:48] <grogbot> <Harsh> @Henke37yes just did it now
[17:48] <grogbot> <Harsh> @DreamMasterok fine i will restart tje system
[17:49] <grogbot> <Henke37> there is one change that comes to mind actually: removing the flag to add the build events in the batch file
[17:49] <grogbot> <DreamMaster> If that doesn't work, go back to the Environment variables listing, and make sure you set the correct folder
[17:49] <grogbot> <Henke37> i think that one of the build events is supposed to copy dependencies?
[17:49] <grogbot> <Harsh> @Henke37 not sure about this
[17:50] <grogbot> <DreamMaster> I think that's unrelated, since always built fine for me without it.
[17:52] <grogbot> <DreamMaster> Make sure the path you set the SCUMMVM_LIBS environment variable to is the folder you uncompressed the zip to, and not any of the subfolders like "include"
[18:23] --> syke joined #scummvm.
[18:23] #scummvm: mode change '+v syke' by ChanServ!ChanServ@services.
[18:28] <grogbot> <Harsh> @DreamMaster the error isnt resolved . Environment varibles were correct.
[18:33] <grogbot> <ZvikaZ> @Harsh , your error is in theora, right? just disable it, and see what happens. add disable-theora flag to create_project
[18:33] <grogbot> <ZvikaZ> I'm running a minimal compilation with:
[18:34] <grogbot> <ZvikaZ> create_project.exe ..\.. --msvc --disable-all-engines --disable-lua --disable-cloud --disable-tts --disable-bink --disable-ogg --disable-vorbis --disable-tremor --disable-mad --disable-flac --disable-faad --disable-theora --disable-fluidsynth --disable-sdlnet --enable-engine=sci32
[18:34] <grogbot> <ZvikaZ> (replace the sci32 at the end with whatever engine you want to work on)
[18:35] <grogbot> <ZvikaZ> @sev, you asked why I'm interested in .exe packing - never mind. Just checked an idea. It's not that important...
[18:41] <grogbot> <DreamMaster> Otherwise, maybe consider posting a screenshot of your environment list dialog window that shows the variable name and path, as well as a screenshot of Windows Explorer for that folder so that we can see it has the expected contents. It's always possible there's a minor spelling mistake or something
[18:47] <-- vliaskov left irc: Remote host closed the connection
[18:53] <-- TAS_2012v left irc: Ping timeout: 272 seconds
[18:54] --> girafe joined #scummvm.
[19:02] <-- Begasus left irc: Quit: Ex-Chat
[19:11] --> SylvainTV joined #scummvm.
[19:11] #scummvm: mode change '+o SylvainTV' by ChanServ!ChanServ@services.
[19:15] <-- syke left irc: Quit: Leaving.
[19:28] --> cd joined #scummvm.
[19:37] <-- VonGuard left irc: Ping timeout: 260 seconds
[19:43] --> lb_ii joined #scummvm.
[19:45] --> _sev joined #scummvm.
[19:45] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[19:46] <grogbot> <sev> @ZvikaZ OK, I see
[19:47] <grogbot> <sev> @ZvikaZ but if you were considering attempt to run a game directly from the packed game, then it may not work very well
[19:48] <grogbot> <ZvikaZ> No... Something else. It's regarding my PR 2039: https://github.com/scummvm/scummvm/pull/2039
[19:49] <grogbot> <ZvikaZ> The GK2 fan-made-subtitles patch
[19:49] <grogbot> <ZvikaZ> That @sluicebox added support for
[19:49] <grogbot> <ZvikaZ> Now I've added a message explaining how to install it, if the user doesn't have it
[19:50] <grogbot> <ZvikaZ> I asked myself whether its feasible to automatically download and install it (if the user desires).
[19:50] <grogbot> <ZvikaZ> However, the patch comes in a zip file (that I succeeded to open from inside ScummVM), and inside there is that .exe file, containing the real patch.
[19:51] <grogbot> <ZvikaZ> I can open it manually with 7-zip
[19:51] <grogbot> <ZvikaZ> Wondered if I can do it from inside ScummVM
[19:51] <grogbot> <ZvikaZ> Seems that currently not, and it doesn't worth the effort
[19:53] <grogbot> <ZvikaZ> Therefore, currently there is a 'download' button, that just calls g_system->openUrl (if the system supports it). From there - it's up to the user to follow the instructions.
[19:57] Nick change: ldevulder__ -> ldevulder
[19:59] <grogbot> <sev> ah
[20:00] <grogbot> <sev> in this case I would rather contact the authors, ask permission to redistribute and then put it as a plain .zip file to our website
[20:05] <grogbot> <Henke37> on that note, how many free games does scummvm support that aren't available for download on the scummvm website?
[20:06] <grogbot> <DreamMaster> You could count a great number of AGI/SCI fan games in that
[20:06] <grogbot> <DreamMaster> Not to mention GLK, eventually
[20:07] <grogbot> <Henke37> right. lets limit that set a bit. free games that have dedicated code for them in scummvm. usually entire custom game engines.
[20:09] <grogbot> <SupSuper> @ZvikaZ scummvm historically doesn't include fan patches so i don't see why gk2 should be different
[20:09] <-- _sev left irc: Quit: This computer has gone to sleep
[20:10] <grogbot> <DreamMaster> I can't think of any off the top of my head. Normally, supporting a new free game is a big thing, and we want to make them available as easily as possible.
[20:10] <grogbot> <Henke37> supernova?
[20:12] --> _sev joined #scummvm.
[20:12] <-- _sev left irc: Changing host
[20:12] --> _sev joined #scummvm.
[20:12] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[20:13] --> ajax16384 joined #scummvm.
[20:13] #scummvm: mode change '+o ajax16384' by ChanServ!ChanServ@services.
[20:15] <grogbot> <DreamMaster> Heh. We have so many game engines these days I can't even remember all of them anymore
[20:18] <-- _sev left irc: Quit: This computer has gone to sleep
[20:19] --> _sev joined #scummvm.
[20:19] <-- _sev left irc: Changing host
[20:19] --> _sev joined #scummvm.
[20:19] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[20:37] <-- yuv422 left irc: Remote host closed the connection
[20:37] --> yuv422 joined #scummvm.
[20:37] #scummvm: mode change '+o yuv422' by ChanServ!ChanServ@services.
[20:37] <-- yuv422 left irc: Remote host closed the connection
[20:38] --> yuv422 joined #scummvm.
[20:38] #scummvm: mode change '+o yuv422' by ChanServ!ChanServ@services.
[20:41] --> syke joined #scummvm.
[20:41] #scummvm: mode change '+v syke' by ChanServ!ChanServ@services.
[20:42] <grogbot> <Scorp> anyone who uses Ghidra and can answer a question? I do not get how to make pointer to be relative. Means LD HL, 0x9000 (z80 equivalent of mov eax) and that 9000 is a memory pointer, so i want it to be DAT_ram_9000
[20:43] <grogbot> <Scorp> @sluicebox maybe you can help?
[21:08] <grogbot> <Scorp> https://cdn.discordapp.com/attachments/581224061091446795/674723342334296075/c7f0e376-e6ab-4e20-8198-359dc9af0a97.jpeg
[21:09] <grogbot> <Scorp> so how to make LD HL,0x643c on the left to be its right counterpart tile8x8Buffer
[21:10] <grogbot> <Scorp> and how to convert all these '\b' to its left counterpart 8
[21:10] <grogbot> <Henke37> fix the datatype?
[21:10] <grogbot> <Scorp> datatype of what
[21:12] <grogbot> <Scorp> in IDA i know how to do it (it actually works automatically), in Ghidra i have no idea, why it does not change in disassm windows
[21:13] <grogbot> <Henke37> the variables, what else?
[21:16] --> TAS_2012v joined #scummvm.
[21:17] <-- ajax16384 left irc: Quit: Leaving
[21:20] <grogbot> <Scorp> what are you speaking about. disassm?
[21:20] <grogbot> <Scorp> or decompiled
[21:23] <grogbot> <Scorp> anyway, retype in decompiler does not work the way I expect it to work, it creates more same byte variables
[21:25] <grogbot> <Scorp> https://imgur.com/xlDOb8i.png
[21:25] <grogbot> <Scorp> So I "Re-type" cVar5 and it just creates me more and more of local_B_X instead of just changing type.
[21:34] <-- syke left irc: Ping timeout: 260 seconds
[21:37] <grogbot> <Henke37> obviously. if the previous type was bigger than the one you say it is, that means that there is more variables occupying the same space
[21:43] <grogbot> <Scorp> no, it is not the case. it is just ghidra likes to repeat same variable multiple times.
[21:44] <grogbot> <Scorp> so after all 15 or so instances of same type finished they stopped multiplying. they all were exact same size.
[21:44] <grogbot> <Scorp> 1 byte
[21:45] <grogbot> <Scorp> and used for counter, so it should all be same exact variable. but ghidra made me 15 of them.
[21:45] <grogbot> <Scorp> or i had to live with its '\b' and in this case there would be only 1 variable like it should be
[21:46] <grogbot> <Henke37> decompilers are usually good at figuring out sizes of primitive values. it can confidently tell by looking at the instructions used to work with the data
[21:47] <grogbot> <Scorp> really. ld b, 8; dec B; djnz loop
[21:47] <grogbot> <Scorp> that's a char, for sure 🙂
[21:48] <grogbot> <Scorp> (it is not)
[21:49] <grogbot> <Scorp> so far i hate that ghidra does not follow what i change in decompiler window and vice versa.
[21:49] <grogbot> <Henke37> note my use of "usually". of course you can outsmart it.
[21:49] <grogbot> <Scorp> so i change the type in disasm - it does not care and keep same in decompiler
[21:49] <grogbot> <Scorp> in other cases it changes them, i do not get why and how
[21:50] <grogbot> <Scorp> same for labels - I cannot rename it in disassm, but I can in decompiler
[21:50] <grogbot> <Scorp> I suppose there should be some way to do it manually, but I do not get how
[21:51] <grogbot> <Scorp> hope someone will guide me later, will go to nap a bit
[22:17] <Scummette> [scummvm] antoniou79 pushed 2 new commits to master: https://git.io/JvZm6
[22:17] <Scummette> scummvm/master 1b584eb antoniou79: BLADERUNNER: Fix "Type a name" text in KIA save screen
[22:17] <Scummette> scummvm/master 7bf3404 antoniou79: BLADERUNNER: Extend max saved game's name length to 41 chars
[22:43] <-- waltervn left irc: Quit: Leaving
[22:48] <grogbot> <waltervn> I keep hitting similar walls in Ghidra, it seems to rely on the decompiler, and if for some reason you don't want to use that, or maybe the decompiler is pretty useless because the code you're working on was handwritten in assembly, Ghidra seems to fall apart
[22:57] --> VonGuard joined #scummvm.
[22:59] <Scummette> [scummvm] yuv422 opened pull request #2044: Dragons (master...dragons) https://git.io/JvZY4

[23:07] Action: Lightkey prefers the Saturn version.
[23:08] <Lightkey> Actually never heard of Blazing Saddles^WDragons but I'm not a consolero.
[23:11] <-- girafe left irc: Read error: Connection reset by peer
[23:22] <grogbot> <DreamMaster> You will be risking your lives, whilst I will be risking an academy award for best supporting actor
[23:23] <Lightkey> Maybe because I've never heard of the cartoon it's based on either, even though Terry Jones was involved.
[23:29] <grogbot> <DreamMaster> https://www.youtube.com/watch?v=ZZvT2r828QY
[23:29] <Lightkey> yuv422: Oh, it was by Illusions but doesn't use the same engine as the newer games?
[23:30] <grogbot> <DreamMaster> One of the downsides of a separate channel for github-notifications.. I didn't immediately see the pull request. Congrats yuv422
[23:32] <-- ny00123 left irc: Quit: Leaving
[23:37] <Lightkey> One of the downsides of YouTube: "Video unavailable: This video is not available.".
[23:38] <grogbot> <sev> @SupSuper I have no idea where you came with the statement that ScummVM does not accept fan translations
[23:46] <-- lb_ii left irc: Remote host closed the connection
[23:48] --> ldevulder_ joined #scummvm.
[23:52] <-- ldevulder left irc: Ping timeout: 240 seconds
[23:57] <grogbot> <SupSuper> that's not what i said. typically fan patches adding missing/extra content to the original game are kept external, rather than referenced directly in scummvm, like zvikaz is doing
[23:58] <grogbot> <SupSuper> for example i don't see why the "gk2 subtitles patch" should be treated differently from something like the "mi1 voices patch"
[00:00] --- Thu Feb 6 2020