[01:05] yuv422 (~yuv422@180-150-79-85.b4964f.syd.nbn.aussiebb.net) left irc: Remote host closed the connection [01:06] yuv422 (~yuv422@180-150-79-85.b4964f.syd.nbn.aussiebb.net) joined #scummvm. [01:06] #scummvm: mode change '+o yuv422' by ChanServ!ChanServ@services. [01:21] yuv422 (~yuv422@180-150-79-85.b4964f.syd.nbn.aussiebb.net) left irc: Remote host closed the connection [01:22] yuv422 (~yuv422@180-150-79-85.b4964f.syd.nbn.aussiebb.net) joined #scummvm. [01:22] #scummvm: mode change '+o yuv422' by ChanServ!ChanServ@services. [01:22] yuv422 (~yuv422@180-150-79-85.b4964f.syd.nbn.aussiebb.net) left irc: Remote host closed the connection [01:33] SylvainTV (~Sylvain@lfbn-lil-1-513-54.w81-254.abo.wanadoo.fr) left irc: Read error: Connection reset by peer [01:50] DominusExult (~dominus@port-92-196-42-175.dynamic.as20676.net) joined #scummvm. [01:50] DominusExult (~dominus@port-92-196-42-175.dynamic.as20676.net) left irc: Changing host [01:50] DominusExult (~dominus@unaffiliated/dominus) joined #scummvm. [01:54] Dominus (~dominus@unaffiliated/dominus) left irc: Ping timeout: 246 seconds [01:54] Nick change: DominusExult -> Dominus [02:18] scummvm/master a262a38 dreammaster: GLK: COMPREHEND: Parse/use action tables like original games [02:18] [scummvm] mduggan pushed 1 new commits to master: https://git.io/JJkGJ [02:18] scummvm/master 1eb6b86 mduggan: ULTIMA8: Correct my typo that made U8 run too fast. [02:30] [scummvm] dreammaster pushed 1 new commits to master: https://git.io/JJkGC [02:30] scummvm/master 092ce97 dreammaster: GLK: COMPREHEND: Fix loading item graphics for CC disk 2 [02:47] delacroix (~delacroix@2a02:810c:640:e00:21e:2aff:fe47:c90f) left irc: Quit: ZNC - http://znc.in [02:49] delacroix (~delacroix@2a02:810c:640:e00:21e:2aff:fe47:c90f) joined #scummvm. [04:15] [scummvm] dreammaster pushed 1 new commits to master: https://git.io/JJkcn [04:15] scummvm/master 2cca542 dreammaster: GLK: COMPREHEND: Fix restarting CC from disk 2 [05:00] JohnnyonFlame (~quassel@181.223.242.181) left irc: Read error: Connection reset by peer [05:31] Lightkey (~Darklock@p200300f69713559722cf30fffe083718.dip0.t-ipconnect.de) left irc: Ping timeout: 244 seconds [05:42] Begasus (~begasus@ptr-4qba4eaezx7td0yduu2.18120a2.ip6.access.telenet.be) joined #scummvm. [05:43] Lightkey (~Darklock@p200300f69713551822cf30fffe083718.dip0.t-ipconnect.de) joined #scummvm. [08:03] cd (~cd@unaffiliated/cd) left irc: Quit: cd [08:16] ny00123 (~ny00123@5.102.220.10) joined #scummvm. [08:46] ajax16384 (~User@109.60.130.33) joined #scummvm. [08:46] #scummvm: mode change '+o ajax16384' by ChanServ!ChanServ@services. [10:20] Shine_ (~Shine@x4d01e7f0.dyn.telefonica.de) joined #scummvm. [10:38] SylvainTV (~Sylvain@lfbn-lil-1-513-54.w81-254.abo.wanadoo.fr) joined #scummvm. [10:38] #scummvm: mode change '+o SylvainTV' by ChanServ!ChanServ@services. [11:17] JohnnyonFlame (~quassel@181.223.242.181) joined #scummvm. [11:27] Shine_ (~Shine@x4d01e7f0.dyn.telefonica.de) left irc: Read error: Connection reset by peer [11:40] [scummvm] ScummVM-Translations pushed 1 new commits to master: https://git.io/JJkze [11:40] scummvm/master df37f7a goodoldgeorge: I18N: Update translation (Hungarian) [11:47] Shine_ (~Shine@x4d01e7f0.dyn.telefonica.de) joined #scummvm. [12:57] eriktorbjorn (~d91tan@213-65-60-100-no2480.tbcn.telia.com) left irc: Quit: Leaving. [13:48] TMM (hp@fsf/member/pdpc.professional.tmm) left irc: Quit: https://quassel-irc.org - Chat comfortably. Anywhere. [13:48] TMM (hp@fsf/member/pdpc.professional.tmm) joined #scummvm. [13:48] #scummvm: mode change '+o TMM' by ChanServ!ChanServ@services. [14:21] eriktorbjorn (~d91tan@213-65-60-100-no2480.tbcn.telia.com) joined #scummvm. [14:21] #scummvm: mode change '+o eriktorbjorn' by ChanServ!ChanServ@services. [14:22] criezy (~criezy@host86-133-88-184.range86-133.btcentralplus.com) joined #scummvm. [14:22] #scummvm: mode change '+o criezy' by ChanServ!ChanServ@services. [15:28] Stormkeeper (~kvirc@54.200-30-62.static.virginmediabusiness.co.uk) left irc: Ping timeout: 258 seconds [17:06] @Henke couldn't we sidestep this pointer-in-own-buffer problem by swapping out the memcpy call with something that can handle overlap? [17:07] or is there also a problem here where ensureCapacity might move the entire string, hmm [17:10] yep [17:10] ensureCapacity will change the pointer [17:10] right, yeah [17:11] thanks for answering for me, i really don't know the minute semantics here [17:12] I guess it could still be argued that if we can't do this "properly", we should always do that extra copy and remove the check? [17:13] BeefEats (~BeefEats@unaffiliated/beefeats) joined #scummvm. [17:17] we can do it properly, casting to uintptr is the way to go [17:18] that's how it's done in less and the like in STL [17:20] Stormkeeper (~kvirc@54.200-30-62.static.virginmediabusiness.co.uk) joined #scummvm. [17:22] there's no additional magic behind uintptr_t? [17:26] in that case yeah sounds good 😛 [17:58] I still think a case could be make for either a) always doing the extra copy, or b) doing the extra copy if capacity needs to be increased. But OTOH I don't have any big issue with just using the original code. [18:00] _sev (~sev@d158167.upc-d.chello.nl) joined #scummvm. [18:00] _sev (~sev@d158167.upc-d.chello.nl) left irc: Changing host [18:00] _sev (~sev@scummvm/undead/sev) joined #scummvm. [18:00] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services. [18:00] BeefEats (~BeefEats@unaffiliated/beefeats) left irc: Quit: Bye [18:05] or maybe hold onto the old storage until after the copy. Anyway... [18:07] [scummvm] dreammaster pushed 1 new commits to master: https://git.io/JJkMT [18:07] scummvm/master a3526a9 dreammaster: GLK: COMPREHEND: Fix testing object validity [18:09] Shine_ (~Shine@x4d01e7f0.dyn.telefonica.de) left irc: Read error: Connection reset by peer [18:10] Shine_ (~Shine@x4d01e7f0.dyn.telefonica.de) joined #scummvm. [18:44] all the magic lies in how uintptr_t is defined. [18:53] ny00123 (~ny00123@5.102.220.10) left irc: Quit: Leaving [18:54] ny00123 (~ny00123@5.102.220.10) joined #scummvm. [18:55] Begasus (~begasus@ptr-4qba4eaezx7td0yduu2.18120a2.ip6.access.telenet.be) left irc: Quit: Ex-Chat [19:35] yuv422 (~yuv422@180-150-79-85.b4964f.syd.nbn.aussiebb.net) joined #scummvm. [19:35] #scummvm: mode change '+o yuv422' by ChanServ!ChanServ@services. [19:40] yuv422 (~yuv422@180-150-79-85.b4964f.syd.nbn.aussiebb.net) left irc: Ping timeout: 246 seconds [20:10] isn't uintptr_t part of c++ [20:13] yes. which is my PR uses the nonstandard scummvm brand replacement [20:21] cd (~cd@unaffiliated/cd) joined #scummvm. [20:48] speachy (~speachy@209.2.65.77) left irc: Ping timeout: 240 seconds [20:51] TMM (hp@fsf/member/pdpc.professional.tmm) left irc: Remote host closed the connection [20:51] TMM (hp@fsf/member/pdpc.professional.tmm) joined #scummvm. [20:51] #scummvm: mode change '+o TMM' by ChanServ!ChanServ@services. [21:05] Shine_ (~Shine@x4d01e7f0.dyn.telefonica.de) left irc: Read error: Connection reset by peer [21:24] ajax16384 (~User@109.60.130.33) left irc: Quit: Leaving [21:48] speachy (~speachy@209.2.65.77) joined #scummvm. [21:51] ny00123 (~ny00123@5.102.220.10) left irc: Quit: Leaving [21:51] ny00123 (~ny00123@5.102.220.10) joined #scummvm. [22:04] speachy (~speachy@209.2.65.77) left irc: Quit: WeeChat 2.8 [22:09] speachy (~speachy@209.2.65.77) joined #scummvm. [22:28] ny00123 (~ny00123@5.102.220.10) left irc: Quit: Leaving [22:34] [scummvm] dreammaster pushed 1 new commits to master: https://git.io/JJkdL [22:34] scummvm/master 56f1386 dreammaster: GLK: COMPREHEND: Fix loading of extra string files [23:13] ldevulder_ (~ldevulder@176.164.236.207) joined #scummvm. [23:14] ldevulder (~ldevulder@i16-lef01-ix2-212-195-29-230.ft.lns.abo.bbox.fr) left irc: Ping timeout: 246 seconds [23:17] timofonic (~timofonic@unaffiliated/timofonic) joined #scummvm. [00:00] --- Sun Jul 5 2020