ScummVM IRC Log - 04 Jul 2020

[Back to Index]

[01:05] <-- yuv422 left irc: Remote host closed the connection
[01:06] --> yuv422 joined #scummvm.
[01:06] #scummvm: mode change '+o yuv422' by ChanServ!ChanServ@services.
[01:21] <-- yuv422 left irc: Remote host closed the connection
[01:22] --> yuv422 joined #scummvm.
[01:22] #scummvm: mode change '+o yuv422' by ChanServ!ChanServ@services.
[01:22] <-- yuv422 left irc: Remote host closed the connection
[01:33] <-- SylvainTV left irc: Read error: Connection reset by peer
[01:50] --> DominusExult joined #scummvm.
[01:50] <-- DominusExult left irc: Changing host
[01:50] --> DominusExult joined #scummvm.
[01:54] <-- Dominus left irc: Ping timeout: 246 seconds
[01:54] Nick change: DominusExult -> Dominus
[02:18] <Scummette> scummvm/master a262a38 dreammaster: GLK: COMPREHEND: Parse/use action tables like original games
[02:18] <Scummette> [scummvm] mduggan pushed 1 new commits to master: https://git.io/JJkGJ
[02:18] <Scummette> scummvm/master 1eb6b86 mduggan: ULTIMA8: Correct my typo that made U8 run too fast.
[02:30] <Scummette> [scummvm] dreammaster pushed 1 new commits to master: https://git.io/JJkGC
[02:30] <Scummette> scummvm/master 092ce97 dreammaster: GLK: COMPREHEND: Fix loading item graphics for CC disk 2
[02:47] <-- delacroix left irc: Quit: ZNC - http://znc.in
[02:49] --> delacroix joined #scummvm.
[04:15] <Scummette> [scummvm] dreammaster pushed 1 new commits to master: https://git.io/JJkcn
[04:15] <Scummette> scummvm/master 2cca542 dreammaster: GLK: COMPREHEND: Fix restarting CC from disk 2
[05:00] <-- JohnnyonFlame left irc: Read error: Connection reset by peer
[05:31] <-- Lightkey left irc: Ping timeout: 244 seconds
[05:42] --> Begasus joined #scummvm.
[05:43] --> Lightkey joined #scummvm.
[08:03] <-- cd left irc: Quit: cd
[08:16] --> ny00123 joined #scummvm.
[08:46] --> ajax16384 joined #scummvm.
[08:46] #scummvm: mode change '+o ajax16384' by ChanServ!ChanServ@services.
[10:20] --> Shine_ joined #scummvm.
[10:38] --> SylvainTV joined #scummvm.
[10:38] #scummvm: mode change '+o SylvainTV' by ChanServ!ChanServ@services.
[11:17] --> JohnnyonFlame joined #scummvm.
[11:27] <-- Shine_ left irc: Read error: Connection reset by peer
[11:40] <Scummette> [scummvm] ScummVM-Translations pushed 1 new commits to master: https://git.io/JJkze
[11:40] <Scummette> scummvm/master df37f7a goodoldgeorge: I18N: Update translation (Hungarian)
[11:47] --> Shine_ joined #scummvm.
[12:57] <-- eriktorbjorn left irc: Quit: Leaving.
[13:48] <-- TMM left irc: Quit: https://quassel-irc.org - Chat comfortably. Anywhere.
[13:48] --> TMM joined #scummvm.
[13:48] #scummvm: mode change '+o TMM' by ChanServ!ChanServ@services.
[14:21] --> eriktorbjorn joined #scummvm.
[14:21] #scummvm: mode change '+o eriktorbjorn' by ChanServ!ChanServ@services.
[14:22] --> criezy joined #scummvm.
[14:22] #scummvm: mode change '+o criezy' by ChanServ!ChanServ@services.
[15:28] <-- Stormkeeper left irc: Ping timeout: 258 seconds
[17:06] <grogbot> <waltervn> @Henke couldn't we sidestep this pointer-in-own-buffer problem by swapping out the memcpy call with something that can handle overlap?
[17:07] <grogbot> <waltervn> or is there also a problem here where ensureCapacity might move the entire string, hmm
[17:10] <grogbot> <lephilousophe> yep
[17:10] <grogbot> <lephilousophe> ensureCapacity will change the pointer
[17:10] <grogbot> <waltervn> right, yeah
[17:11] <grogbot> <Henke37> thanks for answering for me, i really don't know the minute semantics here
[17:12] <grogbot> <waltervn> I guess it could still be argued that if we can't do this "properly", we should always do that extra copy and remove the check?
[17:13] --> BeefEats joined #scummvm.
[17:17] <grogbot> <lephilousophe> we can do it properly, casting to uintptr is the way to go
[17:18] <grogbot> <lephilousophe> that's how it's done in less<T*> and the like in STL
[17:20] --> Stormkeeper joined #scummvm.
[17:22] <grogbot> <waltervn> there's no additional magic behind uintptr_t?
[17:26] <grogbot> <waltervn> in that case yeah sounds good 😛
[17:58] <grogbot> <waltervn> I still think a case could be make for either a) always doing the extra copy, or b) doing the extra copy if capacity needs to be increased. But OTOH I don't have any big issue with just using the original code.
[18:00] --> _sev joined #scummvm.
[18:00] <-- _sev left irc: Changing host
[18:00] --> _sev joined #scummvm.
[18:00] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[18:00] <-- BeefEats left irc: Quit: Bye
[18:05] <grogbot> <waltervn> or maybe hold onto the old storage until after the copy. Anyway...
[18:07] <Scummette> [scummvm] dreammaster pushed 1 new commits to master: https://git.io/JJkMT
[18:07] <Scummette> scummvm/master a3526a9 dreammaster: GLK: COMPREHEND: Fix testing object validity
[18:09] <-- Shine_ left irc: Read error: Connection reset by peer
[18:10] --> Shine_ joined #scummvm.
[18:44] <grogbot> <Henke37> all the magic lies in how uintptr_t is defined.
[18:53] <-- ny00123 left irc: Quit: Leaving
[18:54] --> ny00123 joined #scummvm.
[18:55] <-- Begasus left irc: Quit: Ex-Chat
[19:35] --> yuv422 joined #scummvm.
[19:35] #scummvm: mode change '+o yuv422' by ChanServ!ChanServ@services.
[19:40] <-- yuv422 left irc: Ping timeout: 246 seconds
[20:10] <grogbot> <SupSuper> isn't uintptr_t part of c++
[20:13] <grogbot> <Henke37> yes. which is my PR uses the nonstandard scummvm brand replacement
[20:21] --> cd joined #scummvm.
[20:48] <-- speachy left irc: Ping timeout: 240 seconds
[20:51] <-- TMM left irc: Remote host closed the connection
[20:51] --> TMM joined #scummvm.
[20:51] #scummvm: mode change '+o TMM' by ChanServ!ChanServ@services.
[21:05] <-- Shine_ left irc: Read error: Connection reset by peer
[21:24] <-- ajax16384 left irc: Quit: Leaving
[21:48] --> speachy joined #scummvm.
[21:51] <-- ny00123 left irc: Quit: Leaving
[21:51] --> ny00123 joined #scummvm.
[22:04] <-- speachy left irc: Quit: WeeChat 2.8
[22:09] --> speachy joined #scummvm.
[22:28] <-- ny00123 left irc: Quit: Leaving
[22:34] <Scummette> [scummvm] dreammaster pushed 1 new commits to master: https://git.io/JJkdL
[22:34] <Scummette> scummvm/master 56f1386 dreammaster: GLK: COMPREHEND: Fix loading of extra string files
[23:13] --> ldevulder_ joined #scummvm.
[23:14] <-- ldevulder left irc: Ping timeout: 246 seconds
[23:17] --> timofonic joined #scummvm.
[00:00] --- Sun Jul 5 2020