ScummVM IRC Log - 03 Feb 2020

[Back to Index]

[00:38] <-- ny00123 left irc: Quit: Leaving
[02:31] <-- dreammaster left irc:
[02:37] --> DominusExult joined #scummvm.
[02:37] <-- DominusExult left irc: Changing host
[02:37] --> DominusExult joined #scummvm.
[02:41] <-- Dominus left irc: Ping timeout: 268 seconds
[02:41] Nick change: DominusExult -> Dominus
[02:55] --> dreammaster joined #scummvm.
[02:55] #scummvm: mode change '+o dreammaster' by ChanServ!ChanServ@services.
[03:51] <-- JohnnyonFlame left irc: Read error: Connection reset by peer
[04:00] <-- Cheeseness left irc: Quit: Leaving.
[04:00] --> Cheeseness joined #scummvm.
[04:27] <-- _sev_ left irc: Ping timeout: 240 seconds
[04:30] <-- Scummette left irc: Ping timeout: 272 seconds
[04:31] --> Scummette joined #scummvm.
[05:09] --> syke joined #scummvm.
[05:09] #scummvm: mode change '+v syke' by ChanServ!ChanServ@services.
[05:18] <Scummette> [scummvm] dreammaster opened pull request #2037: ENGINES: Savegame code simplifications (master...saves) https://git.io/Jvs1o
[05:32] <-- dreammaster left irc:
[07:07] <Scummette> [scummvm] bluegr closed pull request #2036: SCI: fix segfault upon detection of pirated game, without fallback (master...segfault) https://git.io/Jvsam
[07:07] <Scummette> [scummvm] bluegr pushed 1 new commits to master: https://git.io/JvsDW
[07:07] <Scummette> scummvm/master 2f9f488 ZvikaZ: SCI: fix segfault upon detection of pirated game, without fallback
[07:09] <Scummette> [scummvm] bluegr closed pull request #2034: ENGINES: add GUI warning when encountering a pirated game (master...pirated_message) https://git.io/Jvssx
[07:09] <Scummette> [scummvm] bluegr reopened pull request #2034: ENGINES: add GUI warning when encountering a pirated game (master...pirated_message) https://git.io/Jvssx
[07:09] <Scummette> [scummvm] bluegr closed pull request #2034: ENGINES: add GUI warning when encountering a pirated game (master...pirated_message) https://git.io/Jvssx
[07:09] <Scummette> [scummvm] bluegr pushed 1 new commits to master: https://git.io/JvsDB
[07:09] <Scummette> scummvm/master de3011f ZvikaZ: ENGINES: Add GUI warning when encountering a pirated game
[07:15] --> ldevulder_ joined #scummvm.
[07:19] <-- ldevulder__ left irc: Ping timeout: 265 seconds
[07:22] --> _sev joined #scummvm.
[07:22] <-- _sev left irc: Changing host
[07:22] --> _sev joined #scummvm.
[07:22] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[07:25] <Scummette> [scummvm] ZvikaZ closed pull request #2033: CONFIGURE: fixed documentation for '--with-sdl-prefix' and indent subengines (master...master) https://git.io/JvsYD
[07:34] <Scummette> [scummvm] bgK pushed 1 new commits to master: https://git.io/JvsDS
[07:34] <Scummette> scummvm/master c3e152b bgK: ENGINES: Mark the pirated game message as translatable
[07:53] Nick change: ldevulder_ -> ldevulder
[07:58] <grogbot> <antoniou79> Good morning!
[07:59] <grogbot> <antoniou79> I have a question about the windows release builds
[08:00] <-- _sev left irc: Quit: This computer has gone to sleep
[08:00] <grogbot> <antoniou79> It seems that the builds were configured with "--enable-text-console" which disables the on-screen debugger console and forces switch of control to the background command console
[08:02] <grogbot> <antoniou79> This can cause issues in some cases, eg. in the current GOG release with Blade Runner, they have disabled the background window so pressing Ctrl+D in-game results in what is seemingly a "freeze" and you have to kill the game to get out of it
[08:02] <grogbot> <antoniou79> So, is there a reason that we choose to have text console enabled?
[08:03] <grogbot> <antoniou79> And if so, can it be reversed by some ScummVM GUI option or does it require a re-build of the scummvm executable?
[08:03] <grogbot> <antoniou79> There is also a question about this in the forums today: https://forums.scummvm.org/viewtopic.php?f=2&p=88289#p88289
[08:05] <-- SylvainTV left irc: Read error: Connection reset by peer
[08:07] <-- syke left irc: Quit: Leaving.
[08:10] --> _sev joined #scummvm.
[08:10] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[08:32] <-- girafe2 left irc: Read error: Connection reset by peer
[08:37] <grogbot> <rootfather> That was clearly an oversight on my side.
[08:37] <grogbot> <rootfather> Needs rebuild
[09:09] --> vliaskov joined #scummvm.
[09:36] <grogbot> <ZvikaZ> Hi. I haven't touched C++ for maybe 25 years (and haven't missed it 😁 ). Now refreshing it, with Bjarne Stroustrup's "A Tour of C++ (2nd Edition)". Saw the following construct: int v[] = {0,1,2,3,4,5,6,7,8,9}; for (auto x : v) // for each x in v cout << x << '\n'; Is anyone really using such for loops? Haven't saw it in quick grepping at our code base
[09:49] <Scummette> [scummvm] sev- pushed 3 new commits to master: https://git.io/JvsHB
[09:49] <Scummette> scummvm/master 5ebf4ea sev-: ULTIMA: More override keywords
[09:49] <Scummette> scummvm/master 7eb783b sev-: ULTIMA: Further work on overrides marking
[09:49] <Scummette> scummvm/master 1d81fad sev-: ULTIMA: Final touches on override handing
[10:06] <ScummBot> Port build status changed with 1d81fadc: Failure: master-amigaos4
[10:25] <-- ced117 left irc: Ping timeout: 265 seconds
[10:43] <grogbot> <waltervn> @ZvikaZ that's a C++11 feature and we're not using C++11 at this point. Maybe sometime in the future
[11:03] <Scummette> [scummvm] ZvikaZ opened pull request #2038: CONFIGURE: fix documentation for '--with-sdl-prefix' and indent subengines (master...configure) https://git.io/Jvs75
[11:16] --> waltervn joined #scummvm.
[11:16] #scummvm: mode change '+o waltervn' by ChanServ!ChanServ@services.
[11:17] <Scummette> [scummvm] sev- pushed 1 new commits to master: https://git.io/Jvs5c
[11:17] <Scummette> scummvm/master 105c104 sev-: ULTIMA: Amiga compilation fix
[11:25] <Scummette> [scummvm] sev- pushed 1 new commits to master: https://git.io/Jvs5V
[11:25] <Scummette> scummvm/master 399c5d6 sev-: ULTIMA: Another attempt to fix Amiga compilation
[11:30] <grogbot> <ZvikaZ> @waltervn nullptr is also a C+11 feature (https://en.cppreference.com/w/cpp/keyword/nullptr) and it's used many times in the code. Or is it defined manually somewhere?
[11:30] <grogbot> <waltervn> yes, it's defined somewhere for non-C++11 compilation
[11:32] <grogbot> <Henke37> how many platforms doesn't support C++11?
[11:32] <grogbot> <Henke37> it's almost been a decade. if they can't keep up it is clearly not maintained and should be dropped
[11:34] <grogbot> <waltervn> that's a discussion that could be had of course
[11:37] <grogbot> <waltervn> if we do switch at some point, I think we should go full-blown STL etc, no point picking some mid-way point I think
[12:04] --> Begasus joined #scummvm.
[12:27] --> ced117 joined #scummvm.
[13:26] <-- Lightkey left irc: Ping timeout: 265 seconds
[13:38] --> Lightkey joined #scummvm.
[14:16] <Scummette> [scummvm] ScummVM-Translations pushed 1 new commits to master: https://git.io/JvsAd
[14:16] <Scummette> scummvm/master 851b19e antoniou79: I18N: Update translation (Greek)
[15:00] <grogbot> <ZvikaZ> I think that if a platform isn't supported by its original vendor, and therefore has only an old toolset, it doesn't mean that its users aren't using it anymore. Maybe ScummVm is a good proof for that 😉
[15:01] <grogbot> <ZvikaZ> The question is if there are really platform that don't support certain feature (such as C++1) And if these platforms have any users...
[15:06] <grogbot> <waltervn> this reminds me of this video I watched recently talking about ScummVM on the N810: https://youtu.be/46I0_ySqy-U?t=403
[15:16] <Scummette> [scummvm] ScummVM-Translations pushed 1 new commits to master: https://git.io/Jvsp8
[15:16] <Scummette> scummvm/master 768ef3c sev-: PRINCE: I18N: Update translation (English)
[15:47] --> timofonic joined #scummvm.
[16:00] --> girafe joined #scummvm.
[16:20] --> ny00123 joined #scummvm.
[16:37] <-- yuv422 left irc: Ping timeout: 265 seconds
[16:55] --> ldevulder_ joined #scummvm.
[16:58] <-- ldevulder left irc: Ping timeout: 265 seconds
[17:02] --> yuv422 joined #scummvm.
[17:02] #scummvm: mode change '+o yuv422' by ChanServ!ChanServ@services.
[17:05] <Scummette> [scummvm] ZvikaZ opened pull request #2039: GUI: add optional 'alignment' parameter to 'MessageDialog', and SCI: GK2: if subtitles patch is missing, explain how to install it (master...gk2sub) https://git.io/JvGvU
[17:12] <-- vliaskov left irc: Quit: Leaving
[17:26] --> ajax16384 joined #scummvm.
[17:26] #scummvm: mode change '+o ajax16384' by ChanServ!ChanServ@services.
[18:20] <Dark-Star> someone could invest some energy in building a transpiler for C++11 to something older. It has been done for C++17 to C++11 before so it should be perfectly doable
[18:22] <-- Begasus left irc: Quit: Ex-Chat
[18:24] --> BeefEats joined #scummvm.
[19:02] <grogbot> <DreamMaster> Regarding C++11, I know the AmigaOS compiler on Buildbot has had trouble with nullptr in header files previously; since some of them weren't indirectly pulling in the file where nullptr is defined for non-11 compilers
[19:05] <grogbot> <Strangerke> waltervn: Did you try to count how many times he said 'Awesome' during the 5 minutes he talked about ScummVM? 🙂
[19:08] <grogbot> <Zadroter> Scummvm using c++ 11?
[19:15] <grogbot> <DreamMaster> We're not currently depending on any C++11 features, no. But we do some have stubs to simulate a few things from C++11 for non-11 compilers, such as the nullptr define
[19:15] <grogbot> <DreamMaster> Which I personally like, since it makes it much clearer that a type is a pointer when you assign nullptr to it rather than just 0
[19:16] <grogbot> <waltervn> I do think it's good that we evaluate once in a while, whether it still makes sense to stick to the current policy
[19:17] <grogbot> <DreamMaster> Agreed; as long as everything we target supports it.
[19:17] <grogbot> <waltervn> our C-with-classes approach might scare away potential contributors, so we need to weigh that against possibly losing a port or two
[19:18] <grogbot> <waltervn> I'm not saying we need to change things right now, but I do think it's good to look at this from time to time, does it still make sense, etc
[19:19] <grogbot> <Strangerke> I think C++17 is way more frightening than our old C++
[19:20] <grogbot> <Strangerke> but yeah, if a transpiler exists, why not Cpp11
[19:28] --> SylvainTV joined #scummvm.
[19:28] #scummvm: mode change '+o SylvainTV' by ChanServ!ChanServ@services.
[19:31] <grogbot> <Zadroter> Oh okay thanks for answer, DreamMaster
[19:39] <grogbot> <SupSuper> visual studio is pretty much c++11 by default now 😛 no going back
[20:43] <-- timofonic left irc: Ping timeout: 260 seconds
[20:44] --> timofonic joined #scummvm.
[20:58] --> cd joined #scummvm.
[21:02] <-- yuv422 left irc: Remote host closed the connection
[21:03] --> yuv422 joined #scummvm.
[21:03] #scummvm: mode change '+o yuv422' by ChanServ!ChanServ@services.
[21:06] <-- yuv422 left irc: Remote host closed the connection
[21:06] --> yuv422 joined #scummvm.
[21:06] #scummvm: mode change '+o yuv422' by ChanServ!ChanServ@services.
[21:07] <grogbot> <Strangerke> Depends which version. I use vs2008
[21:08] <-- ajax16384 left irc: Read error: Connection reset by peer
[21:09] <grogbot> <Henke37> which is more than a decade old.
[21:09] <grogbot> <Henke37> time to move on old man.
[21:14] <Strangerke> no
[21:14] <Strangerke> it's still supporterd, no need to move :P
[21:14] <Strangerke> (supported by ScummVM, obviously not by Microsoft)
[21:14] <grogbot> <SupSuper> i'm not sure it can even be called "standard c++" back then 😛
[21:15] <Strangerke> My laptop wouldn't survive if I tried to move to a more recent version anyway
[21:15] <Strangerke> SupSuper: is it really standard nowadays?
[21:15] <grogbot> <Henke37> sounds like you need a new laptop too
[21:16] <Strangerke> Henle37: yes, it's more or less 10 yo now
[21:16] <Strangerke> but I don't manage to find large laptops for sale
[21:18] <Strangerke> so I wait until they made >20" laptops again
[21:34] <grogbot> <Henke37> who is "they"?
[21:36] <grogbot> <SupSuper> manufacturers?
[21:36] <Strangerke> yes. it's almost impossible to find anything larger than 17" nowadays
[21:37] <grogbot> <SupSuper> and vc++ is 99% standard nowadays, it's all gated by compatibility flags if you need win32
[21:41] <-- waltervn left irc: Quit: Leaving
[21:41] <girafe> does it work with visual studio community ?
[21:41] <grogbot> <SupSuper> yes
[21:43] <grogbot> <Henke37> it's what i use and it works fine for me.
[21:53] <-- SylvainTV left irc: Ping timeout: 265 seconds
[21:53] --> SylvainTV joined #scummvm.
[21:53] #scummvm: mode change '+o SylvainTV' by ChanServ!ChanServ@services.
[22:01] <grogbot> <DreamMaster> We even provide precompiled libraries for Visual Studio, so it's easier for newbie Windows developers to get ScummVM compiling and running
[22:03] <grogbot> <sev> @waltervn, recently it came to my attention, that we accidentally brought more c++11-specific code to the master branch
[22:04] <grogbot> <sev> so far, buildbot was happy, but I wonder about those platforms which are not on the buildbot
[22:04] <grogbot> <sev> @waltervn this: https://github.com/scummvm/scummvm/blob/master/engines/sci/resource_patcher.cpp#L42
[22:06] <grogbot> <SupSuper> doesn't gcc let you explicitly set the c++ version? or is it just using the platform default
[22:06] <Scummette> [scummvm] tsoliman pushed 1 new commits to master: https://git.io/JvGIO
[22:06] <Scummette> scummvm/master 300f0d8 tsoliman: ULTIMA: Set ADGF flags
[22:15] <Scummette> [scummvm] sev- pushed 1 new commits to master: https://git.io/JvGIK
[22:15] <Scummette> scummvm/master 6ccbe9f sev-: DISTS: Add Windows 2.1.1a to Sparkle appcast
[22:18] <grogbot> <sev> we have this option in the configure
[22:19] <grogbot> <md5> yeah, I brought this code in
[22:20] <grogbot> <md5> it build happily, so I missed that it relies on C++ 11 features
[22:21] <grogbot> <md5> it built *
[22:22] <grogbot> <md5> and there's this pull request, which is relevant to this discussion: https://github.com/scummvm/scummvm/pull/1294
[22:26] <-- BeefEats left irc: Quit: Bye
[22:32] <Scummette> [scummvm] sev- pushed 1 new commits to master: https://git.io/JvGLO
[22:32] <Scummette> scummvm/master 2fca080 sev-: DISTS: Making WinSparkle happier
[22:56] --> travis-ci joined #scummvm.
[22:56] <travis-ci> scummvm/scummvm#11840 (master - 300f0d8 : Tarek Soliman): The build has errored.
[22:56] <travis-ci> Change view : https://github.com/scummvm/scummvm/compare/768ef3c35ac8...300f0d870892
[22:56] <travis-ci> Build details : https://travis-ci.org/scummvm/scummvm/builds/645684346
[22:56] travis-ci (travis-ci@ec2-54-147-230-102.compute-1.amazonaws.com) left #scummvm.
[23:11] <Scummette> [scummvm] lolbot-iichan opened pull request #2040: WINTERMUTE: Fix handling of EVENT_WHEELDOWN (master...wme_mousewheel) https://git.io/JvGtC
[00:00] --- Tue Feb 4 2020