[Back to Index]

[00:02] <grogbot> <Aotrs Commander> (Did last try, running ScummVM as an administrator. Didn't work BUT it did trigger the compatibility troubleshooter, not that did any good.)
[00:05] <Scummette> [scummvm] ccawley2011 opened pull request #2589: IPHONE: Use kFeatureFilteringMode to toggle filtering (master...iphone-filtering) https://git.io/JT7jk
[00:06] <-- ny00123 left irc: Quit: Leaving
[00:06] <-- ccawley2011 left irc: Quit: Leaving
[01:55] <-- speachy left irc: Ping timeout: 260 seconds
[01:58] <-- SylvainTV left irc: Read error: Connection reset by peer
[02:01] <-- Lightkey left irc: Ping timeout: 268 seconds
[02:14] --> Lightkey joined #scummvm.
[02:17] --> speachy joined #scummvm.
[02:44] <-- criezy left irc: Quit: criezy
[02:52] --> DominusExult joined #scummvm.
[02:52] <-- DominusExult left irc: Changing host
[02:52] --> DominusExult joined #scummvm.
[02:57] <-- Dominus left irc: Ping timeout: 268 seconds
[02:57] Nick change: DominusExult -> Dominus
[03:05] <ScummBot> Port build status changed with 3fc822e5: Success: master-debian-x86-nullbackend. Nice work, all ports built fine now
[03:20] <grogbot> <Gantonio865> Nice work, now i can sleep in peace once again
[04:25] <-- cd left irc: Quit: cd
[04:39] <Scummette> [scummvm] cadihowley opened pull request #2590: DOCS: Updates GSOD documentation portal project (master...doc-portal-2) https://git.io/JT5sv
[04:50] --> Endy joined #scummvm.
[04:50] #scummvm: mode change '+o Endy' by ChanServ!ChanServ@services.
[06:09] <-- TMM left irc: Quit: https://quassel-irc.org - Chat comfortably. Anywhere.
[06:09] --> TMM joined #scummvm.
[06:09] #scummvm: mode change '+o TMM' by ChanServ!ChanServ@services.
[06:23] --> Mia joined #scummvm.
[06:23] <-- Mia left irc: Changing host
[06:23] --> Mia joined #scummvm.
[06:25] <-- Axy left irc: Ping timeout: 240 seconds
[06:49] <clort> scroll
[07:16] <ScummBot> Port build status changed with 27abcdc4: Failure: master-osx_intel
[07:18] <Scummette> [scummvm] mduggan pushed 5 new commits to master: https://git.io/JT54H
[07:18] <Scummette> scummvm/master 98de738 mduggan: ULTIMA8: Be more robust to empty vpaths
[07:18] <Scummette> scummvm/master 5048fcc mduggan: ULTIMA8: Fix crusader weapon overlays
[07:18] <Scummette> scummvm/master ef725b0 mduggan: ULTIMA8: Fix potential oob access
[07:25] <Scummette> [scummvm] mduggan pushed 1 new commits to master: https://git.io/JT5BW
[07:25] <Scummette> scummvm/master baf9124 mduggan: ULTIMA8: Terminate attack process if target is null
[07:30] --> ldevulder joined #scummvm.
[09:01] <ScummBot> Port build status changed with 283f9672: Success: master-osx_intel. Nice work, all ports built fine now
[09:33] --> vliaskov joined #scummvm.
[09:36] Nick change: Swant -> IKEA
[09:42] Nick change: IKEA -> Swant
[10:17] <Scummette> [scummvm] Mataniko closed pull request #2590: DOCS: Updates GSOD documentation portal project (master...doc-portal-2) https://git.io/JT5sv
[10:17] <Scummette> [scummvm] Mataniko pushed 12 new commits to master: https://git.io/JT5i9
[11:26] <-- palasso left irc: Ping timeout: 240 seconds
[11:28] --> palasso joined #scummvm.
[11:29] <-- palasso left irc: Client Quit
[11:39] --> cd joined #scummvm.
[11:44] --> palasso joined #scummvm.
[11:45] --> Shine_ joined #scummvm.
[12:17] --> ajax16384 joined #scummvm.
[12:17] #scummvm: mode change '+o ajax16384' by ChanServ!ChanServ@services.
[12:25] <-- tsoliman left irc: Quit: I've been banished!
[12:25] --> tsoliman joined #scummvm.
[12:25] #scummvm: mode change '+o tsoliman' by ChanServ!ChanServ@services.
[12:27] --> broosky joined #scummvm.
[12:27] <-- borosky left irc: Read error: Connection reset by peer
[12:37] <grogbot> <GeekOB> Good morning everyone, Myst 3 succesfully tested and running on 2.3.0git for Raspberry Pi 4
[13:13] <grogbot> <aquadran> can you check saves screenshot in monkey4?
[13:15] <grogbot> <GeekOB> Take a screenshot of the saves screen?
[13:16] <grogbot> <aquadran> no, I mean save has screen shots from the game. I wanted to know if it's working or it's black image
[13:16] <grogbot> <GeekOB> Hang on
[13:17] <grogbot> <aquadran> there is a report for Switch, but this might be opengl driver issue
[13:18] <grogbot> <GeekOB> Off to work, I'll check in a couple of hours and get back to you @aquadran
[13:18] <grogbot> <aquadran> thx
[13:30] --> typedfern_ joined #scummvm.
[13:34] <-- typedfern__ left irc: Ping timeout: 268 seconds
[13:44] <grogbot> <GeekOB> No problem, I'll also open the ticket for the background glitch
[14:05] <-- ST left irc: Quit: Leaving.
[14:49] <Scummette> scummvm/master 6f87977 cadihowley: DOCS: adds second draft - Advanced Options pages
[14:49] <Scummette> scummvm/master b68c04b cadihowley: DOCS: adds first draft Games section pages
[14:49] <Scummette> scummvm/master 3a79ee2 cadihowley: DOCS: changes Getting started section
[14:49] <Scummette> [scummvm] ccawley2011 opened pull request #2591: GUI: Add a tab for backend-specific options (master...backend-options) https://git.io/JTdmU
[15:09] <-- palasso left irc: Ping timeout: 268 seconds
[15:09] --> palasso joined #scummvm.
[15:37] --> ccawley2011 joined #scummvm.
[15:37] #scummvm: mode change '+o ccawley2011' by ChanServ!ChanServ@services.
[16:05] <-- Mia left irc: Read error: Connection reset by peer
[16:24] <-- phyber left irc: Quit: .
[16:46] --> phyber joined #scummvm.
[16:52] --> ny00123 joined #scummvm.
[17:00] <Scummette> [scummvm] phcoder opened pull request #2592: SLUDGE: Remove UTF8 code (master...sludgeutf) https://git.io/JTdRk
[17:06] <grogbot> <GeekOB> hi @aquadran, I can confirm I see black image when trying to load a saved game
[17:27] <grogbot> <usineur> @aquadran I never said it was a Switch problem, I have the same problem on linux
[17:30] <grogbot> <aquadran> @usineur you wrote it's gles2 only
[17:31] <grogbot> <aquadran> and change is for gles2 only
[17:32] <grogbot> <usineur> yes, but Switch port is not the only one that use gles2
[17:32] <grogbot> <usineur> on a linux build with --force-opengl-game-es2 there is the same problem
[17:33] <grogbot> <aquadran> ok
[17:33] <grogbot> <GeekOB> do you want me to try compiling with different settings @aquadran ?
[17:33] <grogbot> <aquadran> nope, thx
[17:34] <grogbot> <aquadran> it looks like something wrong with implementation
[17:35] <grogbot> <usineur> also you mentioned that my changes don't use "_storedDisplay" but it does
[17:35] <grogbot> <usineur> glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, _storedDisplay, 0);
[17:36] <grogbot> <aquadran> ok, must be blind I didn't saw it
[17:37] --> criezy joined #scummvm.
[17:37] #scummvm: mode change '+o criezy' by ChanServ!ChanServ@services.
[17:37] <grogbot> <aquadran> weird, I saw different code
[17:39] <grogbot> <aquadran> ok, what I see now it's ok
[17:42] <Scummette> [scummvm] aquadran closed pull request #2587: EMI: Fix screenshot when saving on ES2 (master...screenshot_es2) https://git.io/JT7QT
[17:42] <Scummette> [scummvm] aquadran pushed 1 new commits to master: https://git.io/JTduB
[17:42] <Scummette> scummvm/master 782bfa8 usineur: EMI: Fix screenshot when saving on ES2 (#2587)
[17:43] --> Begasus joined #scummvm.
[17:53] <grogbot> <GeekOB> Is it possible that the black save thumbnail is related to the black background in TLJ?
[17:54] <grogbot> <usineur> No, it's only related to grim engine
[18:01] <grogbot> <GeekOB> is that what your commit #2587 fixes @usineur?
[18:02] <grogbot> <usineur> yes, thumbnails are fixed now for EMI
[18:03] <grogbot> <GeekOB> I'll build from source again and test for the Pi4
[18:06] <grogbot> <usineur> load game -> save game -> load game, and the thumbnail will be visible
[18:07] <grogbot> <GeekOB> will the existing saves be compatible with the change?
[18:07] <grogbot> <usineur> yes
[18:08] <grogbot> <GeekOB> thanks, compiling now, this... will take a while 🙂
[18:08] <grogbot> <GeekOB> (I build on the Pi)
[18:09] <Scummette> [scummvm] AndywinXp opened pull request #2593: SCUMM: COMI: Fix iMUSE Digital #4635/#10473 bugs (master...master) https://git.io/JTdgp
[18:53] <-- Begasus left irc: Quit: Ex-Chat
[18:59] <grogbot> <GeekOB> saved games screenshots in Monkey4 fixed on Raspberry Pi 4
[19:00] <grogbot> <GeekOB> unfortunately, TLJ seems to be broken now 😱 😭
[19:05] <Scummette> [scummvm] criezy pushed 1 new commits to master: https://git.io/JTdrz
[19:05] <Scummette> scummvm/master aa8ff8b criezy: BUILD: Fix missing SDL in link for macOS bundle target
[19:32] <grogbot> <GeekOB> segmentation fault when executing TLJ
[19:32] <grogbot> <GeekOB> weird
[19:36] <grogbot> <GeekOB> do you know if you made any changes that could be causing this @aquadran ?
[19:48] <grogbot> <SupSuper> can confirm TLJ seems to have broken since yesterday, maybe that was the issue @Aotrs Commander was having?
[19:48] <grogbot> <GeekOB> on pc as well?
[19:48] <grogbot> <SupSuper> yup, seems to be general issue
[19:52] <grogbot> <GeekOB> ok, I should stop banging my head against the desk then...
[19:55] <grogbot> <SupSuper> i'll do a quick bisect
[20:04] <grogbot> <Aotrs Commander> Haha, it is just like my luck to pick the exact time to try to play just when the game breaks...! I'll keep an eye open for as/when you fix it, ladies and/or gentleman (as if nothing else it means there's one Gog version guinea-pig to test it on!)
[20:08] <grogbot> <SupSuper> that's the danger of daily builds, but we'll get to the bottom of it
[20:14] <grogbot> <GeekOB> thanks @SupSuper
[20:19] <grogbot> <SupSuper> git says it was... this? oh this is gonna be fun to debug https://github.com/scummvm/scummvm/commit/29cfa7bb0f2c1c76a9ef285b8e5799a7ec91020b
[20:24] <grogbot> <aquadran> @phcoder your commit 😛
[20:27] <grogbot> <phcoder> What is the issue?
[20:28] <grogbot> <aquadran> beautiful "segmentation fault" 🙂
[20:28] <grogbot> <SupSuper> i'll let you know in a min
[20:28] <grogbot> <GeekOB> https://tenor.com/view/tbbt-the-big-bang-theory-sheldon-panic-attack-anxiety-attack-gif-7210524
[20:33] <grogbot> <SupSuper> looks like something wrong in your equals implementation
[20:37] <grogbot> <phcoder> @SupSuper do you have a bug description? Backlog is a bit confusing
[20:37] <grogbot> <SupSuper> sorry i'm just speaking out loud as i step through this
[20:40] <grogbot> <SupSuper> basically The Longest Journey is now crashing on startup and a bisect lead to your commit. my debug is leading me to a filename mismatch, so it's something wrong in the string contents or comparison
[20:42] <grogbot> <SupSuper> @phcoder ok so the problem is \0 are now ending up in Common::String contents
[20:42] --> SylvainTV joined #scummvm.
[20:42] #scummvm: mode change '+o SylvainTV' by ChanServ!ChanServ@services.
[20:42] <grogbot> <SupSuper> so i assume one of the char* constructors is incorrectly copying it
[20:43] <grogbot> <phcoder> It was always the case. String always contains final \0 as per spec
[20:43] <grogbot> <phcoder> Is _size correct?
[20:46] <grogbot> <SupSuper> it is not. sometimes it includes \0, sometimes it doesn't, thus the mismatch
[20:48] <grogbot> <SupSuper> also the docs say: > The presence of \0 characters in the string will cause undefined > behavior in some operations.
[20:49] <grogbot> <phcoder> Except the \0 at _str[_size] which should always be there
[20:50] <grogbot> <phcoder> As c_str() needs to return pointer to internal buffer and it needs to be zero terminated
[20:50] <grogbot> <SupSuper> then there is a size problem somewhere. this is deep in engine bowels so it's gonna take me a while to find it
[20:51] <grogbot> <phcoder> @SupSuper I can take a look later today
[20:54] <grogbot> <phcoder> Can you give me the breakpoint where the mismatch happens?
[21:01] <-- Shine_ left irc: Read error: Connection reset by peer
[21:06] <grogbot> <SupSuper> ok this might be a bug in TLJ
[21:06] <grogbot> <SupSuper> dunno why it didn't happen before though
[21:07] <-- ajax16384 left irc: Read error: Connection reset by peer
[21:07] <grogbot> <GeekOB> what I see on my end is TLJ fails to run on Raspberry Pi
[21:15] <grogbot> <SupSuper> well this was a hell of a rabbit hole
[21:16] <grogbot> <SupSuper> so it's the engine that's adding \0 to strings. why wasn't this a problem before??? i don't know, i'm just gonna fix it 😛
[21:19] <grogbot> <SupSuper> ah i see, the old implementation of equals just used strcmp. something to be aware of @phcoder if more bugs like this show up
[21:19] <grogbot> Command sent by SupSuper
[21:19] <grogbot> ...wow, that means our old string comparisons were really slow
[21:20] <grogbot> <SupSuper> the more you know!
[21:26] <grogbot> <phcoder> @SupSuper I've generally taken care of making BaseString support embed NULs but it doesn't guarantee their handling yet. But yeah having NUL before had indeterminate results
[21:27] <grogbot> <phcoder> Thank you for taking care of this
[21:27] <grogbot> <SupSuper> np. i wonder if it's worth adding an assert for
[21:33] <-- criezy left irc: Quit: criezy
[21:35] <Scummette> [scummvm] SupSuper pushed 1 new commits to master: https://git.io/JTdyR
[21:35] <Scummette> scummvm/master f2aa112 SupSuper: STARK: Don't append \0 when reading null-terminated strings.
[21:35] <grogbot> <SupSuper> @GeekOB pull the latest master and see if this fixes the issue for you
[21:36] <grogbot> <GeekOB> Will do
[22:04] <grogbot> <Henke37> you think that strcmp was slow?
[22:05] <grogbot> <Henke37> i find it hard to beat the C runtime library for this common tasks
[22:07] <grogbot> <SupSuper> we store the size of strings, so we can skip strcmp whenever sizes differ, which is probably 90% of cases
[22:08] <-- SylvainTV left irc: Ping timeout: 260 seconds
[22:09] --> SylvainTV joined #scummvm.
[22:09] #scummvm: mode change '+o SylvainTV' by ChanServ!ChanServ@services.
[22:12] <grogbot> <Henke37> i suppose you can do that if you don't care about ordering.
[22:37] <grogbot> <GeekOB> Compiling @SupSuper
[23:15] <grogbot> <SupSuper> @Aotrs Commander there should be a new buildbot build if you wanna try it again
[23:15] <-- ccawley2011 left irc: Quit: Leaving
[23:23] <grogbot> <GeekOB> The Longest Journey now works again on Raspberry Pi 4
[23:23] <grogbot> <GeekOB> https://cdn.discordapp.com/attachments/581224061091446795/772964175814328340/screenshot.png
[23:24] <grogbot> <GeekOB> Thank you for the quick fix @SupSuper and @phcoder
[23:38] <grogbot> <Aotrs Commander> Downloaded the latest master 64x version, tried it; unfortunately, same results as before. that said, it alreasy had TLJ added, so it's perhaps saving data somewhere other than in the folder, so I'll try uninstalling ScummVM, then installing it, and trying again.
[23:44] <grogbot> <Aotrs Commander> Nope, no joy, sorry folks. (It does seem to be remembering, even when I uninstalled via windows and wiped the folder that it pointed to TLJ, so manybe there's some files, a cache, maybe? That needs to be cleared...?
[23:45] <-- ny00123 left irc: Quit: Leaving
[00:00] --- Tue Nov 3 2020