ScummVM IRC Log - 02 Apr 2020

[Back to Index]

[00:14] <grogbot> <Thunderforge> Can I get some help on this PR? Basically, Codacy complains that my markdown lists don't have two spaces, then when I add them, it says I should remove the two spaces I just added. :/ https://github.com/scummvm/scummvm-web/pull/114
[00:17] <grogbot> <SupSuper> @Thunderforge i would ignore it since it's flagging every scummvm markdown like that
[00:17] <grogbot> <SupSuper> as long as it displays properly in github, it's fine
[00:22] <grogbot> <sev> done
[00:31] <grogbot> <SupSuper> @rootfather can probably merge it when he's around
[00:37] --> dreammaster joined #scummvm.
[00:37] #scummvm: mode change '+o dreammaster' by ChanServ!ChanServ@services.
[00:43] <grogbot> <Thunderforge> @SupSuper Thanks! I'll put it in a way that looks good on GitHUb
[00:50] <-- _sev left irc: Ping timeout: 264 seconds
[00:53] <-- girafe2 left irc: Quit: Leaving
[00:54] --> girafe joined #scummvm.
[00:55] --> _sev joined #scummvm.
[00:55] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[01:03] <-- _sev left irc: Ping timeout: 265 seconds
[01:05] --> vliaskov_ joined #scummvm.
[01:08] <-- vliaskov left irc: Ping timeout: 250 seconds
[01:13] <-- SylvainTV left irc: Read error: Connection reset by peer
[01:24] <-- vliaskov_ left irc: Remote host closed the connection
[01:30] --> _sev joined #scummvm.
[01:30] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[01:34] <-- _sev left irc: Read error: Connection reset by peer
[01:37] <-- timofonic left irc: Ping timeout: 264 seconds
[01:37] --> DominusExult joined #scummvm.
[01:37] <-- DominusExult left irc: Changing host
[01:37] --> DominusExult joined #scummvm.
[01:37] --> _sev joined #scummvm.
[01:37] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[01:41] <-- Dominus left irc: Ping timeout: 256 seconds
[01:41] Nick change: DominusExult -> Dominus
[02:32] <grogbot> <Thunderforge> I'd also appreciate feedback on this PR. It's been about a week and I haven't heard anything one way or another. https://github.com/scummvm/scummvm-web/pull/116
[03:05] <-- cd left irc: Quit: cd
[05:08] <-- dreammaster left irc:
[05:30] Nick change: VonGuard_ -> VonGuard
[06:32] <grogbot> <rootfather> @Thunderforge I merged 114 right now, now looking at 116
[06:51] <Scummette> [scummvm] ZvikaZ opened pull request #2176: SCI: suggest patching if GK2 version is 1.0 (master...z_gk2_corrupt_save) https://git.io/JvdAG
[06:54] <-- _sev left irc: Quit: This computer has gone to sleep
[06:55] <-- BeefEats left irc: Read error: Connection reset by peer
[06:58] --> _sev joined #scummvm.
[06:58] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[07:00] <-- _sev left irc: Client Quit
[07:02] --> _sev joined #scummvm.
[07:02] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[07:04] <-- _sev left irc: Client Quit
[07:05] --> _sev joined #scummvm.
[07:05] <-- _sev left irc: Changing host
[07:05] --> _sev joined #scummvm.
[07:05] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[07:09] <grogbot> <ZvikaZ> Hi. I've just sent a PR, and seems like build check is disabled. Is it on purpose, or a problem?
[07:09] <grogbot> <ZvikaZ> https://cdn.discordapp.com/attachments/581224061091446795/695168318600118282/unknown.png
[07:09] <grogbot> <ZvikaZ> https://github.com/scummvm/scummvm/pull/2176
[07:13] <-- _sev left irc: Quit: This computer has gone to sleep
[07:27] <-- hein left irc: Quit: killed
[07:27] LePhilousophe[m] <-- (valemboi20@gateway/shell/matrix.org/x-wojuponawbfvpmyt) left irc: Quit: killed
[07:27] Kszys[m] <-- (kszysmatri@gateway/shell/matrix.org/x-nmcowjxrcmyohqhb) left irc: Quit: killed
[07:30] --> ldevulder_ joined #scummvm.
[07:31] <-- ldevulder left irc: Ping timeout: 265 seconds
[07:32] --> _sev joined #scummvm.
[07:32] <-- _sev left irc: Changing host
[07:32] --> _sev joined #scummvm.
[07:32] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[07:54] --> waltervn joined #scummvm.
[07:54] #scummvm: mode change '+o waltervn' by ChanServ!ChanServ@services.
[07:57] LePhilousophe[m] --> (valemboi20@gateway/shell/matrix.org/x-ucjtmfmvmhfttqzw) joined #scummvm.
[08:06] --> waltervn_ joined #scummvm.
[08:06] #scummvm: mode change '+o waltervn_' by ChanServ!ChanServ@services.
[08:09] Nick change: ldevulder_ -> ldevulder
[08:09] <-- waltervn left irc: Ping timeout: 240 seconds
[08:15] <-- Dominus left irc: Read error: Connection reset by peer
[08:17] --> Dominus joined #scummvm.
[08:17] <-- Dominus left irc: Changing host
[08:17] --> Dominus joined #scummvm.
[08:17] <-- Lightkey left irc: Ping timeout: 252 seconds
[08:30] --> Lightkey joined #scummvm.
[08:34] --> ajax16384 joined #scummvm.
[08:34] #scummvm: mode change '+o ajax16384' by ChanServ!ChanServ@services.
[08:34] <-- _sev left irc: Quit: This computer has gone to sleep
[08:36] Kszys[m] --> (kszysmatri@gateway/shell/matrix.org/x-btfapekzfqyigsnl) joined #scummvm.
[08:36] --> hein joined #scummvm.
[09:03] --> waltervn__ joined #scummvm.
[09:03] #scummvm: mode change '+o waltervn__' by ChanServ!ChanServ@services.
[09:06] <-- waltervn_ left irc: Ping timeout: 240 seconds
[09:10] --> vliaskov joined #scummvm.
[09:18] --> NULUSIOS joined #scummvm.
[09:21] NULUSIOS (nls@mail2.termoil.com) left #scummvm.
[09:33] --> _sev joined #scummvm.
[09:33] <-- _sev left irc: Changing host
[09:33] --> _sev joined #scummvm.
[09:33] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[10:24] <-- Asterisk left irc: Ping timeout: 258 seconds
[10:27] --> Asterisk joined #scummvm.
[10:30] <-- _sev left irc: Quit: This computer has gone to sleep
[11:04] <-- Dominus left irc: Ping timeout: 240 seconds
[11:04] --> DominusExult joined #scummvm.
[11:04] <-- DominusExult left irc: Changing host
[11:04] --> DominusExult joined #scummvm.
[11:05] Nick change: DominusExult -> Dominus
[11:10] --> _sev joined #scummvm.
[11:10] <-- _sev left irc: Changing host
[11:10] --> _sev joined #scummvm.
[11:10] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[11:12] <-- _sev left irc: Client Quit
[11:16] --> _sev joined #scummvm.
[11:16] <-- _sev left irc: Changing host
[11:16] --> _sev joined #scummvm.
[11:16] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[11:20] <-- Dominus left irc: Ping timeout: 250 seconds
[11:23] --> Dominus joined #scummvm.
[11:23] <-- Dominus left irc: Changing host
[11:23] --> Dominus joined #scummvm.
[11:33] <-- _sev left irc: Quit: This computer has gone to sleep
[11:41] --> _sev joined #scummvm.
[11:41] <-- _sev left irc: Changing host
[11:41] --> _sev joined #scummvm.
[11:41] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[11:52] <Scummette> [scummvm] mduggan closed pull request #2169: ULTIMA8: Uncompress shapes on load for simpler render path (master...u8_un_rle_on_load) https://git.io/JvQUF
[11:52] <Scummette> [scummvm] mduggan pushed 1 new commits to master: https://git.io/JvFTw
[11:52] <Scummette> scummvm/master 66e36e6 mduggan: ULTIMA8: Uncompress shapes on load for simpler render path (#2169)
[11:56] <Scummette> [scummvm] sev- pushed 3 new commits to master: https://git.io/JvFTS
[11:56] <Scummette> scummvm/master bb62c30 sev-: DIRECTOR: Cleanup of transitions code
[11:56] <Scummette> scummvm/master 3975bca sev-: DIRECTOR: Added stub for changed area transitions
[11:56] <Scummette> scummvm/master 1b4226c sev-: DIRECTOR: Plugged memory leak it BITDDecoder
[12:06] <-- yuv422 left irc: Remote host closed the connection
[12:06] --> yuv422 joined #scummvm.
[12:06] #scummvm: mode change '+o yuv422' by ChanServ!ChanServ@services.
[12:12] <Scummette> [scummvm] sev- pushed 1 new commits to master: https://git.io/JvFkZ
[12:12] <Scummette> scummvm/master 358b4f1 sev-: DIRECTOR: Fix warnings
[12:12] <Scummette> [scummvm] sev- pushed 1 new commits to master: https://git.io/JvFkW
[12:15] --> waltervn_ joined #scummvm.
[12:15] #scummvm: mode change '+o waltervn_' by ChanServ!ChanServ@services.
[12:19] <-- waltervn__ left irc: Ping timeout: 265 seconds
[12:35] Nick change: waltervn_ -> waltervn
[12:53] --> h00ligan joined #scummvm.
[12:53] #scummvm: mode change '+o h00ligan' by ChanServ!ChanServ@services.
[12:56] <-- ajax16384 left irc: Ping timeout: 264 seconds
[13:33] <-- _sev left irc: Quit: This computer has gone to sleep
[13:43] --> _sev joined #scummvm.
[13:43] <-- _sev left irc: Changing host
[13:43] --> _sev joined #scummvm.
[13:43] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[14:04] <Scummette> scummvm/master 9d98fa0 sev-: DIRECTOR: Fix warning
[14:04] <Scummette> [scummvm] sev- pushed 1 new commits to master: https://git.io/JvFYf
[14:04] <Scummette> scummvm/master b2f6777 sev-: DIRECTOR: Plug memory leaks
[14:06] <grogbot> <Thunderforge> Thanks @rootfather. I'd like to submit additional PRs to improve the web page, but having a week between submission and approval is a bit difficult to manage. Is pinging people in Discord the best way to make sure that they are reviewed and merged? Or is there something else I should be doing?
[14:09] <Scummette> [scummvm] sev- pushed 1 new commits to master: https://git.io/JvFYs
[14:09] <Scummette> scummvm/master 4b1929b sev-: DIRECTOR: Fix warnings
[14:16] <grogbot> <Henke37> nah, that doesn't work.
[14:16] <grogbot> <Henke37> just get used to random delays between half an hour and forever.
[14:31] <Scummette> [scummvm] sev- pushed 1 new commits to master: https://git.io/JvFOt
[14:31] <Scummette> scummvm/master 56a7b74 sev-: DIRECTOR: Plug memory leaks
[14:36] <-- _sev left irc: Quit: This computer has gone to sleep
[14:41] --> _sev joined #scummvm.
[14:41] <-- _sev left irc: Changing host
[14:41] --> _sev joined #scummvm.
[14:41] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[14:42] --> cd joined #scummvm.
[15:23] <Scummette> [scummvm] sev- pushed 1 new commits to master: https://git.io/JvFsi
[15:23] <Scummette> scummvm/master eb1c9eb sev-: DIRECTOR: Plug memory leaks
[15:29] <grogbot> <antoniou79> I believe it's ok to to ping here or at the PR comments (which might be better) for a pending review. Sometimes people put it in their backlog and then forget.
[15:30] <grogbot> <rootfather> Yes - this time it was just me simply forgetting about looking at it. Usually, the delays are not that bad 🙂
[15:39] <Scummette> [scummvm] sev- pushed 1 new commits to master: https://git.io/JvFGg
[15:39] <Scummette> scummvm/master 529e9fc sev-: DIRECTOR: Plug leaked resources
[15:50] --> BeefEats joined #scummvm.
[15:52] <-- crns left irc: Read error: Connection reset by peer
[15:53] <Scummette> [scummvm] sev- pushed 1 new commits to master: https://git.io/JvFGx
[15:53] <Scummette> scummvm/master afdcc91 sev-: DIRECTOR: Plug memory leaks
[15:55] --> crns joined #scummvm.
[16:02] <Scummette> [scummvm] ZvikaZ opened pull request #2177: GUI: added `warningGuiAndConsole` (master...z_save_warnings) https://git.io/JvFZn
[16:05] <Scummette> [scummvm] sev- pushed 2 new commits to master: https://git.io/JvFZR
[16:05] <Scummette> scummvm/master c529644 sev-: GRAPHICS: MACGUI: Plug memory leak
[16:05] <Scummette> scummvm/master 3fd0003 sev-: DIRECTOR: Plug more memory leaks
[16:05] --> ny00123 joined #scummvm.
[16:07] --> JohnnyonFlame joined #scummvm.
[16:14] <grogbot> <ZvikaZ> Who's responsible for travis <-> github integration? @sev ? @rootfather ? New PRs integrate built with travis, but it's not shown in Github PR page.
[16:21] <grogbot> <rootfather> Im not involved with that, but let me see if I can do something g
[16:21] <grogbot> <rootfather> Whats the problem?
[16:22] <grogbot> <ZvikaZ> See for example https://github.com/scummvm/scummvm/pull/2177
[16:23] <grogbot> <ZvikaZ> https://cdn.discordapp.com/attachments/581224061091446795/695307775630376970/unknown.png
[16:23] <grogbot> <ZvikaZ> It seems as if "All checks" is only Codacy, while in the past it was also travis
[16:23] <grogbot> <ZvikaZ> compare it to: https://github.com/scummvm/scummvm/pull/2128
[16:24] <grogbot> <ZvikaZ> https://cdn.discordapp.com/attachments/581224061091446795/695307976323629136/unknown.png
[16:24] <grogbot> <ZvikaZ> Initially, I thought that somehow travis isn't working. But in travis URL I see that it is working: https://travis-ci.org/github/scummvm/scummvm/builds/670210387?utm_medium=notification
[16:24] <grogbot> <ZvikaZ> https://cdn.discordapp.com/attachments/581224061091446795/695308190258036807/unknown.png
[16:25] <grogbot> <ZvikaZ> But since it's not shown in the GitHub PR page, it'll probably be ignored. And if it'll fail, most people will probably not notice - until the buildbot will fail, and then it wouldn't be nice...
[16:40] <Strangerke> hi guys
[16:45] <grogbot> <SupSuper> @ZvikaZ seems to be a travis issue: https://www.traviscistatus.com/incidents/rx6fhs3wqcln
[16:47] <grogbot> <ZvikaZ> OK, thanks for noting that. But they claim that it was solved 7 days ago... Has anyone contacted them to report that the issue continues?
[16:48] <grogbot> <SupSuper> i'll poke them
[16:59] <grogbot> <rootfather> hm, look at the "Active Mac OS builds" on https://www.traviscistatus.com/
[17:00] <grogbot> <rootfather> since a couple of hours the number is absolutely frozen
[17:00] <grogbot> <rootfather> so looks like their API again
[17:02] <grogbot> <ZvikaZ> @rootfather - funny that the heading is All Systems Operational
[17:04] <grogbot> <SupSuper> time to try github ci again 😛
[17:08] <grogbot> <SupSuper> i see some recommendations of migrating to travis-ci.com
[17:11] <grogbot> <SupSuper> gonna try it on some personal projects first and report back
[17:29] <LePhilousophe> hum. I just tried ScummVM on my Android smartphone (Sony one) and it can't access file system with last master. It displays an error telling it can't access SD card in 2.1.0 and in 2.0.0 (in the store) it works
[17:30] <LePhilousophe> in last master it displays no error but folders are just empty
[17:30] <LePhilousophe> SD card folder is there
[17:30] <LePhilousophe> logcat is mute after enumeration of folders has been done
[17:31] <LePhilousophe> if someone has an idea to debug this...
[18:01] <-- Deledrius left irc: Quit: App.Exit
[18:17] --> Deledrius joined #scummvm.
[19:05] --> SylvainTV joined #scummvm.
[19:05] #scummvm: mode change '+o SylvainTV' by ChanServ!ChanServ@services.
[20:25] <grogbot> <xesf> Hey guys, what would be the reason for this warning "unknown game variant" and for giving me 2 different game options? Is it because the file names are the same? The game in 'castaway' seems to be an unknown game variant. Matched game IDs for the dgds engine: castaway-win, turbosci {"resource.001", 0, "46acc7ab8f6d7f63838ffea5f87380e2", 1175645}, {"resource.map", 0, "374e6d05c5e0acd88fb5af748948c899", 1461},
[20:27] <grogbot> <xesf> https://cdn.discordapp.com/attachments/581224061091446795/695369178001178634/unknown.png
[20:28] <grogbot> <Strangerke> maybe the filenames, it's the fallback detection anyway
[20:29] <grogbot> <rootfather> @xesf could you please open a bug report https://bugs.scummvm.org/ with as much info about the game you want to start (name, version, source/release...) so we can look into this further?
[20:30] <grogbot> <xesf> This is a new engine I am just starting to write
[20:30] <grogbot> <xesf> I may be doing something wrong
[20:30] <grogbot> <xesf> Trying to use AdvancedMetaEngine so I can choose different game engines
[20:30] <grogbot> <xesf> Using Ultima as a template
[20:33] <grogbot> <xesf> Is the checksum of the file in md5?
[20:33] <grogbot> <Strangerke> an md5 of the first 5000 characters usually
[20:33] <grogbot> <Henke37> octets. not characters.
[20:33] <grogbot> <Strangerke> yeah
[20:34] <grogbot> <Strangerke> but each engine may use its own technique so it's better to verify
[20:36] <grogbot> <xesf> yeah, something to do with the md5
[20:37] <grogbot> <xesf> if I remove it, it works fine
[20:41] --> criezy joined #scummvm.
[20:41] #scummvm: mode change '+o criezy' by ChanServ!ChanServ@services.
[20:43] <-- h00ligan left irc: Quit: Leaving
[22:01] <-- Flexman left irc: Read error: Connection reset by peer
[22:02] --> Flexman joined #scummvm.
[22:16] <-- criezy left irc: Quit: criezy
[22:19] <-- waltervn left irc: Quit: Leaving
[22:53] <grogbot> <sev> @xesf what happens if you add exactly the provided md5?
[22:54] <grogbot> <sev> and what is turbosci?
[22:55] <Scummette> [scummvm] sev- pushed 1 new commits to master: https://git.io/JvFV5
[22:55] <Scummette> scummvm/master 31b6d89 sev-: DIRECTOR: Disable non-referenced action skipping as it breaks many things
[23:23] <-- ny00123 left irc: Quit: Leaving
[23:35] <grogbot> <DreamMaster> turbosci looks like the game Id xesf chose for the game he started on, Quarky & Quaysoo's Turbo Science.
[23:37] <grogbot> <DreamMaster> That explains my initial confusion about why the files of resource.001 and resource.map were being used for the detection entry - it's a Sierra educational game
[23:49] --> dreammaster joined #scummvm.
[23:49] #scummvm: mode change '+o dreammaster' by ChanServ!ChanServ@services.
[23:49] <-- bazaar left irc: Ping timeout: 268 seconds
[23:51] --> bazaar joined #scummvm.
[23:53] <Lightkey> It's SCI on speed, obviously.
[23:57] <-- vliaskov left irc: Remote host closed the connection
[00:00] --- Fri Apr 3 2020