[00:07] Joefish (~Joefish@p200300C6F3C4D50049405AB325EDB1AC.dip0.t-ipconnect.de) left irc: Ping timeout: 258 seconds [00:10] mok (b4e05653@gateway/web/freenode/ip.180.224.86.83) joined #scummvm. [00:16] Dominus (~dominus@unaffiliated/dominus) joined #scummvm. [00:18] Hi guys i'm a student studying computer science in South Korea. i'm really interested in scummvm project on GSOC but since i'm not really good at programming for now, i wanna prepare for next chance. The thing i really wanna know is that can i just join this project even if i fail to join GSOC? [00:24] mok: hello! yes, you are free to contribute to ScummVM outside of GSoC. i dont know whether this would impact your ability to contribute through GSoC in the future (i dont know the GSoC rules); someone else here that works on GSoC may know. [00:25] Dominus (~dominus@unaffiliated/dominus) left irc: Quit: Oh no... znc died [00:25] Dominus (~dominus@unaffiliated/dominus) joined #scummvm. [00:27] mok (b4e05653@gateway/web/freenode/ip.180.224.86.83) left irc: Ping timeout: 260 seconds [00:30] m_kiewitz (~m_kiewitz@scummvm/undead/m-kiewitz) left irc: Read error: Connection reset by peer [00:40] mok (b4e05653@gateway/web/freenode/ip.180.224.86.83) joined #scummvm. [00:43] hold onto your butts. [00:43] GitHub77 (~GitHub77@192.30.252.42) joined #scummvm. [00:43] [scummvm] csnover pushed 5 new commits to master: https://git.io/vSqjW [00:43] scummvm/master 31daa95 Colin Snover: SCI: Implement bounds-checked reads of game resources [00:43] scummvm/master 6600fb7 Colin Snover: SCI: Use containers in GfxView and remove some SCI32 code [00:43] scummvm/master 816296f Colin Snover: SCI: Remove unused boilerplate from SciSpan [00:43] GitHub77 (GitHub77@192.30.252.42) left #scummvm. [00:47] |Cable| (~cable@33.138.117.91.dynamic.reverse-mundo-r.com) left irc: Ping timeout: 256 seconds [00:49] SylvainTV (~SylvainTV@LFbn-1-8392-241.w81-254.abo.wanadoo.fr) left irc: Read error: Connection reset by peer [00:49] mok (b4e05653@gateway/web/freenode/ip.180.224.86.83) left irc: Quit: Page closed [01:00] |Cable| (~cable@33.138.117.91.dynamic.reverse-mundo-r.com) joined #scummvm. [01:12] all green. aw yea. [01:14] GitHub132 (~GitHub132@192.30.252.42) joined #scummvm. [01:14] [scummvm] csnover closed pull request #882: SCI: Bounds checking (master...sci-bounds) https://git.io/vSmvg [01:14] GitHub132 (GitHub132@192.30.252.42) left #scummvm. [01:14] Henke37 (~Henrik@81-227-16-59-no133.bredband.skanova.com) left irc: Quit: ERR_SHUTDOWN [01:28] Uhfgood (~Captain_J@97-96-80-60.res.bhn.net) joined #scummvm. [01:52] DominusExult (~dominus@unaffiliated/dominus) joined #scummvm. [01:56] Dominus (~dominus@unaffiliated/dominus) left irc: Ping timeout: 260 seconds [01:56] Nick change: DominusExult -> Dominus [02:03] http://lists.libsdl.org/pipermail/sdl-libsdl.org/2017-March/101330.html [02:35] Littleboy (~littleboy@73.186.252.231) left irc: Quit: Ętre dans le vent, une ambition de feuille morte. [02:53] dreammaster (~dreammast@c-73-149-116-247.hsd1.vt.comcast.net) left irc: [03:12] vinayakvivek (uid121616@gateway/web/irccloud.com/x-qqqwsxursfwiqzwe) joined #scummvm. [04:16] Joefish (~Joefish@p200300C6F3CB910028639F43B116409D.dip0.t-ipconnect.de) joined #scummvm. [05:24] snover: that gitkstyle.png reminded me of both https://github.com/vbarbaresi/MetroGit and https://xkcd.com/657/ [05:28] Begasus (~begasus@ptr-4p6jpim3a8r175tukc3.18120a2.ip6.access.telenet.be) joined #scummvm. [05:33] Begas_VBox (~Begasus@d54C3C8C2.access.telenet.be) joined #scummvm. [05:40] waltervn (~waltervn@84.27.45.186) joined #scummvm. [05:40] #scummvm: mode change '+o waltervn' by ChanServ!ChanServ@services. [05:41] Mellified_Man (~Mellified@eddie.mellified.com) left irc: Quit: Bye! [05:49] morning [05:49] Mellified_Man (~Mellified@eddie.mellified.com) joined #scummvm. [05:51] morning [05:55] Uhfgood (~Captain_J@97-96-80-60.res.bhn.net) left irc: Quit: Leaving [06:02] uruk-hai (~uruk-hai@catv-89-133-22-244.catv.broadband.hu) joined #scummvm. [06:02] #scummvm: mode change '+o uruk-hai' by ChanServ!ChanServ@services. [06:10] t0by (~t0by@unaffiliated/t0by) joined #scummvm. [06:10] #scummvm: mode change '+v t0by' by ChanServ!ChanServ@services. [06:20] LittleToonCat (~littlecat@47.54.148.237) left irc: Remote host closed the connection [06:26] m_kiewitz (~m_kiewitz@scummvm/undead/m-kiewitz) joined #scummvm. [06:26] #scummvm: mode change '+o m_kiewitz' by ChanServ!ChanServ@services. [06:36] Strangerke (~Strangerk@cable-85.28.84.13.coditel.net) left irc: Ping timeout: 240 seconds [06:44] SicVintage[m] (sicvintage@gateway/shell/matrix.org/x-jbucheolaxcweklq) joined #scummvm. [06:45] Joefish (~Joefish@p200300C6F3CB910028639F43B116409D.dip0.t-ipconnect.de) left irc: Quit: WeeChat 1.7 [06:46] Joefish (~Joefish@2003:c6:f3cb:9100:2863:9f43:b116:409d) joined #scummvm. [06:47] _sev|work (~sev@scummvm/undead/sev) left irc: Quit: This computer has gone to sleep [07:26] Lightkey (~Darklock@p200300764C343C4822CF30FFFE083718.dip0.t-ipconnect.de) left irc: Ping timeout: 258 seconds [07:39] Lightkey (~Darklock@2003:76:4c34:3c26:22cf:30ff:fe08:3718) joined #scummvm. [07:44] Begas_VBox (~Begasus@d54C3C8C2.access.telenet.be) left irc: Ping timeout: 240 seconds [07:44] Begasus (~begasus@ptr-4p6jpim3a8r175tukc3.18120a2.ip6.access.telenet.be) left irc: Ping timeout: 240 seconds [07:47] Begasus (~begasus@ptr-4p6jpim3a8r175tukc3.18120a2.ip6.access.telenet.be) joined #scummvm. [07:51] Begas_VBox (~Begasus@d54C3C8C2.access.telenet.be) joined #scummvm. [07:53] Cheeseness (~cheesenes@ppp14-2-162-157.bras1.hba2.internode.on.net) left irc: Read error: Connection reset by peer [07:54] Cheeseness (~cheesenes@ppp14-2-162-157.bras1.hba2.internode.on.net) joined #scummvm. [08:55] t0by (~t0by@unaffiliated/t0by) left irc: Ping timeout: 240 seconds [09:00] Henke37 (~Henrik@81-227-16-59-no133.bredband.skanova.com) joined #scummvm. [09:53] Begasus (~begasus@ptr-4p6jpim3a8r175tukc3.18120a2.ip6.access.telenet.be) left irc: Ping timeout: 240 seconds [10:04] FleetAdmiral[m] (fleetadmir@gateway/shell/matrix.org/x-zmhtoszwiuknwsfz) left irc: Read error: Connection reset by peer [10:04] SicVintage[m] (sicvintage@gateway/shell/matrix.org/x-jbucheolaxcweklq) left irc: Read error: Connection reset by peer [10:05] Begasus (~begasus@ptr-4p6jpim3a8r175tukc3.18120a2.ip6.access.telenet.be) joined #scummvm. [10:17] SicVintage[m] (sicvintage@gateway/shell/matrix.org/x-pwgrmtlpfxiihczw) joined #scummvm. [10:19] ajax16384 (~User@109.60.138.138) joined #scummvm. [10:19] #scummvm: mode change '+o ajax16384' by ChanServ!ChanServ@services. [12:01] FleetAdmiral[m] (fleetadmir@gateway/shell/matrix.org/x-sorebuxgwhynulpr) joined #scummvm. [12:04] uruk-hai (~uruk-hai@catv-89-133-22-244.catv.broadband.hu) left irc: Quit: Leaving [13:20] ashutosh97_ (2f0b061a@gateway/web/freenode/ip.47.11.6.26) joined #scummvm. [13:21] Can anyone tell me where can i find all the files related to GMM ? [13:24] maxyodedara5 (uid218271@gateway/web/irccloud.com/x-chamronorinlddih) joined #scummvm. [13:25] gui/, engines/dialogs.cpp [13:38] ashutosh97_ (2f0b061a@gateway/web/freenode/ip.47.11.6.26) left irc: Ping timeout: 260 seconds [13:39] interesting how after yesterday's AR discussion, suddenly another ancient feature request about that (for FM-TOWNS SCUMM) gets a post [13:47] BTW, I think snover is correct about SCI Mac games not being AR-corrected originally [13:48] but I suppose that doesn't mean we shouldn't offer the option :) [13:51] ashutosh97 (2f0b03e3@gateway/web/freenode/ip.47.11.3.227) joined #scummvm. [13:52] Thank you! Is there any function or variable that returns the name of the current game being played ? [13:53] Littleboy (~littleboy@c-73-186-252-231.hsd1.ma.comcast.net) joined #scummvm. [13:53] #scummvm: mode change '+o Littleboy' by ChanServ!ChanServ@services. [13:55] ashutosh97: maybe look at runGame in base/main.cpp to see how it sets the window caption [13:56] while we're on a subject of AR, it would be nice to get a 5x horizontal, 6x vertical scaler at some point, and perhaps also a 4x/5x scaler [13:56] yes... [13:56] although no-filtering opengl should be able to handle that [13:56] yeah [13:57] is it easy to set that up? how do you specify the client area size? [13:58] I don't think there's any convenient way currently [13:58] (unless you happen to have a screen that's 1200 pixels high, in which fullscreen mode should "just work") [13:59] but I haven't looked at this in a while, so not at all sure [13:59] SicVintage[m] (sicvintage@gateway/shell/matrix.org/x-pwgrmtlpfxiihczw) left #scummvm ("User left"). [14:10] ashutosh97 (2f0b03e3@gateway/web/freenode/ip.47.11.3.227) left irc: Ping timeout: 260 seconds [15:04] ajax16384 (~User@109.60.138.138) left irc: Read error: Connection reset by peer [15:41] hm.. I'm just rewriting my proposal and wondered how long should it be? My milestones start to get longer than a site and I haven't even added all points. with the schedule, abstract and info it will get 6-7 pages. Is that too long? [15:45] Begas_VBox (~Begasus@d54C3C8C2.access.telenet.be) left irc: Quit: Vision[0.9.8]: i've been blurred! [15:46] .. should have reread "tips from past gsocers" on the wiki [15:46] urrghg.. [15:48] Begas_VBox (~Begasus@d54C3C8C2.access.telenet.be) joined #scummvm. [15:53] GitHub177 (~GitHub177@192.30.252.45) joined #scummvm. [15:53] [scummvm] madmoose pushed 1 new commit to master: https://git.io/vSYw8 [15:53] scummvm/master 5f552c9 Thomas Fach-Pedersen: BLADERUNNER: Implement ZBuffer class [15:53] GitHub177 (GitHub177@192.30.252.45) left #scummvm. [16:01] Nick change: Begas_VBox -> Begas_bbl [16:05] Joefish: "page" :) [16:08] WooShell (~Markus@ipbcc07076.dynamic.kabel-deutschland.de) joined #scummvm. [16:09] Port build status changed with 5f552c94: Failure: master-openpandora, master-amigaos4, master-osx_intel, master-caanoo, master-gp2x, master-gp2xwiz [16:16] ajax16384 (~User@109.60.130.33) joined #scummvm. [16:16] #scummvm: mode change '+o ajax16384' by ChanServ!ChanServ@services. [16:18] meow =^.^= [16:22] logix: Let's just tag it under *creative freedom* after being awake for 15 hours :) [16:27] <_sev> bada boom [16:28] :O [16:30] GitHub112 (~GitHub112@192.30.252.45) joined #scummvm. [16:30] [scummvm] sev- pushed 1 new commit to master: https://git.io/vSYi1 [16:30] scummvm/master dc5ed95 Eugene Sandulenko: BLADERUNNER: Remove stray semicolon [16:30] GitHub112 (GitHub112@192.30.252.45) left #scummvm. [16:33] Uhfgood (~Captain_J@97-96-80-60.res.bhn.net) joined #scummvm. [16:34] LittleToonCat (~littlecat@47.54.148.237) joined #scummvm. [16:37] _sev: ty :) [16:37] <_sev> yaw [16:41] Port build status changed with dc5ed954: Success: master-openpandora, master-amigaos4, master-osx_intel, master-caanoo, master-gp2x, master-gp2xwiz [16:52] Littleboy (~littleboy@c-73-186-252-231.hsd1.ma.comcast.net) left irc: Ping timeout: 268 seconds [16:54] user10 (~Thunderbi@leoseb.ujf-grenoble.fr) joined #scummvm. [16:56] user9 (~Thunderbi@leoseb.ujf-grenoble.fr) left irc: Ping timeout: 260 seconds [16:56] Nick change: user10 -> user9 [17:00] t0by (~t0by@host240-247-dynamic.8-87-r.retail.telecomitalia.it) joined #scummvm. [17:00] t0by (~t0by@host240-247-dynamic.8-87-r.retail.telecomitalia.it) left irc: Changing host [17:00] t0by (~t0by@unaffiliated/t0by) joined #scummvm. [17:00] #scummvm: mode change '+v t0by' by ChanServ!ChanServ@services. [17:02] PSA: Chivalry: Medieval Warfare seems to be currently free on Steam [17:02] disclaimer: I'm not a Steam user [17:06] overlockeer (506e45ec@gateway/web/freenode/ip.80.110.69.236) joined #scummvm. [17:08] Hi, I am a Computer Science student from Austria and I would like to apply here for GSOC for the Game Task "Mission Supernova Games". Is that project still available? [17:18] Hi, welcome [17:19] Projects aren't assigned to students until after the application deadline, so everything's available [17:25] I see. Do you have any special requirements for that particular Task or are you looking for something particular in applications for this project? I know my way around C/C++ and asm because of my course work and i am a native german speaker, therefore I think that I would be a good fit for that project. [17:31] who would be a possible Mentor for that project? Sev? [17:33] Hi overlockeer [17:33] I don't think there is special requirements beyond what is writen on the ideas page, but _sev could tell you more. [17:42] khaled_ (c5a59e1a@gateway/web/freenode/ip.197.165.158.26) joined #scummvm. [18:14] girafe (~girafe@LFbn-1-11729-221.w2-7.abo.wanadoo.fr) joined #scummvm. [18:18] Strangerke (~Strangerk@cable-85.28.84.13.coditel.net) joined #scummvm. [18:18] #scummvm: mode change '+o Strangerke' by ChanServ!ChanServ@services. [18:55] Action: t0by yawns [18:58] SylvainTV (~SylvainTV@LFbn-1-8392-241.w81-254.abo.wanadoo.fr) joined #scummvm. [18:58] #scummvm: mode change '+o SylvainTV' by ChanServ!ChanServ@services. [18:59] Zaarin (~dfh@pc203-30.ktv.no) joined #scummvm. [19:00] t0by: bored? want some work to do? [19:00] :) [19:00] Ate too much, slept too little, worked too much. [19:00] More work ain't gonna fix it. [19:01] Nor would more food, technically, but I would be open to trying. [19:01] hi [19:01] Hi Zaarin [19:04] Joefish, could you link to your proposal again? [19:05] Last time I looked at it it was consistent-ish, but sort of ambitious and not enough code-centric, IIRC. [19:05] Note that the C in GSOC is for "code" [19:05] 7 pages is acceptable, 7 pages of random nonsense is not :) [19:06] I thought it was cake :( [19:06] well, I'm out [19:06] In fact you should strive to be detailed *and* realistic :) [19:06] Zaarin, hi [19:06] What's cake? [19:06] I was talking to Joefish [19:06] the C in GSoC, t0by [19:06] nm [19:06] Oh [19:06] cake. [19:06] there you go. [19:06] Right. [19:06] let me know if you need me to explain any more jokes to you tonight [19:06] Where's my cake then. [19:06] I didn't get no cake. [19:07] the cake is a lie [19:07] there [19:07] you heard it from me first [19:07] snover, I didn't get logix's joke. [19:07] Please explain. [19:07] 7 pages is acceptable. [19:10] what joke? ;) [19:17] ^this [19:18] ceci n'est pas un joke [19:23] Hmmm, I wonder what is the gender of an English noum used in a French sentence... Sould it be 'ceci n'est pas une joke'? [19:23] (that would be closer to the original citation as well) [19:24] And t0by, if you don't know what to do you can review the draft proposals we have in the dashboard ;) [19:25] Uh, in my language "joke" is male, so... :) [19:25] *masculine [19:25] In French it is feminine (or at least the French word for joke is) [19:26] Oh, what is it? [19:26] Deledrius (~Deledrius@68.118.139.214) left irc: Ping timeout: 246 seconds [19:27] 'une blague' or 'une plaisanterie' or 'une farce'... they are all feminine :P [19:47] Nite all [19:47] t0by (~t0by@unaffiliated/t0by) left irc: Quit: Bye! [19:48] hello people! [19:48] dtcrshr (~datacrush@unaffiliated/datacrusher) joined #scummvm. [19:50] Hi khaled_ [19:51] you can drop the _ [19:52] thanks to nick completion that's probably more work [19:55] Exactly. I just typed kh+tab. To drop the _ I would need to press 3 more keys :P [19:55] maxyodedara5 (uid218271@gateway/web/irccloud.com/x-chamronorinlddih) left irc: Quit: Connection closed for inactivity [19:56] waltervn (~waltervn@84.27.45.186) left irc: Quit: Leaving [20:01] criezy: optimized version: kh [20:07] GitHub171 (~GitHub171@192.30.252.40) joined #scummvm. [20:07] [scummvm] criezy opened pull request #929: Do not hardcode resolutions for aspect ratio correction (master...ar-correction) https://git.io/vSOOf [20:07] GitHub171 (GitHub171@192.30.252.40) left #scummvm. [20:07] Nick change: Vampire0_ -> Vampire0 [20:14] vinayakvivek (uid121616@gateway/web/irccloud.com/x-qqqwsxursfwiqzwe) left irc: Quit: Connection closed for inactivity [20:18] ajax16384 (~User@109.60.130.33) left irc: Quit: Leaving [20:20] criezy: Concerning your AR correction PR, what about all the hardcoded calls to real2Aspect in surfacesdl-graphics.cpp? They are made only for vertical stretching by a factor 1.2* and nothing else (e.g. 200->240 lines) [20:21] criezy: So I think none of those will work to stretch other resolutions to 4:3 correctly, unless it happens to be a factor 1.2 vertical stretch [20:31] isn't 6/5 correct in all known cases? [20:32] it's not so much "stretching to 4:3" that has to happen [20:33] it's compensating for graphics designed for pixels with 5:6 aspect ratio [20:33] That's what I assumed, yes (and why I changed the OpenGL one to use real2Aspect() instead of forcing a 4/3 ratio for the correction). [20:36] hm [20:41] OpenGLGraphicsManager::endGFXTransaction is putting the return value of getDesiredGameScreenAspect() into an integer. Does that make sense? [20:51] WooShell (~Markus@ipbcc07076.dynamic.kabel-deutschland.de) left irc: Quit: If you understand or if you don't, if you believe or if you doubt - There's a universal justice, and the eyes of truth are always watching you. [21:05] so, any advice for the proposal ? [21:05] no idea what to start with :D [21:05] <_sev> khaled_: what proposal? [21:06] yup forgot to mention [21:06] GSOC [21:07] <_sev> khaled_: still says nothing [21:07] <_sev> GSoC is huge [21:08] _sev: what do you mean huge? [21:08] Do you at least have an idea of what you would like to work on? [21:09] <_sev> khaled_: literally. Hundreds of orgs, thousands of students. And even us have big number of projects to work on [21:10] criezy: nope [21:11] tbh, its the first time I try to go through a project thoroughly [21:12] open source world is a bit intimidating initially :D [21:13] Then looking at our ideas page might help you find a project you are interested in. Or you can bring your own ideas if you want. [21:14] We have several pages on our wiki which might help you. [21:14] From here http://wiki.scummvm.org/index.php/Summer_of_Code [21:14] And http://wiki.scummvm.org/index.php/GSoC_Application for what we are expecting in an application. [21:16] <_sev> should we start 1.10.0 release cycle? Opinions? wjp? snover? criezy? [21:21] That would be a relatively small release in term on new games and features, but this can set us up for a big one next :P [21:22] Deledrius (~Deledrius@68.118.139.214) joined #scummvm. [21:22] There are still some memory issues with the cloud code, so I don't think it is ready. [21:22] Do we have any game in the pipe? How long would it take to get some SCI2 games and Lost Eden ready? [21:24] Lost Eden isn't ready yet [21:24] there are still outstanding issues, no test on BE system, and I'd like to rewrite the savegames [21:25] SCI2 should be getting pretty close. snover, what are your impressions? [21:28] Strangerke: I can do some tests on BE once I unpack the mac I use to build PPC releases. [21:28] I will try to remember to do it around the time we do the next release. [21:29] I'm pretty sure it doesn't work yet, at least because of the savegames ;) [21:31] You have plenty of time to rewrite that code before I have to unpack that mac to build release 1.10.0 :P [21:31] Uh, sorry, I'm on my phone, will be back at HQ in about 30 minutes. Briefly, most sci2/2.1 are ready for testing once my working branch is all merged in [21:31] Mgdx has broken midi, unsure if qfg4 is completable [21:33] criezy: I have some difficulties to organize my free time those past 4 weeks... [21:33] I'll say more in a bit when I have a real keyboard :) [21:47] Zaarin (dfh@pc203-30.ktv.no) left #scummvm. [21:51] dreammaster (~dreammast@c-73-149-116-247.hsd1.vt.comcast.net) joined #scummvm. [21:51] #scummvm: mode change '+o dreammaster' by ChanServ!ChanServ@services. [21:58] SCI32 games that others ran through and reported them as completable: GK1CD, LSL6hires, Torin. Games I ran through and were completable: PQ4CD, GK2 1.1, KQ7 2.00b, Phant1, Shivers, SQ6, MGDX (though with no MIDI, its not very useful), Kings Questions. I dont know about: PQ:SWAT, PQ4floppy, QFG4, GK1floppy. [21:59] oh, and I also dont know about GK2 1.0 or KQ7 1.4/1.51. [22:01] The Hoyle card games are kind of a hot mess due to the way Sierra created and distributed them, and I guess the Poker game uses an external DLL that has not been reverse-engineered. There are also some palette bugs since the Win16s palette shifting isnt implemented. [22:02] If we go all the way up to the head of my working branch, Phantasmagoria 2 is also completable [22:02] but there is a problem with the mustSetViewVisible code in SCI3 that would need to be fixed for that. [22:04] There is no support for Mac SCI32 at this point. [22:08] Deledrius (~Deledrius@68.118.139.214) left irc: Ping timeout: 246 seconds [22:09] I have around 100 commits to land, which I am reviewing right now in preparation. And that is everything on the state of SCI32 right now, I think. [22:10] Deledrius (~Deledrius@68.118.139.214) joined #scummvm. [22:13] How much do all these changes impact older SCI games? Do they need to be restested before the next release? [22:14] the recent bounds-checking code affects the entire engine [22:14] so i would say, an extended testing period prior to release would probably be advisable [22:15] I want to get as many of the potential SCI16 breaking changes in at once, to keep this from needing to happen again in the future [22:16] girafe (~girafe@LFbn-1-11729-221.w2-7.abo.wanadoo.fr) left irc: Read error: Connection reset by peer [22:18] Polynomial-C (~Poly-C@gentoo/developer/Polynomial-C) left irc: Ping timeout: 240 seconds [22:22] Polynomial-C (~Poly-C@gentoo/developer/Polynomial-C) joined #scummvm. [22:23] overlockeer: Can you please allow comments in your sharing settings for your GSoC proposal so that we can review it and give you feedback that way? [22:32] Yes, I changed it just now [22:33] Thank you [22:33] Hmmm.. I seem to be getting a new error in Visual Studio for SCI: [22:34] Error C2248 'Common::SpanBase::SpanBase': cannot access protected member declared in class 'Common::SpanBase' sci c:\users\dreammaster\documents\visual studio 2015\projects\scummvm\common\span.h 687 [22:34] dreammaster: no, everything is perfect. & [22:34] About 150 errors worth of it [22:35] I take it that this is something just introduced? [22:35] yes [22:36] Pretty obviously, I guess, since it compiled for me last time I did a pull :P [22:37] Im not sure right now if I hit some spec edge case or if MSVC has a bug [22:39] It's kind of hard for me to see what exactly it's complaining about, since clicking on any of the error lines only takes me to the closing }; of the SpanImpl template [22:39] the protected qualifier was removed for very old versions of GCC, perhaps MSVC needs this too. [22:39] I am looking to see if I can find anyone else running into a similar problem [22:42] Line 631 you mean? [22:42] yes [22:43] HoloIRCUser1 (~holoirc@2a02:8388:e302:7180:3d21:8c56:9146:cb75) joined #scummvm. [22:43] i mean, there are other ones too [22:44] DominusExult (~dominus@unaffiliated/dominus) joined #scummvm. [22:45] Which visual studio is this? [22:45] 2015 for me [22:46] Dominus (~dominus@unaffiliated/dominus) left irc: Ping timeout: 260 seconds [22:46] Nick change: DominusExult -> Dominus [22:46] I'm just trying to wrap all the protected lines in an extra !defined(_MSC_VER); lets see if that indeed fixes the problem [22:47] Yep. That did the trick. [22:47] HoloIRCUser1 (~holoirc@2a02:8388:e302:7180:3d21:8c56:9146:cb75) left irc: Quit: HoloIRCUser1 [22:48] that error message sure isnt very useful. was that the whole thing, ending at '687'? [22:48] Well, clicking on any of the errors just jumped me to the end of the SpanImpl template class, yes. It wouldn't even tell me what specifically, if anything, was unable to be accessed [22:49] At least committing these extra !defined checks will allow for VS compilation again, and it's not exactly a real problem that stuff for the template will be in public vs protected [22:52] GitHub95 (~GitHub95@192.30.252.40) joined #scummvm. [22:52] [scummvm] dreammaster pushed 1 new commit to master: https://git.io/vSO6q [22:52] scummvm/master 4564b84 Paul Gilbert: COMMON: Compilation fix for Visual Studio 2015... [22:52] GitHub95 (GitHub95@192.30.252.40) left #scummvm. [23:06] khaled_ (c5a59e1a@gateway/web/freenode/ip.197.165.158.26) left irc: Quit: Page closed [23:24] hm. it would be nice to figure out why this is happening in msvc before tossing the access control totally. [23:30] Begas_bbl (~Begasus@d54C3C8C2.access.telenet.be) left irc: Quit: Vision[0.9.8]: i've been blurred! [23:34] I've certainly no objection if anyone wants to try their hand it. If an alternate solution can be figured out, the ifdefs can always be reverted [23:49] of course. i just would not like to find out later that games start acting up because i, not being knowledgeable enough about c++, accidentally triggered some UB. [23:54] criezy: thank you for your feedback on my document, I have received parts of the original source code and will address your comments tomorrow. Good night. [00:00] --- Wed Mar 29 2017