ScummVM IRC Log - 27 Mar 2017

[Back to Index]

[00:08] <dreammaster> I half kind of think they simply plugged in an existing spatial animation package and simply made minor changes as necessary to it. It's the kind of thing that could have been easily done semi-independantly by a single developer
[00:09] <snover> my milestone today is running into a mystery hung game script
[00:12] <dreammaster> Oh? Which game?
[00:12] <snover> lighthouse
[00:13] <dreammaster> Ah. I should have guessed :)
[00:23] <snover> am i that transparent ;)
[00:24] <dreammaster> Nah, given your focus, Lighthouse, being one of the last SCI games, seemed the most likely to be suffering from bizarre issues
[00:28] <-- Joefish left irc: Ping timeout: 256 seconds
[00:28] <snover> rama seems like it might be even worse; some vmds are silently skipped, a lot of the screen items seem to be slightly scaled when they shouldnt be, and thats just from the first room
[00:30] <snover> at least in lighthouse i have been able to play through to what appears to be the third-to-last puzzle
[00:31] <dreammaster> Well, that's something at least
[00:32] <snover> lsl7 has one hung script too, though i was able to temporarily bypass it to get through the rest of the game
[00:34] <dreammaster> Ah. Do you think both games' hangs are due to the same problem and/or deficiency in ScummVM?
[00:34] <-- vinayakvivek left irc: Quit: Connection closed for inactivity
[00:37] <snover> i hope so. its very reminiscent of the hang in kq7 where there is a scripted cutscene that doesnt get a signal to proceed, though in that case it was due to the MIDI code, whereas lsl7/lighthouse dont use midi at all for audio
[00:40] <dreammaster> Fingers crossed for you to be able to figure it out without too much effort & frustration
[00:40] <snover> thanks, i appreciate that :)
[00:51] --> GitHub160 joined #scummvm.
[00:51] <GitHub160> [scummvm] dreammaster pushed 1 new commit to master: https://git.io/vSLWm
[00:51] <GitHub160> scummvm/master aaa2527 Paul Gilbert: TITANIC: Fix loading of CStarPoints2 data
[00:51] GitHub160 (GitHub160@192.30.252.42) left #scummvm.
[01:03] --> Uhfgood joined #scummvm.
[01:05] --> GitHub190 joined #scummvm.
[01:05] <GitHub190> [scummvm] dreammaster pushed 1 new commit to master: https://git.io/vSLW9
[01:05] <GitHub190> scummvm/master 765ec88 Paul Gilbert: TITANIC: Fix loading of CStarView class
[01:05] GitHub190 (GitHub190@192.30.252.45) left #scummvm.
[01:10] <-- Henke37 left irc: Quit: ERR_SHUTDOWN
[01:42] --> GitHub152 joined #scummvm.
[01:42] <GitHub152> [scummvm] dreammaster pushed 1 new commit to master: https://git.io/vSL8q
[01:42] <GitHub152> scummvm/master a925264 Paul Gilbert: TITANIC: Remove redundant static from CStarControlSub6...
[01:42] GitHub152 (GitHub152@192.30.252.40) left #scummvm.
[01:54] --> DominusExult joined #scummvm.
[01:54] <-- DominusExult left irc: Changing host
[01:54] --> DominusExult joined #scummvm.
[01:57] <-- Dominus left irc: Ping timeout: 260 seconds
[01:58] Nick change: DominusExult -> Dominus
[04:01] <-- dreammaster left irc:
[04:41] --> Joefish joined #scummvm.
[05:17] --> Affan joined #scummvm.
[05:17] <Affan> Hello
[05:24] <Joefish> hi
[05:31] <-- Dominus left irc: Read error: Connection reset by peer
[05:32] --> Dominus joined #scummvm.
[05:32] <-- Dominus left irc: Changing host
[05:32] --> Dominus joined #scummvm.
[05:37] --> maxyodedara5 joined #scummvm.
[05:39] --> waltervn joined #scummvm.
[05:39] #scummvm: mode change '+o waltervn' by ChanServ!ChanServ@services.
[05:41] <waltervn> morning
[05:45] <-- Affan left irc: Ping timeout: 260 seconds
[05:45] <Joefish> morning
[05:56] <-- Uhfgood left irc: Quit: Leaving
[06:04] --> GitHub5 joined #scummvm.
[06:04] <GitHub5> [scummvm] sev- pushed 2 new commits to master: https://git.io/vSL2Z
[06:04] <GitHub5> scummvm/master b8a07d3 Eugene Sandulenko: FULLPIPE: Safer string management
[06:04] <GitHub5> scummvm/master baf7c83 Eugene Sandulenko: FULLPIPE: Sanity check on data loading
[06:04] GitHub5 (GitHub5@192.30.252.42) left #scummvm.
[06:06] --> GitHub145 joined #scummvm.
[06:06] <GitHub145> [scummvm] sev- pushed 1 new commit to master: https://git.io/vSL2R
[06:06] <GitHub145> scummvm/master 1298762 Eugene Sandulenko: TITANIC: Fix copy/paste error
[06:06] GitHub145 (GitHub145@192.30.252.42) left #scummvm.
[06:37] --> omer_mor_ joined #scummvm.
[06:40] <-- omer_mor left irc: Ping timeout: 264 seconds
[06:48] --> omer_mor joined #scummvm.
[06:50] <-- omer_mor_ left irc: Ping timeout: 260 seconds
[06:54] --> m_kiewitz joined #scummvm.
[06:54] #scummvm: mode change '+o m_kiewitz' by ChanServ!ChanServ@services.
[07:24] <-- LittleToonCat left irc: Remote host closed the connection
[07:28] <-- Lightkey left irc: Ping timeout: 258 seconds
[07:41] --> Lightkey joined #scummvm.
[07:55] <-- maxyodedara5 left irc: Quit: Connection closed for inactivity
[08:10] <-- TMM left irc: Ping timeout: 264 seconds
[08:16] --> edheldil joined #scummvm.
[08:44] --> Affan joined #scummvm.
[08:51] <-- Dark-Star left irc: Ping timeout: 240 seconds
[08:52] --> TMM joined #scummvm.
[08:52] #scummvm: mode change '+o TMM' by ChanServ!ChanServ@services.
[08:54] --> Dark-Star joined #scummvm.
[08:57] --> Begasus joined #scummvm.
[09:03] --> Begas_VBox joined #scummvm.
[09:09] --> thesquib joined #scummvm.
[09:17] --> Henke37 joined #scummvm.
[10:22] --> ajax16384 joined #scummvm.
[10:22] #scummvm: mode change '+o ajax16384' by ChanServ!ChanServ@services.
[10:25] --> borosky joined #scummvm.
[10:28] <-- broosky left irc: Ping timeout: 264 seconds
[10:44] <-- exmensa left irc: Ping timeout: 260 seconds
[10:55] Affan (Administr@103.75.56.37) left #scummvm ("Leaving").
[11:20] --> exmensa joined #scummvm.
[11:42] --> TAS-2012v joined #scummvm.
[11:43] <-- TAS_2012v left irc: Ping timeout: 260 seconds
[11:43] Nick change: TAS-2012v -> TAS_2012v
[11:47] --> TAS-2012v joined #scummvm.
[11:47] <-- TAS_2012v left irc: Ping timeout: 256 seconds
[11:47] Nick change: TAS-2012v -> TAS_2012v
[11:56] --> TAS-2012v joined #scummvm.
[11:57] <-- TAS_2012v left irc: Ping timeout: 258 seconds
[11:57] Nick change: TAS-2012v -> TAS_2012v
[12:24] <-- edheldil left irc: Remote host closed the connection
[12:29] --> uruk-hai joined #scummvm.
[12:29] #scummvm: mode change '+o uruk-hai' by ChanServ!ChanServ@services.
[12:48] <-- Begas_VBox left irc: Read error: No route to host
[12:49] --> Begasus_ joined #scummvm.
[12:50] <-- Begasus left irc: Ping timeout: 264 seconds
[12:51] --> Begas_VBox joined #scummvm.
[13:08] <-- uruk-hai left irc: Quit: Leaving
[13:12] --> uruk-hai joined #scummvm.
[13:12] #scummvm: mode change '+o uruk-hai' by ChanServ!ChanServ@services.
[14:04] <-- Begas_VBox left irc: Quit: Vision[0.9.8]: i've been blurred!
[14:05] --> Begas_VBox joined #scummvm.
[14:23] <-- Begas_VBox left irc: Quit: Vision[0.9.8]: i've been blurred!
[14:29] --> vinayakvivek joined #scummvm.
[14:32] <-- Strangerke left irc: Ping timeout: 240 seconds
[14:36] Nick change: Begasus_ -> Begas_bbl
[14:51] --> Littleboy joined #scummvm.
[14:51] #scummvm: mode change '+o Littleboy' by ChanServ!ChanServ@services.
[15:10] --> serk joined #scummvm.
[15:13] --> Strangerke joined #scummvm.
[15:15] <-- serk left irc: Quit: Page closed
[15:15] --> Uhfgood joined #scummvm.
[15:20] --> Polynomial-C joined #scummvm.
[15:31] --> ny00123 joined #scummvm.
[15:46] <-- TMM left irc: Quit: Ex-Chat
[15:58] <-- |Cable| left irc: Ping timeout: 240 seconds
[15:58] <-- uruk-hai left irc: Quit: Leaving
[15:59] Nick change: Begas_bbl -> Begasus
[16:09] --> maxyodedara5 joined #scummvm.
[16:11] --> |Cable| joined #scummvm.
[16:11] <-- chadj left irc: Ping timeout: 240 seconds
[16:11] --> Begas_VBox joined #scummvm.
[16:17] <-- Dark-Star left irc: Ping timeout: 240 seconds
[16:17] --> WooShell joined #scummvm.
[16:22] <WooShell> meow =^.^=
[16:23] <-- ajax16384 left irc: Read error: Connection reset by peer
[16:25] --> LittleToonCat joined #scummvm.
[16:28] --> frankyboy_ joined #scummvm.
[16:28] --> Dark-Star joined #scummvm.
[16:34] <-- frankyboy_ left irc: Read error: Connection reset by peer
[16:35] --> frankyboy_ joined #scummvm.
[16:35] <-- frankyboy_ left irc: Client Quit
[16:41] --> chadj joined #scummvm.
[17:00] <wjp> criezy: great work on all the reviewing
[17:02] --> TMM joined #scummvm.
[17:02] #scummvm: mode change '+o TMM' by ChanServ!ChanServ@services.
[17:02] <criezy> I happened to have a few days off ;)
[17:03] <criezy> I am back to work tomorrow though, so hopefully others can find the time to do some reviewing as well.
[17:12] <criezy> wjp or other SCI devs: it looks like we are not doing aspect ratio correction for some SCI games that use uncommon resolutions (such as 320x190, 480x300, 320x220 or 640x440 from reading quickly screen.cpp).
[17:12] <criezy> Currently aspect ratio correction is only used for 320x200 and 640x400 games (at least in the SDL OpenGL case).
[17:12] <criezy> I am wondering which others should be handled and to which ratio they should be corrected.
[17:12] <m_kiewitz> well the resolutions that those other SCI games use :P
[17:12] <m_kiewitz> and yeah at least I knew that already
[17:12] <criezy> See also http://forums.scummvm.org/viewtopic.php?t=14303
[17:13] --> Farmboy0 joined #scummvm.
[17:13] <-- Farmboy0 left irc: Changing host
[17:13] --> Farmboy0 joined #scummvm.
[17:13] <m_kiewitz> yeah, it gets even more difficult because of those Mac versions
[17:13] <m_kiewitz> at least some cut off the icon bar
[17:13] <m_kiewitz> so they are running at 320x190
[17:13] <wjp> how did that work on original hardware?
[17:14] <m_kiewitz> i think it used Mac system menu or something for that
[17:14] <m_kiewitz> and well AGI games were even crazier
[17:14] <m_kiewitz> those had all sorts of extra Mac resources, hi res fonts, hi res graphics, but all custom built
[17:14] <snover> of course apple had to name one of their macOS releases Sierra. goodbye relevant search results :)
[17:15] <m_kiewitz> yeah you should tell that the "Switch" made by Nintendo, snover :P
[17:15] <m_kiewitz> well at least amazon gets seriously confused when you search for that
[17:15] <m_kiewitz> or well, it did
[17:15] <-- t0by left irc: Quit: Bye!
[17:16] <logix> i think "nintendo switch" always produced good search results
[17:16] <m_kiewitz> yes, nintendo switch
[17:16] <logix> well, once amazon had the switch/games up for preorder
[17:16] <m_kiewitz> but "switch" by itself finds network switches :P
[17:16] <logix> yes
[17:16] <m_kiewitz> yes, that's why it's a stupid name
[17:16] <snover> anyway, ive only ever seen sci mac games running in emulation and they always seem to not AR correct
[17:16] <m_kiewitz> Wii for example was weird, but at least it wasn't an already existing word
[17:17] <m_kiewitz> maybe the emulation didn't do it correctly, no idea :P
[17:17] <m_kiewitz> i have just bought Shivers for Mac
[17:17] <m_kiewitz> so at least I will be able to check SCI2.1 or was it SCI2 games
[17:21] --> Vampire0_ joined #scummvm.
[17:21] <logix> m_kiewitz: yeah, might have helped if somebody at nintendo had read RFC 1178 :)
[17:22] <-- Vampire0 left irc: Ping timeout: 268 seconds
[17:22] <snover> logix: heh :)
[17:23] <m_kiewitz> I always liked RFC 1149, but still no implementation yet :(
[17:24] <logix> m_kiewitz: http://www.blug.linux.no/rfc1149/
[17:24] <m_kiewitz> whhhhaaaaatttttt
[17:24] <m_kiewitz> PING 10.0.3.1 (10.0.3.1): 56 data bytes
[17:24] <m_kiewitz> 64 bytes from 10.0.3.1: icmp_seq=0 ttl=255 time=6165731.1 ms
[17:24] <m_kiewitz> lol
[17:28] <criezy> Does this commit make sense: https://github.com/criezy/scummvm/commit/3acad0a79ed92f79e8cdb9af3fe6796846ce5555 ?
[17:29] <snover> can AR setting be retrieved from the engine instead of hardcoding numbers into the backend?
[17:30] <logix> is 320x190 the only AR of that kind or are there others, possibly always (common_width)x(common_height - 10)
[17:31] <logix> ?
[17:36] --> girafe joined #scummvm.
[17:46] --> SylvainTV joined #scummvm.
[17:46] #scummvm: mode change '+o SylvainTV' by ChanServ!ChanServ@services.
[17:52] <m_kiewitz> logix: I don't think so. but there are a few special ones
[17:52] <m_kiewitz> like for exampe 480x300 for SCI0 Mac games
[17:53] <m_kiewitz> and those should probably get scaled like 320x200
[18:15] <-- maxyodedara5 left irc: Quit: Connection closed for inactivity
[18:37] <-- Begas_VBox left irc: Ping timeout: 240 seconds
[18:39] <madmoose> peterkohaut: It's beginning to be playable :)
[18:41] <peterkohaut> madmoose: i'm noticing that too:)
[18:44] <peterkohaut> btw, for me, that looping code was smallest commit for biggest decompiling effort yet
[18:44] <madmoose> peterkohaut: if you make the mouse pick z-values from zbuffer 2 you can even click on actors
[18:46] <peterkohaut> thx for tip
[18:47] <peterkohaut> but now iam working on something different:)
[18:47] <madmoose> That might not be the proper fix :P
[18:47] <madmoose> but I wanted to talk to Officer Leary :)
[18:48] <madmoose> What are you working on?
[18:48] <peterkohaut> proper walking and gui
[18:49] <madmoose> oh, those small things :)
[18:50] <peterkohaut> we will see:)
[18:50] <-- Begasus left irc: Ping timeout: 264 seconds
[18:52] <madmoose> peterkohaut: Which part of the gui? KIA, Spinner, or ui control classes in general?
[18:53] <peterkohaut> mainly uicontrols and kia
[18:54] <peterkohaut> from kia i wants the most clues/suspects db
[18:57] <peterkohaut> afterwards, the spinner, coz we all want to see other places too:)
[18:58] --> ajax16384 joined #scummvm.
[18:58] #scummvm: mode change '+o ajax16384' by ChanServ!ChanServ@services.
[18:59] <madmoose> the spinner looks fairly simple once you have the ui image picker
[19:01] <peterkohaut> maybe i'll switch priorities because ui image picker is quite easy (i named it "buttons" in idb)
[19:10] <-- TMM left irc: Read error: Connection reset by peer
[19:24] <-- Harekiet left irc: Read error: Connection reset by peer
[19:28] --> Harekiet joined #scummvm.
[19:41] --> TMM joined #scummvm.
[19:41] #scummvm: mode change '+o TMM' by ChanServ!ChanServ@services.
[19:44] #scummvm: mode change '+o Strangerke' by ChanServ!ChanServ@services.
[19:52] <-- LittleToonCat left irc: Remote host closed the connection
[19:54] --> LittleToonCat joined #scummvm.
[19:58] <-- Dominus left irc: Quit: Oh no... znc died
[19:59] --> Dominus joined #scummvm.
[19:59] <-- Dominus left irc: Changing host
[19:59] --> Dominus joined #scummvm.
[19:59] <-- Dominus left irc: Remote host closed the connection
[19:59] --> Guest45474 joined #scummvm.
[20:11] <-- Guest45474 left irc: Quit: Oh no... znc died
[20:22] <m_kiewitz> https://www.youtube.com/watch?v=sOzM4ClFG1o
[20:22] <m_kiewitz> tehe
[20:27] <-- ajax16384 left irc: Read error: Connection reset by peer
[20:34] <-- Uhfgood left irc: Quit: Leaving
[20:44] <-- vinayakvivek left irc: Quit: Connection closed for inactivity
[20:45] <-- waltervn left irc: Quit: Leaving
[21:00] --> Dominus joined #scummvm.
[21:03] --> _sev|work joined #scummvm.
[21:03] #scummvm: mode change '+o _sev|work' by ChanServ!ChanServ@services.
[21:08] --> t0by joined #scummvm.
[21:08] #scummvm: mode change '+v t0by' by ChanServ!ChanServ@services.
[21:10] <-- ny00123 left irc: Quit: Leaving
[21:11] <-- Dominus left irc: Quit: Oh no... znc died
[21:14] --> Dominus joined #scummvm.
[21:19] <-- Dominus left irc: Client Quit
[21:20] <-- girafe left irc: Quit: Leaving
[21:32] <snover> wjp, m_kiewitz, Ill land this bounds checking PR tonight unless you run into some late-breaking objections. As far as I know, I did change everything that I got feedback on.
[21:33] <snover> Then after that I will start moving commits from my working branch. Let me know if you want me to do it like a few commits per day or something, so they are spaced out so you dont feel overwhelmed when 100 commits show up suddenly.
[21:33] <snover> (bbiab)
[21:35] <wjp> bound checking is fine by me
[21:35] <wjp> the rest is indeed a rather imposing amount of work :-)
[21:36] <wjp> I've already taken the occasional glance through it
[21:36] <wjp> but no structured review or anything like that
[21:37] <m_kiewitz> 100 commits? o_O
[21:38] <wjp> 108
[21:38] <wjp> he's not exaggerating :-)
[21:38] <m_kiewitz> o_O
[21:38] <m_kiewitz> that's what i don't like about git. there should be a way to combine them.
[21:38] <m_kiewitz> well maybe there is :P
[21:38] <wjp> ...combine them?
[21:39] <m_kiewitz> well in case you work on something and do a pull request and then you fix one issue and another and so on
[21:39] <m_kiewitz> i would prefer it in case you could merge all of those together into 1 commit
[21:40] <-- Gentle left irc: Ping timeout: 256 seconds
[21:40] <wjp> you can combine/split/reorder anything
[21:41] <wjp> but I think snover's commits generally make sense
[21:42] <m_kiewitz> ah you can?
[21:42] <m_kiewitz> well 108 commits? aren't there plenty of bugfixes/regressions inside it?
[21:43] <m_kiewitz> i would understand it in case those were actually commited into main branch already
[21:43] <m_kiewitz> well pushed into main branch
[21:43] <wjp> there may be a few things that could be squashed together
[21:52] <-- WooShell left irc: Quit: If you understand or if you don't, if you believe or if you doubt - There's a universal justice, and the eyes of truth are always watching you.
[21:53] <m_kiewitz> it's not a problem
[21:53] <m_kiewitz> well it would be also maybe nice to combine all the commits of a PR into one commit bundle, if you understand what i mean
[21:53] --> Gentle joined #scummvm.
[21:54] <m_kiewitz> so that you would see "SCI: bounds checks", then you could open that and see all the commits inside of it
[21:54] <m_kiewitz> maybe that's also already possible... idk
[21:55] <wjp> the github interface already kind of provides that
[22:02] <m_kiewitz> are PRs a github invention?
[22:03] <wjp> not sure who invented it, but it's sometimes they provide above "core" git, yes
[22:04] <wjp> I suppose pull requests may have been the original term for emails to Linus requesting code be pulled into linux
[22:05] <wjp> but the outcome (in the git history) is a merge commit where you can see a set of separate commits being merged into master
[22:16] <-- Farmboy0 left irc: Remote host closed the connection
[22:55] --> Dominus joined #scummvm.
[23:02] <-- Dominus left irc: Quit: Oh no... znc died
[23:24] <t0by> um
[23:24] <t0by> what's wrong with
[23:24] <t0by> git checkout master
[23:25] <t0by> git checkout -b relevant_commits
[23:25] <t0by> git cherry-pick commits
[23:25] <t0by> git diff master?
[23:25] <t0by> (or some permutation thereof)
[23:30] <-- t0by left irc: Ping timeout: 256 seconds
[23:34] <snover> well, there is no obvious patch set in that case, you would have to manually figure out the commit range (and then you would not need to cherry-pick anything, just git diff firstcommit..lastcommit)
[23:44] <snover> if there is some VCS out there that has no crappy user experience when it comes to code merging, i havent seen it
[23:45] <-- macdude22 left irc: Ping timeout: 246 seconds
[23:46] --> Dominus joined #scummvm.
[23:48] <Vel0city> I hear https://www.gitkraken.com/ is pretty good.
[23:51] --> dreammaster joined #scummvm.
[23:51] #scummvm: mode change '+o dreammaster' by ChanServ!ChanServ@services.
[23:53] <snover> squash and you lose possibly valuable intermediate changes; rebase and you dont have a single clear point where a feature was merged in; merge and get a non-linear branch history and sometimes this happens http://4.bp.blogspot.com/-Y99dcDsHSl8/TXaprrV505I/AAAAAAAABFI/7OjSuPcr2OQ/s1600/gitkstyle.png
[23:59] <-- Dominus left irc: Quit: Oh no... znc died
[00:00] --- Tue Mar 28 2017