[00:02] diehumblex (uid209517@gateway/web/irccloud.com/x-psmfdznaocpbiild) left irc: Quit: Connection closed for inactivity [00:03] GitHub19 (~GitHub19@192.30.252.41) joined #scummvm. [00:03] [scummvm] dreammaster pushed 1 new commit to master: https://git.io/vyTxB [00:03] scummvm/master 92f1583 Paul Gilbert: TITANIC: Implementing CSurfaceArea methods [00:03] GitHub19 (GitHub19@192.30.252.41) left #scummvm. [00:12] yaaay, fixed the save games. im surprised that this is the first point where there actually needs to be a before-saveload [00:32] WooShell (~Markus@ipbcc071f7.dynamic.kabel-deutschland.de) left irc: Quit: If you understand or if you don't, if you believe or if you doubt - There's a universal justice, and the eyes of truth are always watching you. [00:41] ooh, interesting. sci viewer wont disassemble lighthouse script 64940. havent seen it fail before. [01:00] cody56 (~lavosspaw@p5DE87CE1.dip0.t-ipconnect.de) left irc: Read error: Connection reset by peer [01:07] lavosspawn (~lavosspaw@p5DE87CE1.dip0.t-ipconnect.de) joined #scummvm. [01:23] Henke37 (~Henrik@81-227-16-59-no133.bredband.skanova.com) left irc: Quit: ERR_SHUTDOWN [01:31] girafe2 (~girafe@LFbn-1-11729-221.w2-7.abo.wanadoo.fr) joined #scummvm. [01:32] m_kiewitz: looks like lsl7 does some calls to set the rng seed, though i dont know why yet [01:34] girafe (~girafe@LFbn-1-11729-221.w2-7.abo.wanadoo.fr) left irc: Ping timeout: 260 seconds [01:40] girafe2 (~girafe@LFbn-1-11729-221.w2-7.abo.wanadoo.fr) left irc: Read error: Connection reset by peer [01:43] Littleboy (~littleboy@c-73-186-252-231.hsd1.ma.comcast.net) left irc: Read error: Connection reset by peer [02:18] m_kiewitz (~m_kiewitz@scummvm/undead/m-kiewitz) left irc: Ping timeout: 268 seconds [02:27] exmensa (~exmensa@66.43.202.238) joined #scummvm. [02:30] exmensa_ (~exmensa@66.43.202.238) left irc: Ping timeout: 260 seconds [02:39] Dominus (~dominus@unaffiliated/dominus) left irc: Ping timeout: 240 seconds [02:40] SylvainTV (~SylvainTV@LFbn-1-8392-241.w81-254.abo.wanadoo.fr) left irc: Read error: Connection reset by peer [02:41] Dominus (~dominus@91-115-167-104.adsl.highway.telekom.at) joined #scummvm. [02:41] Dominus (~dominus@91-115-167-104.adsl.highway.telekom.at) left irc: Changing host [02:41] Dominus (~dominus@unaffiliated/dominus) joined #scummvm. [02:43] Vampire0_ (~Vampire@jEdit/Vampire) joined #scummvm. [02:46] Vampire0 (~Vampire@jEdit/Vampire) left irc: Ping timeout: 260 seconds [03:49] nutron (~nutron@unaffiliated/nutron) left irc: Ping timeout: 260 seconds [03:49] nutron (~nutron@unaffiliated/nutron) joined #scummvm. [04:23] lavosspawn (~lavosspaw@p5DE87CE1.dip0.t-ipconnect.de) left irc: Read error: Connection reset by peer [04:28] lavosspawn (~lavosspaw@p5DE87CE1.dip0.t-ipconnect.de) joined #scummvm. [05:16] dreammaster (~dreammast@c-73-149-116-247.hsd1.ma.comcast.net) left irc: [06:22] GitHub76 (~GitHub76@192.30.252.42) joined #scummvm. [06:22] [scummvm] bgK pushed 3 new commits to master: https://git.io/vykLp [06:22] scummvm/master d991986 Bastien Bouclet: SCI32: Add Lighthouse French checksums [06:22] scummvm/master e9d8711 Bastien Bouclet: SCI32: Add Phantasmagoria 2 French checksums [06:22] scummvm/master c81a61e Bastien Bouclet: SIC32: Add RAMA French checksums [06:22] GitHub76 (GitHub76@192.30.252.42) left #scummvm. [07:05] lavosspawn (~lavosspaw@p5DE87CE1.dip0.t-ipconnect.de) left irc: Ping timeout: 240 seconds [07:21] m_kiewitz (~m_kiewitz@scummvm/undead/m-kiewitz) joined #scummvm. [07:21] #scummvm: mode change '+o m_kiewitz' by ChanServ!ChanServ@services. [07:47] lavosspawn (~lavosspaw@p5DE87CE1.dip0.t-ipconnect.de) joined #scummvm. [07:55] #scummvm: mode change '+o eriktorbjorn' by ChanServ!ChanServ@services. [08:02] Lightkey (~Darklock@p200300764C04544022CF30FFFE083718.dip0.t-ipconnect.de) left irc: Ping timeout: 240 seconds [08:09] LittleToonCat (~littlecat@sydnns0115w-047054148237.dhcp-dynamic.FibreOP.ns.bellaliant.net) left irc: Remote host closed the connection [08:16] Lightkey (~Darklock@p200300764C04548522CF30FFFE083718.dip0.t-ipconnect.de) joined #scummvm. [08:16] jamm (~jam@unaffiliated/jamm) joined #scummvm. [08:20] waltervn (~waltervn@541B2DBA.cm-5-4a.dynamic.ziggo.nl) joined #scummvm. [08:20] #scummvm: mode change '+o waltervn' by ChanServ!ChanServ@services. [08:21] morning [08:21] rootfather (~rootfathe@unaffiliated/rootfather) joined #scummvm. [08:21] #scummvm: mode change '+o rootfather' by ChanServ!ChanServ@services. [08:51] demonimin (~demonimin@unaffiliated/demonimin) left irc: Ping timeout: 240 seconds [08:55] demonimin (~demonimin@unaffiliated/demonimin) joined #scummvm. [09:27] exmensa_ (~exmensa@66.43.202.238) joined #scummvm. [09:28] exmensa (~exmensa@66.43.202.238) left irc: Ping timeout: 260 seconds [09:34] exmensa_ (~exmensa@66.43.202.238) left irc: [09:36] user9 (~Thunderbi@leoseb.ujf-grenoble.fr) left irc: Ping timeout: 260 seconds [09:36] user9 (~Thunderbi@leoseb.ujf-grenoble.fr) joined #scummvm. [11:14] Tomaz^W (~tompsson@84.216.7.40) joined #scummvm. [11:23] Henke37 (~Henrik@81-227-16-59-no133.bredband.skanova.com) joined #scummvm. [11:33] lavosspawn (~lavosspaw@p5DE87CE1.dip0.t-ipconnect.de) left irc: Ping timeout: 240 seconds [11:44] WooShell (~Markus@ipbcc071f7.dynamic.kabel-deutschland.de) joined #scummvm. [11:44] good meowning =^.^= [11:50] exmensa (~exmensa@66.43.202.238) joined #scummvm. [11:52] ajax16384 (~User@109.60.130.33) joined #scummvm. [11:52] #scummvm: mode change '+o ajax16384' by ChanServ!ChanServ@services. [12:08] does anybody see any reason for the static_cast instances in engines/sci/sound/drivers/midi.cpp MidiPlayer_Midi::readMt32DrvData() ? [12:28] SylvainTV (~SylvainTV@LFbn-1-8392-241.w81-254.abo.wanadoo.fr) joined #scummvm. [12:28] #scummvm: mode change '+o SylvainTV' by ChanServ!ChanServ@services. [12:33] m_kiewitz (~m_kiewitz@scummvm/undead/m-kiewitz) left irc: Read error: Connection reset by peer [12:35] m_kiewitz (~m_kiewitz@scummvm/undead/m-kiewitz) joined #scummvm. [12:35] #scummvm: mode change '+o m_kiewitz' by ChanServ!ChanServ@services. [12:38] lavosspawn (~lavosspaw@p5DE87CE1.dip0.t-ipconnect.de) joined #scummvm. [13:23] GitHub197 (~GitHub197@192.30.252.40) joined #scummvm. [13:23] [scummvm] wjp pushed 1 new commit to master: https://git.io/vykBE [13:23] scummvm/master 1b1fae6 Willem Jan Palenstijn: SCI: Clean up unnecessary casts [13:23] GitHub197 (GitHub197@192.30.252.40) left #scummvm. [13:24] GitHub88 (~GitHub88@192.30.252.41) joined #scummvm. [13:24] [scummvm] criezy pushed 2 new commits to master: https://git.io/vykBu [13:24] scummvm/master c15d725 Timo Mikkolainen: I18N: Update translation (Finnish)... [13:24] scummvm/master 9734d51 Lothar Serra Mari: I18N: Update translation (German)... [13:24] GitHub88 (GitHub88@192.30.252.41) left #scummvm. [13:30] waltervn: have you maybe talked to the munt people about this SDL thread size problem? [13:39] hrm, I'm not at all happy with the latest changes to the options dialog [13:42] lavosspawn (~lavosspaw@p5DE87CE1.dip0.t-ipconnect.de) left irc: Ping timeout: 260 seconds [13:58] also, while I'm talking to myself, is there any reason why we don't set Globals.TabWidget.Tab.Width to 0 in the modern theme so that all tabs actually fit without scrolling? [14:03] although it's probably a bit more involved since that also forces a maxwidth [14:16] wjp: I have not. Nothing in MUNT uses SDL though, AFAIK. So I suppose we'd have to approach it from a more general "stack footprint" angle. [14:28] true, although SDL is common enough that they might care [14:37] I'll submit a ticket and see what they say [14:59] wjp: no idea why those casts were there, and I put them in there, so... *shrugs* [15:11] most likely explanation is that I was still adjusting to the switch from C to C++ ;) [15:49] :-) [15:49] it did look like a C thing [15:50] _marc` (~marc@mos6581.de) left irc: Quit: _marc` [15:50] gone now, in any case. I quickly ran the MT32 emu on it and things still seemed ok [15:50] (which was also what triggered the munt query) [15:51] https://sourceforge.net/p/munt/bugs/28/ [15:54] _marc` (~marc@fr3-sbg.mos6581.de) joined #scummvm. [16:04] snover, m_kiewitz: any opinions on what to do with https://github.com/wjp/scummvm/commit/dfca64294106511a3966a1dc3306d47f6363f6a6 ? [16:09] I never came up with a very satisfying idea on what to do with kFileIO. Inside the Chest has a similar problem where it reads more out of a file than can go into the buffer [16:12] in QfG4 we can presumably just script-patch the problem too [16:12] (either by making the string in global 157 larger in script 0 or reducing the maxSize in a few places) [16:13] (in script 54) [16:13] i mean, i guess i feel ok with this patch [16:14] I was also considering making it a warning in case bytesRead <= dest_r.maxSize, and an error otherwise [16:15] (is "Inside the Chest" a fan game?) [16:15] its some bonus thing on the kq collection [16:16] basically like an e-magazine thing [16:16] out of curiosity, which SCI version? [16:16] (roughly) [16:17] ah, I see it's actually on the wiki. So 21middle [16:24] alternative: https://github.com/wjp/scummvm/commit/d5082450426342d6ac0faac06bbb47e593d01a58 [16:27] any idea if SSCI also set the rest of the buffer to 0, or is this something we changed? [16:27] (i.e., the memset in fgets_wrapper) [16:38] doesnt look like it, but i dont know if maybe sci16 did that [16:40] the random sci16 IDB I happened to have open also didn't do it [16:40] (SCI1 mgoose) [16:41] so I guess the situation bytesRead <= dest_r.maxSize < maxSize is fairly harmless [16:41] all these seemingly weird changes in the kFileIO code are a big reason why I dont know what to do, whether they are from earlier SCI, or fix some bug in some game, or are just incorrect [16:44] i wonder why we even compress such files AT ALL [16:46] hm? [16:56] lavosspawn (~lavosspaw@p5DE87CE1.dip0.t-ipconnect.de) joined #scummvm. [16:57] vinayakvivek (uid121616@gateway/web/irccloud.com/x-wmbdkeavdzmvlyfm) joined #scummvm. [16:57] wjp: well, we disabled compression for certain files created with kFileIO [16:58] and I wonder why we even do compression at all for those [17:00] no real relation with ReadString/fgets I suppose, but no, I don't really see much reason to compress them either [17:13] LittleToonCat (~littlecat@sydnns0115w-047054148237.dhcp-dynamic.FibreOP.ns.bellaliant.net) joined #scummvm. [17:17] hmm, i wonder where all the kFileIO code comes wrong [17:17] from FreeSCI? [17:18] from [17:18] not wrong [17:18] lol, but i guess wrong is right as well :P [17:19] i guess some implementation that creates files only after writing was fully completed could make sense [17:21] it took a few iterations until we understood enough to get it right I think [17:21] and I'm not sure we're entirely there yet :-) [17:24] if I understand snover, kFileIO has problems. [17:31] yeah. well, not just kFileIO, but also script authors were just terrible at doing their own IO [17:33] D0SFreak (~D0SFreak@172.98.67.25) joined #scummvm. [17:34] ny00123 (~ny00123@89-139-182-239.bb.netvision.net.il) joined #scummvm. [17:35] _marc` (~marc@fr3-sbg.mos6581.de) left irc: Quit: _marc` [17:35] dreammaster (~dreammast@c-73-149-116-247.hsd1.ma.comcast.net) joined #scummvm. [17:35] #scummvm: mode change '+o dreammaster' by ChanServ!ChanServ@services. [17:37] _marc` (~marc@fr3-sbg.mos6581.de) joined #scummvm. [17:40] jamm (~jam@unaffiliated/jamm) left irc: Ping timeout: 240 seconds [17:53] #scummvm: mode change '+o Strangerke' by ChanServ!ChanServ@services. [18:06] GitHub123 (~GitHub123@192.30.252.41) joined #scummvm. [18:06] [scummvm] wjp opened pull request #911: GUI: Improve tab widget (master...tabs) https://git.io/vyk6F [18:06] GitHub123 (GitHub123@192.30.252.41) left #scummvm. [18:07] GitHub96 (~GitHub96@192.30.252.42) joined #scummvm. [18:07] [scummvm] rsn8887 opened pull request #912: SDL: fix options control tab ordering and labels (master...upstream) https://git.io/vyk6x [18:07] GitHub96 (GitHub96@192.30.252.42) left #scummvm. [18:19] rsn8887: how do I reproduce the problem you are addressing with those kPopUpItemSelectCmd changes? [18:20] RLP__ (~D0SFreak@172.98.67.25) joined #scummvm. [18:21] because I'm not seeing it [18:24] D0SFreak (~D0SFreak@172.98.67.25) left irc: Ping timeout: 268 seconds [18:29] ajax16384 (~User@109.60.130.33) left irc: Read error: Connection reset by peer [18:35] If you remove those changes. If the control tab is the first tab (graphics is second). If you then click on the graphics tab. If you then change to any graphicsmode in the graphicsmode pop up without even clicking apply. Then the reflolayout function is invoked and the graphics tab becomes to first tab. As if the controls tab had vanished. But it didn't t was just moved "one to the left" [18:36] with or without visible tab scroll buttons? [18:40] in any case, the change there is a just a hack around a real problem in reflowLayout [18:40] and it should be fixed in reflowLayout instead [18:40] This is in the hires menu (graphics mode 2x was applied to get them [18:40] presumably it's caused by temporarily changing the active tab in GlobalOptionsDialog::reflowLayout [18:41] With visible tab scroll buttons [18:41] Not quite sure why setting the active tab is necessary there [18:41] Exactly [18:41] I think there is a reason [18:41] ah, because otherwise the sub-widgets aren't available [18:42] so that function should not just restore the active tab, but also _firstVisibleTab [18:43] Yes when the Tempor active tab reaches the first one "off the screen" they will all be shifted this is undesirable [18:43] However first visible tab HAS to change if the screen has become to small to show it in its original position [18:45] As part of reflowlayout. But only then. [18:46] I'm thinking https://github.com/scummvm/scummvm/pull/911/commits/78a2433e6867747053b81938260e582c245437b0 [18:46] My changes are ok because a pop up widget selection can never cause the screen to change that way. But an "apply" action could [18:49] Shouldn't you call setfirstvisible before set active? [18:50] No wait that won't work either [18:50] setActive can change _firstVisible again [18:50] what do you mean 'either'? [18:53] Set active might have a valid reason to change first [18:53] Because active might now be off screen [18:54] In that particular case, a change of first would result in the active tab to move off screen again. This can happen when changing from 400 lines to 200 for example [18:54] but that's exactly what you didn't want to happen [18:54] and in that particular change can't happen inside GlobalOptionsDialog::reflow itself [18:54] s/in// [18:55] Hmm one sec. [18:56] Let's say active is the cloud tab all the way to the right and it is also scrolled so it is all the way at the end. [18:56] Now the resolution is changed and reflowlayout is active [18:56] Then the cloud tab has to be scrolled left to become visible in the new resolution. [18:56] sure [18:57] and that's what happens [18:57] The set active at the end would have taken care of that [18:57] But now we call setfirst AFTER that with the original first (remembered at the higher res) [18:57] well, actually it doesn't [18:58] So that shifts it out of the screen? [18:58] but I'm having trouble believing that was the intended effect of that setActive [18:58] Well if that's not the case than it is fine with me ;) [18:58] if we want to scroll in that case, that should be explicit in tabwidget, not in GlobalOptionsDialog [18:58] Yes it is done in tabwkdget as part of the setactive function [18:59] So whenever set active is called that kind o scrolling is done to ensure it is visible [18:59] no [18:59] try this in the "edit game" dialog for example [18:59] Hmm let me get home to my laptop I am about to smash my phone trying to look at code o. This 6i ch screen [19:00] Will be back in 10 minutes [19:10] wjp: Still here? [19:10] The problematic code in Tab.cpp is this: [19:11] // Also ensure the tab is visible in the tab bar [19:11] if (_firstVisibleTab > tabID) [19:11] _firstVisibleTab = tabID; [19:11] else if (_firstVisibleTab + _w / _tabWidth <= tabID) [19:11] _firstVisibleTab = tabID - _w / _tabWidth + 1; [19:11] at the end of setactive [19:11] it messes with first Visible again [19:12] that's kind of intended [19:12] since that's what you want to happen when clicking on a tab [19:12] try what you described before in the "Edit Game" dialog [19:12] (instead of in "Options") [19:14] Littleboy (~littleboy@c-73-186-252-231.hsd1.ma.comcast.net) joined #scummvm. [19:14] #scummvm: mode change '+o Littleboy' by ChanServ!ChanServ@services. [19:14] Ok seems to work well so you think your change is fine? [19:15] So the reflow is doing this: [19:15] It simulates a "click" on every tab [19:15] which reflow? [19:16] kPopUpItemSelectedCmd [19:16] It calls reflowLayout [19:16] whenever the user *selects* a popup line [19:17] Of course if the scroll icons are visible, those "simulated clicks" move the first visible [19:18] then it "clicks" one last time on the tab that was active before reflowLayout() was called. [19:18] of course that does not guarantee the first visible is what it was before. [19:18] Your change introduces a "reset" of firstvisible before that last "click" [19:18] That should be fine. [19:19] In case of a drastic resolution change. Reflowlayout will also be called to redraw everything. [19:20] and then the setfirstvisible you introduced might be changed again with that last click. [19:20] Yes ok after stating it this way I agree, your change will fix it, and my changes to " case kPopUpItemSelectedCmd:" can then be reverted [19:20] D0SFreak (~D0SFreak@172.98.67.25) joined #scummvm. [19:20] Mia (~Mia@78.162.15.220) joined #scummvm. [19:20] Mia (~Mia@78.162.15.220) left irc: Changing host [19:20] Mia (~Mia@unaffiliated/mia) joined #scummvm. [19:21] Thanks for looking at this. I am new to ScummVM so I am just getting familiar with this stuff. I think I picked up enough details to make meaningful improvements (I have especially handheld ports in mind since that's what I use). [19:22] But I have also heard complaints from RPi users about gamepad control, so I think these changes are important for more users than just handheld. [19:23] indeed; many of us (including me) don't look beyond the desktop often, so that is much appreciated [19:23] RLP__ (~D0SFreak@172.98.67.25) left irc: Ping timeout: 240 seconds [19:24] Great! Will you make the commit? [19:24] by the way, this should fix other some other instances of the first tab(s) disappearing: https://github.com/scummvm/scummvm/pull/911/commits/b01c6363f4d7ad7c600b29edbda6d61cfe88a32e [19:24] lavosspawn (~lavosspaw@p5DE87CE1.dip0.t-ipconnect.de) left irc: Ping timeout: 240 seconds [19:24] these are in PR #911 for feedback [19:26] Looks great from glancing over it! [19:26] I'm trying to see if I can make all tabs different sizes to make more fit on screen [19:27] basically making each tab just large enough to have its title fit [19:27] Ah that would be awesome, too. [19:27] Yes that would be great. [19:27] I made another PR earlier addressing those other comments you had. I agree "Controls" should not be the first tab the user sees. [19:28] I saw it; thanks [19:55] Cpasjuste pulled my additions to the vita branch, so somebody should rebase the vita PR and merge it. It shows conflicts because of my addition of the shader menu, they should be straightforward to merge, but I can help (is there a way I can "propose" a manual merge?) [20:08] GitHub14 (~GitHub14@192.30.252.42) joined #scummvm. [20:08] [scummvm] Strangerke pushed 1 new commit to master: https://git.io/vyk9U [20:08] scummvm/master e12a25c Strangerke: CRYO: Improve syncTapePointers [20:08] GitHub14 (GitHub14@192.30.252.42) left #scummvm. [20:20] RLP__ (~D0SFreak@172.98.67.25) joined #scummvm. [20:24] D0SFreak (~D0SFreak@172.98.67.25) left irc: Ping timeout: 260 seconds [20:24] vinayakvivek (uid121616@gateway/web/irccloud.com/x-wmbdkeavdzmvlyfm) left irc: Quit: Connection closed for inactivity [20:45] ok, I think I have independently sized tabs working [20:46] more or less :-) [20:50] hm, clipped RadioButton drawing isn't quite working. (But that's independent of all of this) [21:04] testing would be very welcome [21:05] of PR #911, that is [21:13] <_sev_> rsn8887: I just replied [21:14] <_sev_> cpasjuste: on how to rebase your psp2 branch [21:14] Nick change: _sev_ -> _sev [21:20] D0SFreak (~D0SFreak@172.98.67.25) joined #scummvm. [21:23] ok, added a few more checks that shrunk rectangles don't become invalid when drawing clipped controls [21:24] RLP__ (~D0SFreak@172.98.67.25) left irc: Ping timeout: 268 seconds [21:24] I hope I can leave the GUI code alone for a while again now :-) [21:34] GitHub59 (~GitHub59@192.30.252.40) joined #scummvm. [21:34] [scummvm] sev- pushed 1 new commit to master: https://git.io/vyk5I [21:34] scummvm/master 2168ac1 Eugene Sandulenko: CRYO: Fix warning [21:34] GitHub59 (GitHub59@192.30.252.40) left #scummvm. [21:38] oh, pesky [21:38] nice catch [21:38] I guess that IDXOUT should maybe have a do { } while(0) around it [21:41] Harekiet (~harekiet@kittens.harekiet.com) left irc: Read error: Connection reset by peer [21:41] I also get the feeling the second half of those functions using IDXOUT were thinking of using OFSIN [21:42] exmensa_ (~exmensa@66.43.202.238) joined #scummvm. [21:43] exmensa (~exmensa@66.43.202.238) left irc: Ping timeout: 255 seconds [21:43] Harekiet (~harekiet@kittens.harekiet.com) joined #scummvm. [21:45] GitHub158 (~GitHub158@192.30.252.45) joined #scummvm. [21:45] [scummvm] wjp pushed 1 new commit to master: https://git.io/vyk5o [21:45] scummvm/master a8cbc03 Willem Jan Palenstijn: CRYO: Improve macro safety [21:45] GitHub158 (GitHub158@192.30.252.45) left #scummvm. [22:07] ny00123 (~ny00123@89-139-182-239.bb.netvision.net.il) left irc: Quit: Leaving [22:08] GitHub150 (~GitHub150@192.30.252.42) joined #scummvm. [22:08] [scummvm] sev- pushed 2 new commits to master: https://git.io/vykdS [22:08] scummvm/master f47602f Eugene Sandulenko: DIRECTOR: More debug output on image rendering [22:08] scummvm/master 3798599 Eugene Sandulenko: DIRECTOR: Fix rendering of shapes of type 16 [22:08] GitHub150 (GitHub150@192.30.252.42) left #scummvm. [22:09] exmensa (~exmensa@66.43.202.238) joined #scummvm. [22:11] exmensa_ (~exmensa@66.43.202.238) left irc: Ping timeout: 260 seconds [22:20] RLP__ (~D0SFreak@172.98.67.25) joined #scummvm. [22:24] D0SFreak (~D0SFreak@172.98.67.25) left irc: Ping timeout: 268 seconds [22:26] GitHub196 (~GitHub196@192.30.252.34) joined #scummvm. [22:26] [scummvm] dreammaster pushed 1 new commit to master: https://git.io/vykFF [22:26] scummvm/master 5610eef Paul Gilbert: TITANIC: More implementation of CSurfaceAream, added FRect class [22:26] GitHub196 (GitHub196@192.30.252.34) left #scummvm. [22:28] hum. ive lost my mouse cursor in this game and i cant figure out how to get it back. [22:28] exmensa_ (~exmensa@66.43.202.238) joined #scummvm. [22:29] Can you do a bisect? [22:29] no, i mean, the game hid the mouse cursor and didnt give it back :) [22:29] Ah. One of those kinds of problems. :P [22:29] i finally just figured out how to get it back [22:30] not sure why it was still hidden. bugs! [22:30] exmensa (~exmensa@66.43.202.238) left irc: Ping timeout: 255 seconds [22:30] Ah good. Hopefully it won't be too hard to figure out why the game didn't re-enable it when it should [22:31] kurtwr2 (~kurtwr@c-50-173-166-91.hsd1.ca.comcast.net) left irc: Read error: Connection reset by peer [22:32] i hope so. these remaining bugs are pretty obtuse. [22:32] kurtwr (~kurtwr@c-50-173-166-91.hsd1.ca.comcast.net) joined #scummvm. [22:37] I can sympathize. Now that I'm finally dealing with the final starfield puzzle, it's coming back why I was so pessimistic about it originally.. sooooo much floating point calculations [22:38] And half of them are twisted sets of juggling values on the FPU stack, storing and retrieving values from temporary fields. It's all a real mess [22:38] something that hex-rays can make sense of? [22:43] Well, it has been a little helpful - Sev generated a copy for me a while back. Unfortunately, the methods where I really need it tend to be the really big ones, and they're the ones Hexrays has the most trouble with [22:45] It ends up with about a hundred temporary variables, and a whole mess of GOTOs. Plus, I've already identified some cases where it got stuff completely mixed up, so I've had to treat it, unfortunately, as only maybe correct [22:54] sorry. that sounds like a way worse problem than the ones i have :) [22:58] Well, all I can do is try and plow ahead. Once I've got an implementation for everything, I'll just have to hope that my implementation doesn't need too much fixing [23:05] waltervn (~waltervn@541B2DBA.cm-5-4a.dynamic.ziggo.nl) left irc: Quit: Leaving [23:20] D0SFreak (~D0SFreak@172.98.67.25) joined #scummvm. [23:24] RLP__ (~D0SFreak@172.98.67.25) left irc: Ping timeout: 260 seconds [23:38] D0SFreak (~D0SFreak@172.98.67.25) left irc: Ping timeout: 268 seconds [23:41] D0SFreak (~D0SFreak@172.98.67.25) joined #scummvm. [23:59] nutron (~nutron@unaffiliated/nutron) left irc: Remote host closed the connection [23:59] nutron (~nutron@unaffiliated/nutron) joined #scummvm. [00:00] --- Mon Feb 27 2017