[00:16] GitHub76 (GitHub76@gateway/service/github.com/x-djmdqkwhovccdldx) joined #scummvm. [00:16] [scummvm] dreammaster pushed 1 new commit to master: https://git.io/vpsHC [00:16] scummvm/master 00af6a9 Paul Gilbert: XEEN: Fix Swords Greyhaven guild spell list [00:16] GitHub76 (GitHub76@gateway/service/github.com/x-djmdqkwhovccdldx) left #scummvm. [01:12] SylvainTV (~Sylvain@LFbn-LIL-1-312-132.w81-49.abo.wanadoo.fr) left irc: Read error: Connection reset by peer [01:30] rootfather_ (~rootfathe@p2E52665D.dip0.t-ipconnect.de) joined #scummvm. [01:32] rootfather (~rootfathe@unaffiliated/rootfather) left irc: Ping timeout: 256 seconds [01:36] DominusExult (~dominus@unaffiliated/dominus) joined #scummvm. [01:40] Dominus (~dominus@unaffiliated/dominus) left irc: Ping timeout: 260 seconds [01:40] Nick change: DominusExult -> Dominus [01:51] Joefish (~Joefish@p200300764F0E3900B4D782763358F413.dip0.t-ipconnect.de) left irc: Ping timeout: 276 seconds [01:51] Joefish (~Joefish@p200300764F18B500095F15AE4B174B00.dip0.t-ipconnect.de) joined #scummvm. [01:51] #scummvm: mode change '+v Joefish' by ChanServ!ChanServ@services. [02:37] dreammaster (~dreammast@c-73-149-116-247.hsd1.vt.comcast.net) left irc: [02:42] klusark (~klusark@S01066c3b6b1953d0.vc.shawcable.net) joined #scummvm. [04:44] Drenn (~Drenn@toroon0713w-lp140-01-67-70-13-127.dsl.bell.ca) left irc: Ping timeout: 248 seconds [04:55] _sev (~sev@d158167.upc-d.chello.nl) joined #scummvm. [04:55] _sev (~sev@d158167.upc-d.chello.nl) left irc: Changing host [04:55] _sev (~sev@scummvm/undead/sev) joined #scummvm. [04:55] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services. [04:58] stroggoff (~Praetoria@athedsl-16175.home.otenet.gr) joined #scummvm. [05:39] ced117 (~ced117@opensuse/member/ced117) left irc: Ping timeout: 256 seconds [05:40] ced117 (~ced117@opensuse/member/ced117) joined #scummvm. [05:43] Deledrius (~Deledrius@68.118.139.214) left irc: Quit: App.Exit [05:51] segra (~segra@119.81.159.208) joined #scummvm. [05:51] #scummvm: mode change '+b segra!*@*' by ChanServ!ChanServ@services. [05:51] segra kicked from #scummvm by ChanServ: Banned: You*know*better*than*to*encourage*piracy*in*here.*Tempkick,*2*days. [05:54] Deledrius (~Deledrius@68.118.139.214) joined #scummvm. [06:15] ST (~ScottT@119-18-4-180.cust.aussiebb.net) left irc: Ping timeout: 248 seconds [06:20] ST (~ScottT@119-18-4-180.cust.aussiebb.net) joined #scummvm. [06:20] #scummvm: mode change '+o ST' by ChanServ!ChanServ@services. [06:40] ced117 (~ced117@opensuse/member/ced117) left irc: Ping timeout: 264 seconds [06:51] Strangerke (~Strangerk@cable-85.28.84.13.coditel.net) left irc: Ping timeout: 260 seconds [08:09] criezy|Work (a5e15055@gateway/web/freenode/ip.165.225.80.85) joined #scummvm. [08:09] #scummvm: mode change '+o criezy|Work' by ChanServ!ChanServ@services. [08:15] morganw (~morganw@88.144.28.81) joined #scummvm. [08:25] LittleToonCat (~littlecat@142.162.196.136) left irc: Read error: Connection reset by peer [08:28] klusark (~klusark@S01066c3b6b1953d0.vc.shawcable.net) left irc: Ping timeout: 276 seconds [08:36] Lightkey (~Darklock@p200300F693D1375122CF30FFFE083718.dip0.t-ipconnect.de) left irc: Ping timeout: 276 seconds [08:48] Lightkey (~Darklock@p200300F693D1370322CF30FFFE083718.dip0.t-ipconnect.de) joined #scummvm. [08:51] Polynomial-C (~Poly-C@gentoo/developer/Polynomial-C) left irc: Remote host closed the connection [08:58] hi guys [09:05] hey Strangerke|work [09:09] _sev|work (~sev@5.57.21.50) joined #scummvm. [09:09] _sev|work (~sev@5.57.21.50) left irc: Changing host [09:09] _sev|work (~sev@scummvm/undead/sev) joined #scummvm. [09:09] #scummvm: mode change '+o _sev|work' by ChanServ!ChanServ@services. [09:29] TMM (~Hein-Piet@185.5.121.222) joined #scummvm. [09:29] TMM (~Hein-Piet@185.5.121.222) left irc: Changing host [09:29] TMM (~Hein-Piet@fsf/member/pdpc.professional.tmm) joined #scummvm. [09:29] #scummvm: mode change '+o TMM' by ChanServ!ChanServ@services. [09:39] Nick change: rootfather_ -> rootfather [09:39] rootfather (~rootfathe@p2E52665D.dip0.t-ipconnect.de) left irc: Changing host [09:39] rootfather (~rootfathe@unaffiliated/rootfather) joined #scummvm. [09:39] #scummvm: mode change '+o rootfather' by ChanServ!ChanServ@services. [09:39] gooood morning everypony! [09:40] Congratulations and a huge "Thank you!" to our GSoC students :) [09:42] morning rootfather and _thank you_ and the team for giving us this great opportunity! :) [09:47] Good morning rootfather [09:47] (and everybody else) [10:31] Joefish (~Joefish@p200300764F18B500095F15AE4B174B00.dip0.t-ipconnect.de) left irc: Ping timeout: 255 seconds [10:54] jamm (~jam@unaffiliated/jamm) joined #scummvm. [11:04] _sev|work (~sev@scummvm/undead/sev) left irc: Quit: This computer has gone to sleep [11:38] vzahradn (~vzahradn@85.159.107.86) joined #scummvm. [11:40] vzahradn (~vzahradn@85.159.107.86) left irc: Client Quit [11:43] ccawley2011 (56804d80@gateway/web/freenode/ip.86.128.77.128) joined #scummvm. [11:55] _sev|work (~sev@5.57.21.50) joined #scummvm. [11:55] _sev|work (~sev@5.57.21.50) left irc: Changing host [11:55] _sev|work (~sev@scummvm/undead/sev) joined #scummvm. [11:55] #scummvm: mode change '+o _sev|work' by ChanServ!ChanServ@services. [12:27] _sev|work (~sev@scummvm/undead/sev) left irc: Quit: This computer has gone to sleep [12:55] ccawley2011 (56804d80@gateway/web/freenode/ip.86.128.77.128) left irc: Ping timeout: 260 seconds [12:59] ccawley2011 (56804d80@gateway/web/freenode/ip.86.128.77.128) joined #scummvm. [13:01] _sev|work (~sev@5.57.21.50) joined #scummvm. [13:01] _sev|work (~sev@5.57.21.50) left irc: Changing host [13:01] _sev|work (~sev@scummvm/undead/sev) joined #scummvm. [13:01] #scummvm: mode change '+o _sev|work' by ChanServ!ChanServ@services. [13:28] Littleboy (~littleboy@pool-173-76-38-11.bstnma.fios.verizon.net) joined #scummvm. [13:28] #scummvm: mode change '+o Littleboy' by ChanServ!ChanServ@services. [13:35] ccawley2011 (56804d80@gateway/web/freenode/ip.86.128.77.128) left irc: Ping timeout: 260 seconds [13:35] jamm (~jam@unaffiliated/jamm) left irc: Ping timeout: 264 seconds [13:38] _sev_ (~sev@scummvm/undead/sev) joined #scummvm. [13:38] #scummvm: mode change '+o _sev_' by ChanServ!ChanServ@services. [13:39] ccawley2011 (56804d80@gateway/web/freenode/ip.86.128.77.128) joined #scummvm. [13:39] _sev (~sev@scummvm/undead/sev) left irc: Ping timeout: 265 seconds [13:48] Simei (sid230101@gateway/web/irccloud.com/x-avkhifmmxhyawkhd) left irc: [13:48] Simei (sid230101@gateway/web/irccloud.com/x-qxgxnlsqttmkbjvo) joined #scummvm. [13:54] _sev|work (~sev@scummvm/undead/sev) left irc: Quit: This computer has gone to sleep [13:57] Mellified (sid234533@gateway/web/irccloud.com/x-jdeaiuklosoggoqz) left irc: [13:57] Mellified (sid234533@gateway/web/irccloud.com/x-yjdjkmfifxzxbwap) joined #scummvm. [13:57] ccawley2011 (56804d80@gateway/web/freenode/ip.86.128.77.128) left irc: Ping timeout: 260 seconds [14:19] Joefish (~Joefish@p200300764F18B500095F15AE4B174B00.dip0.t-ipconnect.de) joined #scummvm. [14:19] #scummvm: mode change '+v Joefish' by ChanServ!ChanServ@services. [14:28] ccawley2011 (56804d80@gateway/web/freenode/ip.86.128.77.128) joined #scummvm. [14:35] ccawley2011 (56804d80@gateway/web/freenode/ip.86.128.77.128) left irc: Ping timeout: 260 seconds [14:38] Drenn (~Drenn@toroon0713w-lp130-04-69-158-58-2.dsl.bell.ca) joined #scummvm. [14:42] hm... this use_unknown_dialog gives me headaches [14:43] everything seems to fall apart o.O [14:45] ced117 (~ced117@opensuse/member/ced117) joined #scummvm. [14:49] at least it breaks the scumm engine without touching base/plugins* [15:03] waltervn (~waltervn@2001:1c03:1e0a:7200:a4f6:ec33:1c48:c06c) joined #scummvm. [15:03] #scummvm: mode change '+o waltervn' by ChanServ!ChanServ@services. [15:13] waltervn (~waltervn@2001:1c03:1e0a:7200:a4f6:ec33:1c48:c06c) left irc: Ping timeout: 255 seconds [15:21] waltervn (~waltervn@2001:1c03:1e0a:7200:79ff:7d77:392a:c2fb) joined #scummvm. [15:21] #scummvm: mode change '+o waltervn' by ChanServ!ChanServ@services. [15:27] t0by (~t0by@unaffiliated/t0by) joined #scummvm. [15:27] #scummvm: mode change '+o t0by' by ChanServ!ChanServ@services. [15:33] jamm (~jam@fp76f08856.tkyc113.ap.nuro.jp) joined #scummvm. [15:33] jamm (~jam@fp76f08856.tkyc113.ap.nuro.jp) left irc: Changing host [15:33] jamm (~jam@unaffiliated/jamm) joined #scummvm. [15:40] and it seems that passing the value at this line doesn't work :/ [15:42] _sev|work (~sev@scummvm/undead/sev) joined #scummvm. [15:42] #scummvm: mode change '+o _sev|work' by ChanServ!ChanServ@services. [15:48] _sev|work, I don't think https://github.com/scummvm/scummvm/blob/master/gui/launcher.cpp#L576 is the right line to pass the use_unknown_dialog parameter... [15:49] I tried this and no matter if I did mass add or normal add, the dialog always pops up [15:49] + it requires fiddeling with base/plugins and in the scumm engine to not fall apart [15:50] <_sev|work> rootfather: then I need to take a closer look. Because similar request is in massadd.cpp file, which made me coming to conclusion that this is the place [15:50] <_sev|work> also, you should launch the dialog only when there is only one target, I think. And not multiple [15:50] <_sev|work> target = candidate [15:50] _sev|work (~sev@scummvm/undead/sev) left irc: Quit: This computer has gone to sleep [15:50] I suspect that the Mass Add button is simply referring to https://github.com/scummvm/scummvm/blob/master/gui/launcher.cpp#L576 too [15:52] regarding showing the dialog only if theres not more than one candidate, I think this can be done as soon as I find where the advancedDetector stores the number of available candidates [15:56] From a quick look it seems like it should be OK to pass the use_unknown_dialog parameter at this place. [15:56] The Mass Add dialog has its own call to EngineMan.detectGames() and I don't think it will go through the line you point to. [15:58] and is it normal that I have to fiddle with the base/plugins* system? [15:58] I have the feeling that something is going wrong here ^^ [15:58] oh and it currently breaks the scumm detection as well [16:00] ny00123 (~ny00123@141.226.9.44) joined #scummvm. [16:01] let me try this from scratch with live commentary :D [16:01] If you change the signature of a virtual function (such as adding a parameter to it), then you need to do the change in the base class and derived classes as well. [16:02] So in the case of detectGames that means changing it in MetaEngine, AdvancedMetaEngine, and all the other classes that derive from MetaEngine. [16:08] mh okay [16:14] ccawley2011 (56804d80@gateway/web/freenode/ip.86.128.77.128) joined #scummvm. [16:21] somehow GameList candidates(EngineMan.detectGames(files, true)); doesn't work properly, the dialog is never shown... [16:21] TMM (~Hein-Piet@fsf/member/pdpc.professional.tmm) left irc: Quit: Ex-Chat [16:22] so somehow this doesn't get passed to ReportUnknown [16:22] Drenn (~Drenn@toroon0713w-lp130-04-69-158-58-2.dsl.bell.ca) left irc: Quit: Leaving [16:24] I think I have to manually pass the value from detectGames() to reportUnknown() [16:24] Yes you do. [16:24] How else would it be passed? [16:25] the issue is that at least I think I did this already [16:26] If you get stuck and need help, it would be good to post your code somewhere as we can't really know what is wrong without knowing what you did. [16:34] https://pastebin.com/ZKn42JWh [16:34] this is a diff of what I did so far [16:34] and I somehow have the impression I'm missing something important [16:35] GitHub198 (GitHub198@gateway/service/github.com/x-gxyxwdpblnpxrzks) joined #scummvm. [16:35] [scummvm] ccawley2011 opened pull request #1166: README: Clean up formatting; fix broken links (master...readme-fix) https://git.io/vpZBx [16:35] GitHub198 (GitHub198@gateway/service/github.com/x-gxyxwdpblnpxrzks) left #scummvm. [16:39] rootfather: I have not gone very far, but there is already an issue with the change in base/plugins.cpp [16:39] In GameList EngineManager::detectGames(const Common::FSList &fslist, bool use_unknown_dialog), you need to pass the use_unknown_dialog to the call to detectGames that is a few lines below in that function. [16:42] jamm (~jam@unaffiliated/jamm) left irc: Ping timeout: 248 seconds [16:43] Also it looks like in AdvancedMetaEngine::detectGames you do nothing with the use_unknown_dialog variable, and in particular do not pass it to reportUnknown(). [16:45] It looks like there is a missing step actually as detectGames() does not call directly reportUnknown() but calls detectGame() which itself calls reportUnknown. [16:45] yep I was searching for the reportUnknown() call too... [16:45] hm [16:45] So you need to add the variable to detectGame as well, and pass it to it from detectGames. Then in detectGame pass it to reportUnknow. [16:47] lol I haven't even noticed that there's detectGame() as I was only focused on detectGames() and reportUnknown() [16:54] Stormkeeper (~kvirc@2.30.139.196) left irc: Read error: Connection reset by peer [16:56] LittleToonCat (~littlecat@142.162.196.136) joined #scummvm. [17:01] waltervn (~waltervn@2001:1c03:1e0a:7200:79ff:7d77:392a:c2fb) left irc: Read error: Connection reset by peer [17:04] morganw (~morganw@88.144.28.81) left irc: Quit: morganw [17:06] Farmboy0 (~quassel@p5DD10CA7.dip0.t-ipconnect.de) joined #scummvm. [17:06] Farmboy0 (~quassel@p5DD10CA7.dip0.t-ipconnect.de) left irc: Changing host [17:06] Farmboy0 (~quassel@xoreos/farmboy0) joined #scummvm. [17:07] yes I got it [17:07] now I have to unbreak the scumm engine [17:14] criezy|Work (a5e15055@gateway/web/freenode/ip.165.225.80.85) left irc: Quit: Page closed [17:18] don't forget that useUnknownDialog should be inCamelCase [17:18] hi btw :) [17:21] the variable? [17:21] yes [17:21] fuck :D [17:21] or to be more precise - praise the Lord for Notepad++'s find-and-replace-in-files-function [17:22] or Don Ho [17:22] :D [17:24] nooo the SKY engine is relying on a different detector too :/ [17:28] and sword too... [17:28] waltervn (~waltervn@2001:1c03:1e0a:7200:318b:5d25:116c:251f) joined #scummvm. [17:28] #scummvm: mode change '+o waltervn' by ChanServ!ChanServ@services. [17:32] ajax16384 (~User@109.60.130.33) joined #scummvm. [17:32] #scummvm: mode change '+o ajax16384' by ChanServ!ChanServ@services. [17:36] hm is touching a number of engines a good idea just to solve this? :D [17:53] girafe (~girafe@LFbn-LYO-1-449-251.w2-7.abo.wanadoo.fr) joined #scummvm. [17:58] criezy (~criezy@host109-146-139-127.range109-146.btcentralplus.com) joined #scummvm. [17:58] #scummvm: mode change '+o criezy' by ChanServ!ChanServ@services. [18:05] Strangerke (~Strangerk@cable-85.28.84.13.coditel.net) joined #scummvm. [18:07] rootfather (~rootfathe@unaffiliated/rootfather) left irc: [18:13] rootfather (~rootfathe@p5787AB91.dip0.t-ipconnect.de) joined #scummvm. [18:13] rootfather (~rootfathe@p5787AB91.dip0.t-ipconnect.de) left irc: Changing host [18:13] rootfather (~rootfathe@unaffiliated/rootfather) joined #scummvm. [18:13] #scummvm: mode change '+o rootfather' by ChanServ!ChanServ@services. [18:13] GitHub190 (GitHub190@gateway/service/github.com/x-hyjjwstcucygbkvw) joined #scummvm. [18:13] [scummvm] bgK pushed 1 new commit to master: https://git.io/vpZoL [18:13] scummvm/master c1a12c2 Bastien Bouclet: MOHAWK: MYST: Redraw the tower angle line after the rotation completes... [18:13] GitHub190 (GitHub190@gateway/service/github.com/x-hyjjwstcucygbkvw) left #scummvm. [18:14] SylvainTV (~Sylvain@LFbn-LIL-1-312-132.w81-49.abo.wanadoo.fr) joined #scummvm. [18:14] #scummvm: mode change '+o SylvainTV' by ChanServ!ChanServ@services. [18:34] criezy, would you review the changes I made to the scumm,sword1,sword2 and sky detectors/engines to fix compilation? [18:34] I really don't like that I had to touch the engines itself, just feels weird [18:34] weird as in "small change, huge impact" :D [18:41] e.g. I had to add the new variable even to AdvancedMetaEngine::createInstance o.O [18:46] and I have the impression that the mass add feature now is way slower when scanning directories :/ [18:46] I hope I haven't started instanciating an engine whenever the detector hits *any* file [18:50] rootfather: is your code available somewhere? [18:51] https://pastebin.com/VtB3ZqVF [18:52] if you prefer I can put it in a seperate branch, just don't want to commit something potentially broken to the PR branch [18:56] That's OK. I got your branch locally and applied the diff on top. [19:01] Don't modify the createInstance to add the flag. [19:02] The only case where we want to show the dialog is when calling detectGames from the launcher with the Add button. [19:02] Some from everywhere else it should just be false, which is the default. So you don't even have to change the other calls to detectGames. [19:02] I can do a cleanup now and post a diff if you want. [19:05] that would be great [19:05] the issue is that the "non-advancedDetector" threw tons of errors without modifiying createInstance [19:06] and suddenly, the advancedDetector enabled engines started doing this too [19:06] so somewhere I must have done a slight overshoot [19:24] rootfather: OK. I have got it cleaned up, but I suspect you broke detection for some engines so I will look at that after dinner. [19:24] thanks [19:24] and oh shit [19:25] In the meantime you can try this if you want: https://pastebin.com/r45V9i1J [19:25] It compiles but I have not checked that it works. [19:25] The diff applies to the head your your PR branch [19:28] OK, the only one that looks like it might be broken is ADL. [19:28] Maybe you could grab Mystery House from our donwload page (if you don't already have it) and check. [19:29] And now my dinner should be ready :-) [19:30] hm "git apply" throws an error for line 234 [19:35] ah, line endings I guess [19:48] ok got the patch applied [20:13] ajax16384 (~User@109.60.130.33) left irc: Read error: Connection reset by peer [20:22] okay, the dialog gets shown if I use Add Game and doesn't appear when I do a mass add [20:22] however, as you described, ADL detection is broken and MYSTHOUSE.DSK from the website is not detected. [20:23] Add the bool to the detectGame function in engines/adl/detection.cpp [20:23] That should fix it. [20:28] TMM (~Hein-Piet@5ED0D43B.cm-7-1d.dynamic.ziggo.nl) joined #scummvm. [20:28] TMM (~Hein-Piet@5ED0D43B.cm-7-1d.dynamic.ziggo.nl) left irc: Changing host [20:28] TMM (~Hein-Piet@fsf/member/pdpc.professional.tmm) joined #scummvm. [20:28] #scummvm: mode change '+o TMM' by ChanServ!ChanServ@services. [20:43] criezy, yep, that works [20:53] GitHub135 (GitHub135@gateway/service/github.com/x-loaumgszvdcrqosv) joined #scummvm. [20:53] [scummvm] bonki closed pull request #984: BASE: Code formatting cleanup pass of base (master...aidan/cleanup) https://git.io/v7iDy [20:53] GitHub135 (GitHub135@gateway/service/github.com/x-loaumgszvdcrqosv) left #scummvm. [20:54] will do more testing tomorrow [20:54] cu then [20:59] criezy (~criezy@host109-146-139-127.range109-146.btcentralplus.com) left irc: Quit: criezy [21:40] Drenn (~Drenn@toroon0713w-lp130-04-69-158-58-2.dsl.bell.ca) joined #scummvm. [22:32] Farmboy0 (~quassel@xoreos/farmboy0) left irc: Remote host closed the connection [22:43] ny00123 (~ny00123@141.226.9.44) left irc: Remote host closed the connection [22:43] stroggoff (~Praetoria@athedsl-16175.home.otenet.gr) left irc: Quit: Leaving [22:59] girafe (~girafe@LFbn-LYO-1-449-251.w2-7.abo.wanadoo.fr) left irc: Read error: Connection reset by peer [23:19] TMM (~Hein-Piet@fsf/member/pdpc.professional.tmm) left irc: Remote host closed the connection [23:52] t0by (~t0by@unaffiliated/t0by) left irc: Remote host closed the connection [23:56] waltervn (~waltervn@2001:1c03:1e0a:7200:318b:5d25:116c:251f) left irc: Quit: Leaving [00:00] --- Wed Apr 25 2018