ScummVM IRC Log - 24 Apr 2018

[Back to Index]

[00:16] --> GitHub76 joined #scummvm.
[00:16] <GitHub76> [scummvm] dreammaster pushed 1 new commit to master: https://git.io/vpsHC
[00:16] <GitHub76> scummvm/master 00af6a9 Paul Gilbert: XEEN: Fix Swords Greyhaven guild spell list
[00:16] GitHub76 (GitHub76@gateway/service/github.com/x-djmdqkwhovccdldx) left #scummvm.
[01:12] <-- SylvainTV left irc: Read error: Connection reset by peer
[01:30] --> rootfather_ joined #scummvm.
[01:32] <-- rootfather left irc: Ping timeout: 256 seconds
[01:36] --> DominusExult joined #scummvm.
[01:40] <-- Dominus left irc: Ping timeout: 260 seconds
[01:40] Nick change: DominusExult -> Dominus
[01:51] <-- Joefish left irc: Ping timeout: 276 seconds
[01:51] --> Joefish joined #scummvm.
[01:51] #scummvm: mode change '+v Joefish' by ChanServ!ChanServ@services.
[02:37] <-- dreammaster left irc:
[02:42] --> klusark joined #scummvm.
[04:44] <-- Drenn left irc: Ping timeout: 248 seconds
[04:55] --> _sev joined #scummvm.
[04:55] <-- _sev left irc: Changing host
[04:55] --> _sev joined #scummvm.
[04:55] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[04:58] --> stroggoff joined #scummvm.
[05:39] <-- ced117 left irc: Ping timeout: 256 seconds
[05:40] --> ced117 joined #scummvm.
[05:43] <-- Deledrius left irc: Quit: App.Exit
[05:51] --> segra joined #scummvm.
[05:51] #scummvm: mode change '+b segra!*@*' by ChanServ!ChanServ@services.
[05:51] segra kicked from #scummvm by ChanServ: Banned: You*know*better*than*to*encourage*piracy*in*here.*Tempkick,*2*days.
[05:54] --> Deledrius joined #scummvm.
[06:15] <-- ST left irc: Ping timeout: 248 seconds
[06:20] --> ST joined #scummvm.
[06:20] #scummvm: mode change '+o ST' by ChanServ!ChanServ@services.
[06:40] <-- ced117 left irc: Ping timeout: 264 seconds
[06:51] <-- Strangerke left irc: Ping timeout: 260 seconds
[08:09] --> criezy|Work joined #scummvm.
[08:09] #scummvm: mode change '+o criezy|Work' by ChanServ!ChanServ@services.
[08:15] --> morganw joined #scummvm.
[08:25] <-- LittleToonCat left irc: Read error: Connection reset by peer
[08:28] <-- klusark left irc: Ping timeout: 276 seconds
[08:36] <-- Lightkey left irc: Ping timeout: 276 seconds
[08:48] --> Lightkey joined #scummvm.
[08:51] <-- Polynomial-C left irc: Remote host closed the connection
[08:58] <Strangerke|work> hi guys
[09:05] <Joefish> hey Strangerke|work
[09:09] --> _sev|work joined #scummvm.
[09:09] <-- _sev|work left irc: Changing host
[09:09] --> _sev|work joined #scummvm.
[09:09] #scummvm: mode change '+o _sev|work' by ChanServ!ChanServ@services.
[09:29] --> TMM joined #scummvm.
[09:29] <-- TMM left irc: Changing host
[09:29] --> TMM joined #scummvm.
[09:29] #scummvm: mode change '+o TMM' by ChanServ!ChanServ@services.
[09:39] Nick change: rootfather_ -> rootfather
[09:39] <-- rootfather left irc: Changing host
[09:39] --> rootfather joined #scummvm.
[09:39] #scummvm: mode change '+o rootfather' by ChanServ!ChanServ@services.
[09:39] <rootfather> gooood morning everypony!
[09:40] <rootfather> Congratulations and a huge "Thank you!" to our GSoC students :)
[09:42] <Joefish> morning rootfather and _thank you_ and the team for giving us this great opportunity! :)
[09:47] <criezy|Work> Good morning rootfather
[09:47] <criezy|Work> (and everybody else)
[10:31] <-- Joefish left irc: Ping timeout: 255 seconds
[10:54] --> jamm joined #scummvm.
[11:04] <-- _sev|work left irc: Quit: This computer has gone to sleep
[11:38] --> vzahradn joined #scummvm.
[11:40] <-- vzahradn left irc: Client Quit
[11:43] --> ccawley2011 joined #scummvm.
[11:55] --> _sev|work joined #scummvm.
[11:55] <-- _sev|work left irc: Changing host
[11:55] --> _sev|work joined #scummvm.
[11:55] #scummvm: mode change '+o _sev|work' by ChanServ!ChanServ@services.
[12:27] <-- _sev|work left irc: Quit: This computer has gone to sleep
[12:55] <-- ccawley2011 left irc: Ping timeout: 260 seconds
[12:59] --> ccawley2011 joined #scummvm.
[13:01] --> _sev|work joined #scummvm.
[13:01] <-- _sev|work left irc: Changing host
[13:01] --> _sev|work joined #scummvm.
[13:01] #scummvm: mode change '+o _sev|work' by ChanServ!ChanServ@services.
[13:28] --> Littleboy joined #scummvm.
[13:28] #scummvm: mode change '+o Littleboy' by ChanServ!ChanServ@services.
[13:35] <-- ccawley2011 left irc: Ping timeout: 260 seconds
[13:35] <-- jamm left irc: Ping timeout: 264 seconds
[13:38] --> _sev_ joined #scummvm.
[13:38] #scummvm: mode change '+o _sev_' by ChanServ!ChanServ@services.
[13:39] --> ccawley2011 joined #scummvm.
[13:39] <-- _sev left irc: Ping timeout: 265 seconds
[13:48] <-- Simei left irc:
[13:48] --> Simei joined #scummvm.
[13:54] <-- _sev|work left irc: Quit: This computer has gone to sleep
[13:57] <-- Mellified left irc:
[13:57] --> Mellified joined #scummvm.
[13:57] <-- ccawley2011 left irc: Ping timeout: 260 seconds
[14:19] --> Joefish joined #scummvm.
[14:19] #scummvm: mode change '+v Joefish' by ChanServ!ChanServ@services.
[14:28] --> ccawley2011 joined #scummvm.
[14:35] <-- ccawley2011 left irc: Ping timeout: 260 seconds
[14:38] --> Drenn joined #scummvm.
[14:42] <rootfather> hm... this use_unknown_dialog gives me headaches
[14:43] <rootfather> everything seems to fall apart o.O
[14:45] --> ced117 joined #scummvm.
[14:49] <rootfather> at least it breaks the scumm engine without touching base/plugins*
[15:03] --> waltervn joined #scummvm.
[15:03] #scummvm: mode change '+o waltervn' by ChanServ!ChanServ@services.
[15:13] <-- waltervn left irc: Ping timeout: 255 seconds
[15:21] --> waltervn joined #scummvm.
[15:21] #scummvm: mode change '+o waltervn' by ChanServ!ChanServ@services.
[15:27] --> t0by joined #scummvm.
[15:27] #scummvm: mode change '+o t0by' by ChanServ!ChanServ@services.
[15:33] --> jamm joined #scummvm.
[15:33] <-- jamm left irc: Changing host
[15:33] --> jamm joined #scummvm.
[15:40] <rootfather> and it seems that passing the value at this line doesn't work :/
[15:42] --> _sev|work joined #scummvm.
[15:42] #scummvm: mode change '+o _sev|work' by ChanServ!ChanServ@services.
[15:48] <rootfather> _sev|work, I don't think https://github.com/scummvm/scummvm/blob/master/gui/launcher.cpp#L576 is the right line to pass the use_unknown_dialog parameter...
[15:49] <rootfather> I tried this and no matter if I did mass add or normal add, the dialog always pops up
[15:49] <rootfather> + it requires fiddeling with base/plugins and in the scumm engine to not fall apart
[15:50] <_sev|work> rootfather: then I need to take a closer look. Because similar request is in massadd.cpp file, which made me coming to conclusion that this is the place
[15:50] <_sev|work> also, you should launch the dialog only when there is only one target, I think. And not multiple
[15:50] <_sev|work> target = candidate
[15:50] <-- _sev|work left irc: Quit: This computer has gone to sleep
[15:50] <rootfather> I suspect that the Mass Add button is simply referring to https://github.com/scummvm/scummvm/blob/master/gui/launcher.cpp#L576 too
[15:52] <rootfather> regarding showing the dialog only if theres not more than one candidate, I think this can be done as soon as I find where the advancedDetector stores the number of available candidates
[15:56] <criezy|Work> From a quick look it seems like it should be OK to pass the use_unknown_dialog parameter at this place.
[15:56] <criezy|Work> The Mass Add dialog has its own call to EngineMan.detectGames() and I don't think it will go through the line you point to.
[15:58] <rootfather> and is it normal that I have to fiddle with the base/plugins* system?
[15:58] <rootfather> I have the feeling that something is going wrong here ^^
[15:58] <rootfather> oh and it currently breaks the scumm detection as well
[16:00] --> ny00123 joined #scummvm.
[16:01] <rootfather> let me try this from scratch with live commentary :D
[16:01] <criezy|Work> If you change the signature of a virtual function (such as adding a parameter to it), then you need to do the change in the base class and derived classes as well.
[16:02] <criezy|Work> So in the case of detectGames that means changing it in MetaEngine, AdvancedMetaEngine, and all the other classes that derive from MetaEngine.
[16:08] <rootfather> mh okay
[16:14] --> ccawley2011 joined #scummvm.
[16:21] <rootfather> somehow GameList candidates(EngineMan.detectGames(files, true)); doesn't work properly, the dialog is never shown...
[16:21] <-- TMM left irc: Quit: Ex-Chat
[16:22] <rootfather> so somehow this doesn't get passed to ReportUnknown
[16:22] <-- Drenn left irc: Quit: Leaving
[16:24] <rootfather> I think I have to manually pass the value from detectGames() to reportUnknown()
[16:24] <criezy|Work> Yes you do.
[16:24] <criezy|Work> How else would it be passed?
[16:25] <rootfather> the issue is that at least I think I did this already
[16:26] <criezy|Work> If you get stuck and need help, it would be good to post your code somewhere as we can't really know what is wrong without knowing what you did.
[16:34] <rootfather> https://pastebin.com/ZKn42JWh
[16:34] <rootfather> this is a diff of what I did so far
[16:34] <rootfather> and I somehow have the impression I'm missing something important
[16:35] --> GitHub198 joined #scummvm.
[16:35] <GitHub198> [scummvm] ccawley2011 opened pull request #1166: README: Clean up formatting; fix broken links (master...readme-fix) https://git.io/vpZBx
[16:35] GitHub198 (GitHub198@gateway/service/github.com/x-gxyxwdpblnpxrzks) left #scummvm.
[16:39] <criezy|Work> rootfather: I have not gone very far, but there is already an issue with the change in base/plugins.cpp
[16:39] <criezy|Work> In GameList EngineManager::detectGames(const Common::FSList &fslist, bool use_unknown_dialog), you need to pass the use_unknown_dialog to the call to detectGames that is a few lines below in that function.
[16:42] <-- jamm left irc: Ping timeout: 248 seconds
[16:43] <criezy|Work> Also it looks like in AdvancedMetaEngine::detectGames you do nothing with the use_unknown_dialog variable, and in particular do not pass it to reportUnknown().
[16:45] <criezy|Work> It looks like there is a missing step actually as detectGames() does not call directly reportUnknown() but calls detectGame() which itself calls reportUnknown.
[16:45] <rootfather> yep I was searching for the reportUnknown() call too...
[16:45] <rootfather> hm
[16:45] <criezy|Work> So you need to add the variable to detectGame as well, and pass it to it from detectGames. Then in detectGame pass it to reportUnknow.
[16:47] <rootfather> lol I haven't even noticed that there's detectGame() as I was only focused on detectGames() and reportUnknown()
[16:54] <-- Stormkeeper left irc: Read error: Connection reset by peer
[16:56] --> LittleToonCat joined #scummvm.
[17:01] <-- waltervn left irc: Read error: Connection reset by peer
[17:04] <-- morganw left irc: Quit: morganw
[17:06] --> Farmboy0 joined #scummvm.
[17:06] <-- Farmboy0 left irc: Changing host
[17:06] --> Farmboy0 joined #scummvm.
[17:07] <rootfather> yes I got it
[17:07] <rootfather> now I have to unbreak the scumm engine
[17:14] <-- criezy|Work left irc: Quit: Page closed
[17:18] <bonki> don't forget that useUnknownDialog should be inCamelCase
[17:18] <bonki> hi btw :)
[17:21] <rootfather> the variable?
[17:21] <bonki> yes
[17:21] <rootfather> fuck :D
[17:21] <rootfather> or to be more precise - praise the Lord for Notepad++'s find-and-replace-in-files-function
[17:22] <bonki> or Don Ho
[17:22] <bonki> :D
[17:24] <rootfather> nooo the SKY engine is relying on a different detector too :/
[17:28] <rootfather> and sword too...
[17:28] --> waltervn joined #scummvm.
[17:28] #scummvm: mode change '+o waltervn' by ChanServ!ChanServ@services.
[17:32] --> ajax16384 joined #scummvm.
[17:32] #scummvm: mode change '+o ajax16384' by ChanServ!ChanServ@services.
[17:36] <rootfather> hm is touching a number of engines a good idea just to solve this? :D
[17:53] --> girafe joined #scummvm.
[17:58] --> criezy joined #scummvm.
[17:58] #scummvm: mode change '+o criezy' by ChanServ!ChanServ@services.
[18:05] --> Strangerke joined #scummvm.
[18:07] <-- rootfather left irc:
[18:13] --> rootfather joined #scummvm.
[18:13] <-- rootfather left irc: Changing host
[18:13] --> rootfather joined #scummvm.
[18:13] #scummvm: mode change '+o rootfather' by ChanServ!ChanServ@services.
[18:13] --> GitHub190 joined #scummvm.
[18:13] <GitHub190> [scummvm] bgK pushed 1 new commit to master: https://git.io/vpZoL
[18:13] <GitHub190> scummvm/master c1a12c2 Bastien Bouclet: MOHAWK: MYST: Redraw the tower angle line after the rotation completes...
[18:13] GitHub190 (GitHub190@gateway/service/github.com/x-hyjjwstcucygbkvw) left #scummvm.
[18:14] --> SylvainTV joined #scummvm.
[18:14] #scummvm: mode change '+o SylvainTV' by ChanServ!ChanServ@services.
[18:34] <rootfather> criezy, would you review the changes I made to the scumm,sword1,sword2 and sky detectors/engines to fix compilation?
[18:34] <rootfather> I really don't like that I had to touch the engines itself, just feels weird
[18:34] <rootfather> weird as in "small change, huge impact" :D
[18:41] <rootfather> e.g. I had to add the new variable even to AdvancedMetaEngine::createInstance o.O
[18:46] <rootfather> and I have the impression that the mass add feature now is way slower when scanning directories :/
[18:46] <rootfather> I hope I haven't started instanciating an engine whenever the detector hits *any* file
[18:50] <criezy> rootfather: is your code available somewhere?
[18:51] <rootfather> https://pastebin.com/VtB3ZqVF
[18:52] <rootfather> if you prefer I can put it in a seperate branch, just don't want to commit something potentially broken to the PR branch
[18:56] <criezy> That's OK. I got your branch locally and applied the diff on top.
[19:01] <criezy> Don't modify the createInstance to add the flag.
[19:02] <criezy> The only case where we want to show the dialog is when calling detectGames from the launcher with the Add button.
[19:02] <criezy> Some from everywhere else it should just be false, which is the default. So you don't even have to change the other calls to detectGames.
[19:02] <criezy> I can do a cleanup now and post a diff if you want.
[19:05] <rootfather> that would be great
[19:05] <rootfather> the issue is that the "non-advancedDetector" threw tons of errors without modifiying createInstance
[19:06] <rootfather> and suddenly, the advancedDetector enabled engines started doing this too
[19:06] <rootfather> so somewhere I must have done a slight overshoot
[19:24] <criezy> rootfather: OK. I have got it cleaned up, but I suspect you broke detection for some engines so I will look at that after dinner.
[19:24] <rootfather> thanks
[19:24] <rootfather> and oh shit
[19:25] <criezy> In the meantime you can try this if you want: https://pastebin.com/r45V9i1J
[19:25] <criezy> It compiles but I have not checked that it works.
[19:25] <criezy> The diff applies to the head your your PR branch
[19:28] <criezy> OK, the only one that looks like it might be broken is ADL.
[19:28] <criezy> Maybe you could grab Mystery House from our donwload page (if you don't already have it) and check.
[19:29] <criezy> And now my dinner should be ready :-)
[19:30] <rootfather> hm "git apply" throws an error for line 234
[19:35] <rootfather> ah, line endings I guess
[19:48] <rootfather> ok got the patch applied
[20:13] <-- ajax16384 left irc: Read error: Connection reset by peer
[20:22] <rootfather> okay, the dialog gets shown if I use Add Game and doesn't appear when I do a mass add
[20:22] <rootfather> however, as you described, ADL detection is broken and MYSTHOUSE.DSK from the website is not detected.
[20:23] <criezy> Add the bool to the detectGame function in engines/adl/detection.cpp
[20:23] <criezy> That should fix it.
[20:28] --> TMM joined #scummvm.
[20:28] <-- TMM left irc: Changing host
[20:28] --> TMM joined #scummvm.
[20:28] #scummvm: mode change '+o TMM' by ChanServ!ChanServ@services.
[20:43] <rootfather> criezy, yep, that works
[20:53] --> GitHub135 joined #scummvm.
[20:53] <GitHub135> [scummvm] bonki closed pull request #984: BASE: Code formatting cleanup pass of base (master...aidan/cleanup) https://git.io/v7iDy
[20:53] GitHub135 (GitHub135@gateway/service/github.com/x-loaumgszvdcrqosv) left #scummvm.
[20:54] <rootfather> will do more testing tomorrow
[20:54] <rootfather> cu then
[20:59] <-- criezy left irc: Quit: criezy
[21:40] --> Drenn joined #scummvm.
[22:32] <-- Farmboy0 left irc: Remote host closed the connection
[22:43] <-- ny00123 left irc: Remote host closed the connection
[22:43] <-- stroggoff left irc: Quit: Leaving
[22:59] <-- girafe left irc: Read error: Connection reset by peer
[23:19] <-- TMM left irc: Remote host closed the connection
[23:52] <-- t0by left irc: Remote host closed the connection
[23:56] <-- waltervn left irc: Quit: Leaving
[00:00] --- Wed Apr 25 2018