ScummVM IRC Log - 22 Feb 2017

[Back to Index]

[00:04] <-- demonimin left irc: Ping timeout: 260 seconds
[00:13] --> demonimin joined #scummvm.
[00:13] <-- demonimin left irc: Changing host
[00:13] --> demonimin joined #scummvm.
[00:20] <-- m_kiewitz left irc: Quit: technology isn't intrinsically good or evil. It's how it's used. Like the Death Ray.
[00:20] <-- Mellified_Man left irc: Read error: Connection reset by peer
[00:20] --> Mellified_Man joined #scummvm.
[00:24] <-- Henke37 left irc: Quit: ERR_SHUTDOWN
[00:48] <-- dtcrshr left irc: Ping timeout: 255 seconds
[00:51] <-- SylvainTV left irc: Read error: Connection reset by peer
[01:01] --> dtcrshr joined #scummvm.
[01:04] <-- Harekiet left irc: Read error: Connection reset by peer
[01:07] <-- dtcrshr left irc: Max SendQ exceeded
[01:08] --> dtcrshr joined #scummvm.
[01:10] <-- dtcrshr left irc: Read error: Connection reset by peer
[01:19] --> Harekiet joined #scummvm.
[01:22] --> _sev_ joined #scummvm.
[01:22] #scummvm: mode change '+o _sev_' by ChanServ!ChanServ@services.
[01:23] <-- _sev left irc: Ping timeout: 255 seconds
[01:28] --> dreammaster joined #scummvm.
[01:28] #scummvm: mode change '+o dreammaster' by ChanServ!ChanServ@services.
[01:41] --> GitHub53 joined #scummvm.
[01:41] <GitHub53> [scummvm] dreammaster pushed 1 new commit to master: https://git.io/vDx67
[01:41] <GitHub53> scummvm/master 1a25abb Paul Gilbert: GRAPHICS: Apply eriktorbjorn's fix for non-origin transBlitFrom calls
[01:41] GitHub53 (GitHub53@192.30.252.34) left #scummvm.
[01:46] --> omer_mor_ joined #scummvm.
[01:48] <-- omer_mor left irc: Ping timeout: 260 seconds
[01:54] <-- erdic left irc: Ping timeout: 240 seconds
[01:57] <-- bazaar left irc: Ping timeout: 264 seconds
[02:01] <-- klusark left irc: Quit: quit
[02:02] --> klusark joined #scummvm.
[02:10] --> Littleboy joined #scummvm.
[02:10] #scummvm: mode change '+o Littleboy' by ChanServ!ChanServ@services.
[02:21] --> Vampire0_ joined #scummvm.
[02:22] --> GitHub115 joined #scummvm.
[02:22] <GitHub115> [scummvm] dreammaster pushed 2 new commits to master: https://git.io/vDxMt
[02:22] <GitHub115> scummvm/master 902ce47 Paul Gilbert: TSAGE: R2R: Don't allow F8 to start credits when they're already on
[02:22] <GitHub115> scummvm/master 0706da8 Paul Gilbert: TITANIC: Assert dynamic_cast result in CBellot::Use
[02:22] GitHub115 (GitHub115@192.30.252.40) left #scummvm.
[02:25] <-- Vampire0 left irc: Ping timeout: 268 seconds
[02:25] Nick change: Vampire0_ -> Vampire0
[02:31] <-- Dominus left irc: Ping timeout: 240 seconds
[02:32] --> Dominus joined #scummvm.
[02:32] <-- Dominus left irc: Changing host
[02:32] --> Dominus joined #scummvm.
[02:52] <-- TMM left irc: Ping timeout: 260 seconds
[02:54] --> TMM joined #scummvm.
[02:54] #scummvm: mode change '+o TMM' by ChanServ!ChanServ@services.

[03:01] <-- Dominus left irc: Ping timeout: 240 seconds
[03:15] --> Dominus joined #scummvm.
[03:15] <-- Dominus left irc: Changing host
[03:15] --> Dominus joined #scummvm.
[03:42] <-- Dominus left irc: Ping timeout: 240 seconds
[03:45] --> Dominus joined #scummvm.
[03:45] <-- Dominus left irc: Changing host
[03:45] --> Dominus joined #scummvm.
[03:54] --> GitHub75 joined #scummvm.
[03:54] <GitHub75> [scummvm] dreammaster pushed 2 new commits to master: https://git.io/vDxHa
[03:54] <GitHub75> scummvm/master 2857acb Paul Gilbert: TITANIC: Add missing timer call in endgame sequence
[03:54] <GitHub75> scummvm/master d27aba0 Paul Gilbert: TITANIC: Cleanup and renaming for endgame classes
[03:54] GitHub75 (GitHub75@192.30.252.42) left #scummvm.
[04:18] <-- dreammaster left irc:
[04:40] <-- Mia left irc: Ping timeout: 268 seconds
[04:42] --> Mia joined #scummvm.
[04:42] <-- Mia left irc: Changing host
[04:42] --> Mia joined #scummvm.
[04:49] <rsn8887> Working on ScummVM is too addictive :)
[05:57] <-- pigeon left irc: Quit: leaving
[05:57] --> pigeon joined #scummvm.
[05:57] #scummvm: mode change '+v pigeon' by ChanServ!ChanServ@services.
[06:39] --> waltervn joined #scummvm.
[06:39] #scummvm: mode change '+o waltervn' by ChanServ!ChanServ@services.
[06:40] <waltervn> morning
[07:23] Nick change: rootfather|afk -> rootfather
[07:26] <-- macdude22 left irc: Ping timeout: 240 seconds
[07:41] <-- LittleToonCat left irc: Remote host closed the connection
[07:43] --> m_kiewitz joined #scummvm.
[07:43] <-- m_kiewitz left irc: Changing host
[07:43] --> m_kiewitz joined #scummvm.
[07:43] #scummvm: mode change '+o m_kiewitz' by ChanServ!ChanServ@services.
[08:03] <-- Lightkey left irc: Ping timeout: 240 seconds
[08:16] --> Lightkey joined #scummvm.
[08:33] --> GitHub70 joined #scummvm.
[08:33] <GitHub70> [scummvm] rsn8887 opened pull request #908: SDL: Fix erratic analog pointer + control options (master...upstream) https://git.io/vDpkL
[08:33] GitHub70 (GitHub70@192.30.252.34) left #scummvm.
[08:33] <rsn8887> I just made a PR to dix remaining problems with analog joystick mouse control. And add the mouse speed and analog joystick deadzone to the new control tab.
[08:38] --> _sev|work joined #scummvm.
[08:38] #scummvm: mode change '+o _sev|work' by ChanServ!ChanServ@services.
[08:38] <-- _sev|work left irc: Client Quit
[08:45] --> ajax16384 joined #scummvm.
[08:45] #scummvm: mode change '+o ajax16384' by ChanServ!ChanServ@services.
[08:56] <-- _sev_ left irc: Quit: Leaving
[09:40] <-- Harekiet left irc: Ping timeout: 255 seconds
[09:53] --> Harekiet joined #scummvm.
[09:53] --> t0by joined #scummvm.
[09:53] <-- t0by left irc: Changing host
[09:53] --> t0by joined #scummvm.
[09:53] #scummvm: mode change '+v t0by' by ChanServ!ChanServ@services.
[09:57] <-- TMM left irc: Quit: Ex-Chat
[10:16] <wjp> rsn8887: you are unnecessarily (and sometimes incorrectly) changing a lot of whitespace in there which makes it harder than necessary to see what the actual changes are
[10:42] <-- phyber left irc: Ping timeout: 276 seconds
[10:43] --> phyber joined #scummvm.
[10:45] <-- klusark left irc: Ping timeout: 240 seconds
[10:45] --> TMM joined #scummvm.
[10:45] #scummvm: mode change '+o TMM' by ChanServ!ChanServ@services.
[10:46] --> klusark joined #scummvm.
[10:54] --> phyber_ joined #scummvm.
[10:55] <-- phyber left irc: Ping timeout: 255 seconds
[10:56] --> Henke37 joined #scummvm.
[10:58] <-- phyber_ left irc: Ping timeout: 240 seconds
[10:59] --> phyber joined #scummvm.
[10:59] --> Strangerke_ joined #scummvm.
[11:02] <-- Strangerke left irc: Ping timeout: 260 seconds
[11:02] Nick change: Strangerke_ -> Strangerke
[11:17] <-- Cheeseness left irc: Ping timeout: 240 seconds
[11:26] Nick change: rootfather -> rootfather|afk
[11:37] --> Strangerke_ joined #scummvm.
[11:40] <-- Strangerke left irc: Ping timeout: 260 seconds
[11:40] Nick change: Strangerke_ -> Strangerke
[11:44] --> Cheeseness joined #scummvm.
[12:00] <-- phyber left irc: Ping timeout: 255 seconds
[12:13] --> erdic joined #scummvm.
[12:36] --> Dark-Star|Zzz joined #scummvm.
[12:37] <-- Dark-Star left irc: Quit: No Ping reply in 180 seconds.
[12:45] --> phyber joined #scummvm.
[12:49] <Harekiet> snover http://imgur.com/a/etrQ1 another crash
[12:50] <m_kiewitz> Harekiet: uh oh that looks kinda bad
[12:50] <m_kiewitz> buy may even be a script bug
[12:50] <m_kiewitz> *but
[12:51] <Harekiet> I had some unitialized variable warning before as well, that might be a script error that kinda worked
[12:52] <m_kiewitz> you got that output somewhere still?
[12:53] <Harekiet> [2017-02-22 12:25:16] WARNING: Uninitialized read for parameter 1 from method GKFeature::doVerb (room 5411, script 64950, localCall ffffffff)!
[12:54] <m_kiewitz> when did this happen?
[12:55] <Harekiet> euhm think it was early after arriving in the hunting lodge
[12:55] <Harekiet> this other crash from the screenshot is when you're in the woods with the wolf
[12:57] <Harekiet> oh that one happens pretty much all the time after you encounter the wolf if I retry it with a savegame
[12:58] <m_kiewitz> hmm I'm not sure if I'm not getting something, I'm not experienced in SCI32 at all
[13:00] <m_kiewitz> but it seems the current signature for kList should be "i(.*)". Just a minor nit-pick (unless of course I'm wrong, maybe it was done that way intentionally)
[13:00] <m_kiewitz> 8 would be kListNodeValue
[13:01] <m_kiewitz> so the uninitialized value should be a node or a null and it's neither
[13:01] <m_kiewitz> i guess i should improve the signature checking code and actually allow uninitialized variables for the main kernel call in case there are sub ops
[13:02] --> jamm joined #scummvm.
[13:02] <m_kiewitz> because then you would have gotten the sub op signature mismatch instead
[13:02] <m_kiewitz> ah sounds really like some kind of script bug then
[13:03] <m_kiewitz> it tries to delete a timer
[13:03] <m_kiewitz> was surely ignored by the original interpreter :( but well we could add a workaround for this
[13:04] <m_kiewitz> anyway, as I said - I'm no expert on SCI32, so let's wait what snover thinks about it
[13:04] <-- CuriosTiger left irc: Ping timeout: 252 seconds
[13:05] --> CuriosTiger joined #scummvm.
[13:05] <m_kiewitz> Harekiet: ah, still got that ScummVM window open?
[13:05] <m_kiewitz> if so please enter "room" and then press enter
[13:06] <m_kiewitz> nvm, we already write that info out
[13:06] <m_kiewitz> im a bit sick today (including the last few days), so I'm a bit slow
[13:07] <Harekiet> I can just recreate it fairly easy from my savegame, and it happens in different locations, you encounter the wolf and then I think the walkthrough says you have a limited amount of time before shit goes down
[13:11] <-- Cheeseness left irc: Ping timeout: 260 seconds
[13:12] <Harekiet> well no more gk2 at least for now :)
[13:14] --> bazaar joined #scummvm.
[13:15] <m_kiewitz> Harekiet: if you have some time, you could try to figure out every possible room and/or if the room number actually even changes
[13:15] <m_kiewitz> just enter debugger by pressing Ctrl-Shift-D and then enter "room"
[13:15] <m_kiewitz> that would be useful information for building a workaround
[13:16] --> Cheeseness joined #scummvm.
[13:21] <Harekiet> I'd imaigne it's all the rooms that make up the forest area since I am seem to be able to trigger it everywehre
[13:22] <Harekiet> 611, 621, 631, 641, dunno if it's some logic to that
[13:25] <m_kiewitz> sadly it's not that simple to figure out room numbers anymore. in SCI16 you could most of the time just check for certain background graphics and voila resouce number of those was the room number
[13:25] <m_kiewitz> i see there's a script 651
[13:26] <m_kiewitz> and there's also 610, 620, 630, 640. Also 600, 601, 605, 606, 615, 616, 625, 626, 635, 636
[13:28] <m_kiewitz> but those may be just scripts and no actual rooms
[13:32] <Harekiet> indeed, more different numbers popping up, although all in the 6xx range
[13:33] --> peterkohaut|work joined #scummvm.
[13:34] <-- klusark left irc: Ping timeout: 268 seconds
[13:36] <m_kiewitz> that's good to know. right now we do not support ranges with workarounds. it's so many rooms then, that we may simply use a wildcard for rooms and cross our fingers that nothing else slips through
[13:36] <-- peterkohaut left irc: Ping timeout: 240 seconds
[13:38] --> klusark joined #scummvm.
[13:50] --> Strangerke_ joined #scummvm.
[13:52] <-- Strangerke left irc: Ping timeout: 260 seconds
[13:52] Nick change: Strangerke_ -> Strangerke
[14:09] --> Strangerke_ joined #scummvm.
[14:11] <-- Strangerke left irc: Ping timeout: 240 seconds
[14:11] Nick change: Strangerke_ -> Strangerke
[14:45] --> girafe joined #scummvm.
[15:23] --> Littleboy joined #scummvm.
[15:23] #scummvm: mode change '+o Littleboy' by ChanServ!ChanServ@services.
[15:26] <rsn8887> wjp
[15:28] <rsn8887> wjp: I agree, but I don't know a good way to undo only the whitespace changes. They are scattered all over because I kept adding and removing code to debug this thing before I commited
[15:28] --> Begasus joined #scummvm.
[15:51] <-- Harekiet left irc: Ping timeout: 240 seconds
[15:56] Nick change: Begasus -> Begas_afk
[15:59] <-- TMM left irc: Ping timeout: 255 seconds
[16:02] --> Harekiet joined #scummvm.
[16:02] <-- erdic left irc: Quit: leaving
[16:04] --> erdic joined #scummvm.
[16:08] <-- ajax16384 left irc: Quit: Leaving
[16:10] <-- Cheeseness left irc: Quit: Leaving.
[16:10] --> Raziel^ joined #scummvm.
[16:10] #scummvm: mode change '+v Raziel^' by ChanServ!ChanServ@services.
[16:14] <-- snover left irc: Ping timeout: 255 seconds
[16:18] <-- erdic left irc: Quit: Lost terminal
[16:19] --> erdic joined #scummvm.
[16:19] --> snover joined #scummvm.
[16:19] #scummvm: mode change '+o snover' by ChanServ!ChanServ@services.
[16:21] <snover> m_kiewitz, Harekiet: Uninitialised param read warnings show up all the time right now; they were silently being ignored before and always returned zero, which usually works OK, except notably when there is an interaction with a draggable screen item, returning 0 for the param usually results in a non-draggable draggable
[16:21] <snover> I cant really make those reads work the same as temp reads without having to go through every single sci game
[16:23] <wjp> hrm, annoying
[16:23] <Harekiet> snover yeh that warning didn't really seem to cause issues, that timer deletion thing is preventing progress here now
[16:26] --> ajax16384 joined #scummvm.
[16:26] #scummvm: mode change '+o ajax16384' by ChanServ!ChanServ@services.
[16:29] <-- jamm left irc: Ping timeout: 240 seconds
[16:33] --> dtcrshr joined #scummvm.
[16:33] <-- dtcrshr left irc: Changing host
[16:33] --> dtcrshr joined #scummvm.
[16:36] --> TMM joined #scummvm.
[16:36] #scummvm: mode change '+o TMM' by ChanServ!ChanServ@services.
[16:38] <snover> with regards to the kList crash, the Collect system class& seems broken
[16:40] <snover> or, actually& hm.
[16:42] <snover> its nextNode property should be initialised to 0, im not super sure where the uninitialised value is coming from. it would have to be the node value of a node in the list, if Im reading this correctly
[16:48] <-- snover left irc: Ping timeout: 240 seconds
[16:48] --> Cheeseness joined #scummvm.
[16:51] --> WooShell joined #scummvm.
[16:52] <WooShell> meow =^.^=
[16:52] --> snover joined #scummvm.
[16:52] #scummvm: mode change '+o snover' by ChanServ!ChanServ@services.
[16:56] <m_kiewitz> snover: that should have been a pointer to a node, right? (of course no pointer for us)
[16:56] <m_kiewitz> or what exactly did sierra pass in such case? simply a number starting at 0?
[16:57] <m_kiewitz> also what do you think about the signatures right now, it should be "i[n0]" for kList, right?
[16:57] <m_kiewitz> right now it's "[n0]"
[17:00] Nick change: Begas_afk -> Begasus
[17:01] <-- snover left irc: Ping timeout: 260 seconds
[17:01] --> snover joined #scummvm.
[17:01] #scummvm: mode change '+o snover' by ChanServ!ChanServ@services.
[17:02] <snover> sorry, i seem to be having connectivity issues
[17:02] <snover> node keys are passed into delete
[17:03] <m_kiewitz> hmm weird then that it passes uninitialized as node key O_o
[17:03] <snover> the code looks like this https://gist.github.com/csnover/dabee21b3b00771191fbec98014c0005
[17:06] <snover> there are only two methods that set the nextNode member, delete and release
[17:06] <snover> release just walks through and deletes all the nodes in the elements member
[17:09] <-- TMM left irc: Quit: Ex-Chat
[17:10] <snover> m_kiewitz: as far as your question about the signature, which signature are you referring to specifically? kList itself is "(.*)"
[17:10] --> ny00123 joined #scummvm.
[17:11] <snover> kList(NodeValue) expects a single key node
[17:21] <Harekiet> didn't this timer thing happen before snover since i thought you said people had finished it
[17:22] <snover> i finished the game myself
[17:22] <snover> it never came up on my playthrough
[17:22] <snover> but, i didnt test every possible path, just followed a walkthrough
[17:23] <Harekiet> weird indeed
[17:23] --> GitHub58 joined #scummvm.
[17:23] <GitHub58> [scummvm] sev- pushed 14 new commits to master: https://git.io/vDhlD
[17:23] <GitHub58> scummvm/master 7db8908 Eugene Sandulenko: DIRECTOR: Lingo: Hid another trace under lingoparse debug flag
[17:23] <GitHub58> scummvm/master 9dfb8ff Eugene Sandulenko: DIRECTOR: Lingo: Turned if() statement code into relative jumps...
[17:23] <GitHub58> scummvm/master d73ebf5 Eugene Sandulenko: DIRECTOR: Lingo: Fixed float constants processing
[17:23] GitHub58 (GitHub58@192.30.252.42) left #scummvm.
[17:28] --> LittleToonCat joined #scummvm.
[17:29] <m_kiewitz> snover: the non sub opcode signature
[17:29] <m_kiewitz> the generic one, which then goes to the sub opcode one
[17:29] <snover> { MAP_CALL(List), SIG_SINCE_SCI21, SIGFOR_ALL, "(.*)", kList_subops, NULL },
[17:30] <m_kiewitz> oh right, yeah sorry about that bollocks about the signature right now, i mentioned the correct one 6 hours ago. im really sick atm
[17:30] <snover> no worries.
[17:30] <m_kiewitz> yeah the "(.*)" one, that should bette be "i(.*)"
[17:30] <m_kiewitz> right?
[17:30] <m_kiewitz> because first parameter should always be the sub opcode number
[17:30] <m_kiewitz> correct?
[17:30] <snover> id have to double-check but i dont even know that these signatures are used if there are subops
[17:31] <m_kiewitz> i should also change signature checking for those, so that we verify that one, but let uninitialized parameters through
[17:31] <m_kiewitz> so that Harekiet would have gotten signature mismatch on kList(NodeValue) instead
[17:31] <-- Raziel^ left irc: Ping timeout: 268 seconds
[17:32] <m_kiewitz> the main signature is checked of course
[17:32] <m_kiewitz> maybe we could even just add a "!" to let uninitialized values through, so that they get caught by the sub opcode later
[17:32] <m_kiewitz> in case "!" includes uninitialized values, i haven't checked yet
[17:33] <m_kiewitz> the point is that the first integer is verified, before it gets passed to sub opcode checking
[17:33] <m_kiewitz> so that in case kList(pointer, 5) was called, kList signature mismatch would get triggered, because it's an invalid sub opcode
[17:34] <m_kiewitz> i hope you can understand what I mean
[17:34] --> _sev joined #scummvm.
[17:34] <-- _sev left irc: Changing host
[17:34] --> _sev joined #scummvm.
[17:34] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[17:35] <snover> i think i do
[17:44] --> GitHub10 joined #scummvm.
[17:44] <GitHub10> [scummvm] criezy pushed 1 new commit to master: https://git.io/vDhRi
[17:44] <GitHub10> scummvm/master f9707a8 Timo Mikkolainen: I18N: Update translation (Finnish)...
[17:44] GitHub10 (GitHub10@192.30.252.42) left #scummvm.
[17:45] <Harekiet> Just skipping the call seems to make it work for now, maybe it messes up the logic in the wolf attack but it still seemed to kill me
[17:58] --> Farmboy0 joined #scummvm.
[17:58] <-- Farmboy0 left irc: Changing host
[17:58] --> Farmboy0 joined #scummvm.
[18:09] <-- ajax16384 left irc: Read error: Connection reset by peer
[18:16] <-- Strangerke|work left irc: Ping timeout: 260 seconds
[18:17] --> TMM joined #scummvm.
[18:17] #scummvm: mode change '+o TMM' by ChanServ!ChanServ@services.
[18:18] --> ajax16384 joined #scummvm.
[18:18] #scummvm: mode change '+o ajax16384' by ChanServ!ChanServ@services.
[19:33] <Harekiet> snover waiting for the guard to move in the ludwig castle also has the game weirdly freezing up while it's waiting to play some animation
[19:33] <snover> Harekiet: where did you say you got the game from again? gog?
[19:34] <Harekiet> yeh
[19:35] <snover> i think someone else complained about this problem before, but refused to follow my request to send a save game and reproduction steps
[19:35] <snover> i was not able to reproduce it with my copy of gk2
[19:36] <snover> if you have a reproducible freeze, that would be useful
[19:36] <Harekiet> I noticed it before as well in some previous chapter, if oyu hang around in the grotto the guard moves around now and then but an hourglass pops up and nothing really happens
[19:36] <Harekiet> I'm still waiting with the game in the background frozen
[19:37] <snover> do you have a debugger that will let you execute code?
[19:37] <Harekiet> euhm run and edit and vstudio you mean
[19:37] <snover> when i get a hang like that, which doesnt allow ctrl+shift+d to go into the scummvm debugger, i break into lldb and then run `p g_sci->getSciDebugger()->cmdBacktrace(0, nullptr)`
[19:38] <Harekiet> I can get into the scumm debugger
[19:38] <snover> oh
[19:38] <snover> godo
[19:38] <Harekiet> the music plays and all but it doesn't do much :)
[19:38] <snover> that makes it easier to get the backtrace
[19:39] <Harekiet> I need to get this debugger output sent to some console somewhere
[19:39] <Harekiet> guess a screenshot will do
[19:40] <Harekiet> http://imgur.com/a/as3pF
[19:40] <snover> ./configure --enable-text-console
[19:41] <Harekiet> I'll have to see how that's done in vstudio
[19:42] <snover> maybe just add `-DUSE_TEXT_CONSOLE_FOR_DEBUGGER`, however that works with MSVC
[19:43] <snover> this call stack is reminding me of a similar problem that i ran into in LSL7, where an animation got stuck
[19:43] --> SylvainTV joined #scummvm.
[19:43] #scummvm: mode change '+o SylvainTV' by ChanServ!ChanServ@services.
[19:43] <snover> this is probably the same bug, but i have no idea what the bug is yet
[19:44] <snover> i also dont remember how i identified the defective object in that scenario&
[19:44] <snover> what is the room number?
[19:45] <Harekiet> 960
[19:45] <Harekiet> I'll see if my save triggers it again
[19:45] <Harekiet> pretty much just involves waiting :)
[19:46] <snover> `vo guardControl` and check the value of the `state` property
[19:46] <snover> it is probably stuck at 1
[19:46] <Harekiet> yep that's 1
[19:47] <snover> try running `send guardControl changeState 2`
[19:47] <Harekiet> nop
[19:47] <snover> try running `send guardControl changeState 0` :)
[19:48] <snover> looks like the guard movement should happen randomly between 40 and 50 seconds of waiting
[19:48] <Harekiet> then the hourglass is gone
[19:48] <Harekiet> but the guard is still there
[19:48] <snover> i guess the problem is in guard3 then
[19:49] <Harekiet> it's weird since it happens before in the game but then I just had to wait a very long time and it did eventually go forward
[19:50] <Harekiet> oh returning to the room now the guard is gone
[19:50] <Harekiet> at least I can continue :)
[19:51] --> GitHub43 joined #scummvm.
[19:51] <GitHub43> [scummvm] criezy pushed 1 new commit to master: https://git.io/vDh9p
[19:51] <GitHub43> scummvm/master 80aba31 Lyubomyr Lisen: I18N: Update translation (Ukrainian)...
[19:51] GitHub43 (GitHub43@192.30.252.42) left #scummvm.
[19:53] --> GitHub82 joined #scummvm.
[19:53] <GitHub82> [scummvm] criezy pushed 1 new commit to master: https://git.io/vDhHB
[19:53] <GitHub82> scummvm/master 6fb0f5b Eugene Sandulenko: I18N: Update translation (Ukrainian)...
[19:53] GitHub82 (GitHub82@192.30.252.41) left #scummvm.
[19:53] <rsn8887> wjp: do you want me to go through and remove all the added whitespace? or is it acceptable as is?
[19:54] --> GitHub196 joined #scummvm.
[19:54] <GitHub196> [scummvm] criezy pushed 1 new commit to master: https://git.io/vDhH6
[19:54] <GitHub196> scummvm/master d2e2eac Eugene Sandulenko: I18N: Update translation (Ukrainian)...
[19:54] GitHub196 (GitHub196@192.30.252.42) left #scummvm.
[19:56] --> GitHub142 joined #scummvm.
[19:56] <GitHub142> [scummvm] criezy pushed 1 new commit to master: https://git.io/vDhHN
[19:56] <GitHub142> scummvm/master 842cda6 Eugene Sandulenko: I18N: Update translation (Russian)...
[19:56] GitHub142 (GitHub142@192.30.252.42) left #scummvm.
[19:58] <rsn8887> wjp: I will clean it up...
[20:26] <t0by> rsn8887, on the wiki there is an astyle file
[20:31] <-- Strangerke left irc: Ping timeout: 240 seconds
[20:33] --> Strangerke joined #scummvm.
[20:36] <-- t0by left irc: Quit: Bye!
[20:46] <rsn8887> @wjp t0by, I fixed all the whitespace, should be much easier now to review https://github.com/scummvm/scummvm/pull/908/files
[20:47] <rsn8887> I mean https://github.com/scummvm/scummvm/pull/908
[20:49] <rsn8887> How does git see if "both files changed"? Changed compared to WHAT?
[20:51] <rsn8887> I am so confused. I would like to rebase after cherry-pick but I NEVER want to merge those 30 manual merge conflicts on one of my files ever again, when I cherry-pick next time from my development branch
[20:51] <rsn8887> So I guess I can never squash my PR into just one commit, because then later on I will have to manually merge again when I want to cherry pick from my own development branch
[20:52] <rsn8887> Ah well. I will just leave it as is for now.
[20:59] --> GitHub74 joined #scummvm.
[20:59] <GitHub74> [scummvm] lubomyr opened pull request #909: ANDROIDSDL: changed filename in assets file with scummvm-data for replace old data files (master...master) https://git.io/vDhpx
[20:59] GitHub74 (GitHub74@192.30.252.34) left #scummvm.
[21:04] --> GitHub108 joined #scummvm.
[21:04] <GitHub108> [scummvm] sev- pushed 2 new commits to master: https://git.io/vDhhD
[21:04] <GitHub108> scummvm/master 8a70c0c lubomyr: ANDROIDSDL: changed filename in asset file with scummvm-data for replacing old data-files
[21:04] <GitHub108> scummvm/master db4ef7c Eugene Sandulenko: Merge pull request #909 from lubomyr/master...
[21:04] GitHub108 (GitHub108@192.30.252.34) left #scummvm.
[21:04] --> GitHub177 joined #scummvm.
[21:04] <GitHub177> [scummvm] sev- closed pull request #909: ANDROIDSDL: changed filename in assets file with scummvm-data for replace old data files (master...master) https://git.io/vDhpx
[21:04] GitHub177 (GitHub177@192.30.252.42) left #scummvm.
[21:04] --> GitHub10 joined #scummvm.
[21:04] <GitHub10> [scummvm] criezy pushed 1 new commit to master: https://git.io/vDhh9
[21:04] <GitHub10> scummvm/master 15625c9 Arius: I18N: Update translation (Greek)...
[21:04] GitHub10 (GitHub10@192.30.252.42) left #scummvm.
[21:06] <_sev> rsn8887: please, read our code formatting conventions :/
[21:07] <_sev> rsn8887: your new switch statement has extra indent
[21:08] <Harekiet> snover http://imgur.com/a/kgwMC that ever happened before?
[21:09] <_sev> rsn8887: and line 2063
[21:11] <rsn8887> _sev: yes got it, will fix asap
[21:12] <-- peterkohaut|work left irc: Read error: Connection reset by peer
[21:19] <snover> Harekiet: i never saw it
[21:24] <Harekiet> snover looks like it's some initial state mess up after loading a game right after scummvm starts, moving to another room it's fine and if you then load the previous save again it's fine as well
[21:25] <snover> darn, more bugs with the launcher integration.
[21:25] <snover> can you give me the save game?
[21:27] <Harekiet> https://dl.dropboxusercontent.com/u/3873490/Scene/gk2-cd.024
[21:30] <snover> thanks, i got it.
[21:37] <rsn8887> _sev: I am reworking the shader selector.
[21:37] <_sev> nice
[21:37] <rsn8887> _sev: wth is "p->code" impossible to search a var named p.
[21:38] <-- ajax16384 left irc: Quit: Leaving
[21:38] <_sev> what do you mean?
[21:38] <rsn8887> I am scared by this:
[21:38] <rsn8887> for (int i = 0; p->code; ++p, ++i) {
[21:38] <rsn8887> if (renderMode == p->id)
[21:38] <rsn8887> sel = p->id;
[21:38] <rsn8887> no idea what p is.
[21:38] <_sev> pointer?
[21:39] <snover> Harekiet: seems like such an odd thing to show up now, but it looks like it might be due to a palette submission problem that i also noticed in LSL7
[21:39] <snover> ill need to take a look at that code more to figure out what is wrong
[21:39] <rsn8887> nevermind I see it it is pointer
[21:39] <Harekiet> ah that might explain the blackness indeed, thought it was some unloaded asset
[21:39] <_sev> rsn8887: const Common::RenderModeDescription *p = Common::g_renderModes;
[21:40] <_sev> rsn8887: in fact, I believe that you can use shaders instead of render modes
[21:41] <_sev> rsn8887: there is no sense to use both at the same time
[21:41] <rsn8887> _sev: There is great sense having software AND hardware scalers and shaders at the same time.
[21:41] <_sev> but can you use them at the same time?
[21:41] <rsn8887> _sev: for example, the shader could do an overlay, while the software scaler could do scaling etc.
[21:42] <_sev> I see
[21:42] <rsn8887> _sev: yes, because scalers are purely done in software, then the shader takes that texture and does something more with it.
[21:43] <rsn8887> _sev: A good example is many emulators on xbox and some on windows that allow pre-scale in software 2x and then a shader on top
[21:43] <_sev> I understand
[21:43] <rsn8887> _sev: now I will have to extend common and include g_shaderModes etc. But that should be fine
[21:43] <_sev> yes
[21:50] <-- girafe left irc: Read error: Connection reset by peer
[21:52] <-- ny00123 left irc: Quit: Leaving
[22:19] <rsn8887> _sev: nevermind there's a rat's tail of hundred's of lines of code just to change Rendermode or graphicsMode going all the way back to main.cpp and all the way into the Osystem_PSP2 etc. implementations. I will try to find a simpler way and remove the shader stuff from my PR now, to at least fix the analog stick.
[22:30] <rsn8887> _sev: and SDL2 doesn't even support shaders. It just happens that they can be hacked into the Vita port *very* easily, but no other system will use them, unless it is based of opengl-sdl (where shaders are almost done anyways).
[22:31] <rsn8887> _sev: so there's no point in putting in the work for SDL backend shader suppport. I will leave it to the OpenGL backend.
[22:36] <-- bgK left irc: Ping timeout: 240 seconds
[22:40] --> bgK joined #scummvm.
[22:40] #scummvm: mode change '+o bgK' by ChanServ!ChanServ@services.
[22:40] <-- Farmboy0 left irc: Remote host closed the connection
[22:43] <-- Begasus left irc: Quit: Ex-Chat
[22:50] <rsn8887> _sev: it should be clean now and ready to go. All references to shaders have been removed. After all the reason for PR was analog mouse fixes...
[22:51] <rsn8887> _sev: well one more...
[22:54] <rsn8887> _sev: ok done. Tell me if you need anything else.
[23:18] <rsn8887> _sev: I will make another pull request to allow the VIta to have shaders with a selector in the menu. I will just put a function g_system->GetShaderID(COMMON::STRING) g_system->GetShaderName(int ID) and g_system->GetNumShaders?
[23:19] <rsn8887> https://www.youtube.com/watch?v=QM1iUe6IofM
[23:25] <rsn8887> that
[23:27] --> GitHub108 joined #scummvm.
[23:27] <GitHub108> [scummvm] waltervn pushed 2 new commits to master: https://git.io/vDj8a
[23:27] <GitHub108> scummvm/master 69ae262 Walter van Niftrik: ADL: Add comments to hires6 direction opcode
[23:27] <GitHub108> scummvm/master 23bc483 Walter van Niftrik: ADL: Fix hires6 room description printing
[23:27] GitHub108 (GitHub108@192.30.252.40) left #scummvm.
[23:35] <-- waltervn left irc: Quit: Leaving
[23:55] <-- m_kiewitz left irc: Quit: technology isn't intrinsically good or evil. It's how it's used. Like the Death Ray.
[23:58] <snover> yay, i think i fixed the interpolation problem too
[00:00] --- Thu Feb 23 2017