[01:24] waltervn (~waltervn@scummvm/undead/waltervn) left irc: Quit: Leaving [01:36] Joefish (~Joefish@p200300764F6DF600AA035F7678357274.dip0.t-ipconnect.de) left irc: Ping timeout: 240 seconds [01:37] Joefish (~Joefish@p200300764F41770079D41EE17C25B324.dip0.t-ipconnect.de) joined #scummvm. [01:37] #scummvm: mode change '+v Joefish' by ChanServ!ChanServ@services. [01:48] Dominus (~dominus@unaffiliated/dominus) left irc: Ping timeout: 260 seconds [01:50] Dominus (~dominus@unaffiliated/dominus) joined #scummvm. [01:55] Drenn (~Drenn@mindon2501w-lp140-01-174-93-46-229.dsl.bell.ca) joined #scummvm. [02:09] ignalina (~ignalina@h-238-27.A639.priv.bahnhof.se) joined #scummvm. [02:12] mataniko (~mataniko@cpe-184-153-7-51.nyc.res.rr.com) joined #scummvm. [02:12] #scummvm: mode change '+o mataniko' by ChanServ!ChanServ@services. [02:14] mataniko (~mataniko@cpe-184-153-7-51.nyc.res.rr.com) left irc: Client Quit [02:14] dreammaster (~dreammast@c-67-180-185-91.hsd1.ca.comcast.net) joined #scummvm. [02:14] #scummvm: mode change '+o dreammaster' by ChanServ!ChanServ@services. [02:17] mataniko (~mataniko@cpe-184-153-7-51.nyc.res.rr.com) joined #scummvm. [02:17] #scummvm: mode change '+o mataniko' by ChanServ!ChanServ@services. [02:22] testing [02:24] lb_ii (b00e680b@gateway/web/freenode/ip.176.14.104.11) left irc: Ping timeout: 252 seconds [03:02] dreammaster (~dreammast@c-67-180-185-91.hsd1.ca.comcast.net) left irc: [03:03] Strangerke_ (~Strangerk@cust-225-10-110-94.dyn.as47377.net) joined #scummvm. [03:05] Strangerke (~Strangerk@cust-225-10-110-94.dyn.as47377.net) left irc: Ping timeout: 256 seconds [03:05] Nick change: Strangerke_ -> Strangerke [03:11] ignalina (~ignalina@h-238-27.A639.priv.bahnhof.se) left irc: Quit: Textual IRC Client: www.textualapp.com [03:13] mataniko2 (~UserNick@cpe-184-153-7-51.nyc.res.rr.com) joined #scummvm. [03:13] #scummvm: mode change '+o mataniko2' by ChanServ!ChanServ@services. [03:13] hi [03:18] mataniko2 (~UserNick@cpe-184-153-7-51.nyc.res.rr.com) left irc: Quit: Going offline, see ya! (www.adiirc.com) [03:42] Drenn (~Drenn@mindon2501w-lp140-01-174-93-46-229.dsl.bell.ca) left irc: Read error: Connection timed out [04:49] dreammaster (~dreammast@c-67-180-185-91.hsd1.ca.comcast.net) joined #scummvm. [04:49] #scummvm: mode change '+o dreammaster' by ChanServ!ChanServ@services. [04:51] dreammaster (~dreammast@c-67-180-185-91.hsd1.ca.comcast.net) left irc: Client Quit [05:12] SylvainTV (~Sylvain@ALille-458-1-3-249.w86-228.abo.wanadoo.fr) left irc: Ping timeout: 272 seconds [05:40] Begasus (~begasus@ptr-4p6jping0g0o4cnrdcy.18120a2.ip6.access.telenet.be) joined #scummvm. [05:49] Drenn (~Drenn@mindon2501w-lp140-01-174-93-46-229.dsl.bell.ca) joined #scummvm. [06:10] GitHub73 (GitHub73@gateway/service/github.com/x-wbyyjolgybtknriy) joined #scummvm. [06:10] [scummvm] sev- pushed 1 new commit to master: https://git.io/fN572 [06:10] scummvm/master c518691 Eugene Sandulenko: MOHAWK: Fix warning [06:10] GitHub73 (GitHub73@gateway/service/github.com/x-wbyyjolgybtknriy) left #scummvm. [06:10] SupSuper (~SupSuper@openxcom/dev/supsuper) left irc: Quit: Rip [06:18] KAT (~K4T@HOST-143.tworog.kalety.net) joined #scummvm. [06:27] KAT (~K4T@HOST-143.tworog.kalety.net) left irc: Ping timeout: 260 seconds [06:27] ST1 (~ScottT@119-18-4-180.cust.aussiebb.net) joined #scummvm. [06:27] ST (~ScottT@119-18-4-180.cust.aussiebb.net) left irc: Disconnected by services [06:46] KAT (~K4T@HOST-143.tworog.kalety.net) joined #scummvm. [07:38] Lightkey (~Darklock@p200300F693C2B15622CF30FFFE083718.dip0.t-ipconnect.de) left irc: Ping timeout: 265 seconds [07:54] Lightkey (~Darklock@p200300F693C2B11222CF30FFFE083718.dip0.t-ipconnect.de) joined #scummvm. [07:54] KAT (~K4T@HOST-143.tworog.kalety.net) left irc: Ping timeout: 240 seconds [08:01] KAT (~K4T@HOST-143.tworog.kalety.net) joined #scummvm. [08:23] KAT (~K4T@HOST-143.tworog.kalety.net) left irc: Ping timeout: 256 seconds [08:57] KAT (~K4T@HOST-143.tworog.kalety.net) joined #scummvm. [09:21] KAT (~K4T@HOST-143.tworog.kalety.net) left irc: Ping timeout: 244 seconds [09:48] Drenn (~Drenn@mindon2501w-lp140-01-174-93-46-229.dsl.bell.ca) left irc: Remote host closed the connection [10:03] Dark-Star (~quassel@2a01:238:427f:2f00:3060:fc6b:969e:dcf0) left irc: Ping timeout: 256 seconds [10:05] Dark-Star (~quassel@h2387211.stratoserver.net) joined #scummvm. [10:29] SylvainTV (~Sylvain@ALille-458-1-3-249.w86-228.abo.wanadoo.fr) joined #scummvm. [10:29] #scummvm: mode change '+o SylvainTV' by ChanServ!ChanServ@services. [10:54] t0by (~t0by@unaffiliated/t0by) joined #scummvm. [10:54] #scummvm: mode change '+o t0by' by ChanServ!ChanServ@services. [11:07] Yuv422 (~Yuv422@60-240-103-165.tpgi.com.au) joined #scummvm. [11:28] ignalina (~ignalina@h-238-27.A639.priv.bahnhof.se) joined #scummvm. [11:30] criezy (~criezy@host86-176-174-96.range86-176.btcentralplus.com) joined #scummvm. [11:30] #scummvm: mode change '+o criezy' by ChanServ!ChanServ@services. [13:05] LeChuck joined #scummvm. [13:10] ignalina (~ignalina@h-238-27.A639.priv.bahnhof.se) joined #scummvm. [13:24] ignalina (~ignalina@h-238-27.A639.priv.bahnhof.se) left irc: Quit: My MacBook has gone to sleep. ZZZzzz& [13:25] Yuv422 (~Yuv422@60-240-103-165.tpgi.com.au) left irc: Quit: Yuv422 [14:48] Littleboy (~littleboy@pool-108-7-223-151.bstnma.fios.verizon.net) joined #scummvm. [14:48] #scummvm: mode change '+o Littleboy' by ChanServ!ChanServ@services. [14:54] t0by (~t0by@unaffiliated/t0by) left irc: Remote host closed the connection [14:55] t0by (~t0by@unaffiliated/t0by) joined #scummvm. [14:55] #scummvm: mode change '+o t0by' by ChanServ!ChanServ@services. [15:06] lb_ii: There's some in helga, and some in the white chamber at least [15:20] mataniko (~mataniko@cpe-184-153-7-51.nyc.res.rr.com) left irc: Ping timeout: 260 seconds [15:22] ignalina (~ignalina@h-238-27.A639.priv.bahnhof.se) joined #scummvm. [15:22] mataniko (~mataniko@cpe-184-153-7-51.nyc.res.rr.com) joined #scummvm. [16:04] ny00123 (~ny00123@188.120.129.62) joined #scummvm. [16:05] #scummvm: mode change '+o mataniko' by ChanServ!ChanServ@services. [16:24] SupSuper (~SupSuper@openxcom/dev/supsuper) joined #scummvm. [16:26] ST (~ScottT@119-18-4-180.cust.aussiebb.net) joined #scummvm. [16:26] #scummvm: mode change '+o ST' by ChanServ!ChanServ@services. [16:28] ST1 (~ScottT@119-18-4-180.cust.aussiebb.net) left irc: Ping timeout: 272 seconds [16:46] dreammaster (~dreammast@c-67-180-185-91.hsd1.ca.comcast.net) joined #scummvm. [16:46] #scummvm: mode change '+o dreammaster' by ChanServ!ChanServ@services. [16:56] #scummvm: mode change '+o Strangerke' by ChanServ!ChanServ@services. [18:09] waltervn (~waltervn@scummvm/undead/waltervn) joined #scummvm. [18:09] #scummvm: mode change '+o waltervn' by ChanServ!ChanServ@services. [18:28] KAT (~K4T@93.179.200.166) joined #scummvm. [18:33] dreammaster (~dreammast@c-67-180-185-91.hsd1.ca.comcast.net) left irc: Ping timeout: 272 seconds [18:50] Nick change: KAT -> K4T [18:59] hi, I am looking for someone who was working on Dreamweb engine. Would like to ask some questions [19:00] as far as I know @wjp_ did some thing there but looks like he is not available [19:21] ignalina (~ignalina@h-238-27.A639.priv.bahnhof.se) left irc: Quit: My MacBook has gone to sleep. ZZZzzz& [19:37] Drenn (~Drenn@mindon2501w-lp140-01-174-93-46-229.dsl.bell.ca) joined #scummvm. [19:41] dreammaster (~dreammast@c-67-180-185-91.hsd1.ca.comcast.net) joined #scummvm. [19:41] #scummvm: mode change '+o dreammaster' by ChanServ!ChanServ@services. [19:55] lb_ii (b00e680b@gateway/web/freenode/ip.176.14.104.11) joined #scummvm. [19:55] Hi! [19:55] G'day [20:05] ignalina (~ignalina@h-238-27.A639.priv.bahnhof.se) joined #scummvm. [20:17] _dreammaster (~dreammast@c-67-180-185-91.hsd1.ca.comcast.net) joined #scummvm. [20:17] #scummvm: mode change '+o _dreammaster' by ChanServ!ChanServ@services. [20:18] dreammaster (~dreammast@c-67-180-185-91.hsd1.ca.comcast.net) left irc: Ping timeout: 248 seconds [20:23] t0by (~t0by@unaffiliated/t0by) left irc: Ping timeout: 256 seconds [20:25] somaen: t0by: I want to discuss some details of BaseKeyboardState [21:16] t0by (~t0by@unaffiliated/t0by) joined #scummvm. [21:16] #scummvm: mode change '+o t0by' by ChanServ!ChanServ@services. [21:29] ny00123 (~ny00123@188.120.129.62) left irc: Quit: Leaving [21:39] t0by: hi, are you here? [21:44] K4T (~K4T@93.179.200.166) left irc: Ping timeout: 240 seconds [21:50] lb_ii, sort of [21:51] Littleboy (~littleboy@pool-108-7-223-151.bstnma.fios.verizon.net) left irc: Quit: Ętre dans le vent, une ambition de feuille morte. [21:52] how are you doing? [22:32] toby: oh, sorry, missed your reply [22:33] i'm back and working on FoxTail/WinterMute stuff again [22:34] I found out that FoxTail fork is using completely different numeric constants for F1-F12 keys (like, 1073741882 instead of 112) [22:34] which led me to BaseKeyboardState::readKey() [22:35] current implementation is wrong in several ways [22:38] 1. it first converts keyboard event to a number, then check this number to be AlphaNum to decide is key is displayable. But ASCII "p" and kVkF1 are both 112. [22:39] Which makes _currentPrintable be True for F1-F12 keys, which prevents games like DreamCat Adventures and OpenQuest to access Exit menu by F1 key. [22:40] gamescript condition is "if(((Keyboard.KeyCode == VK_ESCAPE) || (!(Keyboard.Printable) && (Keyboard.KeyCode == VK_F1))))" [22:41] LubomirR (~LubomirR_@bband-dyn233.178-40-63.t-com.sk) left irc: Quit: Leaving [22:45] 2. FoxTail has a cheatcode "Shift+Ctrl+Alt+S" to activate ultrasuperfast movement. It expects Keyboard.KeyCode to be equal to VK_S=115, which is ascii code of lowercase "s". However, current code of BaseKeyboardState::readKey() is checking Shift/CapsLock state to convert Keyboard.KeyCode to uppercase, if needed. [22:46] Looks like either this logic was removed from FoxTail's Wintermute while adding those 1073741882 codes, or it was wrong from the start. [22:47] a sec [22:47] I wonder if there are actual WinterMute games that use lots of keyboard events to test those details further. [22:47] Maybe I should just write a test game, lol. [22:48] https://github.com/lolbot-iichan/scummvm/commit/0786fbbdf9b1fe84d17350aa8e186107b45161a5 - here is my commit for things I've mentioned today [22:48] "wrong in several ways", you say. [22:49] yeah =) [22:50] I'm not saying it isn't, but... "wrong" with respect to which specification? [22:50] Corollary: is original WMELite also wrong? [22:50] Just wrondering. [22:51] Oh, "p" and kVkF1 both map to 112. [22:51] Interesting. [22:51] no, original WMELite sets m_CurrentPrintable = (event->type == SDL_TEXTINPUT); [22:51] Oh, then we borked it ourselves. [22:51] which should be different for "p" and F1 [22:52] Ek. [22:52] That's wrong-wrong then. [22:52] there is a third thing, original WME does not mention ISO-8859 [22:52] https://bitbucket.org/MnemonicWME/wmelite/src/fe84bd13b78b06ba7ecd9b4739eb622d95ebf92b/src/BKeyboardState.cpp?at=default&fileviewer=file-view-default#BKeyboardState.cpp-183 [22:52] lb_ii, if you don't plan on fixing it yourself could you be bothered to write a ticket, lest we forget? [22:53] Thank you [22:53] I have a fix in my branch: https://github.com/lolbot-iichan/scummvm/commit/0786fbbdf9b1fe84d17350aa8e186107b45161a5 [22:53] Neeeeeat. [22:53] But it also contain FoxTail-related stuff [22:53] Let me digest point 2. [22:54] ah, rats. [22:54] And also I temporary removed ISO-8859 check for now, because I'm not sure how to test it. [22:54] lb_ii, I would totally write a 3-line test game for that [22:55] if it helps, here is a bunch of test games I wrote in the pleistocene: https://github.com/tobiatesan/wme_testsuite [22:55] it helps! [22:55] I totally will play with this tomorrow! [22:56] I guess we _might_ want to add a repository or find a suitable place under scummvm/ to put WME test games, if our library is growing. [22:57] lb_ii, sorry, what's with ISO-8859? [22:58] current code is: // Verify that this is a printable ISO-8859-character (including the upper charset) if ((_currentCharCode <= 0x7E && _currentCharCode >= 0x20) || (_currentCharCode <= 0xFF && _currentCharCode >= 0xA0)) [22:58] however, original WMELite does not mention anything about exact encodings and stuff [22:59] Oh. [22:59] I guess this was added by somaen many-many years ago. Maybe he remembers the story behind this. [23:00] You'd have to ask somaen who did the original port for what that stuff is for. If I were a betting man, I'd bet on those being simple bugs/mishaps that do not affect most games and so went unnoticed so far. [23:00] *You'd have to ask somaen (who did the original port) what that stuff if for. [23:00] aslk;dfj [23:00] **You'd have to ask somaen (who did the original port) what that stuff is for. [23:02] As for F1/"p" this is surely a bug that even affects actual games. [23:03] As for another things, this may be related to FoxTail, because I know no more WME games waiting for Shift+Letter keypress. Will play with it tomorrow. [23:04] Btw, while testing decompiler, I found an actual bug in OpenQuest game script [23:04] lb_ii, if you have a minute please make a test game. [23:04] That one _is_ a bug. [23:05] decompiler failed on "if(a == b || a = c || a == d)" code in openquest [23:05] Probably somaen being a bit heavy-handed when porting from SDL. [23:05] (Can't blame him for not thinking of very very edge cases) [23:05] lb_ii, wow? [23:06] https://github.com/JenniBee/openquest/issues/1#issuecomment-412339595 [23:06] wrote to JenniBee, this was an actual issue in openquest, lol [23:07] > Funny thing is that Wintermute docs does not mention === operator, but it is supported [23:07] Action: t0by chuckles [23:08] I haven't found it in any docs, and openquest was the first game I found that makes use of it [23:08] lb_ii, you're doing some great work there [23:09] brb, a second [23:09] ok [23:12] waltervn (~waltervn@scummvm/undead/waltervn) left irc: Quit: Leaving [23:20] _dreammaster (~dreammast@c-67-180-185-91.hsd1.ca.comcast.net) left irc: [00:00] --- Mon Aug 13 2018