[00:12] geep (~JoeBelow@xplr-104-249-224-181.xplornet.com) left irc: Ping timeout: 260 seconds [00:36] D0SFreak (~D0SFreak@172.98.67.96) joined #scummvm. [00:40] RLP__ (~D0SFreak@172.98.67.96) left irc: Ping timeout: 260 seconds [01:10] SylvainTV (~SylvainTV@LFbn-1-8392-241.w81-254.abo.wanadoo.fr) left irc: Read error: Connection reset by peer [01:24] snover (~snover@unaffiliated/snover) left irc: Ping timeout: 240 seconds [01:24] dreammaster (~dreammast@c-73-149-116-247.hsd1.ma.comcast.net) left irc: [01:30] snover (~snover@unaffiliated/snover) joined #scummvm. [01:30] #scummvm: mode change '+o snover' by ChanServ!ChanServ@services. [01:33] DominusExult (~dominus@unaffiliated/dominus) joined #scummvm. [01:35] Dominus (~dominus@unaffiliated/dominus) left irc: Ping timeout: 260 seconds [01:35] Nick change: DominusExult -> Dominus [01:37] RLP__ (~D0SFreak@172.98.67.96) joined #scummvm. [01:40] D0SFreak (~D0SFreak@172.98.67.96) left irc: Ping timeout: 255 seconds [02:37] D0SFreak (~D0SFreak@172.98.67.96) joined #scummvm. [02:40] RLP__ (~D0SFreak@172.98.67.96) left irc: Ping timeout: 260 seconds [03:14] klusark (~klusark@S0106a84e3f792f13.vc.shawcable.net) left irc: Ping timeout: 255 seconds [03:37] RLP__ (~D0SFreak@172.98.67.96) joined #scummvm. [03:41] D0SFreak (~D0SFreak@172.98.67.96) left irc: Ping timeout: 260 seconds [04:06] Henke37 (~Henrik@81-227-16-59-no133.bredband.skanova.com) joined #scummvm. [04:27] vinayakvivek (uid121616@gateway/web/irccloud.com/x-qrpfznfhzmrmhzwq) joined #scummvm. [04:37] D0SFreak (~D0SFreak@172.98.67.96) joined #scummvm. [04:39] kurtwr (~kurtwr@c-50-173-166-91.hsd1.ca.comcast.net) left irc: [04:40] RLP__ (~D0SFreak@172.98.67.96) left irc: Ping timeout: 240 seconds [04:45] Joefish (~ident@p200300C6F3C7470042F62B4EC1BA4D0A.dip0.t-ipconnect.de) joined #scummvm. [04:46] morning [04:48] kurtwr (~kurtwr@c-50-173-166-91.hsd1.ca.comcast.net) joined #scummvm. [04:51] Uhfgood (~Captain_J@97-96-80-60.res.bhn.net) left irc: Quit: Leaving [05:02] somaen (somaen@scummvm/undead/somaen) left irc: Ping timeout: 268 seconds [05:25] waltervn (~waltervn@541B2DBA.cm-5-4a.dynamic.ziggo.nl) joined #scummvm. [05:25] #scummvm: mode change '+o waltervn' by ChanServ!ChanServ@services. [05:30] morning [05:31] morning waltervn [05:32] m_kiewitz (~m_kiewitz@x4d03e32c.dyn.telefonica.de) joined #scummvm. [05:32] m_kiewitz (~m_kiewitz@x4d03e32c.dyn.telefonica.de) left irc: Changing host [05:32] m_kiewitz (~m_kiewitz@scummvm/undead/m-kiewitz) joined #scummvm. [05:32] #scummvm: mode change '+o m_kiewitz' by ChanServ!ChanServ@services. [05:37] RLP__ (~D0SFreak@172.98.67.96) joined #scummvm. [05:40] D0SFreak (~D0SFreak@172.98.67.96) left irc: Ping timeout: 240 seconds [06:04] GitHub178 (~GitHub178@192.30.252.34) joined #scummvm. [06:04] [scummvm] criezy pushed 1 new commit to master: https://git.io/vSMfh [06:04] scummvm/master e8d777f pablobecerra: I18N: Update translation (Spanish)... [06:04] GitHub178 (GitHub178@192.30.252.34) left #scummvm. [06:05] GitHub11 (~GitHub11@192.30.252.34) joined #scummvm. [06:05] [scummvm] criezy pushed 1 new commit to master: https://git.io/vSMJv [06:05] scummvm/master 689a6ff Eugene Sandulenko: I18N: Update translation (Spanish)... [06:05] GitHub11 (GitHub11@192.30.252.34) left #scummvm. [06:10] bgK (~bgk@2001:41d0:2:599c::2a60:8434) left irc: Ping timeout: 255 seconds [06:15] NuSuey (uid3556@gateway/web/irccloud.com/x-uvghhqphzsdxzjnp) joined #scummvm. [06:37] D0SFreak (~D0SFreak@172.98.67.96) joined #scummvm. [06:40] RLP__ (~D0SFreak@172.98.67.96) left irc: Ping timeout: 240 seconds [06:52] peterkohaut_ (~Peter@188-167-125-162.dynamic.chello.sk) joined #scummvm. [06:54] dhewg (~dhewg@adiza.nexticom.net) left irc: Ping timeout: 268 seconds [06:54] dhewg (~dhewg@adiza.nexticom.net) joined #scummvm. [06:54] #scummvm: mode change '+o dhewg' by ChanServ!ChanServ@services. [06:55] LittleToonCat (~littlecat@47.54.148.237) left irc: Ping timeout: 260 seconds [06:55] peterkohaut (~Peter@188-167-125-162.dynamic.chello.sk) left irc: Ping timeout: 260 seconds [06:55] androiduser (~androidus@93.78.5.198) left irc: Ping timeout: 260 seconds [06:55] LittleToonCat (~littlecat@47.54.148.237) joined #scummvm. [06:55] Lightkey (~Darklock@p200300764C343C9222CF30FFFE083718.dip0.t-ipconnect.de) left irc: Ping timeout: 255 seconds [06:57] erdic_ (~erdic@unaffiliated/motley) joined #scummvm. [06:57] bazaar (~bazaar@unaffiliated/bazaar) left irc: Read error: Connection reset by peer [06:57] erdic (~erdic@unaffiliated/motley) left irc: Read error: Connection reset by peer [06:57] Nick change: erdic_ -> erdic [06:57] bazaar_ (~bazaar@unaffiliated/bazaar) joined #scummvm. [07:00] androiduser (~androidus@93.78.5.198) joined #scummvm. [07:08] Lightkey (~Darklock@p200300764C343C4022CF30FFFE083718.dip0.t-ipconnect.de) joined #scummvm. [07:20] _sev|work (~sev@scummvm/undead/sev) joined #scummvm. [07:20] #scummvm: mode change '+o _sev|work' by ChanServ!ChanServ@services. [07:24] Strangerke|work (5bb7582b@gateway/web/freenode/ip.91.183.88.43) joined #scummvm. [07:24] hi guys [07:37] RLP__ (~D0SFreak@172.98.67.96) joined #scummvm. [07:41] D0SFreak (~D0SFreak@172.98.67.96) left irc: Ping timeout: 240 seconds [07:44] LittleToonCat (~littlecat@47.54.148.237) left irc: Remote host closed the connection [07:44] hi Strangerke|work [07:47] _sev|work (~sev@scummvm/undead/sev) left irc: Read error: Connection reset by peer [07:49] _sev|work (~sev@scummvm/undead/sev) joined #scummvm. [07:49] #scummvm: mode change '+o _sev|work' by ChanServ!ChanServ@services. [08:10] TMM (~hp@fsf/member/pdpc.professional.tmm) left irc: Quit: Ex-Chat [08:27] wjp: you there? [08:27] i wonder what to do about that Apple IIgs keyboard [08:31] snover: didn't you have issues with certain scancodes on Mac? I'm almost certain that there was some issue with Shift + 1 etc. [08:36] also wasn't there some other keyboard that did other ascii characters on Shift + 1 etc? [08:37] D0SFreak (~D0SFreak@172.98.67.96) joined #scummvm. [08:41] RLP__ (~D0SFreak@172.98.67.96) left irc: Ping timeout: 240 seconds [09:00] _sev|work (~sev@scummvm/undead/sev) left irc: Quit: This computer has gone to sleep [09:01] _sev|work (~sev@scummvm/undead/sev) joined #scummvm. [09:01] #scummvm: mode change '+o _sev|work' by ChanServ!ChanServ@services. [09:11] Coldwine[m] (coldwinema@gateway/shell/matrix.org/x-afirszlsfnffxikv) left irc: Read error: Connection reset by peer [09:11] FleetAdmiral[m] (fleetadmir@gateway/shell/matrix.org/x-pyczomqwcsqzzxdt) left irc: Read error: Connection reset by peer [09:15] Coldwine[m] (coldwinema@gateway/shell/matrix.org/x-szwkzsqbdtiyodxu) joined #scummvm. [09:23] TMM (~hp@fsf/member/pdpc.professional.tmm) joined #scummvm. [09:23] #scummvm: mode change '+o TMM' by ChanServ!ChanServ@services. [09:27] m_kiewitz: wasn't the layout of the apple IIgs kbd fairly similar to the currently used kbd layout, with shift-1 being ! etc.? [09:27] yes [09:27] but I'm pretty sure that there was another type of keyboard, which did things differently [09:27] c64? :) [09:27] platform, that ScummVM supports [09:28] or maybe it was just that we got the wrong scancode, I remember some issue on at least one platform [09:28] which is why I didn't implement it [09:29] like some sort of key, that didn't return the scancode for "1" [09:29] or where other keys were behind modiiers + "1" [09:29] *modifiers [09:29] FleetAdmiral[m] (fleetadmir@gateway/shell/matrix.org/x-swesmapgqnrtgtll) joined #scummvm. [09:29] can't remember the details [09:31] french kbd layout needs shift to type digits or smth, but that's probably not what you mean either [09:32] ah that's it [09:32] perhaps the dreamcast keyboard, but I don't have one of those [09:32] yeah, it's just a layout [09:32] oh, it was french? ok, cool [09:32] so in case I check for Shift + scancode "1" on French keyboards, I would remove their ability to enter numbers [09:33] no idea what to do about that [09:33] i could also make it optionally, so that people who want that feature an enable it [09:33] *can [09:36] I guess somebody who uses that kind of layout on a regular basis and perhaps even can weigh in on how it was "back in the day" in the games might be the best person to ask [09:36] nah the problem is Apple IIgs games [09:37] Sierra used function keys on PC [09:37] Apple IIgs keyboards do not have function keys [09:37] which is why they used "Shift-1", "Shift-2", etc. [09:37] and in ScummVM you need to press the function key, because I didn't implement that mapping [09:37] reason see above [09:37] and now someone created a bug report for this asking for that functionality [09:38] RLP__ (~D0SFreak@172.98.67.96) joined #scummvm. [09:39] anyway, thanks for helping my memory :P [09:41] D0SFreak (~D0SFreak@172.98.67.96) left irc: Ping timeout: 240 seconds [09:41] Deledrius (~Deledrius@68.118.139.214) left irc: Quit: App.Exit [09:55] Deledrius (~Deledrius@68.118.139.214) joined #scummvm. [09:56] bgK (~bgk@rbx1-fr.quadhost.net) joined #scummvm. [09:56] #scummvm: mode change '+o bgK' by ChanServ!ChanServ@services. [10:34] borosky (~broosky@178235041205.dynamic-ww-06.vectranet.pl) left irc: Ping timeout: 252 seconds [10:37] D0SFreak (~D0SFreak@172.98.67.96) joined #scummvm. [10:41] RLP__ (~D0SFreak@172.98.67.96) left irc: Ping timeout: 240 seconds [10:44] vinayakvivek (uid121616@gateway/web/irccloud.com/x-qrpfznfhzmrmhzwq) left irc: Quit: Connection closed for inactivity [11:38] RLP__ (~D0SFreak@172.98.67.96) joined #scummvm. [11:38] Polynomial-C (~Poly-C@gentoo/developer/Polynomial-C) left irc: Remote host closed the connection [11:41] D0SFreak (~D0SFreak@172.98.67.96) left irc: Ping timeout: 240 seconds [11:52] vinayakvivek (uid121616@gateway/web/irccloud.com/x-tscwtndsjzotltgc) joined #scummvm. [12:00] Henke37 (~Henrik@81-227-16-59-no133.bredband.skanova.com) left irc: Quit: ERR_SHUTDOWN [12:13] _sev|work (~sev@scummvm/undead/sev) left irc: Quit: This computer has gone to sleep [12:22] _sev|work (~sev@5.57.20.49) joined #scummvm. [12:22] _sev|work (~sev@5.57.20.49) left irc: Changing host [12:22] _sev|work (~sev@scummvm/undead/sev) joined #scummvm. [12:22] #scummvm: mode change '+o _sev|work' by ChanServ!ChanServ@services. [12:25] user9 (~Thunderbi@leoseb.ujf-grenoble.fr) left irc: Ping timeout: 255 seconds [12:38] D0SFreak (~D0SFreak@172.98.67.96) joined #scummvm. [12:41] RLP__ (~D0SFreak@172.98.67.96) left irc: Ping timeout: 240 seconds [13:02] user9 (~Thunderbi@leoseb.ujf-grenoble.fr) joined #scummvm. [13:06] user9 (~Thunderbi@leoseb.ujf-grenoble.fr) left irc: Ping timeout: 240 seconds [13:14] rootfather (~rootfathe@unaffiliated/rootfather) joined #scummvm. [13:14] #scummvm: mode change '+o rootfather' by ChanServ!ChanServ@services. [13:17] _sev|work (~sev@scummvm/undead/sev) left irc: Quit: This computer has gone to sleep [13:20] _sev|work (~sev@5.57.20.49) joined #scummvm. [13:20] _sev|work (~sev@5.57.20.49) left irc: Changing host [13:20] _sev|work (~sev@scummvm/undead/sev) joined #scummvm. [13:20] #scummvm: mode change '+o _sev|work' by ChanServ!ChanServ@services. [13:21] _sev|work (~sev@scummvm/undead/sev) left irc: Client Quit [13:26] _sev|work (~sev@scummvm/undead/sev) joined #scummvm. [13:26] #scummvm: mode change '+o _sev|work' by ChanServ!ChanServ@services. [13:29] borosky (~broosky@178235041205.dynamic-ww-06.vectranet.pl) joined #scummvm. [13:38] RLP__ (~D0SFreak@172.98.67.96) joined #scummvm. [13:42] D0SFreak (~D0SFreak@172.98.67.96) left irc: Ping timeout: 268 seconds [13:56] _sev|work (~sev@scummvm/undead/sev) left irc: Quit: This computer has gone to sleep [14:18] _sev|work (~sev@scummvm/undead/sev) joined #scummvm. [14:18] #scummvm: mode change '+o _sev|work' by ChanServ!ChanServ@services. [14:31] user9 (~Thunderbi@leoseb.ujf-grenoble.fr) joined #scummvm. [14:34] vinayakvivek (uid121616@gateway/web/irccloud.com/x-tscwtndsjzotltgc) left irc: Quit: Connection closed for inactivity [14:41] RLP__ (~D0SFreak@172.98.67.96) left irc: Ping timeout: 240 seconds [14:59] _sev|work (~sev@scummvm/undead/sev) left irc: Quit: This computer has gone to sleep [15:04] _sev_ (~sev@scummvm/undead/sev) joined #scummvm. [15:04] #scummvm: mode change '+o _sev_' by ChanServ!ChanServ@services. [15:07] _sev (~sev@scummvm/undead/sev) left irc: Ping timeout: 252 seconds [15:09] vinayakvivek (uid121616@gateway/web/irccloud.com/x-aocegzapcvkkazip) joined #scummvm. [15:23] is there an overview of all supported platforms? I saw it somewhere but can't find it anymore.. [15:24] meh.. okay found it on the wiki :P [15:26] TMM (~hp@fsf/member/pdpc.professional.tmm) left irc: Quit: Ex-Chat [15:27] Henke37 (~Henrik@81-227-16-59-no133.bredband.skanova.com) joined #scummvm. [15:31] _sev|work (~sev@scummvm/undead/sev) joined #scummvm. [15:31] #scummvm: mode change '+o _sev|work' by ChanServ!ChanServ@services. [15:33] borosky (~broosky@178235041205.dynamic-ww-06.vectranet.pl) left irc: Ping timeout: 240 seconds [15:59] _sev|work (~sev@scummvm/undead/sev) left irc: Quit: This computer has gone to sleep [16:00] _sev|work (~sev@scummvm/undead/sev) joined #scummvm. [16:00] #scummvm: mode change '+o _sev|work' by ChanServ!ChanServ@services. [16:01] borosky (~broosky@178235041205.dynamic-ww-06.vectranet.pl) joined #scummvm. [16:07] _sev|work (~sev@scummvm/undead/sev) left irc: Read error: Connection reset by peer [16:07] _sev|work (~sev@scummvm/undead/sev) joined #scummvm. [16:07] #scummvm: mode change '+o _sev|work' by ChanServ!ChanServ@services. [16:09] _sev|work (~sev@scummvm/undead/sev) left irc: Client Quit [16:27] _sev|work (~sev@188.88.24.151) joined #scummvm. [16:27] _sev|work (~sev@188.88.24.151) left irc: Changing host [16:27] _sev|work (~sev@scummvm/undead/sev) joined #scummvm. [16:27] #scummvm: mode change '+o _sev|work' by ChanServ!ChanServ@services. [16:36] LittleToonCat (~littlecat@47.54.148.237) joined #scummvm. [16:56] _sev|work (~sev@scummvm/undead/sev) left irc: Quit: This computer has gone to sleep [17:03] WooShell (~Markus@ipbcc07076.dynamic.kabel-deutschland.de) joined #scummvm. [17:04] meow =^.^= [17:05] m_kiewitz: the macOS keyboard problem was https://github.com/scummvm/scummvm/pull/777 [17:05] ajax16384 (~User@109.60.130.33) joined #scummvm. [17:05] #scummvm: mode change '+o ajax16384' by ChanServ!ChanServ@services. [17:07] alt+ usually sends a non-ASCII character, so hitting e.g. alt+o would send ø instead, and so was not recognised as alt+o [17:10] Farmboy0 (~quassel@p5DD10440.dip0.t-ipconnect.de) joined #scummvm. [17:10] Farmboy0 (~quassel@p5DD10440.dip0.t-ipconnect.de) left irc: Changing host [17:10] Farmboy0 (~quassel@xoreos/farmboy0) joined #scummvm. [17:12] ajax16384 (~User@109.60.130.33) left irc: Quit: Leaving [17:13] Harekiet (~harekiet@kittens.harekiet.com) left irc: Read error: Connection reset by peer [17:18] Harekiet (~harekiet@kittens.harekiet.com) joined #scummvm. [17:27] ajax16384 (~User@109.60.130.33) joined #scummvm. [17:27] #scummvm: mode change '+o ajax16384' by ChanServ!ChanServ@services. [17:31] K4T (K4T@193.0.192.199) joined #scummvm. [17:31] K4T (K4T@193.0.192.199) left irc: Client Quit [17:45] snover: thx [17:45] btw. have you seen the king's quest bug report about the intro? [17:46] no, thanks for pointing it out [17:47] was this the bad sound resource you were talking about before? [17:50] Begasus (~begasus@ptr-4p6jpimwasbiodkuok6.18120a2.ip6.access.telenet.be) joined #scummvm. [17:51] topic [17:53] the crash is in MidiParser_SCI::midiFilterChannels, midiparser_sci.cpp:249 [17:55] so i wonder if this is a data problem, or if it is a not-quite-the-same-as-ssci parser problem [18:04] snover: I definitely know that one king's quest 5 version has a broken credit music sound resource [18:04] ah, ok. i couldnt remember if it was KQ4 or KQ5. [18:05] the code must not crash on that one and I think the original code of mine definitely made it possible to play it [18:05] all the corruption should have been filtered out [18:05] the bug report is not about kq5, but kq4 i think [18:05] yes, ive reproduced the bug report in kq4. [18:06] and it's definitely not us reading incorrectly? [18:10] im not sure yet. the function assumes there are at least 2 bytes of data to read, while only checking once to see if we are at the end of the resource [18:11] original SCI obviously didn't check anything at all [18:11] SylvainTV (~SylvainTV@LFbn-1-8392-241.w81-254.abo.wanadoo.fr) joined #scummvm. [18:11] #scummvm: mode change '+o SylvainTV' by ChanServ!ChanServ@services. [18:11] indeed. [18:14] user9 (~Thunderbi@leoseb.ujf-grenoble.fr) left irc: Remote host closed the connection [18:23] Strangerke_ (~Strangerk@cable-85.28.84.13.coditel.net) joined #scummvm. [18:25] Strangerke (~Strangerk@cable-85.28.84.13.coditel.net) left irc: Ping timeout: 240 seconds [18:25] Nick change: Strangerke_ -> Strangerke [18:37] the resource ends with 0xFC 0xFC, so at first glance it doesnt seem to be obviously truncated [18:40] although&should there be two? [18:40] guess i iwll need to dig a little more later. [18:54] freanux (~freanux@unaffiliated/freanux) left irc: Remote host closed the connection [19:04] freanux (~freanux@unaffiliated/freanux) joined #scummvm. [19:08] girafe (~girafe@LFbn-1-11729-221.w2-7.abo.wanadoo.fr) joined #scummvm. [19:20] freanux (~freanux@unaffiliated/freanux) left irc: Quit: Leaving Circada 0.4.1 [19:25] freanux (~freanux@unaffiliated/freanux) joined #scummvm. [19:30] ny00123 (~ny00123@bzq-109-66-203-148.red.bezeqint.net) joined #scummvm. [19:41] Nick change: peterkohaut_ -> peterkohaut [19:41] what happend to asylum engine for sanitarium? [19:42] no recent progress, afaik [19:42] #scummvm: mode change '+o Strangerke' by ChanServ!ChanServ@services. [19:42] TMM (~hp@fsf/member/pdpc.professional.tmm) joined #scummvm. [19:42] #scummvm: mode change '+o TMM' by ChanServ!ChanServ@services. [19:43] ny00123 (~ny00123@bzq-109-66-203-148.red.bezeqint.net) left irc: Quit: Leaving [19:43] i see, but it was worked on quite intensively from what i can see https://github.com/alexbevi/scummvm/commits/asylum and then one day, dead [19:47] ny00123 (~ny00123@bzq-109-66-203-148.red.bezeqint.net) joined #scummvm. [19:50] Begas_VBox (~Begasus@d54C3C8C2.access.telenet.be) joined #scummvm. [19:51] Begas_VBox (~Begasus@d54C3C8C2.access.telenet.be) left irc: Client Quit [19:53] Begasus (~begasus@ptr-4p6jpimwasbiodkuok6.18120a2.ip6.access.telenet.be) left irc: Quit: Ex-Chat [19:54] yep, alexbevi is badly lacking free time, any volunteer is welcome :/ [19:59] maybe when i finish bladerunner:) [20:04] :) [20:07] GitHub122 (~GitHub122@192.30.252.42) joined #scummvm. [20:07] [scummvm] criezy pushed 1 new commit to master: https://git.io/vSyvK [20:07] scummvm/master 887adf1 Paolo Bossi: I18N: Update translation (Italian)... [20:07] GitHub122 (GitHub122@192.30.252.42) left #scummvm. [20:38] With the current code from trunk I can't type any accentuated characters in ScummVM. [20:38] It works in 1.9.0 and it already uses SDL2 on macs. So this is not an issue of SDL1 vs SDL2. [20:38] Any idea what could be causing this? [20:39] For example, typing Alt+e now gives me e instead of é. [20:40] criezy: probably also https://github.com/scummvm/scummvm/pull/777 [20:41] Hmm, I somehow missed that conversation. [20:42] So some engines use the ascii value instead of keycode when checking shortcuts? [20:42] That sounds bad. [20:43] I think I remember fixing a few engines that were doing that a few years ago. [20:51] ny00123 (~ny00123@bzq-109-66-203-148.red.bezeqint.net) left irc: Quit: Leaving [20:52] ajax16384 (~User@109.60.130.33) left irc: Read error: Connection reset by peer [20:54] i feel like i checked non-ascii input in some sci game recently but i cant figure out which one [20:54] non-ascii input? [20:54] ß [20:55] äöü etc? [20:55] you need a localized SCI01 game for that afaik [20:56] i own quite a few including all Japanese releases [20:56] I think I am probably in a very specific case here, because the change in the PR above only affects the use of Alt and Crtl as far as I can see. [20:57] So with my French keyboard it would be OK and the issue is only when trying to use accentuated latters with my UK keyboard that uses Alt to get them. [20:57] So this should not impact many players. [20:58] After checking, I can indeed still enter accentuated characters with my French keyboard. [20:59] we can't really use scancode [20:59] because then it won't work properly as well w/ some keyboard layouts [21:00] for example scancode y is actually ascii Z on German layouts [21:00] which means if we used the scancode, we would return Alt-Y to the game in case Alt-Z is pressed [21:00] which makes no sense [21:00] the whole keyboard stuff is a nightmare [21:01] Shift-1 etc.for Apple IIgs can also not be implemented in ScummVM because of a typical French keyboard [21:02] however we could introduce another key value [21:02] so in case the engine supports Alt-E as a hotkey, the engine could use that value (likeSCI +AGI) [21:02] andotherengines could use the other value [21:14] Indeed SDL_Scancode do not take into account the layout, but SDL_Keycode do. So why do we use the scancode? [21:15] Hmm nevermind. We do use the keycode, but apparently there is a bug in SDL 1.2 on Windows and it doesn't take into account the current layout. [21:15] But SdlEventSource::obtainKeycode seems to have a workaround for this. [21:15] So the keycode in the Common::Event should be correct. [21:16] Is the reason some engines use the ascii value and not keycode for shortcuts because of this bug on Windows? [21:17] If so it looks like they could be changed now. [21:17] in some cases scancode makes sense [21:18] like for keypad cursor keys etc. [21:18] and afaik keycode (that's the ascii value right?) is correct [21:19] or is there a 3rd value already? [21:20] The keycode is not the ascii value as it does not take into account modifiers. [21:20] yes, but i think the keycode is the so called scancode for the engines and it's incorrect sometimes [21:21] so using it for Alt+Ctrl modifiers will make it not work as well (see Mac, see push request) [21:21] SDL has both a keycode and a scancode. The keycode is supposed to take into account the keyboard layout while the scancode does not. [21:21] we would really need a 3rd value [21:21] yes, but on Mac we get completely different values in keycode [21:21] or was it ascii? [21:22] in any case the previous code had issues too [21:22] and we really need the current code for other cases [21:22] and we can't use keycode when modifiers are held down [21:22] For me the keycode is correct on mac in both SDL1 and SDL 2. It gives me SDLK_e, while the ascii value may be e, E, é or some other values depending on the modifiers used. [21:22] so we would really need a 3rd value [21:23] yes, but there's also Windows +Linux and others [21:23] and i still think there was another issue for Mac anyway [21:24] can't remember what it exactly was [21:24] Yes, there is a comment in the code indicating that in SDL 1.2 the keycode on windows is incorrect. But there is aslo code to get the correct one. So in ScummVM it should be correct. [21:24] i think someone should really go through all platforms w/ keyboard support and test out every single key with different keyboard layouts [21:24] how would it get the correct one? [21:25] and when was it added? [21:25] because back then there definitely were issues [21:25] and I also think that there were issues on Linux [21:25] too [21:26] oh right and there was that num lock issue as well [21:26] it's such a nightmare [21:26] tons of layouts,differences between platforms [21:27] Yes, it looks like this is indeed a nightmare. [21:28] And there was indeed issues. I just checked the history and the workaroud to get the correct keycode on windows with SDL 1.2 was only added 9 months ago. [21:28] scancodes doing sillythings like y == z and z== y were really a stupid thing to do [21:28] just for saving some costs [21:28] what does it do? [21:28] call a win32 API? [21:29] It calls MapVirtualKey [21:29] and right,SDL being broken in all sorts of ways is cherry on the nightmare cake [21:30] i guess we shouldn't use SDL for keyboard processing and instead use native code [21:33] and right, using both SDL1 + SDL2 makes it even worse [21:34] any single change could break something else, I originally changed that code so that Alt-X and others finally work on Mac [21:42] waltervn (~waltervn@541B2DBA.cm-5-4a.dynamic.ziggo.nl) left irc: Quit: Leaving [21:55] Polynomial-C (~Poly-C@55d40f93.access.ecotel.net) joined #scummvm. [21:55] Polynomial-C (~Poly-C@55d40f93.access.ecotel.net) left irc: Changing host [21:55] Polynomial-C (~Poly-C@gentoo/developer/Polynomial-C) joined #scummvm. [22:03] m_kiewitz (~m_kiewitz@scummvm/undead/m-kiewitz) left irc: Read error: Connection reset by peer [22:03] m_kiewitz (~m_kiewitz@x4d03e32c.dyn.telefonica.de) joined #scummvm. [22:03] m_kiewitz (~m_kiewitz@x4d03e32c.dyn.telefonica.de) left irc: Changing host [22:03] m_kiewitz (~m_kiewitz@scummvm/undead/m-kiewitz) joined #scummvm. [22:03] #scummvm: mode change '+o m_kiewitz' by ChanServ!ChanServ@services. [22:07] m-kiewitz (~m_kiewitz@scummvm/undead/m-kiewitz) joined #scummvm. [22:07] #scummvm: mode change '+o m-kiewitz' by ChanServ!ChanServ@services. [22:08] OK, I just made a series of test on both macOS X and Linux, with both SDL 1.2 and SDL 2 and with both a French and a British keyboard layout. [22:09] All 8 combinations are working properly and I have the correct keycode value. [22:09] I also have the correct ascii value except when using Crtl or Alt modifier due to PR 777. If I revert it I get the correct ascii value in all cases. [22:09] m_kiewitz (~m_kiewitz@scummvm/undead/m-kiewitz) left irc: Ping timeout: 260 seconds [22:09] I can't test on Windows, but I assume bgK checked this when he implemented the workaround for SDL 1.2. [22:19] Cheeseness (~cheesenes@ppp118-208-235-174.bras1.hba2.internode.on.net) left irc: Remote host closed the connection [22:23] Cheeseness (~cheesenes@ppp118-208-235-174.bras1.hba2.internode.on.net) joined #scummvm. [22:24] vinayakvivek (uid121616@gateway/web/irccloud.com/x-aocegzapcvkkazip) left irc: Quit: Connection closed for inactivity [22:35] Strangerke_ (~Strangerk@cable-85.28.84.13.coditel.net) joined #scummvm. [22:35] criezy: one would have to try out other keyboard layouts too [22:36] or does the French one map some characters to other ones too? like the "y" to "z" etc? [22:36] and aren't there other platforms w/ keyboard support as well? [22:36] which keys did you try btw? [22:38] Strangerke (~Strangerk@cable-85.28.84.13.coditel.net) left irc: Ping timeout: 252 seconds [22:38] Nick change: Strangerke_ -> Strangerke [22:38] Farmboy0 (~quassel@xoreos/farmboy0) left irc: Remote host closed the connection [22:39] WooShell (~Markus@ipbcc07076.dynamic.kabel-deutschland.de) left irc: Quit: If you understand or if you don't, if you believe or if you doubt - There's a universal justice, and the eyes of truth are always watching you. [22:40] Henke37 (~Henrik@81-227-16-59-no133.bredband.skanova.com) left irc: Quit: ERR_SHUTDOWN [22:42] criezy: we should really create some simple test functionality, where you are meant to try out all sorts of different keyboard combinations, so that we can make sure that really every key works properly [22:59] Joefish (~ident@p200300C6F3C7470042F62B4EC1BA4D0A.dip0.t-ipconnect.de) left irc: Ping timeout: 240 seconds [23:05] borosky (~broosky@178235041205.dynamic-ww-06.vectranet.pl) left irc: Ping timeout: 240 seconds [23:09] The French one maps swaps A and Q. [23:09] I tried A, Q, E (which is the same on both layouts) and 3 (as the british layout uses Alt+3 for #, which still works properly). [23:10] so for alt-3,you got "#" in .ascii and KEYCODE_3 for keycode? [23:10] Yes. [23:10] and which linux did you try? [23:10] Ubuntu. [23:10] 14.04 [23:11] i will write some code to check all sorts of keys, so everything can be fully verified [23:11] is there a list of platforms, that we are supporting keyboards for? [23:11] for example Wii, the Pandora etc.? [23:11] all of those need to be verified [23:11] I don't think so. [23:12] I would assume that amiga has a keyboard as well. [23:12] yes of course :P [23:46] dreammaster (~dreammast@c-73-149-116-247.hsd1.vt.comcast.net) joined #scummvm. [23:46] #scummvm: mode change '+o dreammaster' by ChanServ!ChanServ@services. [23:48] the failing 104.SND from KQ4 has two 0xFC (Stop system message) at the end, which seems very rare based on a random sampling of other sound resources. [23:49] (which is to say, i havent seen *any* other sound yet that does that) [23:49] but what's the problem then? [23:50] and i think we really should create code, that walks and plays all resources of a given game [23:50] so that we can make it automatically go over all sorts of games [23:52] Im not sure yet; Im learning as I go here. [23:59] SylvainTV (~SylvainTV@LFbn-1-8392-241.w81-254.abo.wanadoo.fr) left irc: Read error: Connection reset by peer [00:00] --- Thu Apr 13 2017