ScummVM IRC Log - 02 Aug 2018

[Back to Index]

[00:08] <-- ink0gnito left irc: Ping timeout: 240 seconds
[00:10] --> ink0gnito joined #scummvm.
[01:10] <-- t0by left irc: Remote host closed the connection
[01:18] <-- lb_ii_ left irc: Quit: Page closed
[01:35] <Deledrius> lb_ii: a bit off-topic, but I see you have a Ren'Py decompiler up there. A general-purpose decompiler we use in our projects may interest you https://github.com/zrax/pycdc/
[01:44] <-- Zorix left irc: Ping timeout: 265 seconds
[01:55] --> Zorix joined #scummvm.
[02:01] --> dreammaster joined #scummvm.
[02:01] #scummvm: mode change '+o dreammaster' by ChanServ!ChanServ@services.
[02:02] <-- Dominus left irc: Ping timeout: 260 seconds
[02:03] --> Dominus joined #scummvm.
[02:26] <-- mataniko left irc: Read error: Connection reset by peer
[04:31] <-- ignalina left irc: Quit: ignalina
[05:35] <-- SupSuper left irc: Quit: Rip
[05:45] <-- dreammaster left irc:
[06:05] <-- borosky left irc: Read error: Connection reset by peer
[06:06] --> borosky joined #scummvm.
[06:07] --> rootfather joined #scummvm.
[06:07] #scummvm: mode change '+o rootfather' by ChanServ!ChanServ@services.
[06:07] <rootfather> morning folks
[06:19] <-- borosky left irc: Read error: Connection reset by peer
[06:20] --> borosky joined #scummvm.
[06:39] --> scummvm-bugs joined #scummvm.
[06:46] <-- scummvm-bugs left irc: Remote host closed the connection
[06:46] --> scummvm-bugs joined #scummvm.
[06:47] <-- scummvm-bugs left irc: Remote host closed the connection
[06:48] <Deledrius> morning
[06:49] --> scummvm-bugs joined #scummvm.
[07:13] --> KAT joined #scummvm.
[07:24] <_sev> Deledrius: morning
[07:33] <rootfather> morning Deledrius _sev
[07:36] <-- borosky left irc: Read error: Connection reset by peer
[07:36] <-- tsoliman left irc: Ping timeout: 256 seconds
[07:37] --> stroggoff joined #scummvm.
[07:37] --> tsoliman joined #scummvm.
[07:37] #scummvm: mode change '+o tsoliman' by ChanServ!ChanServ@services.
[07:37] <stroggoff> Hi guys
[07:39] --> borosky joined #scummvm.
[07:40] <rootfather> hi stroggoff
[07:41] <stroggoff> :)

[07:45] <-- Dark-Star left irc: Read error: Connection reset by peer
[07:45] <-- heroux left irc: Ping timeout: 256 seconds
[07:45] Nick change: heroux_ -> heroux
[07:46] --> Dark-Star joined #scummvm.
[07:47] --> heroux_ joined #scummvm.
[07:56] <-- Lightkey left irc: Ping timeout: 260 seconds
[08:30] <-- rootfather left irc: Remote host closed the connection
[09:02] <-- _sev left irc: Quit: This computer has gone to sleep
[09:03] --> _sev joined #scummvm.
[09:03] <-- _sev left irc: Changing host
[09:03] --> _sev joined #scummvm.
[09:03] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[09:05] --> GitHub48 joined #scummvm.
[09:05] <GitHub48> [scummvm] sev- pushed 1 new commit to master: https://git.io/fNKnh
[09:05] <GitHub48> scummvm/master d796670 Eugene Sandulenko: NEWS: Formatting fixes
[09:05] GitHub48 (GitHub48@gateway/service/github.com/x-spzcnyychdptmsyu) left #scummvm.
[09:24] <-- stroggoff left irc: Quit: Leaving
[09:39] <-- _sev left irc: Quit: This computer has gone to sleep
[09:41] --> _sev joined #scummvm.
[09:41] <-- _sev left irc: Changing host
[09:41] --> _sev joined #scummvm.
[09:41] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[09:44] --> Lightkey joined #scummvm.
[09:53] <-- _sev left irc: Quit: This computer has gone to sleep
[09:59] --> _sev joined #scummvm.
[09:59] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[10:01] --> criezy|Work joined #scummvm.
[10:01] #scummvm: mode change '+o criezy|Work' by ChanServ!ChanServ@services.
[10:02] <-- _sev left irc: Client Quit
[10:12] --> _sev joined #scummvm.
[10:12] <-- _sev left irc: Changing host
[10:12] --> _sev joined #scummvm.
[10:12] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[10:13] <-- Drenn left irc: Ping timeout: 260 seconds
[10:33] <-- KAT left irc: Ping timeout: 265 seconds
[10:50] --> stroggoff joined #scummvm.
[10:57] <stroggoff> _sev: I read your new comment on the PR for Blade Runner subtitles. I think I was looking mainly at the wrong wordwrap(?). I thought I was supposed to use the wordWrap in common/str.cpp

[10:58] <_sev> Graphics::Font::wordWrapText()
[10:58] <stroggoff> Yes

[11:10] --> ignalina joined #scummvm.
[11:12] --> LubomirR joined #scummvm.
[11:31] --> Yuv422 joined #scummvm.
[11:35] <-- _sev left irc: Ping timeout: 244 seconds
[11:53] --> rootfather joined #scummvm.
[11:53] #scummvm: mode change '+o rootfather' by ChanServ!ChanServ@services.
[12:09] --> ccawley2011 joined #scummvm.
[12:23] <-- ignalina left irc: Quit: ignalina
[12:33] --> whiterandrek joined #scummvm.
[12:33] #scummvm: mode change '+o whiterandrek' by ChanServ!ChanServ@services.
[13:23] <-- Yuv422 left irc: Quit: Yuv422
[13:47] --> mataniko joined #scummvm.
[13:47] #scummvm: mode change '+o mataniko' by ChanServ!ChanServ@services.
[13:55] <rootfather> hi mataniko
[13:55] <mataniko> good morning
[14:27] <-- whiterandrek left irc: Read error: Connection reset by peer
[14:49] --> ignalina joined #scummvm.
[14:52] <-- rootfather left irc: Quit: Leaving
[15:07] <-- stroggoff left irc: Quit: Leaving
[15:15] <-- ignalina left irc: Quit: ignalina
[15:32] --> ignalina joined #scummvm.
[15:53] <-- ignalina left irc: Quit: ignalina
[15:57] --> ny00123 joined #scummvm.
[15:58] --> _sev joined #scummvm.
[15:58] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[16:19] <-- LubomirR left irc: Quit: Page closed
[16:19] --> LubomirR joined #scummvm.
[16:23] <-- _sev left irc: Quit: This computer has gone to sleep
[16:28] --> _sev joined #scummvm.
[16:28] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[16:37] --> KAT joined #scummvm.
[16:40] --> KAT_ joined #scummvm.
[16:43] --> waltervn joined #scummvm.
[16:43] #scummvm: mode change '+o waltervn' by ChanServ!ChanServ@services.
[16:44] <-- KAT left irc: Ping timeout: 276 seconds
[16:45] <-- criezy|Work left irc: Quit: Page closed
[16:46] --> ignalina joined #scummvm.
[16:50] <LubomirR> Can somebody take a look at https://github.com/scummvm/scummvm/pull/1266 , please?
[16:53] <_sev> looking
[16:54] <_sev> good catch! merging
[16:54] --> wihiterandrek joined #scummvm.
[16:54] #scummvm: mode change '+o wihiterandrek' by ChanServ!ChanServ@services.
[16:54] --> GitHub81 joined #scummvm.
[16:54] <GitHub81> [scummvm] sev- closed pull request #1266: COMMON: Fix kerning issue in wordWrapText. (master...wordwrapfix) https://git.io/fNgdd
[16:54] GitHub81 (GitHub81@gateway/service/github.com/x-frzmoosmzxurezpb) left #scummvm.
[16:54] --> GitHub20 joined #scummvm.
[16:54] <GitHub20> [scummvm] sev- pushed 1 new commit to master: https://git.io/fN6qC

[16:54] GitHub20 (GitHub20@gateway/service/github.com/x-vagftodeetkrbkwq) left #scummvm.
[16:55] <LubomirR> Thanks!
[16:58] --> KAT joined #scummvm.
[17:02] <-- KAT_ left irc: Ping timeout: 276 seconds
[17:38] <-- waltervn left irc: Quit: Leaving
[17:51] <-- ignalina left irc: Quit: ignalina
[17:51] --> SupSuper joined #scummvm.
[17:55] <LubomirR> _sev: One more question - at which stage would you suggest trying to merge Mutation of JB to master? I'm just asking so we can focus on those areas first.
[17:57] <LubomirR> (Assuming you accept not fully implemented engines, but if that's not the case, I'm fine with that too, it'll just be a huge PR. :-) )
[18:06] --> waltervn joined #scummvm.
[18:06] #scummvm: mode change '+o waltervn' by ChanServ!ChanServ@services.
[18:12] --> GitHub146 joined #scummvm.
[18:12] <GitHub146> [scummvm] whiterandrek pushed 1 new commit to master: https://git.io/fN6Cv
[18:12] <GitHub146> scummvm/master e9fde87 whiterandrek: PINK: fixed bug when in walking state you choose another location
[18:12] GitHub146 (GitHub146@gateway/service/github.com/x-jgoieduhoihcajpo) left #scummvm.
[18:18] <-- wihiterandrek left irc: Quit: Leaving
[19:07] --> Drenn joined #scummvm.
[19:13] <somaen> For reference (although t0by isn't around); there are some mechanisms in place in the WME persistence code to retain backwards compatibility with save games even if new fields are added, there's an entire versioning system for that.
[19:13] <-- somaen left irc: Changing host
[19:13] --> somaen joined #scummvm.
[19:13] #scummvm: mode change '+o somaen' by ChanServ!ChanServ@services.
[19:15] <somaen> Old saves will get some default value for that field, and potentially not work with that particular game, but if I understand correctly, that game is broken as is.
[19:16] --> criezy joined #scummvm.
[19:16] #scummvm: mode change '+o criezy' by ChanServ!ChanServ@services.
[19:16] <somaen> As for issues you're seeing, IIRC there's some placement-new magic that happens in the persistence code, so that the various pointers can be properly set up again during deserialization. This means that you'll have to set up _everything_ properly in the save/load code, for all classes that get (de)serialized
[19:19] <somaen> The way that works in WME, is that the Foo::persist() function is used both for save and load, your field should have an entry there to have any chance to survive a save/load-event. Potentially with a version-number guard that special-cases loading to use some default-value if the save-game version is below a particular version-number.
[19:21] <somaen> There, that should cover most of the issues raised, if anyone sees t0by or lb_ii, please tell point them towards the logs :)
[20:30] <-- waltervn left irc: Ping timeout: 240 seconds
[20:42] <_sev> LubomirR: yes, we even welcome in-tree development
[20:43] <_sev> somaen: I think, some simple gist with code or reference to existing case in master could help
[20:53] <LubomirR> _sev: Okay, does that mean I could prepare a PR with the current state? (I put some information including a video on the wiki: http://wiki.scummvm.org/index.php/MutationOfJB )
[20:56] <_sev> yes
[20:57] --> lb_ii joined #scummvm.
[20:59] <lb_ii> somaen, this sounds to be just what we need, I totally will look at it
[20:59] <LubomirR> Awesome, thanks!
[21:10] <-- demonimin left irc: Ping timeout: 268 seconds
[21:17] --> GitHub119 joined #scummvm.
[21:17] <GitHub119> [scummvm] lolbot-iichan opened pull request #1269: COMMON: Added Ukrainian language (master...master) https://git.io/fN6P2
[21:17] GitHub119 (GitHub119@gateway/service/github.com/x-bnxurfxjqddvujki) left #scummvm.
[21:29] <-- LubomirR left irc: Quit: Leaving
[21:46] <-- |Cable| left irc: Ping timeout: 248 seconds
[22:10] <-- Dark-Star left irc: Ping timeout: 256 seconds
[22:11] --> Dark-Star joined #scummvm.
[22:14] <somaen> lb_ii: An example of a (fairly convoluted) persist function that has a special case for game versions: https://github.com/scummvm/scummvm/blob/master/engines/wintermute/base/base_game.cpp#L3067
[22:16] <somaen> Note that checkVersion() returns true for any value when saving, and is as such effectively a (isLoading && checkVersion(1,3,1))
[22:20] <somaen> The pointer-deserialization stuff I mentioned happens through https://github.com/scummvm/scummvm/blob/master/engines/wintermute/base/base_persistence_manager.cpp#L828
[22:22] <somaen> And the macro-magic that handles all the placement new stuff is in https://github.com/scummvm/scummvm/blob/master/engines/wintermute/persistent.h
[22:25] <-- KAT left irc: Ping timeout: 240 seconds
[22:31] <somaen> And then a lot of the deserialization magic also happens in the System-classes
[22:33] <-- ny00123 left irc: Quit: Leaving
[22:40] <-- criezy left irc: Quit: criezy
[22:40] <SupSuper> can someone answer some questions about detection tables for me?
[22:41] <lb_ii> somaen: Thanks a lot!
[22:44] --> GitHub59 joined #scummvm.
[22:44] <GitHub59> [scummvm] sev- pushed 1 new commit to master: https://git.io/fN6Ha
[22:44] <GitHub59> scummvm/master d91307e lolbot-iichan: COMMON: Added Ukrainian language...
[22:44] GitHub59 (GitHub59@gateway/service/github.com/x-hjfgmtiqdnqudrvq) left #scummvm.
[22:44] --> GitHub9 joined #scummvm.
[22:44] <GitHub9> [scummvm] sev- closed pull request #1269: COMMON: Added Ukrainian language (master...master) https://git.io/fN6P2
[22:44] GitHub9 (GitHub9@gateway/service/github.com/x-aqtatlzpxqjaavtj) left #scummvm.
[22:45] <lb_ii> Wooh! Here goes my first pull request ever! *^_^*
[22:47] <lb_ii> SupSuper: I have some experience with them, so let's give it a try
[22:53] <mataniko> lb_ii
[22:54] <mataniko> lb_ii: awesome, thank you for contributing!
[22:54] <lb_ii> thanx!
[22:54] <SupSuper> lb_ii: i guess my question is, just how detailed does variant detection need to be, and what's the advantage over just abstracting the engine from the data?
[22:55] <SupSuper> all the engines i checked had a huge matrix of platform x language x gog release x disc release x ...
[22:58] <lb_ii> I guess this still depends on engine and difference between game versions
[22:59] <lb_ii> there are some engines with detection.cpp and no detection_tables.h
[23:02] <SupSuper> hmm
[23:03] <SupSuper> i guess to get more to the point, my game has 3 main variants: Standard Performance, High Performance and Director's Cut. does this work in detection tables?
[23:04] <SupSuper> they are data differences, not platform differences, eg. both Standard and High Performance are separate installs of a DOS release
[23:05] <lb_ii> somaen: could you and/or t0by please find some time on weekend to take a look at https://github.com/lolbot-iichan/scummvm/commit/91d1047 ? I'll continue work on FoxTail next week and it would be nice to have some feedback on coding style and things done
[23:11] <lb_ii> _sev: could you please help SupSuper on detection tables?
[23:16] <-- Zaarin left irc: Read error: Connection reset by peer
[23:16] --> Zaarin joined #scummvm.
[00:00] --- Fri Aug 3 2018