ScummVM IRC Log - 15 Jan 2012

[Back to Index]

[00:05] <-- LordHoto left irc: Quit: night
[00:07] --> Kirben joined #scummvm.
[00:07] #scummvm: mode change '+o Kirben' by ChanServ!ChanServ@services.
[00:09] <-- Vampire0_ left irc: Read error: Operation timed out
[00:09] --> Vampire0 joined #scummvm.
[00:13] <-- WooShell left irc: Quit: svc.startd: The system is coming down. syncing file systems... done.
[00:18] --> hennymcc joined #scummvm.
[00:27] --> Vampire0_ joined #scummvm.
[00:32] <-- Vampire0 left irc: Ping timeout: 276 seconds
[01:05] <-- hennymcc left irc: Ping timeout: 240 seconds
[01:07] Nick change: Adys_ -> Adys
[02:08] <-- Smartnow left irc: Remote host closed the connection
[02:26] --> Tron_ joined #scummvm.
[02:28] <-- Tron left irc: Ping timeout: 248 seconds
[02:33] --> Vampire0 joined #scummvm.
[02:36] <-- Vampire0_ left irc: Ping timeout: 276 seconds
[02:41] --> droid2727 joined #scummvm.
[02:41] #scummvm: mode change '+o droid2727' by ChanServ!ChanServ@services.
[02:42] <droid2727> nice
[02:42] <droid2727> i got netsplit, but never returned
[02:49] <-- kettuz left irc: Quit: Leaving
[03:09] <-- D0SFreak left irc: Ping timeout: 260 seconds
[03:38] <-- droid2727 left irc: Quit: Statement: Good-bye, meatbags!
[04:10] <-- Javacat left irc: Quit: Please, try the fish
[04:14] sirlemonhead (bduncan22@86-43-167-210-dynamic.b-ras2.prp.dublin.eircom.net) left #scummvm.

[05:06] <Smedles> I got scummvm 1.4.1 building on os2 using GCC 3.4.6 - will work out the errors with gcc 4.4.6 some other time
[05:28] [md5] <-- (~md5@unaffiliated/md5/x-729473) left irc: Ping timeout: 260 seconds
[06:27] --> nutron joined #scummvm.
[06:32] --> bgKa joined #scummvm.
[06:50] --> hennymcc joined #scummvm.
[06:57] <-- Kaidane- left irc: Read error: Connection reset by peer
[06:59] <-- bgKa left irc: Quit: Leaving.
[07:07] <-- SylvainTV left irc: Ping timeout: 268 seconds
[07:20] --> hennymcc_ joined #scummvm.
[07:24] <-- hennymcc left irc: Ping timeout: 248 seconds

[07:52] --> risca joined #scummvm.
[07:54] Nick change: Tron_ -> Tron
[08:06] --> WooShell joined #scummvm.
[08:06] <WooShell> moin
[08:35] --> James|GlideM joined #scummvm.
[08:35] #scummvm: mode change '+v James|GlideM' by ChanServ!ChanServ@services.
[08:37] --> bgKa joined #scummvm.
[08:45] --> Smartnow joined #scummvm.
[08:52] --> ny00123 joined #scummvm.
[09:30] --> dserban joined #scummvm.

[09:32] --> ajax16384 joined #scummvm.
[09:32] #scummvm: mode change '+o ajax16384' by ChanServ!ChanServ@services.
[09:54] --> LordHoto joined #scummvm.
[09:54] #scummvm: mode change '+o LordHoto' by ChanServ!ChanServ@services.
[10:01] --> SylvainTV joined #scummvm.
[10:01] #scummvm: mode change '+o SylvainTV' by ChanServ!ChanServ@services.
[10:35] --> bushwakko joined #scummvm.
[10:35] <-- bushwakko left irc: Client Quit
[10:49] <CIA-38> Eugene Sandulenko master * re739846 / (3 files in 2 dirs):
[10:49] <CIA-38> Merge pull request #166 from BenCastricum/master
[10:49] <CIA-38> SCUMM: Added detection for more Dutch HE demos - http://git.io/wj6EEw
[11:08] --> kettuz joined #scummvm.
[11:16] [md5] --> (~md5@unaffiliated/md5/x-729473) joined #scummvm.
[11:16] #scummvm: mode change '+o [md5]' by ChanServ!ChanServ@services.
[11:18] <-- bgKa left irc: Quit: Leaving.
[11:22] <-- TAS_2012v left irc: Ping timeout: 260 seconds
[11:37] <-- ny00123 left irc: Quit: Leaving
[11:43] --> ny00123 joined #scummvm.
[12:06] --> _athrxx joined #scummvm.
[12:06] #scummvm: mode change '+o _athrxx' by ChanServ!ChanServ@services.
[12:35] <CIA-38> athrxx master * rd355c53 / (8 files):
[12:35] <CIA-38> KYRA: (EOB) - add support for original save game files
[12:35] <CIA-38> The engine will try to import original save game files once per target (especially the "Quick Start Party").
[12:35] <CIA-38> Afterwards the user can manually import save files with the debug console. - http://git.io/SVhflQ
[12:35] <CIA-38> athrxx master * rea275d2 / engines/scumm/sound.cpp : SCUMM: add missing free() - http://git.io/ej48Yw
[12:46] --> TAS_2012v joined #scummvm.
[12:51] --> giucam joined #scummvm.
[12:55] <-- TAS_2012v left irc: Ping timeout: 244 seconds
[13:12] <CIA-38> Johannes Schickel master * rcdb6cf6 / engines/tsage/ringworld2/ringworld2_scenes1.cpp : TSAGE: Don't use "&&" synonym "and". - http://git.io/c-TTPQ
[13:12] --> _marc` joined #scummvm.
[13:14] --> D0SFreak joined #scummvm.
[13:17] <-- Kirben left irc:
[13:20] --> sirlemonhead joined #scummvm.
[13:28] <-- D0SFreak left irc: Ping timeout: 252 seconds
[13:37] --> D0SFreak joined #scummvm.
[13:39] --> lskovlun joined #scummvm.
[13:39] #scummvm: mode change '+o lskovlun' by ChanServ!ChanServ@services.
[13:47] <-- _athrxx left irc: Ping timeout: 240 seconds
[13:51] <-- James|GlideM left irc: Read error: Connection reset by peer
[14:00] --> bgKa joined #scummvm.
[14:15] --> Javacat joined #scummvm.
[14:22] --> Dominus joined #scummvm.
[14:30] --> Vampire0_ joined #scummvm.
[14:31] <-- Vampire0 left irc: Read error: Operation timed out
[14:53] --> _athrxx joined #scummvm.
[14:53] #scummvm: mode change '+o _athrxx' by ChanServ!ChanServ@services.
[14:59] --> digitall joined #scummvm.
[14:59] #scummvm: mode change '+o digitall' by ChanServ!ChanServ@services.
[15:22] <-- bgKa left irc: Quit: Leaving.
[15:31] --> Kaidane joined #scummvm.
[15:32] --> Schnaks_ joined #scummvm.
[15:33] <-- Schnaks left irc: Ping timeout: 240 seconds
[15:33] Nick change: Schnaks_ -> Schnaks
[15:38] <-- Adys left irc: Remote host closed the connection
[15:38] --> Adys joined #scummvm.
[15:44] <-- _sev left irc: Ping timeout: 260 seconds
[15:49] <-- Kaidane left irc: Read error: Connection reset by peer
[15:50] --> Kaidane joined #scummvm.
[16:03] --> Hkz joined #scummvm.
[16:03] #scummvm: mode change '+o Hkz' by ChanServ!ChanServ@services.
[16:12] <giucam> sorry for the silly question, but where is DisposeAfterUse declared? i can't find it
[16:12] <fuzzie> common/types.h?
[16:13] <giucam> ah yes, thanks. somehow ack didn't find it
[16:30] <CIA-38> Filippos Karapetis master * r780b2ef / engines/sci/resource.cpp :
[16:30] <CIA-38> SCI: Plug a leak in ResourceManager::detectSciVersion()
[16:30] <CIA-38> Many thanks to digitall for finding this one - http://git.io/FhgVdg
[16:30] <CIA-38> Filippos Karapetis master * r0f39a43 / engines/sci/graphics/frameout.cpp :
[16:30] <CIA-38> SCI: Plug loads of memory leaks in the SCI32 graphics code
[16:30] <CIA-38> Many thanks to digitall for finding these - http://git.io/InXbMg
[16:32] --> LunaVorax joined #scummvm.
[16:32] <-- LunaVorax left irc: Client Quit
[16:32] --> LunaVorax_ joined #scummvm.
[16:32] <-- LunaVorax_ left irc: Client Quit
[16:38] <-- ScummBot left irc: Ping timeout: 252 seconds
[16:47] <-- |Cable| left irc: Ping timeout: 244 seconds
[16:48] --> bgKa joined #scummvm.
[16:49] --> TAS_2012v joined #scummvm.
[16:49] --> |Cable| joined #scummvm.
[16:50] --> Cable_ joined #scummvm.
[16:57] <CIA-38> Filippos Karapetis master * rf2c163a / engines/sci/resource_audio.cpp :
[16:57] <CIA-38> SCI: Plug a leak in ResourceManager::processWavePatch()
[16:57] <CIA-38> Many thanks to digitall for finding this one - http://git.io/Cwxtlg
[16:57] Nick change: Vampire0_ -> Vampire0
[16:59] <wjp> listResources returns a pointer to a newly created List? How unusual
[17:00] <LordHoto> yeah I was wondering about that too
[17:01] <wjp> I see no reason for it
[17:01] <digitall> It is certainly not the most optimal naming...
[17:01] --> ScummBot joined #scummvm.
[17:01] <LordHoto> I didn't bother to look into reasons ;-)
[17:01] <wjp> the point is more why it doesn't just return the list itself, rather than a pointer
[17:02] --> Kaidane_ joined #scummvm.
[17:02] --> risca joined #scummvm.
[17:03] <[md5]> in any case, a lot of the oddities and crashes seem to be gone now. But of course tons of oddities and unimplemented things are still there
[17:04] <-- Kaidane left irc: Ping timeout: 240 seconds
[17:06] Action: wjp will go and clean this up a bit
[17:08] <-- TAS_2012v left irc: Ping timeout: 240 seconds
[17:12] --> TAS_2012v joined #scummvm.
[17:15] <wjp> and why is every loop iterating over those things a while loop instead of a for loop?
[17:15] Action: wjp cleans up some more
[17:15] <LordHoto> :-D
[17:16] <fuzzie> (sucker)
[17:17] <wjp> (tss)
[17:17] <fuzzie> would love to stay here and sell wjp a quality used ship, but must go buy cookies
[17:18] <wjp> I'm a bit occupied buying this nice bridge
[17:19] <[md5]> Now's not the time to worry about the technicalities. Now's the time to ask yourself: "Are you covered?"
[17:22] --> vpelletier joined #scummvm.
[17:22] <[md5]> wjp: I used the while loops cause the iterator changes. Is there something in particular that is wrong with their usage? :p
[17:22] <[md5]> (I mean, the iterator changes after deleting an item)
[17:23] <wjp> I'm probably talking about different ones
[17:23] <[md5]> oh
[17:23] <[md5]> ok
[17:24] <wjp> these ones, specifically:
[17:24] <CIA-38> Willem Jan Palenstijn master * r56fb569 / (7 files in 2 dirs): SCI: Clean up some memory management and loops - http://git.io/1-k8OA
[17:25] <wjp> but please correct me if I missed something. I'm not feeling entirely awake at the moment
[17:25] <wjp> been lying on the couch reading for the last few hours, which isn't good for alertness :-)
[17:26] <[md5]> oh, these ones
[17:26] <[md5]> yeah, I wasn't referring to them :) but the cleanup looks good at a first glance
[17:42] <-- MetalSnake left irc: Ping timeout: 240 seconds
[17:44] <-- lskovlun left irc: Remote host closed the connection
[17:50] --> lskovlun joined #scummvm.
[17:50] #scummvm: mode change '+o lskovlun' by ChanServ!ChanServ@services.
[17:56] <Hkz> ...
[17:58] <-- Schnaks left irc: Ping timeout: 252 seconds
[18:03] --> Schnaks joined #scummvm.
[18:06] <CIA-38> Filippos Karapetis master * r34b2977 / engines/sci/engine/kstring.cpp :
[18:06] <CIA-38> SCI: Fix a nasty bug in kString(Dup)
[18:06] <CIA-38> The rawString variable is no longer pointing to invalidated data. This
[18:06] <CIA-38> fixes cases where strings are manipulated by game scripts, such as the
[18:06] <CIA-38> graveyard and rada drum puzzles in GK1 - http://git.io/alUX9Q
[18:07] <-- Vampire0 left irc: Quit: Verlassend
[18:12] <LordHoto> [md5]: how is that moving the "SciString *" variable out of the if making any difference?
[18:13] <[md5]> LordHoto: I moved the SciString variable for uniformity, that is all
[18:13] <[md5]> the problem was with the Common::String one
[18:13] --> MetalSnake joined #scummvm.
[18:13] <LordHoto> OK
[18:14] --> clone2727 joined #scummvm.
[18:14] #scummvm: mode change '+o clone2727' by ChanServ!ChanServ@services.
[18:15] <[md5]> hi clone2727
[18:15] <-- Schnaks left irc: Ping timeout: 244 seconds
[18:15] <LordHoto> was just wondering, since it seemed like the commit extended the scope of the variable needlessly
[18:15] --> Schnaks joined #scummvm.
[18:16] <wjp> why not just use fromString?
[18:18] <lskovlun> [md5]: It seems to me I fixed a similar bug a while ago
[18:18] <LordHoto> lskovlun: you did? I think I saw a similar change too, but then thought it was just my bad memory again
[18:19] <LordHoto> I thought*
[18:19] <-- bgKa left irc: Quit: Leaving.
[18:19] <LordHoto> so that might explain why it looked a bit familiar ;-)
[18:19] <[md5]> wjp: yeah, fromString would probably be better
[18:19] <[md5]> thanks
[18:19] <lskovlun> October 30th last year
[18:20] <LordHoto> lskovlun: maybe it would be a good idea to look for other places, which do this?
[18:20] <lskovlun> yeah
[18:21] <LordHoto> do you have the commit hash of your commit at hand?
[18:22] <wjp> 40e22d9e33f2f4e09cabc2bc14805c9b51141b90
[18:22] <LordHoto> thanks
[18:23] <LordHoto> right :-)
[18:23] <LordHoto> that's why it looked familiar :-P
[18:25] <wjp> interestingly SciString::fromString has a different trailing-zero behaviour
[18:26] <[md5]> it does?
[18:26] <wjp> the one place it's used is completely weird
[18:27] <wjp> does that even work?
[18:28] <[md5]> replacing the code with fromString() works here
[18:28] <lskovlun> I would be interested to know where that occurs
[18:28] <wjp> please don't commit anything yet
[18:28] <wjp> 6ec8ec416bfdd4241d451de7ba501873fbae38b2
[18:28] <wjp> kArray/dup
[18:28] --> cyco joined #scummvm.
[18:29] <-- cyco left irc: Client Quit
[18:29] <wjp> that Common::String will only contain data up to the first accidental 0 byte
[18:29] <lskovlun> yes, but which game uses it...
[18:29] <lskovlun> it looks very odd
[18:29] <[md5]> RAMA demo, LSL7
[18:31] <[md5]> basically, it copies everything from script X into an array
[18:32] <[md5]> the scripts in question are basically string buffers
[18:32] <[md5]> this was part of the madness that we found out with SCI3 :P
[18:33] <lskovlun> I tried running lsl7 with that code disabled
[18:33] <lskovlun> seems to work
[18:33] <[md5]> odd
[18:33] <[md5]> is that code ever reached?
[18:33] <[md5]> try an assert
[18:33] <lskovlun> I did
[18:33] <[md5]> hm
[18:33] <[md5]> sec
[18:37] <[md5]> it works here too. Seems it was something else that caused this
[18:39] <lskovlun> so, do we just remove it?
[18:39] <[md5]> yes
[18:39] <lskovlun> we have enough weirdness going around as it is
[18:39] <[md5]> but leave the segment type check, just in case
[18:40] <[md5]> but wait for wjp
[18:40] <[md5]> he asked not to commit anything yet
[18:41] <wjp> oh, just to prevent hasty commits before the end of the discussion :-)
[18:41] <[md5]> ah
[18:41] <[md5]> ok :)
[18:41] <lskovlun> if it is the only place where fromString is used, we can take that out also
[18:41] <[md5]> no, don't remove fromString()
[18:41] <[md5]> it will simplify the code a lot
[18:42] <[md5]> sec to paste
[18:42] <[md5]> http://pastebin.com/jEatgU6J
[18:43] <wjp> can't the first case just use SciArray's operator= ?
[18:43] <wjp> (I mean, it is just duplicating a SciString, right?)
[18:44] <wjp> and as I mentioned earlier, fromString doesn't zero-terminate
[18:44] <wjp> (so fromString should probably be tweaked)
[18:45] <[md5]> the current code doesn't zero-terminate either
[18:45] --> bgKa joined #scummvm.
[18:45] <wjp> size = commonString.size() + 1;
[18:45] <[md5]> ah, right
[18:47] <[md5]> so, in fromString() we should change the size to +1, too
[18:47] <[md5]> and then _data[string.size()] = 0;
[18:48] <wjp> that sounds right
[18:48] <wjp> note that the if around the setSize() isn't necessary because setSize() does that check itself
[18:49] <wjp> as long as you're cleaning it up anyway :-)
[18:51] <lskovlun> http://pastebin.com/zwKjGDhj
[18:54] --> LunaVorax joined #scummvm.
[19:05] <CIA-38> Filippos Karapetis master * r96aa86a / engines/sci/engine/klists.cpp : SCI: Remove wrong script-to-array copying code in kArray - http://git.io/cemD6A
[19:05] <CIA-38> Filippos Karapetis master * raff92ea / engines/sci/engine/segment.cpp : SCI: Zero-terminate strings in SciString::fromString() - http://git.io/mTTGvg
[19:05] <CIA-38> Filippos Karapetis master * rcbe7527 / engines/sci/engine/kstring.cpp : SCI: Use fromString() in kString(Dup) to simplify code - http://git.io/kQ1wug
[19:05] <CIA-38> Filippos Karapetis master * rc69ac88 / engines/sci/engine/vm.cpp : SCI: Ignore an invalid export in a script in the demo of RAMA - http://git.io/jn2Jfw
[19:07] <wjp> no operator= for the SciString->SciString dup?
[19:10] <wjp> i.e., just *dupstring = *s->_segMan->lookupString(argv[1]); ?
[19:12] <wjp> also making the allocation order comment superfluous, and reducing the subfunction to 5 lines? :-)
[19:12] <wjp> well, 7
[19:21] <[md5]> oh yeah, forgot that bit
[19:23] --> _sev joined #scummvm.
[19:23] #scummvm: mode change '+o _sev' by ChanServ!ChanServ@services.
[19:26] <-- ajax16384 left irc: Quit: KVIrc 4.1.3 Equilibrium http://www.kvirc.net/
[19:35] <-- kettuz left irc: Quit: Leaving
[19:37] <CIA-38> Filippos Karapetis master * r7560007 / engines/sci/engine/kstring.cpp :
[19:37] <CIA-38> SCI: Simplify kString(Dup) using the overloaded = operator
[19:37] <CIA-38> Thanks to wjp for his suggestion - http://git.io/RqSRCQ
[19:54] <-- LordHoto left irc: Quit: brb
[19:54] --> LordHoto joined #scummvm.
[19:54] #scummvm: mode change '+o LordHoto' by ChanServ!ChanServ@services.
[20:14] --> Strangerke joined #scummvm.
[20:14] #scummvm: mode change '+o Strangerke' by ChanServ!ChanServ@services.
[20:14] <Strangerke> hi guys
[20:15] <clone2727> Strangerke!
[20:15] <Strangerke> Hi clone2727 :)
[20:15] <[md5]> hi Strangerke
[20:16] <digitall> HELO Strangerke
[20:18] <Strangerke> So... what's up? :)
[20:21] <digitall> Strangerke: Depends on the keymapper settings... ;-)
[20:21] <Strangerke> :P
[20:31] <-- LunaVorax left irc: Remote host closed the connection
[20:33] --> LunaVorax joined #scummvm.
[20:38] --> DOSFreak joined #scummvm.
[20:41] <-- LunaVorax left irc: Quit: Quitte
[20:41] <-- D0SFreak left irc: Ping timeout: 255 seconds
[20:51] --> lunavorax joined #scummvm.
[20:55] <CIA-38> Filippos Karapetis master * r099b2e9 / (2 files):
[20:55] <CIA-38> SCI: Properly handle negative coordinates in drawTextBitmap()
[20:55] <CIA-38> This fixes occasional crashes when going to the map in GK1. Many thanks
[20:55] <CIA-38> to digitall for finding this through Valgrind - http://git.io/JGHqAA
[21:05] <-- Hkz left irc: Quit: Quitting
[21:09] --> Hkz joined #scummvm.
[21:09] #scummvm: mode change '+o Hkz' by ChanServ!ChanServ@services.
[21:10] <-- lskovlun left irc: Remote host closed the connection
[21:22] <-- bgKa left irc: Quit: night
[21:24] --> giucam_ joined #scummvm.
[21:24] <-- giucam left irc: Disconnected by services
[21:24] Nick change: giucam_ -> giucam
[21:34] <-- hennymcc_ left irc: Quit: Verlassend
[21:40] <-- ny00123 left irc: Quit: Leaving
[21:41] <-- MetalSnake left irc: Quit: MetalSnake
[21:42] --> ny00123 joined #scummvm.
[21:58] <CIA-38> Strangerke master * r3d4f4ce / (5 files in 2 dirs): TSAGE: R2R - Scene 1550: Implement subA2B2F() - http://git.io/VTmlYw
[21:58] <-- giucam left irc: Ping timeout: 240 seconds
[22:05] <-- WooShell left irc: Quit: svc.startd: The system is coming down. syncing file systems... done.
[22:05] <CIA-38> Strangerke master * re0ac42f / (2 files):
[22:05] <CIA-38> TSAGE: R2R - Fix a GCC warning
[22:05] <CIA-38> Thanks LordHoto for pointing it - http://git.io/zfPs3g
[22:32] <-- lunavorax left irc: Remote host closed the connection
[22:52] <-- ny00123 left irc: Quit: Leaving
[22:57] <-- LordHoto left irc: Quit: night
[23:01] <-- vpelletier left irc: Quit: leaving
[23:12] [md5] <-- (~md5@unaffiliated/md5/x-729473) left irc:
[23:12] digitall (digitall@cpc2-hitc2-0-0-cust28.9-2.cable.virginmedia.com) left #scummvm ("Zzzz").
[23:18] <CIA-38> Strangerke master * r175e8e0 / (2 files): TSAGE: R2R - Scene 1550: Implement subA4D14() - http://git.io/UQUs3A
[23:22] Action: Endy waves
[23:22] <clone2727> Endy!
[23:23] <Endy> Heya!
[23:25] <-- ScummBot left irc: Ping timeout: 247 seconds
[23:29] <Endy> Hm just saw Leslie from Google floating around... must track her own and say hi and thanks for all the GSoC
[23:29] <clone2727> Endy: At LCA?
[23:30] <Endy> clone2727: Aye :)
[23:31] <clone2727> Endy: Making a speech this time? :P
[23:31] <Endy> Shuddup :)
[23:31] <Endy> Purely here for the bandwidth hehe
[23:31] <clone2727> I can always pull out the video from five years ago ;)
[23:32] Action: Endy grumbles lol
[23:32] --> ScummBot joined #scummvm.
[23:37] <-- _athrxx left irc: Quit: ChatZilla 0.9.88 [Firefox 9.0.1/20111220165912]
[23:59] <-- DJWillis left irc: Ping timeout: 240 seconds
[00:00] --- Mon Jan 16 2012